Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/46201/?format=api
{ "id": 46201, "url": "https://patches.dpdk.org/api/patches/46201/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20181007093244.20659-2-thomas@monjalon.net/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20181007093244.20659-2-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20181007093244.20659-2-thomas@monjalon.net", "date": "2018-10-07T09:32:40", "name": "[v6,1/5] devargs: remove deprecated functions", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "0d6bd799bf8ecd822625e76a8c4636787b432e3f", "submitter": { "id": 685, "url": "https://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20181007093244.20659-2-thomas@monjalon.net/mbox/", "series": [ { "id": 1734, "url": "https://patches.dpdk.org/api/series/1734/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=1734", "date": "2018-10-07T09:32:39", "name": "eal: simplify devargs and hotplug functions", "version": 6, "mbox": "https://patches.dpdk.org/series/1734/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/46201/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/46201/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 8D14D37B0;\n\tSun, 7 Oct 2018 11:32:57 +0200 (CEST)", "from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com\n\t[66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 8043A2C38\n\tfor <dev@dpdk.org>; Sun, 7 Oct 2018 11:32:53 +0200 (CEST)", "from compute1.internal (compute1.nyi.internal [10.202.2.41])\n\tby mailout.nyi.internal (Postfix) with ESMTP id 26E2D21EC1;\n\tSun, 7 Oct 2018 05:32:53 -0400 (EDT)", "from mailfrontend2 ([10.202.2.163])\n\tby compute1.internal (MEProxy); Sun, 07 Oct 2018 05:32:53 -0400", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n\tby mail.messagingengine.com (Postfix) with ESMTPA id 03119102EB;\n\tSun, 7 Oct 2018 05:32:51 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n\tfrom:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding; s=mesmtp; bh=uaoDoSurzg\n\t4kmchmPjcfb5hSjGriGbYkRhioHmeQE9c=; b=jnqL5zENub0AJe3ncXz8WnW1oH\n\t15DFnHhoHpW+/X6RK04okxohaVkET5+QHTTzbpS5G1oQKUKuEGUk+3Su7GooIiom\n\tPMTkTFJdsHryOIUVfMRGFQWD2uPOjOC5d4dlyiXCuBH8MSVKWeBHOd6S7TKFaYGC\n\toWIFE97FnOcMVRy8c=", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:content-transfer-encoding:date:from\n\t:in-reply-to:message-id:mime-version:references:subject:to\n\t:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=\n\tfm3; bh=uaoDoSurzg4kmchmPjcfb5hSjGriGbYkRhioHmeQE9c=; b=mBUu8hMY\n\tAnwPYK+ZyV5utDeU06yZxgYnZkS3b47I+IVwLbJlst8Zg7+eNjpT/Cnzuzge5QYV\n\tXTnCn8Fufjj6X+QzM6fnK+U6A9mHeAOSxdJtxM884lFET7zhEo0inp4Q8eNSORYv\n\tryOCeHUh1rA8BHqSwZesh5+2u1KoTQdqjmcKuVHOpMx1JG8jUnRAhhZ2t3opg0RD\n\t45x3FojjBw8VBQhmV3sK2ByXF9QTk4e6pk6nFRTTS0W6dQ8b9R9wdlVAd0RYOvEY\n\tZFIXHMPrqfxzUdL+XCd0XESUkhjl+MaqY7j5m9ujc0IAESN6Wx+py2D5wnWL1yUV\n\tLqIO1v6AqYkBkQ==" ], "X-ME-Sender": "<xms:xNK5W8MymWOhKw07carzrvOM4oR75qObE86k_T3t5gR1pJAizf9Llg>", "X-ME-Proxy": "<xmx:xNK5W1vTsu4eiDCsGjnVt2bxki9f945uaE-fIpnTJ5Ye89gMAx6kXg>\n\t<xmx:xNK5W4uWg9EAlW3Zq7IZ9D5qKYj-QrK-HxV4dYNqCSK7PfBBRtpezg>\n\t<xmx:xNK5WyGerVnhaYjWeVeSeh_sZjj82Ac8XTW53bsEkAE_V_iJBj5D4Q>\n\t<xmx:xNK5W_jnZH7fqy8W668IJ51clzRh2qEWgue8bAAcm2_qR6UD9WC2Cw>\n\t<xmx:xNK5W_BKntxAYgNcQfF-H4quD-VYaQjGm5QH2mVEMzNl4jlRb26PYw>\n\t<xmx:xdK5WxlTBr1toTMofqzab5FvIePgpyW10F5FZrQtrXeMRFwzWmekwQ>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "gaetan.rivet@6wind.com, ophirmu@mellanox.com, qi.z.zhang@intel.com,\n\tferruh.yigit@intel.com, ktraynor@redhat.com", "Date": "Sun, 7 Oct 2018 11:32:40 +0200", "Message-Id": "<20181007093244.20659-2-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.19.0", "In-Reply-To": "<20181007093244.20659-1-thomas@monjalon.net>", "References": "<20180907222727.20521-1-thomas@monjalon.net>\n\t<20181007093244.20659-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v6 1/5] devargs: remove deprecated functions", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "rte_eal_parse_devargs_str() does not support parsing the bus name\nat the start of devargs. So it was renamed and deprecated.\n\nrte_eal_devargs_add(), rte_eal_devargs_type_count() and\nrte_eal_devargs_dump() were declared deprecated and had their\nimplementation body renamed.\n\nAll these functions were deprecated in release 18.05.\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\nReviewed-by: Andrew Rybchenko <arybchenko@solarflare.com>\nAcked-by: Gaetan Rivet <gaetan.rivet@6wind.com>\n---\nThe library version is not updated because it should be done\nin earlier patch https://patches.dpdk.org/patch/43903/\n---\n doc/guides/rel_notes/release_18_11.rst | 5 ++\n lib/librte_eal/common/eal_common_devargs.c | 30 ---------\n lib/librte_eal/common/include/rte_devargs.h | 71 ---------------------\n lib/librte_eal/rte_eal_version.map | 4 --\n 4 files changed, 5 insertions(+), 105 deletions(-)", "diff": "diff --git a/doc/guides/rel_notes/release_18_11.rst b/doc/guides/rel_notes/release_18_11.rst\nindex 2133a5b9b..4f4420ad3 100644\n--- a/doc/guides/rel_notes/release_18_11.rst\n+++ b/doc/guides/rel_notes/release_18_11.rst\n@@ -118,6 +118,11 @@ API Changes\n Also, make sure to start the actual text at the margin.\n =========================================================\n \n+* eal: The following devargs functions, which were deprecated in 18.05,\n+ were removed in 18.11:\n+ ``rte_eal_parse_devargs_str()``, ``rte_eal_devargs_add()``,\n+ ``rte_eal_devargs_type_count()``, and ``rte_eal_devargs_dump()``.\n+\n * mbuf: The ``__rte_mbuf_raw_free()`` and ``__rte_pktmbuf_prefree_seg()``\n functions were deprecated since 17.05 and are replaced by\n ``rte_mbuf_raw_free()`` and ``rte_pktmbuf_prefree_seg()``.\ndiff --git a/lib/librte_eal/common/eal_common_devargs.c b/lib/librte_eal/common/eal_common_devargs.c\nindex 88afece10..5cb5c624d 100644\n--- a/lib/librte_eal/common/eal_common_devargs.c\n+++ b/lib/librte_eal/common/eal_common_devargs.c\n@@ -28,36 +28,6 @@ TAILQ_HEAD(rte_devargs_list, rte_devargs);\n struct rte_devargs_list devargs_list =\n \tTAILQ_HEAD_INITIALIZER(devargs_list);\n \n-int\n-rte_eal_parse_devargs_str(const char *devargs_str,\n-\t\t\tchar **drvname, char **drvargs)\n-{\n-\tchar *sep;\n-\n-\tif ((devargs_str) == NULL || (drvname) == NULL || (drvargs == NULL))\n-\t\treturn -1;\n-\n-\t*drvname = strdup(devargs_str);\n-\tif (*drvname == NULL)\n-\t\treturn -1;\n-\n-\t/* set the first ',' to '\\0' to split name and arguments */\n-\tsep = strchr(*drvname, ',');\n-\tif (sep != NULL) {\n-\t\tsep[0] = '\\0';\n-\t\t*drvargs = strdup(sep + 1);\n-\t} else {\n-\t\t*drvargs = strdup(\"\");\n-\t}\n-\n-\tif (*drvargs == NULL) {\n-\t\tfree(*drvname);\n-\t\t*drvname = NULL;\n-\t\treturn -1;\n-\t}\n-\treturn 0;\n-}\n-\n static size_t\n devargs_layer_count(const char *s)\n {\ndiff --git a/lib/librte_eal/common/include/rte_devargs.h b/lib/librte_eal/common/include/rte_devargs.h\nindex 097a4ce7b..0eef6e9c4 100644\n--- a/lib/librte_eal/common/include/rte_devargs.h\n+++ b/lib/librte_eal/common/include/rte_devargs.h\n@@ -66,36 +66,6 @@ struct rte_devargs {\n \tconst char *data; /**< Device string storage. */\n };\n \n-/**\n- * @deprecated\n- * Parse a devargs string.\n- *\n- * For PCI devices, the format of arguments string is \"PCI_ADDR\" or\n- * \"PCI_ADDR,key=val,key2=val2,...\". Examples: \"08:00.1\", \"0000:5:00.0\",\n- * \"04:00.0,arg=val\".\n- *\n- * For virtual devices, the format of arguments string is \"DRIVER_NAME*\"\n- * or \"DRIVER_NAME*,key=val,key2=val2,...\". Examples: \"net_ring\",\n- * \"net_ring0\", \"net_pmdAnything,arg=0:arg2=1\".\n- *\n- * The function parses the arguments string to get driver name and driver\n- * arguments.\n- *\n- * @param devargs_str\n- * The arguments as given by the user.\n- * @param drvname\n- * The pointer to the string to store parsed driver name.\n- * @param drvargs\n- * The pointer to the string to store parsed driver arguments.\n- *\n- * @return\n- * - 0 on success\n- * - A negative value on error\n- */\n-__rte_deprecated\n-int rte_eal_parse_devargs_str(const char *devargs_str,\n-\t\t\t\tchar **drvname, char **drvargs);\n-\n /**\n * Parse a device string.\n *\n@@ -201,23 +171,6 @@ rte_devargs_insert(struct rte_devargs *da);\n __rte_experimental\n int rte_devargs_add(enum rte_devtype devtype, const char *devargs_str);\n \n-/**\n- * @deprecated\n- * Add a device to the user device list\n- * See rte_devargs_parse() for details.\n- *\n- * @param devtype\n- * The type of the device.\n- * @param devargs_str\n- * The arguments as given by the user.\n- *\n- * @return\n- * - 0 on success\n- * - A negative value on error\n- */\n-__rte_deprecated\n-int rte_eal_devargs_add(enum rte_devtype devtype, const char *devargs_str);\n-\n /**\n * Remove a device from the user device list.\n * Its resources are freed.\n@@ -251,20 +204,6 @@ __rte_experimental\n unsigned int\n rte_devargs_type_count(enum rte_devtype devtype);\n \n-/**\n- * @deprecated\n- * Count the number of user devices of a specified type\n- *\n- * @param devtype\n- * The type of the devices to counted.\n- *\n- * @return\n- * The number of devices.\n- */\n-__rte_deprecated\n-unsigned int\n-rte_eal_devargs_type_count(enum rte_devtype devtype);\n-\n /**\n * This function dumps the list of user device and their arguments.\n *\n@@ -274,16 +213,6 @@ rte_eal_devargs_type_count(enum rte_devtype devtype);\n __rte_experimental\n void rte_devargs_dump(FILE *f);\n \n-/**\n- * @deprecated\n- * This function dumps the list of user device and their arguments.\n- *\n- * @param f\n- * A pointer to a file for output\n- */\n-__rte_deprecated\n-void rte_eal_devargs_dump(FILE *f);\n-\n /**\n * Find next rte_devargs matching the provided bus name.\n *\ndiff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map\nindex 73282bbb0..3df7f9831 100644\n--- a/lib/librte_eal/rte_eal_version.map\n+++ b/lib/librte_eal/rte_eal_version.map\n@@ -19,9 +19,6 @@ DPDK_2.0 {\n \trte_dump_tailq;\n \trte_eal_alarm_cancel;\n \trte_eal_alarm_set;\n-\trte_eal_devargs_add;\n-\trte_eal_devargs_dump;\n-\trte_eal_devargs_type_count;\n \trte_eal_get_configuration;\n \trte_eal_get_lcore_state;\n \trte_eal_get_physmem_size;\n@@ -32,7 +29,6 @@ DPDK_2.0 {\n \trte_eal_lcore_role;\n \trte_eal_mp_remote_launch;\n \trte_eal_mp_wait_lcore;\n-\trte_eal_parse_devargs_str;\n \trte_eal_process_type;\n \trte_eal_remote_launch;\n \trte_eal_tailq_lookup;\n", "prefixes": [ "v6", "1/5" ] }