Patch Comment List
List patch comments
GET /api/patches/459/comments/?format=api&order=id
[ { "id": 1644, "web_url": "https://patches.dpdk.org/comment/1644/", "msgid": "<20784375.UWMeVtoV91@xps13>", "list_archive_url": "https://inbox.dpdk.org/dev/20784375.UWMeVtoV91@xps13", "date": "2014-10-14T14:09:36", "subject": "Re: [dpdk-dev] [PATCH 1/6] ether: enhancement for VMDQ support", "submitter": { "id": 1, "url": "https://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "content": "2014-09-23 21:14, Chen Jing D:\n> The change includes several parts:\n> 1. Clear pool bitmap when trying to remove specific MAC.\n> 2. Define RSS, DCB and VMDQ flags to combine rx_mq_mode.\n> 3. Use 'struct' to replace 'union', which to expand the rx_adv_conf\n> arguments to better support RSS, DCB and VMDQ.\n> 4. Fix bug in rte_eth_dev_config_restore function, which will restore\n> all MAC address to default pool.\n> 5. Define additional 3 arguments for better VMDQ support.\n> \n> Signed-off-by: Chen Jing D(Mark) <jing.d.chen@intel.com>\n> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>\n> Acked-by: Jingjing Wu <jingjing.wu@intel.com>\n> Acked-by: Jijiang Liu <jijiang.liu@intel.com>\n> Acked-by: Huawei Xie <huawei.xie@intel.com>\n\nWhaou, there were a lot of reviewers!\nThe patch should be really clean. Let's see :)\n\n> --- a/lib/librte_ether/rte_ethdev.c\n> +++ b/lib/librte_ether/rte_ethdev.c\n> \t\t/* add address to the hardware */\n> -\t\tif (*dev->dev_ops->mac_addr_add)\n> +\t\tif (*dev->dev_ops->mac_addr_add &&\n> +\t\t\tdev->data->mac_pool_sel[i] & (1ULL << pool))\n> \t\t\t(*dev->dev_ops->mac_addr_add)(dev, &addr, i, pool);\n\n> +\t/* Update pool bitmap in NIC data structure */\n> +\tdev->data->mac_pool_sel[index] = 0;\n\nReset is a better word than \"Update\" in this case.\nBut do we really need a comment for that?\n\n> +#define ETH_MQ_RX_RSS_FLAG 0x1\n> +#define ETH_MQ_RX_DCB_FLAG 0x2\n> +#define ETH_MQ_RX_VMDQ_FLAG 0x4\n\nNeed a comment to know where these flags can be used.\n\n> enum rte_eth_rx_mq_mode {\n> -\tETH_MQ_RX_NONE = 0, /**< None of DCB,RSS or VMDQ mode */\n> -\n> -\tETH_MQ_RX_RSS, /**< For RX side, only RSS is on */\n> -\tETH_MQ_RX_DCB, /**< For RX side,only DCB is on. */\n> -\tETH_MQ_RX_DCB_RSS, /**< Both DCB and RSS enable */\n> -\n> -\tETH_MQ_RX_VMDQ_ONLY, /**< Only VMDQ, no RSS nor DCB */\n> -\tETH_MQ_RX_VMDQ_RSS, /**< RSS mode with VMDQ */\n> -\tETH_MQ_RX_VMDQ_DCB, /**< Use VMDQ+DCB to route traffic to queues */\n> -\tETH_MQ_RX_VMDQ_DCB_RSS, /**< Enable both VMDQ and DCB in VMDq */\n> +\t/**< None of DCB,RSS or VMDQ mode */\n> +\tETH_MQ_RX_NONE = 0,\n> +\n> +\t/**< For RX side, only RSS is on */\n> +\tETH_MQ_RX_RSS = ETH_MQ_RX_RSS_FLAG,\n> +\t/**< For RX side,only DCB is on. */\n> +\tETH_MQ_RX_DCB = ETH_MQ_RX_DCB_FLAG,\n> +\t/**< Both DCB and RSS enable */\n> +\tETH_MQ_RX_DCB_RSS = ETH_MQ_RX_RSS_FLAG | ETH_MQ_RX_DCB_FLAG,\n> +\n> +\t/**< Only VMDQ, no RSS nor DCB */\n> +\tETH_MQ_RX_VMDQ_ONLY = ETH_MQ_RX_VMDQ_FLAG,\n> +\t/**< RSS mode with VMDQ */\n> +\tETH_MQ_RX_VMDQ_RSS = ETH_MQ_RX_RSS_FLAG | ETH_MQ_RX_VMDQ_FLAG,\n> +\t/**< Use VMDQ+DCB to route traffic to queues */\n> +\tETH_MQ_RX_VMDQ_DCB = ETH_MQ_RX_VMDQ_FLAG | ETH_MQ_RX_DCB_FLAG,\n> +\t/**< Enable both VMDQ and DCB in VMDq */\n> +\tETH_MQ_RX_VMDQ_DCB_RSS = ETH_MQ_RX_RSS_FLAG | ETH_MQ_RX_DCB_FLAG |\n> +\t\t\t\t ETH_MQ_RX_VMDQ_FLAG,\n> };\n\nWhy not simply remove all these combinations and keep only flags?\nPlease keep it simple.\n\n> +\t/**< Specify the queue range belongs to VMDQ pools if VMDQ applicable */\n> +\tuint16_t vmdq_queue_base;\n> +\tuint16_t vmdq_queue_num;\n\nIf comment is before, it should be /** not /**<.\n\n> +\tuint16_t vmdq_pool_base; /** < Specify the start pool ID of VMDQ pools */\n\nThere is a typo with the space --^\nPlease, when writing comments, ask yourself if each word is required\nand how it can be shorter.\nExample here: /**< first ID of VMDQ pools */\n\nConclusion: NACK\nThere are only few typos and minor things but it would help to have more\ncareful reviews. Having a list of people at the beginning of the patch\ndidn't help in this case.\n\nThanks for your attention", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 8EE7668BE;\n\tTue, 14 Oct 2014 16:02:08 +0200 (CEST)", "from mail-wi0-f169.google.com (mail-wi0-f169.google.com\n\t[209.85.212.169]) by dpdk.org (Postfix) with ESMTP id 2C63D58E6\n\tfor <dev@dpdk.org>; Tue, 14 Oct 2014 16:02:07 +0200 (CEST)", "by mail-wi0-f169.google.com with SMTP id h11so6120584wiw.4\n\tfor <dev@dpdk.org>; Tue, 14 Oct 2014 07:09:51 -0700 (PDT)", "from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])\n\tby mx.google.com with ESMTPSA id\n\tfa7sm20340165wjd.27.2014.10.14.07.09.49 for <multiple recipients>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 14 Oct 2014 07:09:50 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:organization\n\t:user-agent:in-reply-to:references:mime-version\n\t:content-transfer-encoding:content-type;\n\tbh=mvr4OUc/6dS5LPfL0bKuxeJSqvEWVJNz2kVWfhS2BZ8=;\n\tb=GtTq0lr1An+wH1/l1FbhTkXnH+/CurGR1oGA97cwyAnwRq7b3NOljkN6w80sbAmlGW\n\t+Ct7RDQPGfONjs1T2/GL04CN1ypUYuoPsQDiITpPrQ/LFlWnS/g+w4rqOl+1CqDQN+vh\n\ts0sDltGato6ytfWDGudQP+WV8niCy+8Ay55c6M1u2TvErNLhzq/61B4m5kwj2QFzFBqp\n\tdaR1BjW+w4p386jVMoNIPVvJA0J8O4esUuKaD/Hu6DWM+HLFluE6FEk+CI6Fn46xAO16\n\t2G7MzRea8O5dIJuuxMzRqe1gwIsTrk2oy+60VwIMK9rnftriK4km44/RPSXRyevRUU0F\n\taNiQ==", "X-Gm-Message-State": "ALoCoQldWMT42VSMC7ADtoewYPiZLRRYzIJ86DzF9fazU9AUlFw3Laba4bGfpo5OT6pFmP+N/N+A", "X-Received": "by 10.194.91.212 with SMTP id cg20mr5638527wjb.66.1413295791356; \n\tTue, 14 Oct 2014 07:09:51 -0700 (PDT)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "\"Chen Jing D(Mark)\" <jing.d.chen@intel.com>", "Date": "Tue, 14 Oct 2014 16:09:36 +0200", "Message-ID": "<20784375.UWMeVtoV91@xps13>", "Organization": "6WIND", "User-Agent": "KMail/4.14.1 (Linux/3.16.4-1-ARCH; KDE/4.14.1; x86_64; ; )", "In-Reply-To": "<1411478047-1251-2-git-send-email-jing.d.chen@intel.com>", "References": "<1411478047-1251-1-git-send-email-jing.d.chen@intel.com>\n\t<1411478047-1251-2-git-send-email-jing.d.chen@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "7Bit", "Content-Type": "text/plain; charset=\"us-ascii\"", "Cc": "dev@dpdk.org", "Subject": "Re: [dpdk-dev] [PATCH 1/6] ether: enhancement for VMDQ support", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 1659, "web_url": "https://patches.dpdk.org/comment/1659/", "msgid": "<4341B239C0EFF9468EE453F9E9F4604D015F35FE@shsmsx102.ccr.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/4341B239C0EFF9468EE453F9E9F4604D015F35FE@shsmsx102.ccr.corp.intel.com", "date": "2014-10-15T06:59:24", "subject": "Re: [dpdk-dev] [PATCH 1/6] ether: enhancement for VMDQ support", "submitter": { "id": 40, "url": "https://patches.dpdk.org/api/people/40/?format=api", "name": "Chen, Jing D", "email": "jing.d.chen@intel.com" }, "content": "> -----Original Message-----\n> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]\n> Sent: Tuesday, October 14, 2014 10:10 PM\n> To: Chen, Jing D\n> Cc: dev@dpdk.org\n> Subject: Re: [dpdk-dev] [PATCH 1/6] ether: enhancement for VMDQ support\n> \n> 2014-09-23 21:14, Chen Jing D:\n> > The change includes several parts:\n> > 1. Clear pool bitmap when trying to remove specific MAC.\n> > 2. Define RSS, DCB and VMDQ flags to combine rx_mq_mode.\n> > 3. Use 'struct' to replace 'union', which to expand the rx_adv_conf\n> > arguments to better support RSS, DCB and VMDQ.\n> > 4. Fix bug in rte_eth_dev_config_restore function, which will restore\n> > all MAC address to default pool.\n> > 5. Define additional 3 arguments for better VMDQ support.\n> >\n> > Signed-off-by: Chen Jing D(Mark) <jing.d.chen@intel.com>\n> > Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>\n> > Acked-by: Jingjing Wu <jingjing.wu@intel.com>\n> > Acked-by: Jijiang Liu <jijiang.liu@intel.com>\n> > Acked-by: Huawei Xie <huawei.xie@intel.com>\n> \n> Whaou, there were a lot of reviewers!\n> The patch should be really clean. Let's see :)\n\nFirst time I saw you are so humorous. :)\n\n> \n> > --- a/lib/librte_ether/rte_ethdev.c\n> > +++ b/lib/librte_ether/rte_ethdev.c\n> > \t\t/* add address to the hardware */\n> > -\t\tif (*dev->dev_ops->mac_addr_add)\n> > +\t\tif (*dev->dev_ops->mac_addr_add &&\n> > +\t\t\tdev->data->mac_pool_sel[i] & (1ULL << pool))\n> > \t\t\t(*dev->dev_ops->mac_addr_add)(dev, &addr, i,\n> pool);\n> \n> > +\t/* Update pool bitmap in NIC data structure */\n> > +\tdev->data->mac_pool_sel[index] = 0;\n> \n> Reset is a better word than \"Update\" in this case.\n> But do we really need a comment for that?\n\nAccept.\n\n> \n> > +#define ETH_MQ_RX_RSS_FLAG 0x1\n> > +#define ETH_MQ_RX_DCB_FLAG 0x2\n> > +#define ETH_MQ_RX_VMDQ_FLAG 0x4\n> \n> Need a comment to know where these flags can be used.\n\nAccept.\n\n> \n> > enum rte_eth_rx_mq_mode {\n> > -\tETH_MQ_RX_NONE = 0, /**< None of DCB,RSS or VMDQ mode */\n> > -\n> > -\tETH_MQ_RX_RSS, /**< For RX side, only RSS is on */\n> > -\tETH_MQ_RX_DCB, /**< For RX side,only DCB is on. */\n> > -\tETH_MQ_RX_DCB_RSS, /**< Both DCB and RSS enable */\n> > -\n> > -\tETH_MQ_RX_VMDQ_ONLY, /**< Only VMDQ, no RSS nor DCB */\n> > -\tETH_MQ_RX_VMDQ_RSS, /**< RSS mode with VMDQ */\n> > -\tETH_MQ_RX_VMDQ_DCB, /**< Use VMDQ+DCB to route traffic to\n> queues */\n> > -\tETH_MQ_RX_VMDQ_DCB_RSS, /**< Enable both VMDQ and DCB in\n> VMDq */\n> > +\t/**< None of DCB,RSS or VMDQ mode */\n> > +\tETH_MQ_RX_NONE = 0,\n> > +\n> > +\t/**< For RX side, only RSS is on */\n> > +\tETH_MQ_RX_RSS = ETH_MQ_RX_RSS_FLAG,\n> > +\t/**< For RX side,only DCB is on. */\n> > +\tETH_MQ_RX_DCB = ETH_MQ_RX_DCB_FLAG,\n> > +\t/**< Both DCB and RSS enable */\n> > +\tETH_MQ_RX_DCB_RSS = ETH_MQ_RX_RSS_FLAG |\n> ETH_MQ_RX_DCB_FLAG,\n> > +\n> > +\t/**< Only VMDQ, no RSS nor DCB */\n> > +\tETH_MQ_RX_VMDQ_ONLY = ETH_MQ_RX_VMDQ_FLAG,\n> > +\t/**< RSS mode with VMDQ */\n> > +\tETH_MQ_RX_VMDQ_RSS = ETH_MQ_RX_RSS_FLAG |\n> ETH_MQ_RX_VMDQ_FLAG,\n> > +\t/**< Use VMDQ+DCB to route traffic to queues */\n> > +\tETH_MQ_RX_VMDQ_DCB = ETH_MQ_RX_VMDQ_FLAG |\n> ETH_MQ_RX_DCB_FLAG,\n> > +\t/**< Enable both VMDQ and DCB in VMDq */\n> > +\tETH_MQ_RX_VMDQ_DCB_RSS = ETH_MQ_RX_RSS_FLAG |\n> ETH_MQ_RX_DCB_FLAG |\n> > +\t\t\t\t ETH_MQ_RX_VMDQ_FLAG,\n> > };\n> \n> Why not simply remove all these combinations and keep only flags?\n> Please keep it simple.\n\nOne reason is back-compatibility. \nAnother reason is not all NIC driver support all the combined modes, only limited sets\ndriver supported. Under this condition, it's better to use the combination definition \n(VMDQ_DCB, DCB_RSS, etc) to let driver check whether it supports.\n\t\n> \n> > +\t/**< Specify the queue range belongs to VMDQ pools if VMDQ\n> applicable */\n> > +\tuint16_t vmdq_queue_base;\n> > +\tuint16_t vmdq_queue_num;\n> \n> If comment is before, it should be /** not /**<.\n\nAccept.\n\n> \n> > +\tuint16_t vmdq_pool_base; /** < Specify the start pool ID of VMDQ\n> pools */\n> \n> There is a typo with the space --^\n> Please, when writing comments, ask yourself if each word is required\n> and how it can be shorter.\n> Example here: /**< first ID of VMDQ pools */\n> \n> Conclusion: NACK\n> There are only few typos and minor things but it would help to have more\n> careful reviews. Having a list of people at the beginning of the patch\n> didn't help in this case.\n\nI listed all the code reviewers out to reduce their workload to reply the email,\nnot mean to make it easier to be applied.\n\n> \n> Thanks for your attention\n> --\n> Thomas", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id D57057E74;\n\tWed, 15 Oct 2014 08:51:41 +0200 (CEST)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id 30B2E7E70\n\tfor <dev@dpdk.org>; Wed, 15 Oct 2014 08:51:40 +0200 (CEST)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga103.fm.intel.com with ESMTP; 14 Oct 2014 23:49:27 -0700", "from fmsmsx107.amr.corp.intel.com ([10.18.124.205])\n\tby fmsmga001.fm.intel.com with ESMTP; 14 Oct 2014 23:59:26 -0700", "from shsmsx152.ccr.corp.intel.com (10.239.6.52) by\n\tfmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP\n\tServer (TLS) id 14.3.195.1; Tue, 14 Oct 2014 23:59:26 -0700", "from shsmsx102.ccr.corp.intel.com ([169.254.2.192]) by\n\tSHSMSX152.ccr.corp.intel.com ([169.254.6.190]) with mapi id\n\t14.03.0195.001; Wed, 15 Oct 2014 14:59:24 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.04,722,1406617200\"; d=\"scan'208\";a=\"605584226\"", "From": "\"Chen, Jing D\" <jing.d.chen@intel.com>", "To": "Thomas Monjalon <thomas.monjalon@6wind.com>", "Thread-Topic": "[dpdk-dev] [PATCH 1/6] ether: enhancement for VMDQ support", "Thread-Index": "AQHP1zBT6w/kKa8rS0Kz9pa3obOE+pwvPHsAgAGakvA=", "Date": "Wed, 15 Oct 2014 06:59:24 +0000", "Message-ID": "<4341B239C0EFF9468EE453F9E9F4604D015F35FE@shsmsx102.ccr.corp.intel.com>", "References": "<1411478047-1251-1-git-send-email-jing.d.chen@intel.com>\n\t<1411478047-1251-2-git-send-email-jing.d.chen@intel.com>\n\t<20784375.UWMeVtoV91@xps13>", "In-Reply-To": "<20784375.UWMeVtoV91@xps13>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[10.239.127.40]", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "Cc": "\"dev@dpdk.org\" <dev@dpdk.org>", "Subject": "Re: [dpdk-dev] [PATCH 1/6] ether: enhancement for VMDQ support", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 1662, "web_url": "https://patches.dpdk.org/comment/1662/", "msgid": "<10317086.OmtuOpvoDk@xps13>", "list_archive_url": "https://inbox.dpdk.org/dev/10317086.OmtuOpvoDk@xps13", "date": "2014-10-15T08:10:58", "subject": "Re: [dpdk-dev] [PATCH 1/6] ether: enhancement for VMDQ support", "submitter": { "id": 1, "url": "https://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "content": "2014-10-15 06:59, Chen, Jing D:\n> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]\n> > > enum rte_eth_rx_mq_mode {\n> > > -\tETH_MQ_RX_NONE = 0, /**< None of DCB,RSS or VMDQ mode */\n> > > -\n> > > -\tETH_MQ_RX_RSS, /**< For RX side, only RSS is on */\n> > > -\tETH_MQ_RX_DCB, /**< For RX side,only DCB is on. */\n> > > -\tETH_MQ_RX_DCB_RSS, /**< Both DCB and RSS enable */\n> > > -\n> > > -\tETH_MQ_RX_VMDQ_ONLY, /**< Only VMDQ, no RSS nor DCB */\n> > > -\tETH_MQ_RX_VMDQ_RSS, /**< RSS mode with VMDQ */\n> > > -\tETH_MQ_RX_VMDQ_DCB, /**< Use VMDQ+DCB to route traffic to\n> > queues */\n> > > -\tETH_MQ_RX_VMDQ_DCB_RSS, /**< Enable both VMDQ and DCB in\n> > VMDq */\n> > > +\t/**< None of DCB,RSS or VMDQ mode */\n> > > +\tETH_MQ_RX_NONE = 0,\n> > > +\n> > > +\t/**< For RX side, only RSS is on */\n> > > +\tETH_MQ_RX_RSS = ETH_MQ_RX_RSS_FLAG,\n> > > +\t/**< For RX side,only DCB is on. */\n> > > +\tETH_MQ_RX_DCB = ETH_MQ_RX_DCB_FLAG,\n> > > +\t/**< Both DCB and RSS enable */\n> > > +\tETH_MQ_RX_DCB_RSS = ETH_MQ_RX_RSS_FLAG |\n> > ETH_MQ_RX_DCB_FLAG,\n> > > +\n> > > +\t/**< Only VMDQ, no RSS nor DCB */\n> > > +\tETH_MQ_RX_VMDQ_ONLY = ETH_MQ_RX_VMDQ_FLAG,\n> > > +\t/**< RSS mode with VMDQ */\n> > > +\tETH_MQ_RX_VMDQ_RSS = ETH_MQ_RX_RSS_FLAG |\n> > ETH_MQ_RX_VMDQ_FLAG,\n> > > +\t/**< Use VMDQ+DCB to route traffic to queues */\n> > > +\tETH_MQ_RX_VMDQ_DCB = ETH_MQ_RX_VMDQ_FLAG |\n> > ETH_MQ_RX_DCB_FLAG,\n> > > +\t/**< Enable both VMDQ and DCB in VMDq */\n> > > +\tETH_MQ_RX_VMDQ_DCB_RSS = ETH_MQ_RX_RSS_FLAG |\n> > ETH_MQ_RX_DCB_FLAG |\n> > > +\t\t\t\t ETH_MQ_RX_VMDQ_FLAG,\n> > > };\n> > \n> > Why not simply remove all these combinations and keep only flags?\n> > Please keep it simple.\n> \n> One reason is back-compatibility.\n\nI understand but I think we should prefer cleanup.\nAs there is no way to advertise deprecation of flags, it should be\nsimply removed.\n\n> Another reason is not all NIC driver support all the combined modes, only limited sets\n> driver supported. Under this condition, it's better to use the combination definition \n> (VMDQ_DCB, DCB_RSS, etc) to let driver check whether it supports.\n\nDriver can do the same checks with simple flags and it's probably simpler\n(e.g. a driver which doesn't support VMDQ had no need to check all VMDQ\ncombinations).\n\n> > There are only few typos and minor things but it would help to have more\n> > careful reviews. Having a list of people at the beginning of the patch\n> > didn't help in this case.\n> \n> I listed all the code reviewers out to reduce their workload to reply the email,\n> not mean to make it easier to be applied.\n\nI have no problem with listing of reviewers when submitting patches.\nTo say more, I prefer you list them by yourself and you add new reviewers\nwhen sending new versions of the patchset.\nBut I would like reviewers to be more careful. They are especially useful to\ndiscuss design choices and check typos.\nHaving reviewer give credits to the patch only if we are confident that the\nreview task is generally seriously achieved.", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 2C0867E92;\n\tWed, 15 Oct 2014 10:03:28 +0200 (CEST)", "from mail-wi0-f175.google.com (mail-wi0-f175.google.com\n\t[209.85.212.175]) by dpdk.org (Postfix) with ESMTP id D323C7E8E\n\tfor <dev@dpdk.org>; Wed, 15 Oct 2014 10:03:25 +0200 (CEST)", "by mail-wi0-f175.google.com with SMTP id d1so12176601wiv.14\n\tfor <dev@dpdk.org>; Wed, 15 Oct 2014 01:11:13 -0700 (PDT)", "from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])\n\tby mx.google.com with ESMTPSA id\n\tp1sm22896781wjy.22.2014.10.15.01.11.12 for <multiple recipients>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 15 Oct 2014 01:11:12 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:organization\n\t:user-agent:in-reply-to:references:mime-version\n\t:content-transfer-encoding:content-type;\n\tbh=EGNn6/koWup0H8sMATLwzLy1YQu/xEq68CeKIVbPJN4=;\n\tb=aOX/GW/6TCdRMVNL1YouCOa2XBt7KbnQP8RgF/l7DSMsUZrxphmiuwn+eotedIRK+8\n\tWvdxezyGCmCX/9nz38hWX5YdtqpMOuot99A0LCJZgJUHv0X9EeORYLscmmcRd50inXUa\n\teRam61lJlJIidxp2IySMP9akMvZ+TkP4O0ZSuQZl15nhQaVjrYnbSBEGlp9Ca1pz8YF+\n\tukzD44YZ34UGA5tKeL7eEYu/tukZgeiDQ4zabTOh8bORwE+C58Os7Ajg31x0uYHx2o9G\n\t9ALsqdcSvz4cUK9fJfocaRUXOnwz/9uZW/G+x+vlOSs0lHyRYBWobDaOvTFKBDGR3GN2\n\tOYXw==", "X-Gm-Message-State": "ALoCoQkSTJg3p3CHmceXBwb4Oax1mpzTCWylu+oezNgHBUlnxK7q7cOVWBdhYTEqlfJdkNOhFraR", "X-Received": "by 10.194.61.164 with SMTP id q4mr10376421wjr.60.1413360673667; \n\tWed, 15 Oct 2014 01:11:13 -0700 (PDT)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "\"Chen, Jing D\" <jing.d.chen@intel.com>", "Date": "Wed, 15 Oct 2014 10:10:58 +0200", "Message-ID": "<10317086.OmtuOpvoDk@xps13>", "Organization": "6WIND", "User-Agent": "KMail/4.14.1 (Linux/3.16.4-1-ARCH; KDE/4.14.1; x86_64; ; )", "In-Reply-To": "<4341B239C0EFF9468EE453F9E9F4604D015F35FE@shsmsx102.ccr.corp.intel.com>", "References": "<1411478047-1251-1-git-send-email-jing.d.chen@intel.com>\n\t<20784375.UWMeVtoV91@xps13>\n\t<4341B239C0EFF9468EE453F9E9F4604D015F35FE@shsmsx102.ccr.corp.intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "7Bit", "Content-Type": "text/plain; charset=\"us-ascii\"", "Cc": "dev@dpdk.org", "Subject": "Re: [dpdk-dev] [PATCH 1/6] ether: enhancement for VMDQ support", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 1663, "web_url": "https://patches.dpdk.org/comment/1663/", "msgid": "<4341B239C0EFF9468EE453F9E9F4604D015F36E1@shsmsx102.ccr.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/4341B239C0EFF9468EE453F9E9F4604D015F36E1@shsmsx102.ccr.corp.intel.com", "date": "2014-10-15T09:47:25", "subject": "Re: [dpdk-dev] [PATCH 1/6] ether: enhancement for VMDQ support", "submitter": { "id": 40, "url": "https://patches.dpdk.org/api/people/40/?format=api", "name": "Chen, Jing D", "email": "jing.d.chen@intel.com" }, "content": "> -----Original Message-----\n> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]\n> Sent: Wednesday, October 15, 2014 4:11 PM\n> To: Chen, Jing D\n> Cc: dev@dpdk.org\n> Subject: Re: [dpdk-dev] [PATCH 1/6] ether: enhancement for VMDQ support\n> \n> 2014-10-15 06:59, Chen, Jing D:\n> > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]\n> > > > enum rte_eth_rx_mq_mode {\n> > > > -\tETH_MQ_RX_NONE = 0, /**< None of DCB,RSS or VMDQ mode */\n> > > > -\n> > > > -\tETH_MQ_RX_RSS, /**< For RX side, only RSS is on */\n> > > > -\tETH_MQ_RX_DCB, /**< For RX side,only DCB is on. */\n> > > > -\tETH_MQ_RX_DCB_RSS, /**< Both DCB and RSS enable */\n> > > > -\n> > > > -\tETH_MQ_RX_VMDQ_ONLY, /**< Only VMDQ, no RSS nor DCB */\n> > > > -\tETH_MQ_RX_VMDQ_RSS, /**< RSS mode with VMDQ */\n> > > > -\tETH_MQ_RX_VMDQ_DCB, /**< Use VMDQ+DCB to route traffic to\n> > > queues */\n> > > > -\tETH_MQ_RX_VMDQ_DCB_RSS, /**< Enable both VMDQ and DCB in\n> > > VMDq */\n> > > > +\t/**< None of DCB,RSS or VMDQ mode */\n> > > > +\tETH_MQ_RX_NONE = 0,\n> > > > +\n> > > > +\t/**< For RX side, only RSS is on */\n> > > > +\tETH_MQ_RX_RSS = ETH_MQ_RX_RSS_FLAG,\n> > > > +\t/**< For RX side,only DCB is on. */\n> > > > +\tETH_MQ_RX_DCB = ETH_MQ_RX_DCB_FLAG,\n> > > > +\t/**< Both DCB and RSS enable */\n> > > > +\tETH_MQ_RX_DCB_RSS = ETH_MQ_RX_RSS_FLAG |\n> > > ETH_MQ_RX_DCB_FLAG,\n> > > > +\n> > > > +\t/**< Only VMDQ, no RSS nor DCB */\n> > > > +\tETH_MQ_RX_VMDQ_ONLY = ETH_MQ_RX_VMDQ_FLAG,\n> > > > +\t/**< RSS mode with VMDQ */\n> > > > +\tETH_MQ_RX_VMDQ_RSS = ETH_MQ_RX_RSS_FLAG |\n> > > ETH_MQ_RX_VMDQ_FLAG,\n> > > > +\t/**< Use VMDQ+DCB to route traffic to queues */\n> > > > +\tETH_MQ_RX_VMDQ_DCB = ETH_MQ_RX_VMDQ_FLAG |\n> > > ETH_MQ_RX_DCB_FLAG,\n> > > > +\t/**< Enable both VMDQ and DCB in VMDq */\n> > > > +\tETH_MQ_RX_VMDQ_DCB_RSS = ETH_MQ_RX_RSS_FLAG |\n> > > ETH_MQ_RX_DCB_FLAG |\n> > > > +\t\t\t\t ETH_MQ_RX_VMDQ_FLAG,\n> > > > };\n> > >\n> > > Why not simply remove all these combinations and keep only flags?\n> > > Please keep it simple.\n> >\n> > One reason is back-compatibility.\n> \n> I understand but I think we should prefer cleanup.\n> As there is no way to advertise deprecation of flags, it should be\n> simply removed.\n> \n> > Another reason is not all NIC driver support all the combined modes, only\n> limited sets\n> > driver supported. Under this condition, it's better to use the combination\n> definition\n> > (VMDQ_DCB, DCB_RSS, etc) to let driver check whether it supports.\n> \n> Driver can do the same checks with simple flags and it's probably simpler\n> (e.g. a driver which doesn't support VMDQ had no need to check all VMDQ\n> combinations).\n\n\nBelow is an example with the change in ixgbe_dcb_hw_configure(). DCB only \ncan be enabled in case DCB or VMDQ_DCB is selected.\n\nBefore the change:\n\nswitch(dev->data->dev_conf.rxmode.mq_mode){\ncase ETH_MQ_RX_VMDQ_DCB:\n.....\ncase ETH_MQ_RX_DCB:\n.....\ndefault:\nFAILED.\n}\n\nWith the change, it will be:\n\nswitch(dev->data->dev_conf.rxmode.mq_mode){\ncase ETH_MQ_RX_VMDQ_FLAG | ETH_MQ_RX_DCB_FLAG:\n.....\ncase ETH_MQ_RX_DCB_FLAG:\n.....\nDefault:\nFAILED\n}\n\nWon't it look weird for reading? In fact, it's more complex in rte_eth_dev_check_mq_mode(),\nWith the change, the code will look weird.\n\nIn fact, I don't see benefit with the change to old code. New PMD driver can use simple flag while\nold driver (IXGBE/IGB) can use original definition.\n\n> \n> > > There are only few typos and minor things but it would help to have more\n> > > careful reviews. Having a list of people at the beginning of the patch\n> > > didn't help in this case.\n> >\n> > I listed all the code reviewers out to reduce their workload to reply the\n> email,\n> > not mean to make it easier to be applied.\n> \n> I have no problem with listing of reviewers when submitting patches.\n> To say more, I prefer you list them by yourself and you add new reviewers\n> when sending new versions of the patchset.\n> But I would like reviewers to be more careful. They are especially useful to\n> discuss design choices and check typos.\n> Having reviewer give credits to the patch only if we are confident that the\n> review task is generally seriously achieved.\n> \n> --\n> Thomas", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 50D8A7E96;\n\tWed, 15 Oct 2014 11:40:16 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id 4AEF47E93\n\tfor <dev@dpdk.org>; Wed, 15 Oct 2014 11:40:13 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga102.jf.intel.com with ESMTP; 15 Oct 2014 02:41:34 -0700", "from fmsmsx107.amr.corp.intel.com ([10.18.124.205])\n\tby orsmga001.jf.intel.com with ESMTP; 15 Oct 2014 02:47:27 -0700", "from fmsmsx113.amr.corp.intel.com (10.18.116.7) by\n\tfmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP\n\tServer (TLS) id 14.3.195.1; Wed, 15 Oct 2014 02:47:27 -0700", "from shsmsx103.ccr.corp.intel.com (10.239.4.69) by\n\tFMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server\n\t(TLS) id 14.3.195.1; Wed, 15 Oct 2014 02:47:27 -0700", "from shsmsx102.ccr.corp.intel.com ([169.254.2.192]) by\n\tSHSMSX103.ccr.corp.intel.com ([169.254.4.204]) with mapi id\n\t14.03.0195.001; Wed, 15 Oct 2014 17:47:26 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.04,723,1406617200\"; d=\"scan'208\";a=\"589296607\"", "From": "\"Chen, Jing D\" <jing.d.chen@intel.com>", "To": "Thomas Monjalon <thomas.monjalon@6wind.com>", "Thread-Topic": "[dpdk-dev] [PATCH 1/6] ether: enhancement for VMDQ support", "Thread-Index": "AQHP1zBT6w/kKa8rS0Kz9pa3obOE+pwvPHsAgAGakvD//5OPAIAAmRyw", "Date": "Wed, 15 Oct 2014 09:47:25 +0000", "Message-ID": "<4341B239C0EFF9468EE453F9E9F4604D015F36E1@shsmsx102.ccr.corp.intel.com>", "References": "<1411478047-1251-1-git-send-email-jing.d.chen@intel.com>\n\t<20784375.UWMeVtoV91@xps13>\n\t<4341B239C0EFF9468EE453F9E9F4604D015F35FE@shsmsx102.ccr.corp.intel.com>\n\t<10317086.OmtuOpvoDk@xps13>", "In-Reply-To": "<10317086.OmtuOpvoDk@xps13>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[10.239.127.40]", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "Cc": "\"dev@dpdk.org\" <dev@dpdk.org>", "Subject": "Re: [dpdk-dev] [PATCH 1/6] ether: enhancement for VMDQ support", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 1664, "web_url": "https://patches.dpdk.org/comment/1664/", "msgid": "<2528969.6AYAK7jRAV@xps13>", "list_archive_url": "https://inbox.dpdk.org/dev/2528969.6AYAK7jRAV@xps13", "date": "2014-10-15T09:59:54", "subject": "Re: [dpdk-dev] [PATCH 1/6] ether: enhancement for VMDQ support", "submitter": { "id": 1, "url": "https://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "content": "2014-10-15 09:47, Chen, Jing D:\n> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]\n> > 2014-10-15 06:59, Chen, Jing D:\n> > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]\n> > > > > enum rte_eth_rx_mq_mode {\n> > > > > -\tETH_MQ_RX_NONE = 0, /**< None of DCB,RSS or VMDQ mode */\n> > > > > -\n> > > > > -\tETH_MQ_RX_RSS, /**< For RX side, only RSS is on */\n> > > > > -\tETH_MQ_RX_DCB, /**< For RX side,only DCB is on. */\n> > > > > -\tETH_MQ_RX_DCB_RSS, /**< Both DCB and RSS enable */\n> > > > > -\n> > > > > -\tETH_MQ_RX_VMDQ_ONLY, /**< Only VMDQ, no RSS nor DCB */\n> > > > > -\tETH_MQ_RX_VMDQ_RSS, /**< RSS mode with VMDQ */\n> > > > > -\tETH_MQ_RX_VMDQ_DCB, /**< Use VMDQ+DCB to route traffic to queues */\n> > > > > -\tETH_MQ_RX_VMDQ_DCB_RSS, /**< Enable both VMDQ and DCB in VMDq */\n> > > > > +\t/**< None of DCB,RSS or VMDQ mode */\n> > > > > +\tETH_MQ_RX_NONE = 0,\n> > > > > +\n> > > > > +\t/**< For RX side, only RSS is on */\n> > > > > +\tETH_MQ_RX_RSS = ETH_MQ_RX_RSS_FLAG,\n> > > > > +\t/**< For RX side,only DCB is on. */\n> > > > > +\tETH_MQ_RX_DCB = ETH_MQ_RX_DCB_FLAG,\n> > > > > +\t/**< Both DCB and RSS enable */\n> > > > > +\tETH_MQ_RX_DCB_RSS = ETH_MQ_RX_RSS_FLAG | ETH_MQ_RX_DCB_FLAG,\n> > > > > +\n> > > > > +\t/**< Only VMDQ, no RSS nor DCB */\n> > > > > +\tETH_MQ_RX_VMDQ_ONLY = ETH_MQ_RX_VMDQ_FLAG,\n> > > > > +\t/**< RSS mode with VMDQ */\n> > > > > +\tETH_MQ_RX_VMDQ_RSS = ETH_MQ_RX_RSS_FLAG | ETH_MQ_RX_VMDQ_FLAG,\n> > > > > +\t/**< Use VMDQ+DCB to route traffic to queues */\n> > > > > +\tETH_MQ_RX_VMDQ_DCB = ETH_MQ_RX_VMDQ_FLAG | ETH_MQ_RX_DCB_FLAG,\n> > > > > +\t/**< Enable both VMDQ and DCB in VMDq */\n> > > > > +\tETH_MQ_RX_VMDQ_DCB_RSS = ETH_MQ_RX_RSS_FLAG | ETH_MQ_RX_DCB_FLAG |\n> > > > > +\t\t\t\t ETH_MQ_RX_VMDQ_FLAG,\n> > > > > };\n> > > >\n> > > > Why not simply remove all these combinations and keep only flags?\n> > > > Please keep it simple.\n> > >\n> > > One reason is back-compatibility.\n> > \n> > I understand but I think we should prefer cleanup.\n> > As there is no way to advertise deprecation of flags, it should be\n> > simply removed.\n> > \n> > > Another reason is not all NIC driver support all the combined modes, only\n> > > limited sets\n> > > driver supported. Under this condition, it's better to use the combination\n> > > definition\n> > > (VMDQ_DCB, DCB_RSS, etc) to let driver check whether it supports.\n> > \n> > Driver can do the same checks with simple flags and it's probably simpler\n> > (e.g. a driver which doesn't support VMDQ had no need to check all VMDQ\n> > combinations).\n[...]\n> case ETH_MQ_RX_VMDQ_FLAG | ETH_MQ_RX_DCB_FLAG:\n[...] \n> Won't it look weird for reading? In fact, it's more complex in\n> rte_eth_dev_check_mq_mode(),\n> With the change, the code will look weird.\n\nI think that defining all combinations of flags is more weird.\n\n> In fact, I don't see benefit with the change to old code. New PMD driver\n> can use simple flag while old driver (IXGBE/IGB) can use original definition.\n\nIf nobody else agree with my point of view, I'll accept yours.", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 0F9597E9A;\n\tWed, 15 Oct 2014 11:52:27 +0200 (CEST)", "from mail-wg0-f41.google.com (mail-wg0-f41.google.com\n\t[74.125.82.41]) by dpdk.org (Postfix) with ESMTP id BBCC37E99\n\tfor <dev@dpdk.org>; Wed, 15 Oct 2014 11:52:23 +0200 (CEST)", "by mail-wg0-f41.google.com with SMTP id b13so941252wgh.12\n\tfor <dev@dpdk.org>; Wed, 15 Oct 2014 03:00:12 -0700 (PDT)", "from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])\n\tby mx.google.com with ESMTPSA id\n\tfa7sm23262027wjd.27.2014.10.15.03.00.10 for <multiple recipients>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 15 Oct 2014 03:00:11 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:organization\n\t:user-agent:in-reply-to:references:mime-version\n\t:content-transfer-encoding:content-type;\n\tbh=zc07hlbSaG75cpvTdLdHbo0ZKXh0sK6BHPHMNL1wghg=;\n\tb=LXYlFmvkOdgirVaH19fmSSMuzHijiWSXFA8NI9VNFiDu//QzAa99aylLQEaXwAi4YI\n\tgEde2hemrC4tr4GAB5n+xrW/ta8XfAy6dSAfMg+G0QSicU1FpmQ/qS/auGVrLm7B4nEU\n\tQiwKX9X0tSmhIGGx5X19UYUiQ84sWXm0g/puNp09UpAjRf0MR1y6Bq0+ACrWNPLvZVVx\n\tLjU52lsVjkEsf0MtKLKnUByyaEyK4B1FSkDBqHDu5Q/7f+EK/w3S65YQG/uf/bMYr1wu\n\tcD04EhWaDjc5oQeYinKeFy69KmbU6yHekG5tlW335H5HxezUq+Onxh9wu0jlo0zbalAs\n\t7GmA==", "X-Gm-Message-State": "ALoCoQnqx3cEyV7cCOKPaprgV4Qx6FYPn262h5pP54zA+KcVJjgKv1v2VO+WU7Zku93lfW35wvdq", "X-Received": "by 10.194.81.70 with SMTP id y6mr1701158wjx.113.1413367212099;\n\tWed, 15 Oct 2014 03:00:12 -0700 (PDT)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "\"Chen, Jing D\" <jing.d.chen@intel.com>", "Date": "Wed, 15 Oct 2014 11:59:54 +0200", "Message-ID": "<2528969.6AYAK7jRAV@xps13>", "Organization": "6WIND", "User-Agent": "KMail/4.14.1 (Linux/3.16.4-1-ARCH; KDE/4.14.1; x86_64; ; )", "In-Reply-To": "<4341B239C0EFF9468EE453F9E9F4604D015F36E1@shsmsx102.ccr.corp.intel.com>", "References": "<1411478047-1251-1-git-send-email-jing.d.chen@intel.com>\n\t<10317086.OmtuOpvoDk@xps13>\n\t<4341B239C0EFF9468EE453F9E9F4604D015F36E1@shsmsx102.ccr.corp.intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "7Bit", "Content-Type": "text/plain; charset=\"us-ascii\"", "Cc": "dev@dpdk.org", "Subject": "Re: [dpdk-dev] [PATCH 1/6] ether: enhancement for VMDQ support", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 1682, "web_url": "https://patches.dpdk.org/comment/1682/", "msgid": "<1413454046-13407-1-git-send-email-jing.d.chen@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1413454046-13407-1-git-send-email-jing.d.chen@intel.com", "date": "2014-10-16T10:07:20", "subject": "[dpdk-dev] [PATCH v2 0/6] i40e VMDQ support", "submitter": { "id": 40, "url": "https://patches.dpdk.org/api/people/40/?format=api", "name": "Chen, Jing D", "email": "jing.d.chen@intel.com" }, "content": "From: \"Chen Jing D(Mark)\" <jing.d.chen@intel.com>\n\nv2:\n- Fix a few typos.\n- Add comments for RX mq mode flags.\n- Remove '\\n' from some log messages.\n- Remove 'Acked-by' in commit log.\n\nv1:\nDefine extra VMDQ arguments to expand VMDQ configuration. This also\nincludes change in igb and ixgbe PMD driver. In the meanwhile, fix 2\ndefects in rte_ether library.\n\nAdd full VMDQ support in i40e PMD driver. renamed some functions, setup\nVMDQ VSI after it's enabled in application. It also make some improvement\non macaddr add/delete to support setting multiple macaddr for single or\nmultiple pools.\n\nFinally, change i40e rx/tx_queue_setup and dev_start/stop functions to\nconfigure/switch queues belonging to VMDQ pools.\n\n\nChen Jing D(Mark) (6):\n ether: enhancement for VMDQ support\n igb: change for VMDQ arguments expansion\n ixgbe: change for VMDQ arguments expansion\n i40e: add VMDQ support\n i40e: macaddr add/del enhancement\n i40e: Add full VMDQ pools support\n\n config/common_linuxapp | 1 +\n lib/librte_ether/rte_ethdev.c | 12 +-\n lib/librte_ether/rte_ethdev.h | 43 +++-\n lib/librte_pmd_e1000/igb_ethdev.c | 3 +\n lib/librte_pmd_i40e/i40e_ethdev.c | 499 ++++++++++++++++++++++++++---------\n lib/librte_pmd_i40e/i40e_ethdev.h | 21 ++-\n lib/librte_pmd_i40e/i40e_rxtx.c | 125 +++++++--\n lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 1 +\n 8 files changed, 536 insertions(+), 169 deletions(-)", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id A9BFB7E72;\n\tThu, 16 Oct 2014 11:59:59 +0200 (CEST)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id BD3547E6E\n\tfor <dev@dpdk.org>; Thu, 16 Oct 2014 11:59:57 +0200 (CEST)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga103.fm.intel.com with ESMTP; 16 Oct 2014 02:57:46 -0700", "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby fmsmga001.fm.intel.com with ESMTP; 16 Oct 2014 03:07:47 -0700", "from shecgisg003.sh.intel.com (shecgisg003.sh.intel.com\n\t[10.239.29.90])\n\tby shvmail01.sh.intel.com with ESMTP id s9GA7kud007038;\n\tThu, 16 Oct 2014 18:07:46 +0800", "from shecgisg003.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg003.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid s9GA7hgj013441; Thu, 16 Oct 2014 18:07:45 +0800", "(from jingche2@localhost)\n\tby shecgisg003.sh.intel.com (8.13.6/8.13.6/Submit) id s9GA7hL7013437; \n\tThu, 16 Oct 2014 18:07:43 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.04,731,1406617200\"; d=\"scan'208\";a=\"606347163\"", "From": "\"Chen Jing D(Mark)\" <jing.d.chen@intel.com>", "To": "dev@dpdk.org", "Date": "Thu, 16 Oct 2014 18:07:20 +0800", "Message-Id": "<1413454046-13407-1-git-send-email-jing.d.chen@intel.com>", "X-Mailer": "git-send-email 1.7.12.2", "In-Reply-To": "<1411478047-1251-2-git-send-email-jing.d.chen@intel.com>", "References": "<1411478047-1251-2-git-send-email-jing.d.chen@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 0/6] i40e VMDQ support", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 1779, "web_url": "https://patches.dpdk.org/comment/1779/", "msgid": "<B6059B2012717B4390714544B1F509E110D920B7@SHSMSX103.ccr.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/B6059B2012717B4390714544B1F509E110D920B7@SHSMSX103.ccr.corp.intel.com", "date": "2014-10-21T03:30:04", "subject": "Re: [dpdk-dev] [PATCH v2 0/6] i40e VMDQ support", "submitter": { "id": 54, "url": "https://patches.dpdk.org/api/people/54/?format=api", "name": "Cao, Min", "email": "min.cao@intel.com" }, "content": "Tested-by: Min Cao <min.cao@intel.com>\n\nThis patch has been verified on fortville and it is ready to be integrated to dpdk.org.\n\n-----Original Message-----\nFrom: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Chen Jing D(Mark)\nSent: Thursday, October 16, 2014 6:07 PM\nTo: dev@dpdk.org\nSubject: [dpdk-dev] [PATCH v2 0/6] i40e VMDQ support\n\nFrom: \"Chen Jing D(Mark)\" <jing.d.chen@intel.com>\n\nv2:\n- Fix a few typos.\n- Add comments for RX mq mode flags.\n- Remove '\\n' from some log messages.\n- Remove 'Acked-by' in commit log.\n\nv1:\nDefine extra VMDQ arguments to expand VMDQ configuration. This also\nincludes change in igb and ixgbe PMD driver. In the meanwhile, fix 2\ndefects in rte_ether library.\n\nAdd full VMDQ support in i40e PMD driver. renamed some functions, setup\nVMDQ VSI after it's enabled in application. It also make some improvement\non macaddr add/delete to support setting multiple macaddr for single or\nmultiple pools.\n\nFinally, change i40e rx/tx_queue_setup and dev_start/stop functions to\nconfigure/switch queues belonging to VMDQ pools.\n\n\nChen Jing D(Mark) (6):\n ether: enhancement for VMDQ support\n igb: change for VMDQ arguments expansion\n ixgbe: change for VMDQ arguments expansion\n i40e: add VMDQ support\n i40e: macaddr add/del enhancement\n i40e: Add full VMDQ pools support\n\n config/common_linuxapp | 1 +\n lib/librte_ether/rte_ethdev.c | 12 +-\n lib/librte_ether/rte_ethdev.h | 43 +++-\n lib/librte_pmd_e1000/igb_ethdev.c | 3 +\n lib/librte_pmd_i40e/i40e_ethdev.c | 499 ++++++++++++++++++++++++++---------\n lib/librte_pmd_i40e/i40e_ethdev.h | 21 ++-\n lib/librte_pmd_i40e/i40e_rxtx.c | 125 +++++++--\n lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 1 +\n 8 files changed, 536 insertions(+), 169 deletions(-)", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 623E07E96;\n\tTue, 21 Oct 2014 05:23:52 +0200 (CEST)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id 9FC007E7A\n\tfor <dev@dpdk.org>; Tue, 21 Oct 2014 05:23:50 +0200 (CEST)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga101.fm.intel.com with ESMTP; 20 Oct 2014 20:32:04 -0700", "from pgsmsx103.gar.corp.intel.com ([10.221.44.82])\n\tby fmsmga001.fm.intel.com with ESMTP; 20 Oct 2014 20:31:29 -0700", "from pgsmsx102.gar.corp.intel.com (10.221.44.80) by\n\tPGSMSX103.gar.corp.intel.com (10.221.44.82) with Microsoft SMTP\n\tServer (TLS) id 14.3.195.1; Tue, 21 Oct 2014 11:30:16 +0800", "from shsmsx104.ccr.corp.intel.com (10.239.4.70) by\n\tPGSMSX102.gar.corp.intel.com (10.221.44.80) with Microsoft SMTP\n\tServer (TLS) id 14.3.195.1; Tue, 21 Oct 2014 11:30:16 +0800", "from shsmsx103.ccr.corp.intel.com ([169.254.4.207]) by\n\tSHSMSX104.ccr.corp.intel.com ([169.254.5.174]) with mapi id\n\t14.03.0195.001; Tue, 21 Oct 2014 11:30:05 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.04,760,1406617200\"; d=\"scan'208\";a=\"608469343\"", "From": "\"Cao, Min\" <min.cao@intel.com>", "To": "\"Chen, Jing D\" <jing.d.chen@intel.com>, \"dev@dpdk.org\" <dev@dpdk.org>", "Thread-Topic": "[dpdk-dev] [PATCH v2 0/6] i40e VMDQ support", "Thread-Index": "AQHP6SkcyfN3JqFSSU+7D3cqiftx6Zw565TQ", "Date": "Tue, 21 Oct 2014 03:30:04 +0000", "Message-ID": "<B6059B2012717B4390714544B1F509E110D920B7@SHSMSX103.ccr.corp.intel.com>", "References": "<1411478047-1251-2-git-send-email-jing.d.chen@intel.com>\n\t<1413454046-13407-1-git-send-email-jing.d.chen@intel.com>", "In-Reply-To": "<1413454046-13407-1-git-send-email-jing.d.chen@intel.com>", "Accept-Language": "zh-CN, en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[10.239.127.40]", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "Subject": "Re: [dpdk-dev] [PATCH v2 0/6] i40e VMDQ support", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 2184, "web_url": "https://patches.dpdk.org/comment/2184/", "msgid": "<4341B239C0EFF9468EE453F9E9F4604D01605B4D@shsmsx102.ccr.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/4341B239C0EFF9468EE453F9E9F4604D01605B4D@shsmsx102.ccr.corp.intel.com", "date": "2014-11-03T07:54:10", "subject": "Re: [dpdk-dev] [PATCH v2 0/6] i40e VMDQ support", "submitter": { "id": 40, "url": "https://patches.dpdk.org/api/people/40/?format=api", "name": "Chen, Jing D", "email": "jing.d.chen@intel.com" }, "content": "Hi,\n\nAny comments on this patch?\n\n> -----Original Message-----\n> From: Chen, Jing D\n> Sent: Thursday, October 16, 2014 6:07 PM\n> To: dev@dpdk.org\n> Cc: Ananyev, Konstantin; thomas.monjalon@6wind.com; Chen, Jing D\n> Subject: [PATCH v2 0/6] i40e VMDQ support\n> \n> From: \"Chen Jing D(Mark)\" <jing.d.chen@intel.com>\n> \n> v2:\n> - Fix a few typos.\n> - Add comments for RX mq mode flags.\n> - Remove '\\n' from some log messages.\n> - Remove 'Acked-by' in commit log.\n> \n> v1:\n> Define extra VMDQ arguments to expand VMDQ configuration. This also\n> includes change in igb and ixgbe PMD driver. In the meanwhile, fix 2\n> defects in rte_ether library.\n> \n> Add full VMDQ support in i40e PMD driver. renamed some functions, setup\n> VMDQ VSI after it's enabled in application. It also make some improvement\n> on macaddr add/delete to support setting multiple macaddr for single or\n> multiple pools.\n> \n> Finally, change i40e rx/tx_queue_setup and dev_start/stop functions to\n> configure/switch queues belonging to VMDQ pools.\n> \n> \n> Chen Jing D(Mark) (6):\n> ether: enhancement for VMDQ support\n> igb: change for VMDQ arguments expansion\n> ixgbe: change for VMDQ arguments expansion\n> i40e: add VMDQ support\n> i40e: macaddr add/del enhancement\n> i40e: Add full VMDQ pools support\n> \n> config/common_linuxapp | 1 +\n> lib/librte_ether/rte_ethdev.c | 12 +-\n> lib/librte_ether/rte_ethdev.h | 43 +++-\n> lib/librte_pmd_e1000/igb_ethdev.c | 3 +\n> lib/librte_pmd_i40e/i40e_ethdev.c | 499\n> ++++++++++++++++++++++++++---------\n> lib/librte_pmd_i40e/i40e_ethdev.h | 21 ++-\n> lib/librte_pmd_i40e/i40e_rxtx.c | 125 +++++++--\n> lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 1 +\n> 8 files changed, 536 insertions(+), 169 deletions(-)\n> \n> --\n> 1.7.7.6", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id C478658D2;\n\tMon, 3 Nov 2014 08:46:50 +0100 (CET)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id 566712A9\n\tfor <dev@dpdk.org>; Mon, 3 Nov 2014 08:46:49 +0100 (CET)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga101.jf.intel.com with ESMTP; 02 Nov 2014 23:56:01 -0800", "from pgsmsx101.gar.corp.intel.com ([10.221.44.78])\n\tby orsmga002.jf.intel.com with ESMTP; 02 Nov 2014 23:56:00 -0800", "from kmsmsx152.gar.corp.intel.com (172.21.73.87) by\n\tPGSMSX101.gar.corp.intel.com (10.221.44.78) with Microsoft SMTP\n\tServer (TLS) id 14.3.195.1; Mon, 3 Nov 2014 15:54:12 +0800", "from shsmsx104.ccr.corp.intel.com (10.239.4.70) by\n\tKMSMSX152.gar.corp.intel.com (172.21.73.87) with Microsoft SMTP\n\tServer (TLS) id 14.3.195.1; Mon, 3 Nov 2014 15:54:12 +0800", "from shsmsx102.ccr.corp.intel.com ([169.254.2.156]) by\n\tSHSMSX104.ccr.corp.intel.com ([169.254.5.174]) with mapi id\n\t14.03.0195.001; Mon, 3 Nov 2014 15:54:11 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.07,305,1413270000\"; d=\"scan'208\";a=\"630162908\"", "From": "\"Chen, Jing D\" <jing.d.chen@intel.com>", "To": "\"dev@dpdk.org\" <dev@dpdk.org>", "Thread-Topic": "[PATCH v2 0/6] i40e VMDQ support", "Thread-Index": "AQHP6SkNgvA0kbTqhUaBN1RDX3CQVJxOpB2g", "Date": "Mon, 3 Nov 2014 07:54:10 +0000", "Message-ID": "<4341B239C0EFF9468EE453F9E9F4604D01605B4D@shsmsx102.ccr.corp.intel.com>", "References": "<1411478047-1251-2-git-send-email-jing.d.chen@intel.com>\n\t<1413454046-13407-1-git-send-email-jing.d.chen@intel.com>", "In-Reply-To": "<1413454046-13407-1-git-send-email-jing.d.chen@intel.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[10.239.127.40]", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "Subject": "Re: [dpdk-dev] [PATCH v2 0/6] i40e VMDQ support", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 2255, "web_url": "https://patches.dpdk.org/comment/2255/", "msgid": "<1415095289-28961-1-git-send-email-jing.d.chen@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1415095289-28961-1-git-send-email-jing.d.chen@intel.com", "date": "2014-11-04T10:01:23", "subject": "[dpdk-dev] [PATCH v3 0/6] i40e VMDQ support", "submitter": { "id": 40, "url": "https://patches.dpdk.org/api/people/40/?format=api", "name": "Chen, Jing D", "email": "jing.d.chen@intel.com" }, "content": "From: \"Chen Jing D(Mark)\" <jing.d.chen@intel.com>\n\nv3:\n- Fix comments style.\n- Simplify words in comments.\n- Add variable defintion for BSD config file.\n- Code rebase to latest DPDK repo.\n\nv2:\n- Fix a few typos.\n- Add comments for RX mq mode flags.\n- Remove '\\n' from some log messages.\n- Remove 'Acked-by' in commit log.\n\nv1:\nDefine extra VMDQ arguments to expand VMDQ configuration. This also\nincludes change in igb and ixgbe PMD driver. In the meanwhile, fix 2\ndefects in rte_ether library.\n\nAdd full VMDQ support in i40e PMD driver. renamed some functions, setup\nVMDQ VSI after it's enabled in application. It also make some improvement\non macaddr add/delete to support setting multiple macaddr for single or\nmultiple pools.\n\nFinally, change i40e rx/tx_queue_setup and dev_start/stop functions to\nconfigure/switch queues belonging to VMDQ pools.\n\n\nChen Jing D(Mark) (6):\n ether: enhancement for VMDQ support\n igb: change for VMDQ arguments expansion\n ixgbe: change for VMDQ arguments expansion\n i40e: add VMDQ support\n i40e: macaddr add/del enhancement\n i40e: Add full VMDQ pools support\n\n config/common_bsdapp | 1 +\n config/common_linuxapp | 1 +\n lib/librte_ether/rte_ethdev.c | 6 +-\n lib/librte_ether/rte_ethdev.h | 41 ++-\n lib/librte_pmd_e1000/igb_ethdev.c | 3 +\n lib/librte_pmd_i40e/i40e_ethdev.c | 498 ++++++++++++++++++++++++++---------\n lib/librte_pmd_i40e/i40e_ethdev.h | 21 ++-\n lib/librte_pmd_i40e/i40e_rxtx.c | 125 +++++++--\n lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 1 +\n 9 files changed, 532 insertions(+), 165 deletions(-)", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 6C6DA7E75;\n\tTue, 4 Nov 2014 10:52:27 +0100 (CET)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id 5BBCF7E04\n\tfor <dev@dpdk.org>; Tue, 4 Nov 2014 10:52:24 +0100 (CET)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby fmsmga103.fm.intel.com with ESMTP; 04 Nov 2014 01:55:27 -0800", "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby FMSMGA003.fm.intel.com with ESMTP; 04 Nov 2014 01:53:13 -0800", "from shecgisg003.sh.intel.com (shecgisg003.sh.intel.com\n\t[10.239.29.90])\n\tby shvmail01.sh.intel.com with ESMTP id sA4A1bXi011214;\n\tTue, 4 Nov 2014 18:01:37 +0800", "from shecgisg003.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg003.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid sA4A1Zeq028995; Tue, 4 Nov 2014 18:01:37 +0800", "(from jingche2@localhost)\n\tby shecgisg003.sh.intel.com (8.13.6/8.13.6/Submit) id sA4A1YLf028991; \n\tTue, 4 Nov 2014 18:01:34 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"4.97,862,1389772800\"; d=\"scan'208\";a=\"411065155\"", "From": "\"Chen Jing D(Mark)\" <jing.d.chen@intel.com>", "To": "dev@dpdk.org", "Date": "Tue, 4 Nov 2014 18:01:23 +0800", "Message-Id": "<1415095289-28961-1-git-send-email-jing.d.chen@intel.com>", "X-Mailer": "git-send-email 1.7.12.2", "In-Reply-To": "<1411478047-1251-2-git-send-email-jing.d.chen@intel.com>", "References": "<1411478047-1251-2-git-send-email-jing.d.chen@intel.com>", "Subject": "[dpdk-dev] [PATCH v3 0/6] i40e VMDQ support", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 2263, "web_url": "https://patches.dpdk.org/comment/2263/", "msgid": "<2601191342CEEE43887BDE71AB977258213A249C@IRSMSX105.ger.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/2601191342CEEE43887BDE71AB977258213A249C@IRSMSX105.ger.corp.intel.com", "date": "2014-11-04T11:19:30", "subject": "Re: [dpdk-dev] [PATCH v3 0/6] i40e VMDQ support", "submitter": { "id": 33, "url": "https://patches.dpdk.org/api/people/33/?format=api", "name": "Ananyev, Konstantin", "email": "konstantin.ananyev@intel.com" }, "content": "> From: Chen, Jing D\n> Sent: Tuesday, November 04, 2014 10:01 AM\n> To: dev@dpdk.org\n> Cc: Ananyev, Konstantin; thomas.monjalon@6wind.com; De Lara Guarch, Pablo; Chen, Jing D\n> Subject: [PATCH v3 0/6] i40e VMDQ support\n> \n> From: \"Chen Jing D(Mark)\" <jing.d.chen@intel.com>\n> \n> v3:\n> - Fix comments style.\n> - Simplify words in comments.\n> - Add variable defintion for BSD config file.\n> - Code rebase to latest DPDK repo.\n> \n> v2:\n> - Fix a few typos.\n> - Add comments for RX mq mode flags.\n> - Remove '\\n' from some log messages.\n> - Remove 'Acked-by' in commit log.\n> \n> v1:\n> Define extra VMDQ arguments to expand VMDQ configuration. This also\n> includes change in igb and ixgbe PMD driver. In the meanwhile, fix 2\n> defects in rte_ether library.\n> \n> Add full VMDQ support in i40e PMD driver. renamed some functions, setup\n> VMDQ VSI after it's enabled in application. It also make some improvement\n> on macaddr add/delete to support setting multiple macaddr for single or\n> multiple pools.\n> \n> Finally, change i40e rx/tx_queue_setup and dev_start/stop functions to\n> configure/switch queues belonging to VMDQ pools.\n> \n> \n> Chen Jing D(Mark) (6):\n> ether: enhancement for VMDQ support\n> igb: change for VMDQ arguments expansion\n> ixgbe: change for VMDQ arguments expansion\n> i40e: add VMDQ support\n> i40e: macaddr add/del enhancement\n> i40e: Add full VMDQ pools support\n> \n> config/common_bsdapp | 1 +\n> config/common_linuxapp | 1 +\n> lib/librte_ether/rte_ethdev.c | 6 +-\n> lib/librte_ether/rte_ethdev.h | 41 ++-\n> lib/librte_pmd_e1000/igb_ethdev.c | 3 +\n> lib/librte_pmd_i40e/i40e_ethdev.c | 498 ++++++++++++++++++++++++++---------\n> lib/librte_pmd_i40e/i40e_ethdev.h | 21 ++-\n> lib/librte_pmd_i40e/i40e_rxtx.c | 125 +++++++--\n> lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 1 +\n> 9 files changed, 532 insertions(+), 165 deletions(-)\n> \n> --\n> 1.7.7.6\n\nAcked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id D4F1C7E97;\n\tTue, 4 Nov 2014 12:10:33 +0100 (CET)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id 76FD37E75\n\tfor <dev@dpdk.org>; Tue, 4 Nov 2014 12:10:31 +0100 (CET)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga102.fm.intel.com with ESMTP; 04 Nov 2014 03:19:48 -0800", "from irsmsx104.ger.corp.intel.com ([163.33.3.159])\n\tby fmsmga002.fm.intel.com with ESMTP; 04 Nov 2014 03:19:47 -0800", "from irsmsx108.ger.corp.intel.com (163.33.3.3) by\n\tIRSMSX104.ger.corp.intel.com (163.33.3.159) with Microsoft SMTP\n\tServer (TLS) id 14.3.195.1; Tue, 4 Nov 2014 11:19:30 +0000", "from irsmsx105.ger.corp.intel.com ([169.254.7.56]) by\n\tIRSMSX108.ger.corp.intel.com ([169.254.11.82]) with mapi id\n\t14.03.0195.001; Tue, 4 Nov 2014 11:19:30 +0000" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.07,312,1413270000\"; d=\"scan'208\";a=\"626181407\"", "From": "\"Ananyev, Konstantin\" <konstantin.ananyev@intel.com>", "To": "\"Chen, Jing D\" <jing.d.chen@intel.com>, \"dev@dpdk.org\" <dev@dpdk.org>", "Thread-Topic": "[PATCH v3 0/6] i40e VMDQ support", "Thread-Index": "AQHP+BZV5aT+53xFZ0uB1wwZtcYW3pxQUUyg", "Date": "Tue, 4 Nov 2014 11:19:30 +0000", "Message-ID": "<2601191342CEEE43887BDE71AB977258213A249C@IRSMSX105.ger.corp.intel.com>", "References": "<1411478047-1251-2-git-send-email-jing.d.chen@intel.com>\n\t<1415095289-28961-1-git-send-email-jing.d.chen@intel.com>", "In-Reply-To": "<1415095289-28961-1-git-send-email-jing.d.chen@intel.com>", "Accept-Language": "en-IE, en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[163.33.239.180]", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "Subject": "Re: [dpdk-dev] [PATCH v3 0/6] i40e VMDQ support", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 2271, "web_url": "https://patches.dpdk.org/comment/2271/", "msgid": "<41622560.Wpna8IZiRk@xps13>", "list_archive_url": "https://inbox.dpdk.org/dev/41622560.Wpna8IZiRk@xps13", "date": "2014-11-04T23:17:29", "subject": "Re: [dpdk-dev] [PATCH v3 0/6] i40e VMDQ support", "submitter": { "id": 1, "url": "https://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "content": "> > v3:\n> > - Fix comments style.\n> > - Simplify words in comments.\n> > - Add variable defintion for BSD config file.\n> > - Code rebase to latest DPDK repo.\n> > \n> > v2:\n> > - Fix a few typos.\n> > - Add comments for RX mq mode flags.\n> > - Remove '\\n' from some log messages.\n> > - Remove 'Acked-by' in commit log.\n> > \n> > v1:\n> > Define extra VMDQ arguments to expand VMDQ configuration. This also\n> > includes change in igb and ixgbe PMD driver. In the meanwhile, fix 2\n> > defects in rte_ether library.\n> > \n> > Add full VMDQ support in i40e PMD driver. renamed some functions, setup\n> > VMDQ VSI after it's enabled in application. It also make some improvement\n> > on macaddr add/delete to support setting multiple macaddr for single or\n> > multiple pools.\n> > \n> > Finally, change i40e rx/tx_queue_setup and dev_start/stop functions to\n> > configure/switch queues belonging to VMDQ pools.\n> > \n> > Chen Jing D(Mark) (6):\n> > ether: enhancement for VMDQ support\n> > igb: change for VMDQ arguments expansion\n> > ixgbe: change for VMDQ arguments expansion\n> > i40e: add VMDQ support\n> > i40e: macaddr add/del enhancement\n> > i40e: Add full VMDQ pools support\n> \n> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>\n\nApplied\n\nIt will need to be well explained in the programmer's guide.\n\nThanks", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 467095944;\n\tWed, 5 Nov 2014 00:08:35 +0100 (CET)", "from mail-wg0-f45.google.com (mail-wg0-f45.google.com\n\t[74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 660C13989\n\tfor <dev@dpdk.org>; Wed, 5 Nov 2014 00:08:34 +0100 (CET)", "by mail-wg0-f45.google.com with SMTP id x12so14765916wgg.32\n\tfor <dev@dpdk.org>; Tue, 04 Nov 2014 15:17:53 -0800 (PST)", "from xps13.localnet (guy78-1-82-235-116-147.fbx.proxad.net.\n\t[82.235.116.147]) by mx.google.com with ESMTPSA id\n\tdc8sm2594664wib.7.2014.11.04.15.17.52 for <multiple recipients>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 04 Nov 2014 15:17:52 -0800 (PST)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:organization\n\t:user-agent:in-reply-to:references:mime-version\n\t:content-transfer-encoding:content-type;\n\tbh=isa62phNu5RFCxE8Muf+fw/0JVHfJCMijr1cmvoMo9A=;\n\tb=JziJZ97JpPtV1TrywpInZKBTs1pi5Tr4F98S1HyNFQvd+Ug9UOfYAyNZC2M5QjrGdG\n\tNJ3RAxUK8VsjUF/o+OorkET/08LzfyJVW1cA8R0gy9Y7jBlED3B+hvTvcukDZ5FQAFdb\n\tZ/+lR/b+TYrO03Ts/l4ygtBrHUWew/VPLvs6EXSrsWmrGvxRRlaA7oXvPHXRSI4bmGfF\n\tQ1flgixV+emaFlvsKBLonRMS47ShmCje9u2S1ZsXB5OdcjzHiQziGYG49KW/a7cq1Asz\n\tBrsEceV7VzV4pn4iGPlk3C19KVfg1NHHS/+ysZi3YNoqr6bRwA0h0nhTlhDhsigYEY/B\n\tLv3A==", "X-Gm-Message-State": "ALoCoQlhQY8iyXURBAHiwAG94ZE3AJH5dEd+8iXIfX5OSTay6j1XZ5CwNlRQcMoaDLkHj5HN5Ven", "X-Received": "by 10.194.82.161 with SMTP id j1mr60273841wjy.38.1415143073767; \n\tTue, 04 Nov 2014 15:17:53 -0800 (PST)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "\"Chen, Jing D\" <jing.d.chen@intel.com>", "Date": "Wed, 05 Nov 2014 00:17:29 +0100", "Message-ID": "<41622560.Wpna8IZiRk@xps13>", "Organization": "6WIND", "User-Agent": "KMail/4.14.2 (Linux/3.17.2-1-ARCH; KDE/4.14.2; x86_64; ; )", "In-Reply-To": "<2601191342CEEE43887BDE71AB977258213A249C@IRSMSX105.ger.corp.intel.com>", "References": "<1411478047-1251-2-git-send-email-jing.d.chen@intel.com>\n\t<1415095289-28961-1-git-send-email-jing.d.chen@intel.com>\n\t<2601191342CEEE43887BDE71AB977258213A249C@IRSMSX105.ger.corp.intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "7Bit", "Content-Type": "text/plain; charset=\"us-ascii\"", "Cc": "dev@dpdk.org", "Subject": "Re: [dpdk-dev] [PATCH v3 0/6] i40e VMDQ support", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 4048, "web_url": "https://patches.dpdk.org/comment/4048/", "msgid": "<B6059B2012717B4390714544B1F509E110DF061A@SHSMSX103.ccr.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/B6059B2012717B4390714544B1F509E110DF061A@SHSMSX103.ccr.corp.intel.com", "date": "2014-12-11T06:09:53", "subject": "Re: [dpdk-dev] [PATCH v3 0/6] i40e VMDQ support", "submitter": { "id": 54, "url": "https://patches.dpdk.org/api/people/54/?format=api", "name": "Cao, Min", "email": "min.cao@intel.com" }, "content": "Tested-by: Min Cao <min.cao@intel.com>\n\nPatch name: \t\ti40e VMDQ support\nBrief description: \t\nTest Flag: \t\t\tTested-by\nTester name: \t\tmin.cao@intel.com\nResult summary:\t\ttotal 1 cases, 1 passed, 0 failed\n\nTest Case 1:\t\t\nName:\t\t\t\tperf_vmdq_performance\nEnvironment:\t\tOS: Fedora20 3.11.10-301.fc20.x86_64\n\t\t\t\tgcc (GCC) 4.8.2\n\t\t\t\tCPU: Intel(R) Xeon(R) CPU E5-2680 0 @ 2.70GHz\n\t\t\t\tNIC: Fortville eagle\nTest result:\t\tPASSED\n\n-----Original Message-----\nFrom: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Chen Jing D(Mark)\nSent: Tuesday, November 04, 2014 6:01 PM\nTo: dev@dpdk.org\nSubject: [dpdk-dev] [PATCH v3 0/6] i40e VMDQ support\n\nFrom: \"Chen Jing D(Mark)\" <jing.d.chen@intel.com>\n\nv3:\n- Fix comments style.\n- Simplify words in comments.\n- Add variable defintion for BSD config file.\n- Code rebase to latest DPDK repo.\n\nv2:\n- Fix a few typos.\n- Add comments for RX mq mode flags.\n- Remove '\\n' from some log messages.\n- Remove 'Acked-by' in commit log.\n\nv1:\nDefine extra VMDQ arguments to expand VMDQ configuration. This also\nincludes change in igb and ixgbe PMD driver. In the meanwhile, fix 2\ndefects in rte_ether library.\n\nAdd full VMDQ support in i40e PMD driver. renamed some functions, setup\nVMDQ VSI after it's enabled in application. It also make some improvement\non macaddr add/delete to support setting multiple macaddr for single or\nmultiple pools.\n\nFinally, change i40e rx/tx_queue_setup and dev_start/stop functions to\nconfigure/switch queues belonging to VMDQ pools.\n\n\nChen Jing D(Mark) (6):\n ether: enhancement for VMDQ support\n igb: change for VMDQ arguments expansion\n ixgbe: change for VMDQ arguments expansion\n i40e: add VMDQ support\n i40e: macaddr add/del enhancement\n i40e: Add full VMDQ pools support\n\n config/common_bsdapp | 1 +\n config/common_linuxapp | 1 +\n lib/librte_ether/rte_ethdev.c | 6 +-\n lib/librte_ether/rte_ethdev.h | 41 ++-\n lib/librte_pmd_e1000/igb_ethdev.c | 3 +\n lib/librte_pmd_i40e/i40e_ethdev.c | 498 ++++++++++++++++++++++++++---------\n lib/librte_pmd_i40e/i40e_ethdev.h | 21 ++-\n lib/librte_pmd_i40e/i40e_rxtx.c | 125 +++++++--\n lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 1 +\n 9 files changed, 532 insertions(+), 165 deletions(-)", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 3C89C7E23;\n\tThu, 11 Dec 2014 07:10:02 +0100 (CET)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id 516C568BE\n\tfor <dev@dpdk.org>; Thu, 11 Dec 2014 07:10:00 +0100 (CET)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga101.fm.intel.com with ESMTP; 10 Dec 2014 22:09:59 -0800", "from pgsmsx104.gar.corp.intel.com ([10.221.44.91])\n\tby fmsmga001.fm.intel.com with ESMTP; 10 Dec 2014 22:09:57 -0800", "from shsmsx104.ccr.corp.intel.com (10.239.4.70) by\n\tPGSMSX104.gar.corp.intel.com (10.221.44.91) with Microsoft SMTP\n\tServer (TLS) id 14.3.195.1; Thu, 11 Dec 2014 14:09:56 +0800", "from shsmsx103.ccr.corp.intel.com ([169.254.4.240]) by\n\tSHSMSX104.ccr.corp.intel.com ([169.254.5.182]) with mapi id\n\t14.03.0195.001; Thu, 11 Dec 2014 14:09:53 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.07,556,1413270000\"; d=\"scan'208\";a=\"635960882\"", "From": "\"Cao, Min\" <min.cao@intel.com>", "To": "\"dev@dpdk.org\" <dev@dpdk.org>", "Thread-Topic": "[dpdk-dev] [PATCH v3 0/6] i40e VMDQ support", "Thread-Index": "AQHP+BZ9DcPesZFYGkWa/BhVj+c9MpyKIc5w", "Date": "Thu, 11 Dec 2014 06:09:53 +0000", "Message-ID": "<B6059B2012717B4390714544B1F509E110DF061A@SHSMSX103.ccr.corp.intel.com>", "References": "<1411478047-1251-2-git-send-email-jing.d.chen@intel.com>\n\t<1415095289-28961-1-git-send-email-jing.d.chen@intel.com>", "In-Reply-To": "<1415095289-28961-1-git-send-email-jing.d.chen@intel.com>", "Accept-Language": "zh-CN, en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[10.239.127.40]", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "Subject": "Re: [dpdk-dev] [PATCH v3 0/6] i40e VMDQ support", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]