Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 4586,
    "url": "https://patches.dpdk.org/api/patches/4586/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1430406219-23901-21-git-send-email-helin.zhang@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1430406219-23901-21-git-send-email-helin.zhang@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1430406219-23901-21-git-send-email-helin.zhang@intel.com",
    "date": "2015-04-30T15:03:26",
    "name": "[dpdk-dev,v2,20/33] i40e/base: i40e_aq_get_link_info() should be used directly",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "87e7deeb148fda710828f7f5226d66174fe44cfc",
    "submitter": {
        "id": 14,
        "url": "https://patches.dpdk.org/api/people/14/?format=api",
        "name": "Zhang, Helin",
        "email": "helin.zhang@intel.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1430406219-23901-21-git-send-email-helin.zhang@intel.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/4586/comments/",
    "check": "pending",
    "checks": "https://patches.dpdk.org/api/patches/4586/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id CD2A3CD04;\n\tThu, 30 Apr 2015 17:05:53 +0200 (CEST)",
            "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id 4E394CCE4\n\tfor <dev@dpdk.org>; Thu, 30 Apr 2015 17:05:47 +0200 (CEST)",
            "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga101.fm.intel.com with ESMTP; 30 Apr 2015 08:04:32 -0700",
            "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby fmsmga002.fm.intel.com with ESMTP; 30 Apr 2015 08:04:31 -0700",
            "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id t3UF4SoT028789;\n\tThu, 30 Apr 2015 23:04:28 +0800",
            "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid t3UF4PCo024076; Thu, 30 Apr 2015 23:04:27 +0800",
            "(from hzhan75@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id t3UF4PuC024072; \n\tThu, 30 Apr 2015 23:04:25 +0800"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.11,677,1422950400\"; d=\"scan'208\";a=\"718493167\"",
        "From": "Helin Zhang <helin.zhang@intel.com>",
        "To": "dev@dpdk.org",
        "Date": "Thu, 30 Apr 2015 23:03:26 +0800",
        "Message-Id": "<1430406219-23901-21-git-send-email-helin.zhang@intel.com>",
        "X-Mailer": "git-send-email 1.7.4.1",
        "In-Reply-To": "<1430406219-23901-1-git-send-email-helin.zhang@intel.com>",
        "References": "<1429518150-28098-1-git-send-email-helin.zhang@intel.com>\n\t<1430406219-23901-1-git-send-email-helin.zhang@intel.com>",
        "Cc": "monica.kenguva@intel.com, steven.j.murray@intel.com,\n\tshannon.nelson@intel.com",
        "Subject": "[dpdk-dev] [PATCH v2 20/33] i40e/base: i40e_aq_get_link_info()\n\tshould be used directly",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "As i40e_update_link_info() is just a simple wrapper of AQ command\ninterface of i40e_aq_get_link_info(), the AQ command interface\nshould be used directly.\n\nSigned-off-by: Helin Zhang <helin.zhang@intel.com>\n---\n lib/librte_pmd_i40e/i40e/i40e_common.c    | 34 ++-----------------------------\n lib/librte_pmd_i40e/i40e/i40e_prototype.h |  2 --\n 2 files changed, 2 insertions(+), 34 deletions(-)",
    "diff": "diff --git a/lib/librte_pmd_i40e/i40e/i40e_common.c b/lib/librte_pmd_i40e/i40e/i40e_common.c\nindex 09440db..3524aba 100644\n--- a/lib/librte_pmd_i40e/i40e/i40e_common.c\n+++ b/lib/librte_pmd_i40e/i40e/i40e_common.c\n@@ -1234,14 +1234,14 @@ enum i40e_status_code i40e_set_fc(struct i40e_hw *hw, u8 *aq_failures,\n \t\t\t*aq_failures |= I40E_SET_FC_AQ_FAIL_SET;\n \t}\n \t/* Update the link info */\n-\tstatus = i40e_update_link_info(hw, true);\n+\tstatus = i40e_aq_get_link_info(hw, true, NULL, NULL);\n \tif (status) {\n \t\t/* Wait a little bit (on 40G cards it sometimes takes a really\n \t\t * long time for link to come back from the atomic reset)\n \t\t * and try once more\n \t\t */\n \t\ti40e_msec_delay(1000);\n-\t\tstatus = i40e_update_link_info(hw, true);\n+\t\tstatus = i40e_aq_get_link_info(hw, true, NULL, NULL);\n \t}\n \tif (status)\n \t\t*aq_failures |= I40E_SET_FC_AQ_FAIL_UPDATE;\n@@ -1427,36 +1427,6 @@ aq_get_link_info_exit:\n }\n \n /**\n- * i40e_update_link_info\n- * @hw: pointer to the hw struct\n- * @enable_lse: enable/disable LinkStatusEvent reporting\n- *\n- * Returns the link status of the adapter\n- **/\n-enum i40e_status_code i40e_update_link_info(struct i40e_hw *hw,\n-\t\t\t\t\t     bool enable_lse)\n-{\n-\tstruct i40e_aq_get_phy_abilities_resp abilities;\n-\tenum i40e_status_code status;\n-\n-\tstatus = i40e_aq_get_link_info(hw, enable_lse, NULL, NULL);\n-\tif (status)\n-\t\treturn status;\n-\n-\tstatus = i40e_aq_get_phy_capabilities(hw, false, false,\n-\t\t\t\t\t      &abilities, NULL);\n-\tif (status)\n-\t\treturn status;\n-\n-\tif (abilities.abilities & I40E_AQ_PHY_AN_ENABLED)\n-\t\thw->phy.link_info.an_enabled = true;\n-\telse\n-\t\thw->phy.link_info.an_enabled = false;\n-\n-\treturn status;\n-}\n-\n-/**\n  * i40e_aq_set_phy_int_mask\n  * @hw: pointer to the hw struct\n  * @mask: interrupt mask to be set\ndiff --git a/lib/librte_pmd_i40e/i40e/i40e_prototype.h b/lib/librte_pmd_i40e/i40e/i40e_prototype.h\nindex 9cf17ac..7bb02fc 100644\n--- a/lib/librte_pmd_i40e/i40e/i40e_prototype.h\n+++ b/lib/librte_pmd_i40e/i40e/i40e_prototype.h\n@@ -128,8 +128,6 @@ enum i40e_status_code i40e_aq_set_link_restart_an(struct i40e_hw *hw,\n enum i40e_status_code i40e_aq_get_link_info(struct i40e_hw *hw,\n \t\t\t\tbool enable_lse, struct i40e_link_status *link,\n \t\t\t\tstruct i40e_asq_cmd_details *cmd_details);\n-enum i40e_status_code i40e_update_link_info(struct i40e_hw *hw,\n-\t\t\t\t\t    bool enable_lse);\n enum i40e_status_code i40e_aq_set_local_advt_reg(struct i40e_hw *hw,\n \t\t\t\tu64 advt_reg,\n \t\t\t\tstruct i40e_asq_cmd_details *cmd_details);\n",
    "prefixes": [
        "dpdk-dev",
        "v2",
        "20/33"
    ]
}