Patch Comment List
List patch comments
GET /api/patches/456/comments/?format=api&order=-submitter
[ { "id": 949, "web_url": "https://patches.dpdk.org/comment/949/", "msgid": "<20140924100512.GA4446@hmsreliant.think-freely.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20140924100512.GA4446@hmsreliant.think-freely.org", "date": "2014-09-24T10:05:12", "subject": "Re: [dpdk-dev] [PATCH v2 3/5] testpmd: Change rxfreet default to 32", "submitter": { "id": 32, "url": "https://patches.dpdk.org/api/people/32/?format=api", "name": "Neil Horman", "email": "nhorman@tuxdriver.com" }, "content": "On Wed, Sep 24, 2014 at 09:03:20AM +0000, Richardson, Bruce wrote:\n> > -----Original Message-----\n> > From: Neil Horman [mailto:nhorman@tuxdriver.com]\n> > Sent: Tuesday, September 23, 2014 6:03 PM\n> > To: Richardson, Bruce\n> > Cc: dev@dpdk.org\n> > Subject: Re: [dpdk-dev] [PATCH v2 3/5] testpmd: Change rxfreet default to 32\n> > \n> > On Tue, Sep 23, 2014 at 12:08:15PM +0100, Bruce Richardson wrote:\n> > > To improve performance by using bulk alloc or vectored RX routines, we\n> > > need to set rx free threshold (rxfreet) value to 32, so make this the\n> > > testpmd default.\n> > >\n> > > Thirty-two is the minimum setting needed to enable either the\n> > > bulk alloc or vector RX routines inside the ixgbe driver, so it's\n> > > best made the default for that reason. Please see\n> > > \"check_rx_burst_bulk_alloc_preconditions()\" in ixgbe_rxtx.c, and\n> > > RX function assignment logic in \"ixgbe_dev_rx_queue_setup()\" in\n> > > the same file.\n> > >\n> > > The difference in IO performance for testpmd when called without any\n> > > optional parameters, and using 10G NICs using the ixgbe driver, can be\n> > > significant - approx 25% or more.\n> > >\n> > > Updates in V2:\n> > > * Updated commit message with additional details\n> > >\n> > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>\n> > > ---\n> > > app/test-pmd/testpmd.c | 4 +++-\n> > > 1 file changed, 3 insertions(+), 1 deletion(-)\n> > >\n> > > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c\n> > > index 9f6cdc4..f76406f 100644\n> > > --- a/app/test-pmd/testpmd.c\n> > > +++ b/app/test-pmd/testpmd.c\n> > > @@ -225,7 +225,9 @@ struct rte_eth_thresh tx_thresh = {\n> > > /*\n> > > * Configurable value of RX free threshold.\n> > > */\n> > > -uint16_t rx_free_thresh = 0; /* Immediately free RX descriptors by default. */\n> > > +uint16_t rx_free_thresh = 32; /* Refill RX descriptors once every 32 packets,\n> > > +\t\tThis setting is needed for ixgbe to enable bulk alloc or vector\n> > > +\t\treceive functionality. */\n> > \n> > I thought we were talking about making this a pmd private selectable item, or\n> > allowing a reserved \"let the pmd decide\" setting. Or are we saving that for a\n> > later time?\n> > \n> \n> Yes, we are looking at that - and hopefully we can also get a patch for that in for our next release. However, I've left this patch in just in case that doesn't actually happen, as the performance improvements for 10G are just too good to leave aside for the sake of a 1-line change. Ideally, I'd like this go to in, and then be replaced by a \"proper\" fix.\n> \nOk, thanks\nNeil\n\n> /Bruce\n> \n> > Neil\n> > \n> > >\n> > > /*\n> > > * Configurable value of RX drop enable.\n> > > --\n> > > 1.9.3\n> > >\n> > >\n>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id B93AFB39D;\n\tWed, 24 Sep 2014 11:59:10 +0200 (CEST)", "from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58])\n\tby dpdk.org (Postfix) with ESMTP id 5483EB39B\n\tfor <dev@dpdk.org>; Wed, 24 Sep 2014 11:59:08 +0200 (CEST)", "from hmsreliant.think-freely.org\n\t([2001:470:8:a08:7aac:c0ff:fec2:933b] helo=localhost)\n\tby smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63)\n\t(envelope-from <nhorman@tuxdriver.com>)\n\tid 1XWjRh-0007S7-Nh; Wed, 24 Sep 2014 06:05:19 -0400" ], "Date": "Wed, 24 Sep 2014 06:05:12 -0400", "From": "Neil Horman <nhorman@tuxdriver.com>", "To": "\"Richardson, Bruce\" <bruce.richardson@intel.com>", "Message-ID": "<20140924100512.GA4446@hmsreliant.think-freely.org>", "References": "<1410948102-12740-1-git-send-email-bruce.richardson@intel.com>\n\t<1411470497-10209-1-git-send-email-bruce.richardson@intel.com>\n\t<1411470497-10209-4-git-send-email-bruce.richardson@intel.com>\n\t<20140923170231.GC12884@hmsreliant.think-freely.org>\n\t<59AF69C657FD0841A61C55336867B5B03440521B@IRSMSX103.ger.corp.intel.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=us-ascii", "Content-Disposition": "inline", "In-Reply-To": "<59AF69C657FD0841A61C55336867B5B03440521B@IRSMSX103.ger.corp.intel.com>", "User-Agent": "Mutt/1.5.23 (2014-03-12)", "X-Spam-Score": "-2.9 (--)", "X-Spam-Status": "No", "Cc": "\"dev@dpdk.org\" <dev@dpdk.org>", "Subject": "Re: [dpdk-dev] [PATCH v2 3/5] testpmd: Change rxfreet default to 32", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 941, "web_url": "https://patches.dpdk.org/comment/941/", "msgid": "<20140923170231.GC12884@hmsreliant.think-freely.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20140923170231.GC12884@hmsreliant.think-freely.org", "date": "2014-09-23T17:02:31", "subject": "Re: [dpdk-dev] [PATCH v2 3/5] testpmd: Change rxfreet default to 32", "submitter": { "id": 32, "url": "https://patches.dpdk.org/api/people/32/?format=api", "name": "Neil Horman", "email": "nhorman@tuxdriver.com" }, "content": "On Tue, Sep 23, 2014 at 12:08:15PM +0100, Bruce Richardson wrote:\n> To improve performance by using bulk alloc or vectored RX routines, we\n> need to set rx free threshold (rxfreet) value to 32, so make this the\n> testpmd default.\n> \n> Thirty-two is the minimum setting needed to enable either the\n> bulk alloc or vector RX routines inside the ixgbe driver, so it's\n> best made the default for that reason. Please see\n> \"check_rx_burst_bulk_alloc_preconditions()\" in ixgbe_rxtx.c, and\n> RX function assignment logic in \"ixgbe_dev_rx_queue_setup()\" in\n> the same file.\n> \n> The difference in IO performance for testpmd when called without any\n> optional parameters, and using 10G NICs using the ixgbe driver, can be\n> significant - approx 25% or more.\n> \n> Updates in V2:\n> * Updated commit message with additional details\n> \n> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>\n> ---\n> app/test-pmd/testpmd.c | 4 +++-\n> 1 file changed, 3 insertions(+), 1 deletion(-)\n> \n> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c\n> index 9f6cdc4..f76406f 100644\n> --- a/app/test-pmd/testpmd.c\n> +++ b/app/test-pmd/testpmd.c\n> @@ -225,7 +225,9 @@ struct rte_eth_thresh tx_thresh = {\n> /*\n> * Configurable value of RX free threshold.\n> */\n> -uint16_t rx_free_thresh = 0; /* Immediately free RX descriptors by default. */\n> +uint16_t rx_free_thresh = 32; /* Refill RX descriptors once every 32 packets,\n> +\t\tThis setting is needed for ixgbe to enable bulk alloc or vector\n> +\t\treceive functionality. */\n\nI thought we were talking about making this a pmd private selectable item, or\nallowing a reserved \"let the pmd decide\" setting. Or are we saving that for a\nlater time?\n\nNeil\n\n> \n> /*\n> * Configurable value of RX drop enable.\n> -- \n> 1.9.3\n> \n>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 887335920;\n\tTue, 23 Sep 2014 18:56:33 +0200 (CEST)", "from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58])\n\tby dpdk.org (Postfix) with ESMTP id EC04958FE\n\tfor <dev@dpdk.org>; Tue, 23 Sep 2014 18:56:31 +0200 (CEST)", "from [2001:470:8:a08:18c5:c64e:4bf:67a] (helo=localhost)\n\tby smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63)\n\t(envelope-from <nhorman@tuxdriver.com>)\n\tid 1XWTU2-0008UC-8Z; Tue, 23 Sep 2014 13:02:40 -0400" ], "Date": "Tue, 23 Sep 2014 13:02:31 -0400", "From": "Neil Horman <nhorman@tuxdriver.com>", "To": "Bruce Richardson <bruce.richardson@intel.com>", "Message-ID": "<20140923170231.GC12884@hmsreliant.think-freely.org>", "References": "<1410948102-12740-1-git-send-email-bruce.richardson@intel.com>\n\t<1411470497-10209-1-git-send-email-bruce.richardson@intel.com>\n\t<1411470497-10209-4-git-send-email-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=us-ascii", "Content-Disposition": "inline", "In-Reply-To": "<1411470497-10209-4-git-send-email-bruce.richardson@intel.com>", "User-Agent": "Mutt/1.5.23 (2014-03-12)", "X-Spam-Score": "-2.9 (--)", "X-Spam-Status": "No", "Cc": "dev@dpdk.org", "Subject": "Re: [dpdk-dev] [PATCH v2 3/5] testpmd: Change rxfreet default to 32", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 944, "web_url": "https://patches.dpdk.org/comment/944/", "msgid": "<59AF69C657FD0841A61C55336867B5B03440521B@IRSMSX103.ger.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/59AF69C657FD0841A61C55336867B5B03440521B@IRSMSX103.ger.corp.intel.com", "date": "2014-09-24T09:03:20", "subject": "Re: [dpdk-dev] [PATCH v2 3/5] testpmd: Change rxfreet default to 32", "submitter": { "id": 20, "url": "https://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "content": "> -----Original Message-----\n> From: Neil Horman [mailto:nhorman@tuxdriver.com]\n> Sent: Tuesday, September 23, 2014 6:03 PM\n> To: Richardson, Bruce\n> Cc: dev@dpdk.org\n> Subject: Re: [dpdk-dev] [PATCH v2 3/5] testpmd: Change rxfreet default to 32\n> \n> On Tue, Sep 23, 2014 at 12:08:15PM +0100, Bruce Richardson wrote:\n> > To improve performance by using bulk alloc or vectored RX routines, we\n> > need to set rx free threshold (rxfreet) value to 32, so make this the\n> > testpmd default.\n> >\n> > Thirty-two is the minimum setting needed to enable either the\n> > bulk alloc or vector RX routines inside the ixgbe driver, so it's\n> > best made the default for that reason. Please see\n> > \"check_rx_burst_bulk_alloc_preconditions()\" in ixgbe_rxtx.c, and\n> > RX function assignment logic in \"ixgbe_dev_rx_queue_setup()\" in\n> > the same file.\n> >\n> > The difference in IO performance for testpmd when called without any\n> > optional parameters, and using 10G NICs using the ixgbe driver, can be\n> > significant - approx 25% or more.\n> >\n> > Updates in V2:\n> > * Updated commit message with additional details\n> >\n> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>\n> > ---\n> > app/test-pmd/testpmd.c | 4 +++-\n> > 1 file changed, 3 insertions(+), 1 deletion(-)\n> >\n> > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c\n> > index 9f6cdc4..f76406f 100644\n> > --- a/app/test-pmd/testpmd.c\n> > +++ b/app/test-pmd/testpmd.c\n> > @@ -225,7 +225,9 @@ struct rte_eth_thresh tx_thresh = {\n> > /*\n> > * Configurable value of RX free threshold.\n> > */\n> > -uint16_t rx_free_thresh = 0; /* Immediately free RX descriptors by default. */\n> > +uint16_t rx_free_thresh = 32; /* Refill RX descriptors once every 32 packets,\n> > +\t\tThis setting is needed for ixgbe to enable bulk alloc or vector\n> > +\t\treceive functionality. */\n> \n> I thought we were talking about making this a pmd private selectable item, or\n> allowing a reserved \"let the pmd decide\" setting. Or are we saving that for a\n> later time?\n> \n\nYes, we are looking at that - and hopefully we can also get a patch for that in for our next release. However, I've left this patch in just in case that doesn't actually happen, as the performance improvements for 10G are just too good to leave aside for the sake of a 1-line change. Ideally, I'd like this go to in, and then be replaced by a \"proper\" fix.\n\n/Bruce\n\n> Neil\n> \n> >\n> > /*\n> > * Configurable value of RX drop enable.\n> > --\n> > 1.9.3\n> >\n> >", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id A43F35953;\n\tWed, 24 Sep 2014 10:58:30 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id 19AEE333\n\tfor <dev@dpdk.org>; Wed, 24 Sep 2014 10:58:27 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga102.jf.intel.com with ESMTP; 24 Sep 2014 01:58:24 -0700", "from irsmsx101.ger.corp.intel.com ([163.33.3.153])\n\tby orsmga001.jf.intel.com with ESMTP; 24 Sep 2014 02:04:03 -0700", "from irsmsx107.ger.corp.intel.com (163.33.3.99) by\n\tIRSMSX101.ger.corp.intel.com (163.33.3.153) with Microsoft SMTP\n\tServer (TLS) id 14.3.195.1; Wed, 24 Sep 2014 10:03:21 +0100", "from irsmsx103.ger.corp.intel.com ([169.254.3.112]) by\n\tIRSMSX107.ger.corp.intel.com ([169.254.10.108]) with mapi id\n\t14.03.0195.001; Wed, 24 Sep 2014 10:03:21 +0100" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.04,587,1406617200\"; d=\"scan'208\";a=\"578104089\"", "From": "\"Richardson, Bruce\" <bruce.richardson@intel.com>", "To": "Neil Horman <nhorman@tuxdriver.com>", "Thread-Topic": "[dpdk-dev] [PATCH v2 3/5] testpmd: Change rxfreet default to 32", "Thread-Index": "AQHP1x64pnhngwnmO0eRzTenUB9NPZwO4VGAgAEcskA=", "Date": "Wed, 24 Sep 2014 09:03:20 +0000", "Message-ID": "<59AF69C657FD0841A61C55336867B5B03440521B@IRSMSX103.ger.corp.intel.com>", "References": "<1410948102-12740-1-git-send-email-bruce.richardson@intel.com>\n\t<1411470497-10209-1-git-send-email-bruce.richardson@intel.com>\n\t<1411470497-10209-4-git-send-email-bruce.richardson@intel.com>\n\t<20140923170231.GC12884@hmsreliant.think-freely.org>", "In-Reply-To": "<20140923170231.GC12884@hmsreliant.think-freely.org>", "Accept-Language": "en-GB, en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[163.33.239.181]", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "Cc": "\"dev@dpdk.org\" <dev@dpdk.org>", "Subject": "Re: [dpdk-dev] [PATCH v2 3/5] testpmd: Change rxfreet default to 32", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 2455, "web_url": "https://patches.dpdk.org/comment/2455/", "msgid": "<20141107134929.GA12092@bricha3-MOBL3>", "list_archive_url": "https://inbox.dpdk.org/dev/20141107134929.GA12092@bricha3-MOBL3", "date": "2014-11-07T13:49:30", "subject": "Re: [dpdk-dev] [PATCH v2 3/5] testpmd: Change rxfreet default to 32", "submitter": { "id": 20, "url": "https://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "content": "On Fri, Nov 07, 2014 at 01:30:53PM +0100, Thomas Monjalon wrote:\n> Hi Bruce,\n> \n> 2014-09-24 09:03, Richardson, Bruce:\n> > From: Neil Horman [mailto:nhorman@tuxdriver.com]\n> > > On Tue, Sep 23, 2014 at 12:08:15PM +0100, Bruce Richardson wrote:\n> > > > --- a/app/test-pmd/testpmd.c\n> > > > +++ b/app/test-pmd/testpmd.c\n> > > > @@ -225,7 +225,9 @@ struct rte_eth_thresh tx_thresh = {\n> > > > /*\n> > > > * Configurable value of RX free threshold.\n> > > > */\n> > > > -uint16_t rx_free_thresh = 0; /* Immediately free RX descriptors by default. */\n> > > > +uint16_t rx_free_thresh = 32; /* Refill RX descriptors once every 32 packets,\n> > > > +\t\tThis setting is needed for ixgbe to enable bulk alloc or vector\n> > > > +\t\treceive functionality. */\n> > > \n> > > I thought we were talking about making this a pmd private selectable item,\n> > > or allowing a reserved \"let the pmd decide\" setting. Or are we saving\n> > > that for a later time?\n> > \n> > Yes, we are looking at that - and hopefully we can also get a patch for that\n> > in for our next release. However, I've left this patch in just in case that\n> > doesn't actually happen, as the performance improvements for 10G are just\n> > too good to leave aside for the sake of a 1-line change. Ideally, I'd like\n> > this go to in, and then be replaced by a \"proper\" fix.\n> \n> Now the patch for PMD defaults is integrated:\n> \thttp://dpdk.org/ml/archives/dev/2014-October/006511.html\n> Are you working on getting these defaults in testpmd?\n> \n\nNot at the minute, as I'm busy on other things. If I find time I can look at it,\nthough, if nobody else volunteers to do so first.\n\n/Bruce\n\n\n> Thanks\n> -- \n> Thomas", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id AE2387F18;\n\tFri, 7 Nov 2014 14:40:06 +0100 (CET)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id AF36B7EC4\n\tfor <dev@dpdk.org>; Fri, 7 Nov 2014 14:40:02 +0100 (CET)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga102.fm.intel.com with ESMTP; 07 Nov 2014 05:49:33 -0800", "from bricha3-mobl3.ger.corp.intel.com ([10.243.20.32])\n\tby fmsmga002.fm.intel.com with SMTP; 07 Nov 2014 05:49:30 -0800", "by (sSMTP sendmail emulation); Fri, 07 Nov 2014 13:49:30 +0025" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.07,332,1413270000\"; d=\"scan'208\";a=\"628319636\"", "Date": "Fri, 7 Nov 2014 13:49:30 +0000", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "Thomas Monjalon <thomas.monjalon@6wind.com>", "Message-ID": "<20141107134929.GA12092@bricha3-MOBL3>", "References": "<1410948102-12740-1-git-send-email-bruce.richardson@intel.com>\n\t<20140923170231.GC12884@hmsreliant.think-freely.org>\n\t<59AF69C657FD0841A61C55336867B5B03440521B@IRSMSX103.ger.corp.intel.com>\n\t<2215672.o2GmOzFsZU@xps13>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=us-ascii", "Content-Disposition": "inline", "In-Reply-To": "<2215672.o2GmOzFsZU@xps13>", "Organization": "Intel Shannon Ltd.", "User-Agent": "Mutt/1.5.23 (2014-03-12)", "Cc": "dev@dpdk.org", "Subject": "Re: [dpdk-dev] [PATCH v2 3/5] testpmd: Change rxfreet default to 32", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 2450, "web_url": "https://patches.dpdk.org/comment/2450/", "msgid": "<2215672.o2GmOzFsZU@xps13>", "list_archive_url": "https://inbox.dpdk.org/dev/2215672.o2GmOzFsZU@xps13", "date": "2014-11-07T12:30:53", "subject": "Re: [dpdk-dev] [PATCH v2 3/5] testpmd: Change rxfreet default to 32", "submitter": { "id": 1, "url": "https://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "content": "Hi Bruce,\n\n2014-09-24 09:03, Richardson, Bruce:\n> From: Neil Horman [mailto:nhorman@tuxdriver.com]\n> > On Tue, Sep 23, 2014 at 12:08:15PM +0100, Bruce Richardson wrote:\n> > > --- a/app/test-pmd/testpmd.c\n> > > +++ b/app/test-pmd/testpmd.c\n> > > @@ -225,7 +225,9 @@ struct rte_eth_thresh tx_thresh = {\n> > > /*\n> > > * Configurable value of RX free threshold.\n> > > */\n> > > -uint16_t rx_free_thresh = 0; /* Immediately free RX descriptors by default. */\n> > > +uint16_t rx_free_thresh = 32; /* Refill RX descriptors once every 32 packets,\n> > > +\t\tThis setting is needed for ixgbe to enable bulk alloc or vector\n> > > +\t\treceive functionality. */\n> > \n> > I thought we were talking about making this a pmd private selectable item,\n> > or allowing a reserved \"let the pmd decide\" setting. Or are we saving\n> > that for a later time?\n> \n> Yes, we are looking at that - and hopefully we can also get a patch for that\n> in for our next release. However, I've left this patch in just in case that\n> doesn't actually happen, as the performance improvements for 10G are just\n> too good to leave aside for the sake of a 1-line change. Ideally, I'd like\n> this go to in, and then be replaced by a \"proper\" fix.\n\nNow the patch for PMD defaults is integrated:\n\thttp://dpdk.org/ml/archives/dev/2014-October/006511.html\nAre you working on getting these defaults in testpmd?\n\nThanks", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 870887F4D;\n\tFri, 7 Nov 2014 13:21:44 +0100 (CET)", "from mail-wi0-f180.google.com (mail-wi0-f180.google.com\n\t[209.85.212.180]) by dpdk.org (Postfix) with ESMTP id 3175D7F49\n\tfor <dev@dpdk.org>; Fri, 7 Nov 2014 13:21:42 +0100 (CET)", "by mail-wi0-f180.google.com with SMTP id hi2so4390998wib.7\n\tfor <dev@dpdk.org>; Fri, 07 Nov 2014 04:31:13 -0800 (PST)", "from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])\n\tby mx.google.com with ESMTPSA id\n\tu2sm11646725wjz.11.2014.11.07.04.31.11 for <multiple recipients>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 07 Nov 2014 04:31:11 -0800 (PST)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:organization\n\t:user-agent:in-reply-to:references:mime-version\n\t:content-transfer-encoding:content-type;\n\tbh=PPYRm7TGsSTmEegM5WgyZ924m9Qtgbe8SmBKUFeWvLc=;\n\tb=gCbodOsBbqeRAyUc3l/GBf5owiQEgJJlraUVzs+9GBDvZObxj42iXTMgw7hDo4LrsJ\n\tTy9DW56mQ/ShAOWErsiW9h2NryPgyZ5DLcPOYH9Iu3NkeORUJgEkPTD5gAuplEA53Lz8\n\tmRKu/xkYMDBMABHmH11BMCACvvb5AxyFZOkG+4eNs6JhbNJjoRICt1uanQLVFb58VMrI\n\tj4eyZRRHa88V0hK4MltYsYKD7N68VnoipQhNj2YQWCUxgF2gtx+I2Tw0sj6dw3wjcnaE\n\t1OvgHApaCKIMvtYCS8F0SbgA3O8muCE12K/CC+7CbAAfcQQ1MmG3umsxa8GQT/jJhhfW\n\t9RkQ==", "X-Gm-Message-State": "ALoCoQm/FxYwf5gc62+ZBhGxQtKFCKii0cfAPj6pwrrN9ETtNEqyvDsd02BX+6Xc1dCip/++Jbmq", "X-Received": "by 10.194.243.164 with SMTP id\n\twz4mr13997007wjc.129.1415363472947; \n\tFri, 07 Nov 2014 04:31:12 -0800 (PST)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "\"Richardson, Bruce\" <bruce.richardson@intel.com>", "Date": "Fri, 07 Nov 2014 13:30:53 +0100", "Message-ID": "<2215672.o2GmOzFsZU@xps13>", "Organization": "6WIND", "User-Agent": "KMail/4.14.2 (Linux/3.17.2-1-ARCH; KDE/4.14.2; x86_64; ; )", "In-Reply-To": "<59AF69C657FD0841A61C55336867B5B03440521B@IRSMSX103.ger.corp.intel.com>", "References": "<1410948102-12740-1-git-send-email-bruce.richardson@intel.com>\n\t<20140923170231.GC12884@hmsreliant.think-freely.org>\n\t<59AF69C657FD0841A61C55336867B5B03440521B@IRSMSX103.ger.corp.intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "7Bit", "Content-Type": "text/plain; charset=\"us-ascii\"", "Cc": "dev@dpdk.org", "Subject": "Re: [dpdk-dev] [PATCH v2 3/5] testpmd: Change rxfreet default to 32", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]