Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/45544/?format=api
{ "id": 45544, "url": "https://patches.dpdk.org/api/patches/45544/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20180928030838.15887-1-johndale@cisco.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180928030838.15887-1-johndale@cisco.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180928030838.15887-1-johndale@cisco.com", "date": "2018-09-28T03:08:36", "name": "[v2,1/3] net/enic: fix flow API memory leak", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "e0ad597e0fc1d575322318d7c0c54c415fcae61f", "submitter": { "id": 359, "url": "https://patches.dpdk.org/api/people/359/?format=api", "name": "John Daley (johndale)", "email": "johndale@cisco.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20180928030838.15887-1-johndale@cisco.com/mbox/", "series": [ { "id": 1559, "url": "https://patches.dpdk.org/api/series/1559/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=1559", "date": "2018-09-28T03:08:36", "name": "[v2,1/3] net/enic: fix flow API memory leak", "version": 2, "mbox": "https://patches.dpdk.org/series/1559/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/45544/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/45544/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0F47B1B11F;\n\tFri, 28 Sep 2018 05:09:00 +0200 (CEST)", "from alln-iport-2.cisco.com (alln-iport-2.cisco.com\n\t[173.37.142.89]) by dpdk.org (Postfix) with ESMTP id 4DA621B109;\n\tFri, 28 Sep 2018 05:08:57 +0200 (CEST)", "from rcdn-core-9.cisco.com ([173.37.93.145])\n\tby alln-iport-2.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t28 Sep 2018 03:08:56 +0000", "from cisco.com (savbu-usnic-a.cisco.com [10.193.184.48])\n\tby rcdn-core-9.cisco.com (8.15.2/8.15.2) with ESMTP id w8S38t5S010574;\n\tFri, 28 Sep 2018 03:08:55 GMT", "by cisco.com (Postfix, from userid 392789)\n\tid 8A4F920F2001; Thu, 27 Sep 2018 20:08:55 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n\td=cisco.com; i=@cisco.com; l=1129; q=dns/txt; s=iport;\n\tt=1538104137; x=1539313737;\n\th=from:to:cc:subject:date:message-id:in-reply-to: references;\n\tbh=fhpml+Xw0ws9l1M0rOADrEdQBMu2/NoU2UQqamVvbY4=;\n\tb=HYTB9y9XwYpGFAbPYtN4Ny7dP8apH2JZ2ewn5ezXfgDkXkrxrwNxKjIb\n\tks7H39RfdKAX6qlAqBOSyuH2WpFSos3E00oZQLsEnXcISI+JfXFCaPDFa\n\t2weLTrGjZsokpsTQvJWPqbPhMqjK6ohoawbRBGALzgXptVPSQiBsGi4z1 4=;", "X-IronPort-AV": "E=Sophos;i=\"5.54,313,1534809600\"; d=\"scan'208\";a=\"177911766\"", "From": "John Daley <johndale@cisco.com>", "To": "ferruh.yigit@intel.com", "Cc": "dev@dpdk.org, John Daley <johndale@cisco.com>, stable@dpdk.org,\n\tHyong Youb Kim <hyonkim@cisco.com>", "Date": "Thu, 27 Sep 2018 20:08:36 -0700", "Message-Id": "<20180928030838.15887-1-johndale@cisco.com>", "X-Mailer": "git-send-email 2.16.2", "In-Reply-To": "<20180928015827.25786-1-johndale@cisco.com>", "References": "<20180928015827.25786-1-johndale@cisco.com>", "X-Outbound-SMTP-Client": "10.193.184.48, savbu-usnic-a.cisco.com", "X-Outbound-Node": "rcdn-core-9.cisco.com", "Subject": "[dpdk-dev] [PATCH v2 1/3] net/enic: fix flow API memory leak", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "rte_flow structures were not being freed when destroyed or flushed.\n\nFixes: 6ced137607d0 (\"net/enic: flow API for NICs with advanced filters enabled\")\nCc: stable@dpdk.org\n\nSigned-off-by: Hyong Youb Kim <hyonkim@cisco.com>\nSigned-off-by: John Daley <johndale@cisco.com>\n---\nv2: fix signoff\n\n drivers/net/enic/enic_flow.c | 2 ++\n 1 file changed, 2 insertions(+)", "diff": "diff --git a/drivers/net/enic/enic_flow.c b/drivers/net/enic/enic_flow.c\nindex 0cf04aefd..9b612f1d5 100644\n--- a/drivers/net/enic/enic_flow.c\n+++ b/drivers/net/enic/enic_flow.c\n@@ -1532,6 +1532,7 @@ enic_flow_destroy(struct rte_eth_dev *dev, struct rte_flow *flow,\n \tenic_flow_del_filter(enic, flow->enic_filter_id, error);\n \tLIST_REMOVE(flow, next);\n \trte_spinlock_unlock(&enic->flows_lock);\n+\trte_free(flow);\n \treturn 0;\n }\n \n@@ -1555,6 +1556,7 @@ enic_flow_flush(struct rte_eth_dev *dev, struct rte_flow_error *error)\n \t\tflow = LIST_FIRST(&enic->flows);\n \t\tenic_flow_del_filter(enic, flow->enic_filter_id, error);\n \t\tLIST_REMOVE(flow, next);\n+\t\trte_free(flow);\n \t}\n \trte_spinlock_unlock(&enic->flows_lock);\n \treturn 0;\n", "prefixes": [ "v2", "1/3" ] }