Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 45483,
    "url": "https://patches.dpdk.org/api/patches/45483/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1538033190-2884-1-git-send-email-han.li1@zte.com.cn/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1538033190-2884-1-git-send-email-han.li1@zte.com.cn>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1538033190-2884-1-git-send-email-han.li1@zte.com.cn",
    "date": "2018-09-27T07:26:30",
    "name": "drivers/net/i40e/:remove i40e_nvmupd_command redundant code",
    "commit_ref": null,
    "pull_url": null,
    "state": "rejected",
    "archived": true,
    "hash": "747fde4d6c9e97d091a17817b857e7832b76a6a5",
    "submitter": {
        "id": 782,
        "url": "https://patches.dpdk.org/api/people/782/?format=api",
        "name": "Li Han",
        "email": "han.li1@zte.com.cn"
    },
    "delegate": {
        "id": 1540,
        "url": "https://patches.dpdk.org/api/users/1540/?format=api",
        "username": "qzhan15",
        "first_name": "Qi",
        "last_name": "Zhang",
        "email": "qi.z.zhang@intel.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1538033190-2884-1-git-send-email-han.li1@zte.com.cn/mbox/",
    "series": [
        {
            "id": 1538,
            "url": "https://patches.dpdk.org/api/series/1538/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=1538",
            "date": "2018-09-27T07:26:30",
            "name": "drivers/net/i40e/:remove i40e_nvmupd_command redundant code",
            "version": 1,
            "mbox": "https://patches.dpdk.org/series/1538/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/45483/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/45483/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 37EF41B13A;\n\tThu, 27 Sep 2018 09:51:02 +0200 (CEST)",
            "from mxhk.zte.com.cn (mxhk.zte.com.cn [63.217.80.70])\n\tby dpdk.org (Postfix) with ESMTP id 800CF1B139\n\tfor <dev@dpdk.org>; Thu, 27 Sep 2018 09:51:00 +0200 (CEST)",
            "from mse01.zte.com.cn (unknown [10.30.3.20])\n\tby Forcepoint Email with ESMTPS id 89FC4856040A22C8F1DE;\n\tThu, 27 Sep 2018 15:50:59 +0800 (CST)",
            "from notes_smtp.zte.com.cn ([10.30.1.239])\n\tby mse01.zte.com.cn with ESMTP id w8R7oq02091205;\n\tThu, 27 Sep 2018 15:50:52 +0800 (GMT-8)\n\t(envelope-from han.li1@zte.com.cn)",
            "from localhost.localdomain.localdomain ([10.43.166.165])\n\tby szsmtp06.zte.com.cn (Lotus Domino Release 8.5.3FP6)\n\twith ESMTP id 2018092715512187-1411894 ;\n\tThu, 27 Sep 2018 15:51:21 +0800 "
        ],
        "From": "Li Han <han.li1@zte.com.cn>",
        "To": "qi.z.zhang@intel.com",
        "Cc": "dev@dpdk.org, Li Han <han.li1@zte.com.cn>",
        "Date": "Thu, 27 Sep 2018 03:26:30 -0400",
        "Message-Id": "<1538033190-2884-1-git-send-email-han.li1@zte.com.cn>",
        "X-Mailer": "git-send-email 1.8.3.1",
        "X-MIMETrack": "Itemize by SMTP Server on SZSMTP06/server/zte_ltd(Release\n\t8.5.3FP6|November 21, 2013) at 2018-09-27 15:51:22,\n\tSerialize by Router on notes_smtp/zte_ltd(Release 9.0.1FP7|August 17,\n\t2016) at\n\t2018-09-27 15:50:40, Serialize complete at 2018-09-27 15:50:40",
        "X-MAIL": "mse01.zte.com.cn w8R7oq02091205",
        "Subject": "[dpdk-dev] [PATCH] drivers/net/i40e/:remove i40e_nvmupd_command\n\tredundant code",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "in function i40e_nvmupd_validate_command, when \"cmd->data_size < 1\"\nit'll return I40E_NVMUPD_INVALID,and in function \"i40e_nvmupd_command\"\nwhen \"upd_cmd == I40E_NVMUPD_STATUS\",it check \"!cmd->data_size\" again,\nbut it's no need.\n\nSigned-off-by: Li Han <han.li1@zte.com.cn>\n---\n drivers/net/i40e/base/i40e_nvm.c | 5 -----\n 1 file changed, 5 deletions(-)",
    "diff": "diff --git a/drivers/net/i40e/base/i40e_nvm.c b/drivers/net/i40e/base/i40e_nvm.c\nindex c77dac0..5de22e4 100644\n--- a/drivers/net/i40e/base/i40e_nvm.c\n+++ b/drivers/net/i40e/base/i40e_nvm.c\n@@ -869,11 +869,6 @@ enum i40e_status_code i40e_nvmupd_command(struct i40e_hw *hw,\n \t * going into the state machine\n \t */\n \tif (upd_cmd == I40E_NVMUPD_STATUS) {\n-\t\tif (!cmd->data_size) {\n-\t\t\t*perrno = -EFAULT;\n-\t\t\treturn I40E_ERR_BUF_TOO_SHORT;\n-\t\t}\n-\n \t\tbytes[0] = hw->nvmupd_state;\n \n \t\tif (cmd->data_size >= 4) {\n",
    "prefixes": []
}