Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 45370,
    "url": "https://patches.dpdk.org/api/patches/45370/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20180926093112.24235-1-sthemmin@microsoft.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20180926093112.24235-1-sthemmin@microsoft.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20180926093112.24235-1-sthemmin@microsoft.com",
    "date": "2018-09-26T09:31:12",
    "name": "net/netvsc: check return from kvargs_process",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "16a398ef5b1c1911908009fb5ea08e77a2394119",
    "submitter": {
        "id": 27,
        "url": "https://patches.dpdk.org/api/people/27/?format=api",
        "name": "Stephen Hemminger",
        "email": "stephen@networkplumber.org"
    },
    "delegate": {
        "id": 319,
        "url": "https://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20180926093112.24235-1-sthemmin@microsoft.com/mbox/",
    "series": [
        {
            "id": 1514,
            "url": "https://patches.dpdk.org/api/series/1514/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=1514",
            "date": "2018-09-26T09:31:12",
            "name": "net/netvsc: check return from kvargs_process",
            "version": 1,
            "mbox": "https://patches.dpdk.org/series/1514/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/45370/comments/",
    "check": "warning",
    "checks": "https://patches.dpdk.org/api/patches/45370/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E96101B134;\n\tWed, 26 Sep 2018 11:31:17 +0200 (CEST)",
            "from mail-ed1-f67.google.com (mail-ed1-f67.google.com\n\t[209.85.208.67]) by dpdk.org (Postfix) with ESMTP id 6DA771B133\n\tfor <dev@dpdk.org>; Wed, 26 Sep 2018 11:31:16 +0200 (CEST)",
            "by mail-ed1-f67.google.com with SMTP id j62-v6so1267997edd.7\n\tfor <dev@dpdk.org>; Wed, 26 Sep 2018 02:31:16 -0700 (PDT)",
            "from localhost.localdomain ([213.244.170.154])\n\tby smtp.gmail.com with ESMTPSA id\n\tl30-v6sm11437715edc.70.2018.09.26.02.31.14\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 26 Sep 2018 02:31:14 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id;\n\tbh=mObjsn17rqa0QVC0xzp0s2/10xHsMMwerg3knKYAx8Q=;\n\tb=sYg46O2L9gnifwaZ/S+Y6GQ1ykNodbXWlUJn7rXt7Ofd6oiamj5cCJNJWuZ3ESpfKr\n\t/M4q4ciZq8V6USD3950QikfhTlws6Ojn+X40LQPY+1zZjK/TeB6jzOzbXRMS1DzUJqN6\n\tEG/79tTFpVBvmOm4aymj+A2hS1X/igfm8P8+i5DsvlH+GJjc7h+59/3ldcpShsCbtG/v\n\tH6+xBA75h28hpelCPWqg76fAcZ1MtKP+U7wLrWmOGVNZq6I/4Qx5u4Qi4g51K3cxx+bK\n\t/AdUZGocw0rdECZqL1VFoZbCvnVoyxknB6gNReqyzKXbJYUX6Cu681wbf8F3c0RH/+ig\n\tX7tA==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=mObjsn17rqa0QVC0xzp0s2/10xHsMMwerg3knKYAx8Q=;\n\tb=J8ZHvf0KcStcjWZq/Gu0Oj+D2K9FIA1phHKTJxZtBcEGOeWhXwNr4TCITQWy+K3a1v\n\twals3oVli+aWmUlBLHFlJGcWMUJWEmFFr4wdeeGIzr4gxud78C5ae00qnWetsYy6kfnR\n\tnoB7gtVw0FbYgunblDNIDdJHJOu6kxYVeYyr1A1xJabo2tCvVOwvr5VZU/2E8s2+6KQL\n\tTZB6TNFBNmASM7BHeCcBRiavW+J8y3PDXLxPgtXC9nvM3f6ojPrXUMFPi7ry7MhxPCqi\n\tggVt29DBUjYFPLe8oKNy3bGmupLKJBI0kOi5MCB1o2+s/wXUVH8u9vrCWM0jgIS3Cb0w\n\tpxWw==",
        "X-Gm-Message-State": "ABuFfohDvpuL36xqfhOPwNhjFQVsIrlQVNlTd3L7La01MQm30bgs4I0j\n\tAchuGgoKoy8rhuU7J7n4QjraD2uFfx8I+Q==",
        "X-Google-Smtp-Source": "ACcGV60lFs/xYRDOr10+k6rqzs/CEmBuiTvi5fpOc3xFoSlNZzlzN7J7I+LoAuKnCWzh+sEhvLzrUg==",
        "X-Received": "by 2002:a50:9471:: with SMTP id\n\tq46-v6mr8291824eda.70.1537954275658; \n\tWed, 26 Sep 2018 02:31:15 -0700 (PDT)",
        "From": "Stephen Hemminger <stephen@networkplumber.org>",
        "X-Google-Original-From": "Stephen Hemminger <sthemmin@microsoft.com>",
        "To": "dev@dpdk.org",
        "Cc": "Stephen Hemminger <sthemmin@microsoft.com>",
        "Date": "Wed, 26 Sep 2018 10:31:12 +0100",
        "Message-Id": "<20180926093112.24235-1-sthemmin@microsoft.com>",
        "X-Mailer": "git-send-email 2.17.1",
        "Subject": "[dpdk-dev] [PATCH] net/netvsc: check return from kvargs_process",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Should check return value from processing latency value.\n\nCoverity issue: 322104\nSigned-off-by: Stephen Hemminger <sthemmin@microsoft.com>\n---\nPatch against dpdk-next-net\n\n drivers/net/netvsc/hn_ethdev.c | 8 ++++++--\n 1 file changed, 6 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c\nindex b67cce1ba8f5..8845fc0e6176 100644\n--- a/drivers/net/netvsc/hn_ethdev.c\n+++ b/drivers/net/netvsc/hn_ethdev.c\n@@ -167,6 +167,7 @@ static int hn_parse_args(const struct rte_eth_dev *dev)\n \t\tNULL\n \t};\n \tstruct rte_kvargs *kvlist;\n+\tint ret;\n \n \tif (!devargs)\n \t\treturn 0;\n@@ -180,9 +181,12 @@ static int hn_parse_args(const struct rte_eth_dev *dev)\n \t\treturn -EINVAL;\n \t}\n \n-\trte_kvargs_process(kvlist, \"latency\", hn_set_latency, hv);\n+\tret = rte_kvargs_process(kvlist, \"latency\", hn_set_latency, hv);\n+\tif (ret)\n+\t\tPMD_DRV_LOG(ERR, \"Unable to process latency arg\\n\");\n+\n \trte_kvargs_free(kvlist);\n-\treturn 0;\n+\treturn ret;\n }\n \n /* Update link status.\n",
    "prefixes": []
}