Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/45348/?format=api
{ "id": 45348, "url": "https://patches.dpdk.org/api/patches/45348/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20180926025422.21912-5-johndale@cisco.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180926025422.21912-5-johndale@cisco.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180926025422.21912-5-johndale@cisco.com", "date": "2018-09-26T02:54:21", "name": "[5/6] net/enic: add VLAN and csum offloads to simple Tx handler", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "216d41a4a2711c9e8f065b2b422f78f899023dab", "submitter": { "id": 359, "url": "https://patches.dpdk.org/api/people/359/?format=api", "name": "John Daley (johndale)", "email": "johndale@cisco.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20180926025422.21912-5-johndale@cisco.com/mbox/", "series": [ { "id": 1506, "url": "https://patches.dpdk.org/api/series/1506/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=1506", "date": "2018-09-26T02:54:17", "name": "[1/6] net/enic: do not use non-standard integer types", "version": 1, "mbox": "https://patches.dpdk.org/series/1506/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/45348/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/45348/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6A1311B0F9;\n\tWed, 26 Sep 2018 04:56:55 +0200 (CEST)", "from rcdn-iport-1.cisco.com (rcdn-iport-1.cisco.com [173.37.86.72])\n\tby dpdk.org (Postfix) with ESMTP id 4E3337CBC\n\tfor <dev@dpdk.org>; Wed, 26 Sep 2018 04:56:53 +0200 (CEST)", "from rcdn-core-9.cisco.com ([173.37.93.145])\n\tby rcdn-iport-1.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t26 Sep 2018 02:56:52 +0000", "from cisco.com (savbu-usnic-a.cisco.com [10.193.184.48])\n\tby rcdn-core-9.cisco.com (8.15.2/8.15.2) with ESMTP id w8Q2uqSH015728;\n\tWed, 26 Sep 2018 02:56:52 GMT", "by cisco.com (Postfix, from userid 392789)\n\tid 140C020F2001; Tue, 25 Sep 2018 19:56:52 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n\td=cisco.com; i=@cisco.com; l=3073; q=dns/txt; s=iport;\n\tt=1537930613; x=1539140213;\n\th=from:to:cc:subject:date:message-id:in-reply-to: references;\n\tbh=qt5chTvLKeoz9Jf7B/k5hUvrDEhoPY5p0W1duoaaV2A=;\n\tb=Be8PSy3yLFZM7rooDzgoIL0L9ncZBbsSRffQNY2qI3oTkjawVlkMo4nx\n\tA0IX23WInReyXBL8FkslTnOkU3eM1Ok0fto7BjSKqZ1XPeFirGGG8vjKJ\n\tBd7q0Zhoe/UYUTUM7yFjYGZ5kfC3Q9AurOeoTBZmN3YDJDu5pqOGP43u4 E=;", "X-IronPort-AV": "E=Sophos;i=\"5.54,304,1534809600\"; d=\"scan'208\";a=\"457342278\"", "From": "John Daley <johndale@cisco.com>", "To": "ferruh.yigit@intel.com", "Cc": "dev@dpdk.org, Hyong Youb Kim <hyonkim@cisco.com>", "Date": "Tue, 25 Sep 2018 19:54:21 -0700", "Message-Id": "<20180926025422.21912-5-johndale@cisco.com>", "X-Mailer": "git-send-email 2.16.2", "In-Reply-To": "<20180926025422.21912-1-johndale@cisco.com>", "References": "<20180926025422.21912-1-johndale@cisco.com>", "X-Outbound-SMTP-Client": "10.193.184.48, savbu-usnic-a.cisco.com", "X-Outbound-Node": "rcdn-core-9.cisco.com", "Subject": "[dpdk-dev] [PATCH 5/6] net/enic: add VLAN and csum offloads to\n\tsimple Tx handler", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Hyong Youb Kim <hyonkim@cisco.com>\n\nCurrently the simple Tx handler supports no offloads, which makes it\nusable only for a small number of benchmarks. Add vlan and checksum\noffloads to the handler, as cycles/packet increases only by about 3\ncycles, and applications commonly use those offloads.\n\nSigned-off-by: Hyong Youb Kim <hyonkim@cisco.com>\nReviewed-by: John Daley <johndale@cisco.com>\n---\n drivers/net/enic/enic_main.c | 14 +++++++++++---\n drivers/net/enic/enic_rxtx.c | 21 +++++++++++++++++++++\n 2 files changed, 32 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c\nindex fd940c583..03c5ef741 100644\n--- a/drivers/net/enic/enic_main.c\n+++ b/drivers/net/enic/enic_main.c\n@@ -534,6 +534,7 @@ int enic_enable(struct enic *enic)\n \tunsigned int index;\n \tint err;\n \tstruct rte_eth_dev *eth_dev = enic->rte_dev;\n+\tuint64_t simple_tx_offloads;\n \n \teth_dev->data->dev_link.link_speed = vnic_dev_port_speed(enic->vdev);\n \teth_dev->data->dev_link.link_duplex = ETH_LINK_FULL_DUPLEX;\n@@ -572,10 +573,17 @@ int enic_enable(struct enic *enic)\n \t}\n \n \t/*\n-\t * Use the simple TX handler if possible. All offloads must be\n-\t * disabled.\n+\t * Use the simple TX handler if possible. Only checksum offloads\n+\t * and vlan insertion are supported.\n \t */\n-\tif (eth_dev->data->dev_conf.txmode.offloads == 0) {\n+\tsimple_tx_offloads = enic->tx_offload_capa &\n+\t\t(DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM |\n+\t\t DEV_TX_OFFLOAD_VLAN_INSERT |\n+\t\t DEV_TX_OFFLOAD_IPV4_CKSUM |\n+\t\t DEV_TX_OFFLOAD_UDP_CKSUM |\n+\t\t DEV_TX_OFFLOAD_TCP_CKSUM);\n+\tif ((eth_dev->data->dev_conf.txmode.offloads &\n+\t ~simple_tx_offloads) == 0) {\n \t\tPMD_INIT_LOG(DEBUG, \" use the simple tx handler\");\n \t\teth_dev->tx_pkt_burst = &enic_simple_xmit_pkts;\n \t\tfor (index = 0; index < enic->wq_count; index++)\ndiff --git a/drivers/net/enic/enic_rxtx.c b/drivers/net/enic/enic_rxtx.c\nindex 8d57c418f..276a2e559 100644\n--- a/drivers/net/enic/enic_rxtx.c\n+++ b/drivers/net/enic/enic_rxtx.c\n@@ -842,12 +842,33 @@ static void enqueue_simple_pkts(struct rte_mbuf **pkts,\n \t\t\t\tstruct enic *enic)\n {\n \tstruct rte_mbuf *p;\n+\tuint16_t mss;\n \n \twhile (n) {\n \t\tn--;\n \t\tp = *pkts++;\n \t\tdesc->address = p->buf_iova + p->data_off;\n \t\tdesc->length = p->pkt_len;\n+\t\t/* VLAN insert */\n+\t\tdesc->vlan_tag = p->vlan_tci;\n+\t\tdesc->header_length_flags &=\n+\t\t\t((1 << WQ_ENET_FLAGS_EOP_SHIFT) |\n+\t\t\t (1 << WQ_ENET_FLAGS_CQ_ENTRY_SHIFT));\n+\t\tif (p->ol_flags & PKT_TX_VLAN) {\n+\t\t\tdesc->header_length_flags |=\n+\t\t\t\t1 << WQ_ENET_FLAGS_VLAN_TAG_INSERT_SHIFT;\n+\t\t}\n+\t\t/*\n+\t\t * Checksum offload. We use WQ_ENET_OFFLOAD_MODE_CSUM, which\n+\t\t * is 0, so no need to set offload_mode.\n+\t\t */\n+\t\tmss = 0;\n+\t\tif (p->ol_flags & PKT_TX_IP_CKSUM)\n+\t\t\tmss |= ENIC_CALC_IP_CKSUM << WQ_ENET_MSS_SHIFT;\n+\t\tif (p->ol_flags & PKT_TX_L4_MASK)\n+\t\t\tmss |= ENIC_CALC_TCP_UDP_CKSUM << WQ_ENET_MSS_SHIFT;\n+\t\tdesc->mss_loopback = mss;\n+\n \t\t/*\n \t\t * The app should not send oversized\n \t\t * packets. tx_pkt_prepare includes a check as\n", "prefixes": [ "5/6" ] }