Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 45336,
    "url": "https://patches.dpdk.org/api/patches/45336/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20180925153230.72096-1-kevin.laatz@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20180925153230.72096-1-kevin.laatz@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20180925153230.72096-1-kevin.laatz@intel.com",
    "date": "2018-09-25T15:32:28",
    "name": "[v4,1/3] lib/librte_table: add hash func header files",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "2167ccbae880ef2f3eb188033007645a49e3e78c",
    "submitter": {
        "id": 921,
        "url": "https://patches.dpdk.org/api/people/921/?format=api",
        "name": "Kevin Laatz",
        "email": "kevin.laatz@intel.com"
    },
    "delegate": {
        "id": 10018,
        "url": "https://patches.dpdk.org/api/users/10018/?format=api",
        "username": "cristian_dumitrescu",
        "first_name": "Cristian",
        "last_name": "Dumitrescu",
        "email": "cristian.dumitrescu@intel.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20180925153230.72096-1-kevin.laatz@intel.com/mbox/",
    "series": [
        {
            "id": 1500,
            "url": "https://patches.dpdk.org/api/series/1500/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=1500",
            "date": "2018-09-25T15:32:29",
            "name": "[v4,1/3] lib/librte_table: add hash func header files",
            "version": 4,
            "mbox": "https://patches.dpdk.org/series/1500/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/45336/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/45336/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id BAD4A1B452;\n\tTue, 25 Sep 2018 17:34:48 +0200 (CEST)",
            "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n\tby dpdk.org (Postfix) with ESMTP id 0F5105F25\n\tfor <dev@dpdk.org>; Tue, 25 Sep 2018 17:34:37 +0200 (CEST)",
            "from orsmga004.jf.intel.com ([10.7.209.38])\n\tby orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t25 Sep 2018 08:34:36 -0700",
            "from silpixa00397517.ir.intel.com (HELO\n\tsilpixa00397517.ger.corp.intel.com) ([10.237.222.54])\n\tby orsmga004.jf.intel.com with ESMTP; 25 Sep 2018 08:32:29 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.54,302,1534834800\"; d=\"scan'208\";a=\"235804445\"",
        "From": "Kevin Laatz <kevin.laatz@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "jianbo.liu@arm.com, gavin.hu@arm.com, jerin.jacob@caviumnetworks.com,\n\tcristian.dumitrescu@intel.com, Kevin Laatz <kevin.laatz@intel.com>",
        "Date": "Tue, 25 Sep 2018 16:32:28 +0100",
        "Message-Id": "<20180925153230.72096-1-kevin.laatz@intel.com>",
        "X-Mailer": "git-send-email 2.9.5",
        "In-Reply-To": "<20180907100626.8165-1-kevin.laatz@intel.com>",
        "References": "<20180907100626.8165-1-kevin.laatz@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v4 1/3] lib/librte_table: add hash func header\n\tfiles",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "This commit adds rte_table_hash_func.h and rte_table_hash_func_arm64.h to\nlibrte_table. This reduces code duplication by removing duplicate header\nfiles within two folders and consolidating them into a single one. This\nalso adds a scalar implementation of the x86_64 intrinsic for crc32 as a\ngeneric fallback.\n\nSigned-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>\nSigned-off-by: Kevin Laatz <kevin.laatz@intel.com>\nAcked-by: Gavin Hu <gavin.hu@arm.com>\n---\nv2:\n   - Fixed typo in commit message\n   - Fixed typo in arm header that caused some compilations to fail for the\n     entire patchset\nv3:\n   - Improved commit message\n\nv4:\n   - Fixed checkpatch.sh and check-git-log.sh errors\n---\n lib/librte_table/Makefile                    |   2 +\n lib/librte_table/meson.build                 |   2 +\n lib/librte_table/rte_table_hash_func.h       | 245 +++++++++++++++++++++++++++\n lib/librte_table/rte_table_hash_func_arm64.h |  21 +++\n 4 files changed, 270 insertions(+)\n create mode 100644 lib/librte_table/rte_table_hash_func.h\n create mode 100644 lib/librte_table/rte_table_hash_func_arm64.h",
    "diff": "diff --git a/lib/librte_table/Makefile b/lib/librte_table/Makefile\nindex 276d476..f935678 100644\n--- a/lib/librte_table/Makefile\n+++ b/lib/librte_table/Makefile\n@@ -46,6 +46,8 @@ SYMLINK-$(CONFIG_RTE_LIBRTE_TABLE)-include += rte_table_acl.h\n endif\n SYMLINK-$(CONFIG_RTE_LIBRTE_TABLE)-include += rte_table_hash.h\n SYMLINK-$(CONFIG_RTE_LIBRTE_TABLE)-include += rte_table_hash_cuckoo.h\n+SYMLINK-$(CONFIG_RTE_LIBRTE_TABLE)-include += rte_table_hash_func.h\n+SYMLINK-$(CONFIG_RTE_LIBRTE_TABLE)-include += rte_table_hash_func_arm64.h\n SYMLINK-$(CONFIG_RTE_LIBRTE_TABLE)-include += rte_lru.h\n ifeq ($(CONFIG_RTE_ARCH_X86),y)\n SYMLINK-$(CONFIG_RTE_LIBRTE_TABLE)-include += rte_lru_x86.h\ndiff --git a/lib/librte_table/meson.build b/lib/librte_table/meson.build\nindex 8b2f841..6ae3cd6 100644\n--- a/lib/librte_table/meson.build\n+++ b/lib/librte_table/meson.build\n@@ -19,6 +19,8 @@ headers = files('rte_table.h',\n \t\t'rte_table_lpm_ipv6.h',\n \t\t'rte_table_hash.h',\n \t\t'rte_table_hash_cuckoo.h',\n+\t\t'rte_table_hash_func.h',\n+\t\t'rte_table_hash_func_arm64.h',\n \t\t'rte_lru.h',\n \t\t'rte_table_array.h',\n \t\t'rte_table_stub.h')\ndiff --git a/lib/librte_table/rte_table_hash_func.h b/lib/librte_table/rte_table_hash_func.h\nnew file mode 100644\nindex 0000000..02296ea\n--- /dev/null\n+++ b/lib/librte_table/rte_table_hash_func.h\n@@ -0,0 +1,245 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(c) 2010-2018 Intel Corporation\n+ */\n+\n+#ifndef __INCLUDE_RTE_TABLE_HASH_FUNC_H__\n+#define __INCLUDE_RTE_TABLE_HASH_FUNC_H__\n+\n+#ifdef __cplusplus\n+extern \"C\" {\n+#endif\n+\n+#include <stdint.h>\n+\n+#include <rte_compat.h>\n+#include <rte_common.h>\n+\n+static inline uint64_t __rte_experimental\n+rte_crc32_u64_generic(uint64_t crc, uint64_t value)\n+{\n+\tint i;\n+\n+\tcrc = (crc & 0xFFFFFFFFLLU) ^ value;\n+\tfor (i = 63; i >= 0; i--) {\n+\t\tuint64_t mask;\n+\n+\t\tmask = -(crc & 1LLU);\n+\t\tcrc = (crc >> 1LLU) ^ (0x82F63B78LLU & mask);\n+\t}\n+\n+\treturn crc;\n+}\n+\n+#if defined(RTE_ARCH_X86_64)\n+\n+#include <x86intrin.h>\n+\n+static inline uint64_t\n+rte_crc32_u64(uint64_t crc, uint64_t v)\n+{\n+\treturn _mm_crc32_u64(crc, v);\n+}\n+\n+#elif defined(RTE_ARCH_ARM64)\n+#include \"rte_table_hash_func_arm64.h\"\n+#else\n+\n+static inline uint64_t\n+rte_crc32_u64(uint64_t crc, uint64_t v)\n+{\n+\treturn rte_crc32_u64_generic(crc, v);\n+}\n+\n+#endif\n+\n+static inline uint64_t __rte_experimental\n+rte_table_hash_crc_key8(void *key, void *mask, __rte_unused uint32_t key_size,\n+\tuint64_t seed)\n+{\n+\tuint64_t *k = key;\n+\tuint64_t *m = mask;\n+\tuint64_t crc0;\n+\n+\tcrc0 = rte_crc32_u64(seed, k[0] & m[0]);\n+\n+\treturn crc0;\n+}\n+\n+static inline uint64_t __rte_experimental\n+rte_table_hash_crc_key16(void *key, void *mask, __rte_unused uint32_t key_size,\n+\tuint64_t seed)\n+{\n+\tuint64_t *k = key;\n+\tuint64_t *m = mask;\n+\tuint64_t k0, crc0, crc1;\n+\n+\tk0 = k[0] & m[0];\n+\n+\tcrc0 = rte_crc32_u64(k0, seed);\n+\tcrc1 = rte_crc32_u64(k0 >> 32, k[1] & m[1]);\n+\n+\tcrc0 ^= crc1;\n+\n+\treturn crc0;\n+}\n+\n+static inline uint64_t __rte_experimental\n+rte_table_hash_crc_key24(void *key, void *mask, __rte_unused uint32_t key_size,\n+\tuint64_t seed)\n+{\n+\tuint64_t *k = key;\n+\tuint64_t *m = mask;\n+\tuint64_t k0, k2, crc0, crc1;\n+\n+\tk0 = k[0] & m[0];\n+\tk2 = k[2] & m[2];\n+\n+\tcrc0 = rte_crc32_u64(k0, seed);\n+\tcrc1 = rte_crc32_u64(k0 >> 32, k[1] & m[1]);\n+\n+\tcrc0 = rte_crc32_u64(crc0, k2);\n+\n+\tcrc0 ^= crc1;\n+\n+\treturn crc0;\n+}\n+\n+static inline uint64_t __rte_experimental\n+rte_table_hash_crc_key32(void *key, void *mask, __rte_unused uint32_t key_size,\n+\tuint64_t seed)\n+{\n+\tuint64_t *k = key;\n+\tuint64_t *m = mask;\n+\tuint64_t k0, k2, crc0, crc1, crc2, crc3;\n+\n+\tk0 = k[0] & m[0];\n+\tk2 = k[2] & m[2];\n+\n+\tcrc0 = rte_crc32_u64(k0, seed);\n+\tcrc1 = rte_crc32_u64(k0 >> 32, k[1] & m[1]);\n+\n+\tcrc2 = rte_crc32_u64(k2, k[3] & m[3]);\n+\tcrc3 = k2 >> 32;\n+\n+\tcrc0 = rte_crc32_u64(crc0, crc1);\n+\tcrc1 = rte_crc32_u64(crc2, crc3);\n+\n+\tcrc0 ^= crc1;\n+\n+\treturn crc0;\n+}\n+\n+static inline uint64_t __rte_experimental\n+rte_table_hash_crc_key40(void *key, void *mask, __rte_unused uint32_t key_size,\n+\tuint64_t seed)\n+{\n+\tuint64_t *k = key;\n+\tuint64_t *m = mask;\n+\tuint64_t k0, k2, crc0, crc1, crc2, crc3;\n+\n+\tk0 = k[0] & m[0];\n+\tk2 = k[2] & m[2];\n+\n+\tcrc0 = rte_crc32_u64(k0, seed);\n+\tcrc1 = rte_crc32_u64(k0 >> 32, k[1] & m[1]);\n+\n+\tcrc2 = rte_crc32_u64(k2, k[3] & m[3]);\n+\tcrc3 = rte_crc32_u64(k2 >> 32, k[4] & m[4]);\n+\n+\tcrc0 = rte_crc32_u64(crc0, crc1);\n+\tcrc1 = rte_crc32_u64(crc2, crc3);\n+\n+\tcrc0 ^= crc1;\n+\n+\treturn crc0;\n+}\n+\n+static inline uint64_t __rte_experimental\n+rte_table_hash_crc_key48(void *key, void *mask, __rte_unused uint32_t key_size,\n+\tuint64_t seed)\n+{\n+\tuint64_t *k = key;\n+\tuint64_t *m = mask;\n+\tuint64_t k0, k2, k5, crc0, crc1, crc2, crc3;\n+\n+\tk0 = k[0] & m[0];\n+\tk2 = k[2] & m[2];\n+\tk5 = k[5] & m[5];\n+\n+\tcrc0 = rte_crc32_u64(k0, seed);\n+\tcrc1 = rte_crc32_u64(k0 >> 32, k[1] & m[1]);\n+\n+\tcrc2 = rte_crc32_u64(k2, k[3] & m[3]);\n+\tcrc3 = rte_crc32_u64(k2 >> 32, k[4] & m[4]);\n+\n+\tcrc0 = rte_crc32_u64(crc0, (crc1 << 32) ^ crc2);\n+\tcrc1 = rte_crc32_u64(crc3, k5);\n+\n+\tcrc0 ^= crc1;\n+\n+\treturn crc0;\n+}\n+\n+static inline uint64_t __rte_experimental\n+rte_table_hash_crc_key56(void *key, void *mask, __rte_unused uint32_t key_size,\n+\tuint64_t seed)\n+{\n+\tuint64_t *k = key;\n+\tuint64_t *m = mask;\n+\tuint64_t k0, k2, k5, crc0, crc1, crc2, crc3, crc4, crc5;\n+\n+\tk0 = k[0] & m[0];\n+\tk2 = k[2] & m[2];\n+\tk5 = k[5] & m[5];\n+\n+\tcrc0 = rte_crc32_u64(k0, seed);\n+\tcrc1 = rte_crc32_u64(k0 >> 32, k[1] & m[1]);\n+\n+\tcrc2 = rte_crc32_u64(k2, k[3] & m[3]);\n+\tcrc3 = rte_crc32_u64(k2 >> 32, k[4] & m[4]);\n+\n+\tcrc4 = rte_crc32_u64(k5, k[6] & m[6]);\n+\tcrc5 = k5 >> 32;\n+\n+\tcrc0 = rte_crc32_u64(crc0, (crc1 << 32) ^ crc2);\n+\tcrc1 = rte_crc32_u64(crc3, (crc4 << 32) ^ crc5);\n+\n+\tcrc0 ^= crc1;\n+\n+\treturn crc0;\n+}\n+\n+static inline uint64_t __rte_experimental\n+rte_table_hash_crc_key64(void *key, void *mask, __rte_unused uint32_t key_size,\n+\tuint64_t seed)\n+{\n+\tuint64_t *k = key;\n+\tuint64_t *m = mask;\n+\tuint64_t k0, k2, k5, crc0, crc1, crc2, crc3, crc4, crc5;\n+\n+\tk0 = k[0] & m[0];\n+\tk2 = k[2] & m[2];\n+\tk5 = k[5] & m[5];\n+\n+\tcrc0 = rte_crc32_u64(k0, seed);\n+\tcrc1 = rte_crc32_u64(k0 >> 32, k[1] & m[1]);\n+\n+\tcrc2 = rte_crc32_u64(k2, k[3] & m[3]);\n+\tcrc3 = rte_crc32_u64(k2 >> 32, k[4] & m[4]);\n+\n+\tcrc4 = rte_crc32_u64(k5, k[6] & m[6]);\n+\tcrc5 = rte_crc32_u64(k5 >> 32, k[7] & m[7]);\n+\n+\tcrc0 = rte_crc32_u64(crc0, (crc1 << 32) ^ crc2);\n+\tcrc1 = rte_crc32_u64(crc3, (crc4 << 32) ^ crc5);\n+\n+\tcrc0 ^= crc1;\n+\n+\treturn crc0;\n+}\n+\n+#ifdef __cplusplus\n+}\n+#endif\n+\n+#endif\ndiff --git a/lib/librte_table/rte_table_hash_func_arm64.h b/lib/librte_table/rte_table_hash_func_arm64.h\nnew file mode 100644\nindex 0000000..eb04c1f\n--- /dev/null\n+++ b/lib/librte_table/rte_table_hash_func_arm64.h\n@@ -0,0 +1,21 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(c) 2017-2018 Linaro Limited\n+ */\n+\n+#ifndef __INCLUDE_RTE_TABLE_HASH_FUNC_ARM64_H__\n+#define __INCLUDE_RTE_TABLE_HASH_FUNC_ARM64_H__\n+\n+#define _CRC32CX(crc, val)\t\\\n+\t__asm__(\"crc32cx %w[c], %w[c], %x[v]\":[c] \"+r\" (crc):[v] \"r\" (val))\n+\n+static inline uint64_t\n+rte_crc32_u64(uint64_t crc, uint64_t v)\n+{\n+\tuint32_t crc32 = crc;\n+\n+\t_CRC32CX(crc32, v);\n+\n+\treturn crc32;\n+}\n+\n+#endif\n",
    "prefixes": [
        "v4",
        "1/3"
    ]
}