Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/45281/?format=api
{ "id": 45281, "url": "https://patches.dpdk.org/api/patches/45281/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20180925031001.164277-1-xiao.w.wang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180925031001.164277-1-xiao.w.wang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180925031001.164277-1-xiao.w.wang@intel.com", "date": "2018-09-25T03:10:01", "name": "net/ifc: fix function name", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "07a83c131c98432fdacee233a3591de8bec2bf6f", "submitter": { "id": 281, "url": "https://patches.dpdk.org/api/people/281/?format=api", "name": "Xiao Wang", "email": "xiao.w.wang@intel.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20180925031001.164277-1-xiao.w.wang@intel.com/mbox/", "series": [ { "id": 1478, "url": "https://patches.dpdk.org/api/series/1478/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=1478", "date": "2018-09-25T03:10:01", "name": "net/ifc: fix function name", "version": 1, "mbox": "https://patches.dpdk.org/series/1478/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/45281/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/45281/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B19591B3A7;\n\tTue, 25 Sep 2018 05:17:56 +0200 (CEST)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby dpdk.org (Postfix) with ESMTP id 433A51B396\n\tfor <dev@dpdk.org>; Tue, 25 Sep 2018 05:17:55 +0200 (CEST)", "from orsmga007.jf.intel.com ([10.7.209.58])\n\tby orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t24 Sep 2018 20:17:54 -0700", "from dpdk-xiao-1.sh.intel.com ([10.67.111.123])\n\tby orsmga007.jf.intel.com with ESMTP; 24 Sep 2018 20:17:46 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.54,300,1534834800\"; d=\"scan'208\";a=\"75650471\"", "From": "Xiao Wang <xiao.w.wang@intel.com>", "To": "qi.z.zhang@intel.com", "Cc": "dev@dpdk.org, xiaolong.ye@intel.com, Xiao Wang <xiao.w.wang@intel.com>", "Date": "Tue, 25 Sep 2018 11:10:01 +0800", "Message-Id": "<20180925031001.164277-1-xiao.w.wang@intel.com>", "X-Mailer": "git-send-email 2.15.1", "Subject": "[dpdk-dev] [PATCH] net/ifc: fix function name", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The address translation from user virtual address to guest physical\naddress should not be named as qva_to_gpa.\n\nFixes: a3f8150eac6d (\"net/ifcvf: add ifcvf vDPA driver\")\n\nSigned-off-by: Xiao Wang <xiao.w.wang@intel.com>\n---\n drivers/net/ifc/ifcvf_vdpa.c | 14 +++++++-------\n 1 file changed, 7 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/ifc/ifcvf_vdpa.c b/drivers/net/ifc/ifcvf_vdpa.c\nindex 7d3085d8d..a26da8086 100644\n--- a/drivers/net/ifc/ifcvf_vdpa.c\n+++ b/drivers/net/ifc/ifcvf_vdpa.c\n@@ -206,7 +206,7 @@ ifcvf_dma_map(struct ifcvf_internal *internal, int do_map)\n }\n \n static uint64_t\n-qva_to_gpa(int vid, uint64_t qva)\n+hva_to_gpa(int vid, uint64_t hva)\n {\n \tstruct rte_vhost_memory *mem = NULL;\n \tstruct rte_vhost_mem_region *reg;\n@@ -219,9 +219,9 @@ qva_to_gpa(int vid, uint64_t qva)\n \tfor (i = 0; i < mem->nregions; i++) {\n \t\treg = &mem->regions[i];\n \n-\t\tif (qva >= reg->host_user_addr &&\n-\t\t\t\tqva < reg->host_user_addr + reg->size) {\n-\t\t\tgpa = qva - reg->host_user_addr + reg->guest_phys_addr;\n+\t\tif (hva >= reg->host_user_addr &&\n+\t\t\t\thva < reg->host_user_addr + reg->size) {\n+\t\t\tgpa = hva - reg->host_user_addr + reg->guest_phys_addr;\n \t\t\tbreak;\n \t\t}\n \t}\n@@ -247,21 +247,21 @@ vdpa_ifcvf_start(struct ifcvf_internal *internal)\n \n \tfor (i = 0; i < nr_vring; i++) {\n \t\trte_vhost_get_vhost_vring(vid, i, &vq);\n-\t\tgpa = qva_to_gpa(vid, (uint64_t)(uintptr_t)vq.desc);\n+\t\tgpa = hva_to_gpa(vid, (uint64_t)(uintptr_t)vq.desc);\n \t\tif (gpa == 0) {\n \t\t\tDRV_LOG(ERR, \"Fail to get GPA for descriptor ring.\");\n \t\t\treturn -1;\n \t\t}\n \t\thw->vring[i].desc = gpa;\n \n-\t\tgpa = qva_to_gpa(vid, (uint64_t)(uintptr_t)vq.avail);\n+\t\tgpa = hva_to_gpa(vid, (uint64_t)(uintptr_t)vq.avail);\n \t\tif (gpa == 0) {\n \t\t\tDRV_LOG(ERR, \"Fail to get GPA for available ring.\");\n \t\t\treturn -1;\n \t\t}\n \t\thw->vring[i].avail = gpa;\n \n-\t\tgpa = qva_to_gpa(vid, (uint64_t)(uintptr_t)vq.used);\n+\t\tgpa = hva_to_gpa(vid, (uint64_t)(uintptr_t)vq.used);\n \t\tif (gpa == 0) {\n \t\t\tDRV_LOG(ERR, \"Fail to get GPA for used ring.\");\n \t\t\treturn -1;\n", "prefixes": [] }