Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/45273/?format=api
https://patches.dpdk.org/api/patches/45273/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20180925023442.134705-9-qi.z.zhang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180925023442.134705-9-qi.z.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180925023442.134705-9-qi.z.zhang@intel.com", "date": "2018-09-25T02:34:30", "name": "[08/20] net/i40e/base: read LLDP config area with correct endianness", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "f06767489081883bb4c53f0eaa1eb861ee9b3a00", "submitter": { "id": 504, "url": "https://patches.dpdk.org/api/people/504/?format=api", "name": "Qi Zhang", "email": "qi.z.zhang@intel.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20180925023442.134705-9-qi.z.zhang@intel.com/mbox/", "series": [ { "id": 1477, "url": "https://patches.dpdk.org/api/series/1477/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=1477", "date": "2018-09-25T02:34:22", "name": "base code update", "version": 1, "mbox": "https://patches.dpdk.org/series/1477/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/45273/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/45273/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D887F1B20C;\n\tTue, 25 Sep 2018 04:34:36 +0200 (CEST)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby dpdk.org (Postfix) with ESMTP id E2B081B148;\n\tTue, 25 Sep 2018 04:34:11 +0200 (CEST)", "from orsmga005.jf.intel.com ([10.7.209.41])\n\tby orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t24 Sep 2018 19:34:08 -0700", "from dpdk51.sh.intel.com ([10.67.110.190])\n\tby orsmga005.jf.intel.com with ESMTP; 24 Sep 2018 19:33:53 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.54,300,1534834800\"; d=\"scan'208\";a=\"259958527\"", "From": "Qi Zhang <qi.z.zhang@intel.com>", "To": "beilei.xing@intel.com", "Cc": "dev@dpdk.org, ferruh.yigit@intel.com, helin.zhang@intel.com,\n\tQi Zhang <qi.z.zhang@intel.com>, stable@dpdk.org", "Date": "Tue, 25 Sep 2018 10:34:30 +0800", "Message-Id": "<20180925023442.134705-9-qi.z.zhang@intel.com>", "X-Mailer": "git-send-email 2.13.6", "In-Reply-To": "<20180925023442.134705-1-qi.z.zhang@intel.com>", "References": "<20180925023442.134705-1-qi.z.zhang@intel.com>", "Subject": "[dpdk-dev] [PATCH 08/20] net/i40e/base: read LLDP config area with\n\tcorrect endianness", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The NVM is in little endian so when we read from it we need to do\nthe correct thing for the endianness of the machine.\n\nCc: stable@dpdk.org\n\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\n---\n drivers/net/i40e/base/i40e_dcb.c | 11 +++++++----\n 1 file changed, 7 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/i40e/base/i40e_dcb.c b/drivers/net/i40e/base/i40e_dcb.c\nindex 7cd444bb3..a26f82b3a 100644\n--- a/drivers/net/i40e/base/i40e_dcb.c\n+++ b/drivers/net/i40e/base/i40e_dcb.c\n@@ -1262,18 +1262,20 @@ static enum i40e_status_code _i40e_read_lldp_cfg(struct i40e_hw *hw,\n {\n \tu32 address, offset = (2 * word_offset);\n \tenum i40e_status_code ret;\n+\t__le16 raw_mem;\n \tu16 mem;\n \n \tret = i40e_acquire_nvm(hw, I40E_RESOURCE_READ);\n \tif (ret != I40E_SUCCESS)\n \t\treturn ret;\n \n-\tret = i40e_aq_read_nvm(hw, 0x0, module * 2, sizeof(mem), &mem, true,\n-\t\t\t NULL);\n+\tret = i40e_aq_read_nvm(hw, 0x0, module * 2, sizeof(raw_mem), &raw_mem,\n+\t\t\t true, NULL);\n \ti40e_release_nvm(hw);\n \tif (ret != I40E_SUCCESS)\n \t\treturn ret;\n \n+\tmem = LE16_TO_CPU(raw_mem);\n \t/* Check if this pointer needs to be read in word size or 4K sector\n \t * units.\n \t */\n@@ -1286,12 +1288,13 @@ static enum i40e_status_code _i40e_read_lldp_cfg(struct i40e_hw *hw,\n \tif (ret != I40E_SUCCESS)\n \t\tgoto err_lldp_cfg;\n \n-\tret = i40e_aq_read_nvm(hw, module, offset, sizeof(mem), &mem, true,\n-\t\t\t NULL);\n+\tret = i40e_aq_read_nvm(hw, module, offset, sizeof(raw_mem), &raw_mem,\n+\t\t\t true, NULL);\n \ti40e_release_nvm(hw);\n \tif (ret != I40E_SUCCESS)\n \t\treturn ret;\n \n+\tmem = LE16_TO_CPU(raw_mem);\n \toffset = mem + word_offset;\n \toffset *= 2;\n \n", "prefixes": [ "08/20" ] }{ "id": 45273, "url": "