Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/45271/?format=api
{ "id": 45271, "url": "https://patches.dpdk.org/api/patches/45271/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20180925023442.134705-11-qi.z.zhang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180925023442.134705-11-qi.z.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180925023442.134705-11-qi.z.zhang@intel.com", "date": "2018-09-25T02:34:32", "name": "[10/20] net/i40e/base: gracefully clean the resources", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "b79c8a035883adc0ba0d737e74d1e5c8638955cc", "submitter": { "id": 504, "url": "https://patches.dpdk.org/api/people/504/?format=api", "name": "Qi Zhang", "email": "qi.z.zhang@intel.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20180925023442.134705-11-qi.z.zhang@intel.com/mbox/", "series": [ { "id": 1477, "url": "https://patches.dpdk.org/api/series/1477/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=1477", "date": "2018-09-25T02:34:22", "name": "base code update", "version": 1, "mbox": "https://patches.dpdk.org/series/1477/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/45271/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/45271/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6F7391B1FE;\n\tTue, 25 Sep 2018 04:34:32 +0200 (CEST)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby dpdk.org (Postfix) with ESMTP id 957645F3C;\n\tTue, 25 Sep 2018 04:34:11 +0200 (CEST)", "from orsmga005.jf.intel.com ([10.7.209.41])\n\tby orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t24 Sep 2018 19:34:08 -0700", "from dpdk51.sh.intel.com ([10.67.110.190])\n\tby orsmga005.jf.intel.com with ESMTP; 24 Sep 2018 19:33:56 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.54,300,1534834800\"; d=\"scan'208\";a=\"259958530\"", "From": "Qi Zhang <qi.z.zhang@intel.com>", "To": "beilei.xing@intel.com", "Cc": "dev@dpdk.org, ferruh.yigit@intel.com, helin.zhang@intel.com,\n\tQi Zhang <qi.z.zhang@intel.com>, stable@dpdk.org", "Date": "Tue, 25 Sep 2018 10:34:32 +0800", "Message-Id": "<20180925023442.134705-11-qi.z.zhang@intel.com>", "X-Mailer": "git-send-email 2.13.6", "In-Reply-To": "<20180925023442.134705-1-qi.z.zhang@intel.com>", "References": "<20180925023442.134705-1-qi.z.zhang@intel.com>", "Subject": "[dpdk-dev] [PATCH 10/20] net/i40e/base: gracefully clean the\n\tresources", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Allocated resources were not freed in the event of failure in\ni40e_init_asq function. This patch gracefully handles all failures.\n\nCc: stable@dpdk.org\n\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\n---\n drivers/net/i40e/base/i40e_adminq.c | 7 ++++++-\n 1 file changed, 6 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/i40e/base/i40e_adminq.c b/drivers/net/i40e/base/i40e_adminq.c\nindex 5736e0cb3..bb4c5c61e 100644\n--- a/drivers/net/i40e/base/i40e_adminq.c\n+++ b/drivers/net/i40e/base/i40e_adminq.c\n@@ -97,6 +97,7 @@ enum i40e_status_code i40e_alloc_adminq_arq_ring(struct i40e_hw *hw)\n **/\n void i40e_free_adminq_asq(struct i40e_hw *hw)\n {\n+\ti40e_free_virt_mem(hw, &hw->aq.asq.cmd_buf);\n \ti40e_free_dma_mem(hw, &hw->aq.asq.desc_buf);\n }\n \n@@ -404,7 +405,7 @@ enum i40e_status_code i40e_init_asq(struct i40e_hw *hw)\n \t/* initialize base registers */\n \tret_code = i40e_config_asq_regs(hw);\n \tif (ret_code != I40E_SUCCESS)\n-\t\tgoto init_adminq_free_rings;\n+\t\tgoto init_config_regs;\n \n \t/* success! */\n \thw->aq.asq.count = hw->aq.num_asq_entries;\n@@ -412,6 +413,10 @@ enum i40e_status_code i40e_init_asq(struct i40e_hw *hw)\n \n init_adminq_free_rings:\n \ti40e_free_adminq_asq(hw);\n+\treturn ret_code;\n+\n+init_config_regs:\n+\ti40e_free_asq_bufs(hw);\n \n init_adminq_exit:\n \treturn ret_code;\n", "prefixes": [ "10/20" ] }