Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/45269/?format=api
{ "id": 45269, "url": "https://patches.dpdk.org/api/patches/45269/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20180925023442.134705-13-qi.z.zhang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180925023442.134705-13-qi.z.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180925023442.134705-13-qi.z.zhang@intel.com", "date": "2018-09-25T02:34:34", "name": "[12/20] net/i40e/base: change AQ command for PHY access", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "95af6bac02d4f34b7a0f6f13a3942d9c730a1f8d", "submitter": { "id": 504, "url": "https://patches.dpdk.org/api/people/504/?format=api", "name": "Qi Zhang", "email": "qi.z.zhang@intel.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20180925023442.134705-13-qi.z.zhang@intel.com/mbox/", "series": [ { "id": 1477, "url": "https://patches.dpdk.org/api/series/1477/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=1477", "date": "2018-09-25T02:34:22", "name": "base code update", "version": 1, "mbox": "https://patches.dpdk.org/series/1477/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/45269/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/45269/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6E8D41B1F3;\n\tTue, 25 Sep 2018 04:34:29 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id 19E611B148\n\tfor <dev@dpdk.org>; Tue, 25 Sep 2018 04:34:10 +0200 (CEST)", "from orsmga005.jf.intel.com ([10.7.209.41])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t24 Sep 2018 19:34:08 -0700", "from dpdk51.sh.intel.com ([10.67.110.190])\n\tby orsmga005.jf.intel.com with ESMTP; 24 Sep 2018 19:33:59 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.54,300,1534834800\"; d=\"scan'208\";a=\"259958535\"", "From": "Qi Zhang <qi.z.zhang@intel.com>", "To": "beilei.xing@intel.com", "Cc": "dev@dpdk.org, ferruh.yigit@intel.com, helin.zhang@intel.com,\n\tQi Zhang <qi.z.zhang@intel.com>", "Date": "Tue, 25 Sep 2018 10:34:34 +0800", "Message-Id": "<20180925023442.134705-13-qi.z.zhang@intel.com>", "X-Mailer": "git-send-email 2.13.6", "In-Reply-To": "<20180925023442.134705-1-qi.z.zhang@intel.com>", "References": "<20180925023442.134705-1-qi.z.zhang@intel.com>", "Subject": "[dpdk-dev] [PATCH 12/20] net/i40e/base: change AQ command for PHY\n\taccess", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add new field - command flags with only one flag for now. Added flag\ntells FW that it shouldn't change page while accessing QSFP module,\nas it was set manually.\n\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\n---\n drivers/net/i40e/base/i40e_adminq_cmd.h | 4 +++-\n drivers/net/i40e/base/i40e_common.c | 18 +++++++++++++-----\n drivers/net/i40e/base/i40e_prototype.h | 4 ++--\n drivers/net/i40e/i40e_ethdev.c | 8 ++++----\n 4 files changed, 22 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/net/i40e/base/i40e_adminq_cmd.h b/drivers/net/i40e/base/i40e_adminq_cmd.h\nindex 343b48f25..1e6932120 100644\n--- a/drivers/net/i40e/base/i40e_adminq_cmd.h\n+++ b/drivers/net/i40e/base/i40e_adminq_cmd.h\n@@ -2276,7 +2276,9 @@ struct i40e_aqc_phy_register_access {\n #define I40E_AQ_PHY_REG_ACCESS_EXTERNAL\t1\n #define I40E_AQ_PHY_REG_ACCESS_EXTERNAL_MODULE\t2\n \tu8\tdev_addres;\n-\tu8\treserved1[2];\n+\tu8\tcmd_flags;\n+#define I40E_AQ_PHY_REG_ACCESS_DONT_CHANGE_QSFP_PAGE\t1\n+\tu8\treserved1;\n \t__le32\treg_address;\n \t__le32\treg_value;\n \tu8\treserved2[4];\ndiff --git a/drivers/net/i40e/base/i40e_common.c b/drivers/net/i40e/base/i40e_common.c\nindex 0eb369ff6..e0b7f4086 100644\n--- a/drivers/net/i40e/base/i40e_common.c\n+++ b/drivers/net/i40e/base/i40e_common.c\n@@ -6796,7 +6796,7 @@ static enum i40e_status_code i40e_led_get_reg(struct i40e_hw *hw, u16 led_addr,\n \tif (hw->flags & I40E_HW_FLAG_AQ_PHY_ACCESS_CAPABLE) {\n \t\tstatus = i40e_aq_get_phy_register(hw,\n \t\t\t\t\t\tI40E_AQ_PHY_REG_ACCESS_EXTERNAL,\n-\t\t\t\t\t\tI40E_PHY_COM_REG_PAGE,\n+\t\t\t\t\t\tI40E_PHY_COM_REG_PAGE, true,\n \t\t\t\t\t\tI40E_PHY_LED_PROV_REG_1,\n \t\t\t\t\t\treg_val, NULL);\n \t} else {\n@@ -6824,7 +6824,7 @@ static enum i40e_status_code i40e_led_set_reg(struct i40e_hw *hw, u16 led_addr,\n \tif (hw->flags & I40E_HW_FLAG_AQ_PHY_ACCESS_CAPABLE) {\n \t\tstatus = i40e_aq_set_phy_register(hw,\n \t\t\t\t\t\tI40E_AQ_PHY_REG_ACCESS_EXTERNAL,\n-\t\t\t\t\t\tI40E_PHY_COM_REG_PAGE,\n+\t\t\t\t\t\tI40E_PHY_COM_REG_PAGE, true,\n \t\t\t\t\t\tI40E_PHY_LED_PROV_REG_1,\n \t\t\t\t\t\treg_val, NULL);\n \t} else {\n@@ -6858,7 +6858,7 @@ enum i40e_status_code i40e_led_get_phy(struct i40e_hw *hw, u16 *led_addr,\n \tif (hw->flags & I40E_HW_FLAG_AQ_PHY_ACCESS_CAPABLE) {\n \t\tstatus = i40e_aq_get_phy_register(hw,\n \t\t\t\t\t\tI40E_AQ_PHY_REG_ACCESS_EXTERNAL,\n-\t\t\t\t\t\tI40E_PHY_COM_REG_PAGE,\n+\t\t\t\t\t\tI40E_PHY_COM_REG_PAGE, true,\n \t\t\t\t\t\tI40E_PHY_LED_PROV_REG_1,\n \t\t\t\t\t\t®_val_aq, NULL);\n \t\tif (status == I40E_SUCCESS)\n@@ -7064,6 +7064,7 @@ void i40e_write_rx_ctl(struct i40e_hw *hw, u32 reg_addr, u32 reg_val)\n * @hw: pointer to the hw struct\n * @phy_select: select which phy should be accessed\n * @dev_addr: PHY device address\n+ * @page_change: enable auto page change\n * @reg_addr: PHY register address\n * @reg_val: new register value\n * @cmd_details: pointer to command details structure or NULL\n@@ -7071,7 +7072,7 @@ void i40e_write_rx_ctl(struct i40e_hw *hw, u32 reg_addr, u32 reg_val)\n * Write the external PHY register.\n **/\n enum i40e_status_code i40e_aq_set_phy_register(struct i40e_hw *hw,\n-\t\t\t\tu8 phy_select, u8 dev_addr,\n+\t\t\t\tu8 phy_select, u8 dev_addr, bool page_change,\n \t\t\t\tu32 reg_addr, u32 reg_val,\n \t\t\t\tstruct i40e_asq_cmd_details *cmd_details)\n {\n@@ -7088,6 +7089,9 @@ enum i40e_status_code i40e_aq_set_phy_register(struct i40e_hw *hw,\n \tcmd->reg_address = CPU_TO_LE32(reg_addr);\n \tcmd->reg_value = CPU_TO_LE32(reg_val);\n \n+\tif (!page_change)\n+\t\tcmd->cmd_flags = I40E_AQ_PHY_REG_ACCESS_DONT_CHANGE_QSFP_PAGE;\n+\n \tstatus = i40e_asq_send_command(hw, &desc, NULL, 0, cmd_details);\n \n \treturn status;\n@@ -7098,6 +7102,7 @@ enum i40e_status_code i40e_aq_set_phy_register(struct i40e_hw *hw,\n * @hw: pointer to the hw struct\n * @phy_select: select which phy should be accessed\n * @dev_addr: PHY device address\n+ * @page_change: enable auto page change\n * @reg_addr: PHY register address\n * @reg_val: read register value\n * @cmd_details: pointer to command details structure or NULL\n@@ -7105,7 +7110,7 @@ enum i40e_status_code i40e_aq_set_phy_register(struct i40e_hw *hw,\n * Read the external PHY register.\n **/\n enum i40e_status_code i40e_aq_get_phy_register(struct i40e_hw *hw,\n-\t\t\t\tu8 phy_select, u8 dev_addr,\n+\t\t\t\tu8 phy_select, u8 dev_addr, bool page_change,\n \t\t\t\tu32 reg_addr, u32 *reg_val,\n \t\t\t\tstruct i40e_asq_cmd_details *cmd_details)\n {\n@@ -7121,6 +7126,9 @@ enum i40e_status_code i40e_aq_get_phy_register(struct i40e_hw *hw,\n \tcmd->dev_addres = dev_addr;\n \tcmd->reg_address = CPU_TO_LE32(reg_addr);\n \n+\tif (!page_change)\n+\t\tcmd->cmd_flags = I40E_AQ_PHY_REG_ACCESS_DONT_CHANGE_QSFP_PAGE;\n+\n \tstatus = i40e_asq_send_command(hw, &desc, NULL, 0, cmd_details);\n \tif (!status)\n \t\t*reg_val = LE32_TO_CPU(cmd->reg_value);\ndiff --git a/drivers/net/i40e/base/i40e_prototype.h b/drivers/net/i40e/base/i40e_prototype.h\nindex 9dd07de2b..f325924ee 100644\n--- a/drivers/net/i40e/base/i40e_prototype.h\n+++ b/drivers/net/i40e/base/i40e_prototype.h\n@@ -545,11 +545,11 @@ enum i40e_status_code i40e_aq_rx_ctl_write_register(struct i40e_hw *hw,\n \t\t\t\tstruct i40e_asq_cmd_details *cmd_details);\n void i40e_write_rx_ctl(struct i40e_hw *hw, u32 reg_addr, u32 reg_val);\n enum i40e_status_code i40e_aq_set_phy_register(struct i40e_hw *hw,\n-\t\t\t\tu8 phy_select, u8 dev_addr,\n+\t\t\t\tu8 phy_select, u8 dev_addr, bool page_change,\n \t\t\t\tu32 reg_addr, u32 reg_val,\n \t\t\t\tstruct i40e_asq_cmd_details *cmd_details);\n enum i40e_status_code i40e_aq_get_phy_register(struct i40e_hw *hw,\n-\t\t\t\tu8 phy_select, u8 dev_addr,\n+\t\t\t\tu8 phy_select, u8 dev_addr, bool page_change,\n \t\t\t\tu32 reg_addr, u32 *reg_val,\n \t\t\t\tstruct i40e_asq_cmd_details *cmd_details);\n \ndiff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c\nindex 8a78a6a4b..8c0fd0091 100644\n--- a/drivers/net/i40e/i40e_ethdev.c\n+++ b/drivers/net/i40e/i40e_ethdev.c\n@@ -11717,7 +11717,7 @@ static int i40e_get_module_info(struct rte_eth_dev *dev,\n \tcase I40E_MODULE_TYPE_SFP:\n \t\tstatus = i40e_aq_get_phy_register(hw,\n \t\t\t\tI40E_AQ_PHY_REG_ACCESS_EXTERNAL_MODULE,\n-\t\t\t\tI40E_I2C_EEPROM_DEV_ADDR,\n+\t\t\t\tI40E_I2C_EEPROM_DEV_ADDR, 1,\n \t\t\t\tI40E_MODULE_SFF_8472_COMP,\n \t\t\t\t&sff8472_comp, NULL);\n \t\tif (status)\n@@ -11725,7 +11725,7 @@ static int i40e_get_module_info(struct rte_eth_dev *dev,\n \n \t\tstatus = i40e_aq_get_phy_register(hw,\n \t\t\t\tI40E_AQ_PHY_REG_ACCESS_EXTERNAL_MODULE,\n-\t\t\t\tI40E_I2C_EEPROM_DEV_ADDR,\n+\t\t\t\tI40E_I2C_EEPROM_DEV_ADDR, 1,\n \t\t\t\tI40E_MODULE_SFF_8472_SWAP,\n \t\t\t\t&sff8472_swap, NULL);\n \t\tif (status)\n@@ -11753,7 +11753,7 @@ static int i40e_get_module_info(struct rte_eth_dev *dev,\n \t\t/* Read from memory page 0. */\n \t\tstatus = i40e_aq_get_phy_register(hw,\n \t\t\t\tI40E_AQ_PHY_REG_ACCESS_EXTERNAL_MODULE,\n-\t\t\t\t0,\n+\t\t\t\t0, 1,\n \t\t\t\tI40E_MODULE_REVISION_ADDR,\n \t\t\t\t&sff8636_rev, NULL);\n \t\tif (status)\n@@ -11814,7 +11814,7 @@ static int i40e_get_module_eeprom(struct rte_eth_dev *dev,\n \t\t}\n \t\tstatus = i40e_aq_get_phy_register(hw,\n \t\t\t\tI40E_AQ_PHY_REG_ACCESS_EXTERNAL_MODULE,\n-\t\t\t\taddr, offset, &value, NULL);\n+\t\t\t\taddr, offset, 1, &value, NULL);\n \t\tif (status)\n \t\t\treturn -EIO;\n \t\tdata[i] = (uint8_t)value;\n", "prefixes": [ "12/20" ] }