Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 45262,
    "url": "https://patches.dpdk.org/api/patches/45262/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20180925023442.134705-6-qi.z.zhang@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20180925023442.134705-6-qi.z.zhang@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20180925023442.134705-6-qi.z.zhang@intel.com",
    "date": "2018-09-25T02:34:27",
    "name": "[05/20] net/i40e/base: add admin queue definitions for cloud filters",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "b6504e6d49a72908f382b052055a4cd1256487a1",
    "submitter": {
        "id": 504,
        "url": "https://patches.dpdk.org/api/people/504/?format=api",
        "name": "Qi Zhang",
        "email": "qi.z.zhang@intel.com"
    },
    "delegate": {
        "id": 1540,
        "url": "https://patches.dpdk.org/api/users/1540/?format=api",
        "username": "qzhan15",
        "first_name": "Qi",
        "last_name": "Zhang",
        "email": "qi.z.zhang@intel.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20180925023442.134705-6-qi.z.zhang@intel.com/mbox/",
    "series": [
        {
            "id": 1477,
            "url": "https://patches.dpdk.org/api/series/1477/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=1477",
            "date": "2018-09-25T02:34:22",
            "name": "base code update",
            "version": 1,
            "mbox": "https://patches.dpdk.org/series/1477/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/45262/comments/",
    "check": "warning",
    "checks": "https://patches.dpdk.org/api/patches/45262/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B621C1B152;\n\tTue, 25 Sep 2018 04:34:14 +0200 (CEST)",
            "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby dpdk.org (Postfix) with ESMTP id 4247A5F3C\n\tfor <dev@dpdk.org>; Tue, 25 Sep 2018 04:34:09 +0200 (CEST)",
            "from orsmga005.jf.intel.com ([10.7.209.41])\n\tby orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t24 Sep 2018 19:34:08 -0700",
            "from dpdk51.sh.intel.com ([10.67.110.190])\n\tby orsmga005.jf.intel.com with ESMTP; 24 Sep 2018 19:33:49 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.54,300,1534834800\"; d=\"scan'208\";a=\"259958519\"",
        "From": "Qi Zhang <qi.z.zhang@intel.com>",
        "To": "beilei.xing@intel.com",
        "Cc": "dev@dpdk.org, ferruh.yigit@intel.com, helin.zhang@intel.com,\n\tQi Zhang <qi.z.zhang@intel.com>",
        "Date": "Tue, 25 Sep 2018 10:34:27 +0800",
        "Message-Id": "<20180925023442.134705-6-qi.z.zhang@intel.com>",
        "X-Mailer": "git-send-email 2.13.6",
        "In-Reply-To": "<20180925023442.134705-1-qi.z.zhang@intel.com>",
        "References": "<20180925023442.134705-1-qi.z.zhang@intel.com>",
        "Subject": "[dpdk-dev] [PATCH 05/20] net/i40e/base: add admin queue definitions\n\tfor cloud filters",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Add new admin queue definitions and extended fields for cloud\nfilter support. Define big buffer for extended general fields\nin Add/Remove Cloud filters command.\n\nAlso rename i40e_aqc_add_remove_cloud_filters_element_data to\ni40e_aq__cloud_filters_element_data.\n\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\n---\n drivers/net/i40e/base/i40e_adminq_cmd.h | 57 +++++++++++++++++++++++++++++++--\n drivers/net/i40e/base/i40e_common.c     | 14 ++++----\n drivers/net/i40e/base/i40e_prototype.h  |  4 +--\n 3 files changed, 64 insertions(+), 11 deletions(-)",
    "diff": "diff --git a/drivers/net/i40e/base/i40e_adminq_cmd.h b/drivers/net/i40e/base/i40e_adminq_cmd.h\nindex 2d714ec5e..d02890f98 100644\n--- a/drivers/net/i40e/base/i40e_adminq_cmd.h\n+++ b/drivers/net/i40e/base/i40e_adminq_cmd.h\n@@ -1358,6 +1358,7 @@ struct i40e_aqc_add_remove_cloud_filters {\n \t\t\t\t\tI40E_AQC_ADD_CLOUD_CMD_SEID_NUM_SHIFT)\n \tu8\tbig_buffer_flag;\n #define I40E_AQC_ADD_REM_CLOUD_CMD_BIG_BUFFER\t1\n+#define I40E_AQC_ADD_CLOUD_CMD_BB\t\t1\n \tu8\treserved2[3];\n \t__le32\taddr_high;\n \t__le32\taddr_low;\n@@ -1365,7 +1366,7 @@ struct i40e_aqc_add_remove_cloud_filters {\n \n I40E_CHECK_CMD_LENGTH(i40e_aqc_add_remove_cloud_filters);\n \n-struct i40e_aqc_add_remove_cloud_filters_element_data {\n+struct i40e_aqc_cloud_filters_element_data {\n \tu8\touter_mac[6];\n \tu8\tinner_mac[6];\n \t__le16\tinner_vlan;\n@@ -1396,6 +1397,9 @@ struct i40e_aqc_add_remove_cloud_filters_element_data {\n #define I40E_AQC_ADD_CLOUD_FILTER_OMAC_TEN_ID_IMAC\t0x000B\n #define I40E_AQC_ADD_CLOUD_FILTER_IIP\t\t\t0x000C\n /* 0x0010 to 0x0017 is for custom filters */\n+#define I40E_AQC_ADD_CLOUD_FILTER_IP_PORT\t\t0x0010 /* Dest IP + L4 Port */\n+#define I40E_AQC_ADD_CLOUD_FILTER_MAC_PORT\t\t0x0011 /* Dest MAC + L4 Port */\n+#define I40E_AQC_ADD_CLOUD_FILTER_MAC_VLAN_PORT\t\t0x0012 /* Dest MAC + VLAN + L4 Port */\n \n #define I40E_AQC_ADD_CLOUD_FLAGS_TO_QUEUE\t\t0x0080\n #define I40E_AQC_ADD_CLOUD_VNK_SHIFT\t\t\t6\n@@ -1435,7 +1439,7 @@ struct i40e_aqc_add_remove_cloud_filters_element_data {\n  * DCR288\n  */\n struct i40e_aqc_add_rm_cloud_filt_elem_ext {\n-\tstruct i40e_aqc_add_remove_cloud_filters_element_data element;\n+\tstruct i40e_aqc_cloud_filters_element_data element;\n \tu16     general_fields[32];\n #define I40E_AQC_ADD_CLOUD_FV_FLU_0X10_WORD0\t0\n #define I40E_AQC_ADD_CLOUD_FV_FLU_0X10_WORD1\t1\n@@ -1470,6 +1474,49 @@ struct i40e_aqc_add_rm_cloud_filt_elem_ext {\n #define I40E_AQC_ADD_CLOUD_FV_FLU_0X17_WORD7\t30\n };\n \n+I40E_CHECK_STRUCT_LEN(0x40, i40e_aqc_cloud_filters_element_data);\n+\n+/* i40e_aqc_cloud_filters_element_bb is used when\n+ * I40E_AQC_CLOUD_CMD_BB flag is set.\n+ */\n+struct i40e_aqc_cloud_filters_element_bb {\n+\tstruct i40e_aqc_cloud_filters_element_data element;\n+\tu16     general_fields[32];\n+#define I40E_AQC_ADD_CLOUD_FV_FLU_0X10_WORD0\t0\n+#define I40E_AQC_ADD_CLOUD_FV_FLU_0X10_WORD1\t1\n+#define I40E_AQC_ADD_CLOUD_FV_FLU_0X10_WORD2\t2\n+#define I40E_AQC_ADD_CLOUD_FV_FLU_0X11_WORD0\t3\n+#define I40E_AQC_ADD_CLOUD_FV_FLU_0X11_WORD1\t4\n+#define I40E_AQC_ADD_CLOUD_FV_FLU_0X11_WORD2\t5\n+#define I40E_AQC_ADD_CLOUD_FV_FLU_0X12_WORD0\t6\n+#define I40E_AQC_ADD_CLOUD_FV_FLU_0X12_WORD1\t7\n+#define I40E_AQC_ADD_CLOUD_FV_FLU_0X12_WORD2\t8\n+#define I40E_AQC_ADD_CLOUD_FV_FLU_0X13_WORD0\t9\n+#define I40E_AQC_ADD_CLOUD_FV_FLU_0X13_WORD1\t10\n+#define I40E_AQC_ADD_CLOUD_FV_FLU_0X13_WORD2\t11\n+#define I40E_AQC_ADD_CLOUD_FV_FLU_0X14_WORD0\t12\n+#define I40E_AQC_ADD_CLOUD_FV_FLU_0X14_WORD1\t13\n+#define I40E_AQC_ADD_CLOUD_FV_FLU_0X14_WORD2\t14\n+#define I40E_AQC_ADD_CLOUD_FV_FLU_0X16_WORD0\t15\n+#define I40E_AQC_ADD_CLOUD_FV_FLU_0X16_WORD1\t16\n+#define I40E_AQC_ADD_CLOUD_FV_FLU_0X16_WORD2\t17\n+#define I40E_AQC_ADD_CLOUD_FV_FLU_0X16_WORD3\t18\n+#define I40E_AQC_ADD_CLOUD_FV_FLU_0X16_WORD4\t19\n+#define I40E_AQC_ADD_CLOUD_FV_FLU_0X16_WORD5\t20\n+#define I40E_AQC_ADD_CLOUD_FV_FLU_0X16_WORD6\t21\n+#define I40E_AQC_ADD_CLOUD_FV_FLU_0X16_WORD7\t22\n+#define I40E_AQC_ADD_CLOUD_FV_FLU_0X17_WORD0\t23\n+#define I40E_AQC_ADD_CLOUD_FV_FLU_0X17_WORD1\t24\n+#define I40E_AQC_ADD_CLOUD_FV_FLU_0X17_WORD2\t25\n+#define I40E_AQC_ADD_CLOUD_FV_FLU_0X17_WORD3\t26\n+#define I40E_AQC_ADD_CLOUD_FV_FLU_0X17_WORD4\t27\n+#define I40E_AQC_ADD_CLOUD_FV_FLU_0X17_WORD5\t28\n+#define I40E_AQC_ADD_CLOUD_FV_FLU_0X17_WORD6\t29\n+#define I40E_AQC_ADD_CLOUD_FV_FLU_0X17_WORD7\t30\n+};\n+\n+I40E_CHECK_STRUCT_LEN(0x80, i40e_aqc_cloud_filters_element_bb);\n+\n struct i40e_aqc_remove_cloud_filters_completion {\n \t__le16 perfect_ovlan_used;\n \t__le16 perfect_ovlan_free;\n@@ -1490,6 +1537,8 @@ struct i40e_filter_data {\n \tu8 input[3];\n };\n \n+I40E_CHECK_STRUCT_LEN(4, i40e_filter_data);\n+\n struct i40e_aqc_replace_cloud_filters_cmd {\n \tu8\tvalid_flags;\n #define I40E_AQC_REPLACE_L1_FILTER\t\t0x0\n@@ -1505,6 +1554,8 @@ struct i40e_aqc_replace_cloud_filters_cmd {\n \t__le32 addr_low;\n };\n \n+I40E_CHECK_CMD_LENGTH(i40e_aqc_replace_cloud_filters_cmd);\n+\n struct i40e_aqc_replace_cloud_filters_cmd_buf {\n \tu8\tdata[32];\n /* Filter type INPUT codes*/\n@@ -1529,6 +1580,8 @@ struct i40e_aqc_replace_cloud_filters_cmd_buf {\n \tstruct i40e_filter_data\tfilters[8];\n };\n \n+I40E_CHECK_STRUCT_LEN(0x40, i40e_aqc_replace_cloud_filters_cmd_buf);\n+\n /* Add Mirror Rule (indirect or direct 0x0260)\n  * Delete Mirror Rule (indirect or direct 0x0261)\n  * note: some rule types (4,5) do not use an external buffer.\ndiff --git a/drivers/net/i40e/base/i40e_common.c b/drivers/net/i40e/base/i40e_common.c\nindex 856e7bef6..77af8507f 100644\n--- a/drivers/net/i40e/base/i40e_common.c\n+++ b/drivers/net/i40e/base/i40e_common.c\n@@ -5686,10 +5686,10 @@ void i40e_add_filter_to_drop_tx_flow_control_frames(struct i40e_hw *hw,\n  * to be shifted 1 byte over from the VxLAN VNI\n  **/\n STATIC void i40e_fix_up_geneve_vni(\n-\tstruct i40e_aqc_add_remove_cloud_filters_element_data *filters,\n+\tstruct i40e_aqc_cloud_filters_element_data *filters,\n \tu8 filter_count)\n {\n-\tstruct i40e_aqc_add_remove_cloud_filters_element_data *f = filters;\n+\tstruct i40e_aqc_cloud_filters_element_data *f = filters;\n \tint i;\n \n \tfor (i = 0; i < filter_count; i++) {\n@@ -5714,13 +5714,13 @@ STATIC void i40e_fix_up_geneve_vni(\n  * @filter_count: number of filters contained in the buffer\n  *\n  * Set the cloud filters for a given VSI.  The contents of the\n- * i40e_aqc_add_remove_cloud_filters_element_data are filled\n+ * i40e_aqc_cloud_filters_element_data are filled\n  * in by the caller of the function.\n  *\n  **/\n enum i40e_status_code i40e_aq_add_cloud_filters(struct i40e_hw *hw,\n \tu16 seid,\n-\tstruct i40e_aqc_add_remove_cloud_filters_element_data *filters,\n+\tstruct i40e_aqc_cloud_filters_element_data *filters,\n \tu8 filter_count)\n {\n \tstruct i40e_aq_desc desc;\n@@ -5806,13 +5806,13 @@ enum i40e_status_code i40e_aq_add_cloud_filters_big_buffer(struct i40e_hw *hw,\n  * @filter_count: number of filters contained in the buffer\n  *\n  * Remove the cloud filters for a given VSI.  The contents of the\n- * i40e_aqc_add_remove_cloud_filters_element_data are filled\n- * in by the caller of the function.\n+ * i40e_aqc_cloud_filters_element_data are filled in by the caller\n+ * of the function.\n  *\n  **/\n enum i40e_status_code i40e_aq_remove_cloud_filters(struct i40e_hw *hw,\n \tu16 seid,\n-\tstruct i40e_aqc_add_remove_cloud_filters_element_data *filters,\n+\tstruct i40e_aqc_cloud_filters_element_data *filters,\n \tu8 filter_count)\n {\n \tstruct i40e_aq_desc desc;\ndiff --git a/drivers/net/i40e/base/i40e_prototype.h b/drivers/net/i40e/base/i40e_prototype.h\nindex 6331aadf2..bdab055af 100644\n--- a/drivers/net/i40e/base/i40e_prototype.h\n+++ b/drivers/net/i40e/base/i40e_prototype.h\n@@ -379,7 +379,7 @@ enum i40e_status_code i40e_read_lldp_cfg(struct i40e_hw *hw,\n \t\t\t\t\tstruct i40e_lldp_variables *lldp_cfg);\n enum i40e_status_code i40e_aq_add_cloud_filters(struct i40e_hw *hw,\n \t\tu16 vsi,\n-\t\tstruct i40e_aqc_add_remove_cloud_filters_element_data *filters,\n+\t\tstruct i40e_aqc_cloud_filters_element_data *filters,\n \t\tu8 filter_count);\n enum i40e_status_code i40e_aq_add_cloud_filters_big_buffer(struct i40e_hw *hw,\n \tu16 seid,\n@@ -387,7 +387,7 @@ enum i40e_status_code i40e_aq_add_cloud_filters_big_buffer(struct i40e_hw *hw,\n \tu8 filter_count);\n enum i40e_status_code i40e_aq_remove_cloud_filters(struct i40e_hw *hw,\n \t\tu16 vsi,\n-\t\tstruct i40e_aqc_add_remove_cloud_filters_element_data *filters,\n+\t\tstruct i40e_aqc_cloud_filters_element_data *filters,\n \t\tu8 filter_count);\n enum i40e_status_code i40e_aq_remove_cloud_filters_big_buffer(\n \tstruct i40e_hw *hw, u16 seid,\n",
    "prefixes": [
        "05/20"
    ]
}