Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 45244,
    "url": "https://patches.dpdk.org/api/patches/45244/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/153782023114.27450.13792732999240312966.stgit@T460/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<153782023114.27450.13792732999240312966.stgit@T460>",
    "list_archive_url": "https://inbox.dpdk.org/dev/153782023114.27450.13792732999240312966.stgit@T460",
    "date": "2018-09-24T20:17:11",
    "name": "[v6,2/5] vhost: make message handling functions prepare the reply",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "e7717e98881b58cf96eebeac35cccc5e10b20c6d",
    "submitter": {
        "id": 1062,
        "url": "https://patches.dpdk.org/api/people/1062/?format=api",
        "name": "Nikolay Nikolaev",
        "email": "nicknickolaev@gmail.com"
    },
    "delegate": {
        "id": 2642,
        "url": "https://patches.dpdk.org/api/users/2642/?format=api",
        "username": "mcoquelin",
        "first_name": "Maxime",
        "last_name": "Coquelin",
        "email": "maxime.coquelin@redhat.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/153782023114.27450.13792732999240312966.stgit@T460/mbox/",
    "series": [
        {
            "id": 1475,
            "url": "https://patches.dpdk.org/api/series/1475/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=1475",
            "date": "2018-09-24T20:16:55",
            "name": "vhost: vhost_user.c code cleanup",
            "version": 6,
            "mbox": "https://patches.dpdk.org/series/1475/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/45244/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/45244/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D40731B192;\n\tMon, 24 Sep 2018 22:17:15 +0200 (CEST)",
            "from mail-wm1-f67.google.com (mail-wm1-f67.google.com\n\t[209.85.128.67]) by dpdk.org (Postfix) with ESMTP id 4FF7E1B192\n\tfor <dev@dpdk.org>; Mon, 24 Sep 2018 22:17:14 +0200 (CEST)",
            "by mail-wm1-f67.google.com with SMTP id q8-v6so11319949wmq.4\n\tfor <dev@dpdk.org>; Mon, 24 Sep 2018 13:17:14 -0700 (PDT)",
            "from [127.0.1.1] ([82.146.27.14]) by smtp.gmail.com with ESMTPSA id\n\tz80-v6sm511924wrb.1.2018.09.24.13.17.12\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 24 Sep 2018 13:17:12 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:from:to:cc:date:message-id:in-reply-to:references\n\t:user-agent:mime-version:content-transfer-encoding;\n\tbh=KlqevEpVE/LgiA1Ie+DmN7/5IIg5yXavGQgJ7mPQScY=;\n\tb=HD4C2xZsibUk+axWXQlouqRmPSbD6GFM+VpRTkvheaAeThlYExHiCloF8MDqqAr1ru\n\t+KgrQpM2PgvAZaufmzr6pL61xQMqgogn0BOquUvOtZlyrKXKwj3HMQ53J1MAsO4sxaQV\n\tp/j0RIfc0ofLJhHt1Pf6sZVAXeEEDOqS/yBMDZ/bRihFAWLwF5Qwv81vKJqPn960jz7Q\n\tTnrr98w5BM8SZ62JSyouKjMutx3WM6Guclsx1QXmUMTas7EaEQ75ib+oLA7n8SNNWce1\n\tzACdW33+xvgy8sq6eNCwa7AQsYBTqoTfU4aWYcWd2Mq4DJ8/Y6D+bLfI/jK0YY9C9j0p\n\t7qCA==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:from:to:cc:date:message-id:in-reply-to\n\t:references:user-agent:mime-version:content-transfer-encoding;\n\tbh=KlqevEpVE/LgiA1Ie+DmN7/5IIg5yXavGQgJ7mPQScY=;\n\tb=H3sHTnke4XAEO5XJ8SmG0oZLo1vnrVkhl/nfeMhGmz77Ls5fqHkTtzibVdpSzN+RBp\n\tYRmIrfyqmA+j/ZzOAih50TZQfVT1G8rrg9OG+aaJ3iZWBeb/Q3DwWqL6naVU3/EYov4s\n\tK0fpMmUEUdJgtFWMlvfcuVDMr++mUM/0c241WRFiAYjgkxGcNMeIOu/AJwSFpyrAwMbH\n\tV5bKVuKt4cw/eK3oIe9HFt5haQeNwiEmyRorerZNOEtc4OaZLgSJhRw2Yb1tvEPh8S4p\n\trR8+pWo4lRXvzorGj0vRUtnfu3hNK1miWmeXYTbmBEnVcPc6S6alBxiFZhUxMrMtMSgW\n\tA2og==",
        "X-Gm-Message-State": "ABuFfogkO7nQkH3koIEgELWgPP2qQMKY1Ynmj8xrdBLERqa+vKbD4s9S\n\thh3HGYqmmbvw3/+WOvSBqNBq0FcrgrYqeQ==",
        "X-Google-Smtp-Source": "ACcGV60N6KB/mV56/4YfImazStSXdqQ5kI60jajmYO/tOYG38nyVWg140DLZfrl6aQm8cAAlUK6FMg==",
        "X-Received": "by 2002:a1c:1609:: with SMTP id 9-v6mr54404wmw.12.1537820233425; \n\tMon, 24 Sep 2018 13:17:13 -0700 (PDT)",
        "From": "Nikolay Nikolaev <nicknickolaev@gmail.com>",
        "To": "maxime.coquelin@redhat.com, anatoly.burakov@intel.com,\n\ttiwei.bie@intel.com, zhihong.wang@intel.com",
        "Cc": "dev@dpdk.org",
        "Date": "Mon, 24 Sep 2018 23:17:11 +0300",
        "Message-ID": "<153782023114.27450.13792732999240312966.stgit@T460>",
        "In-Reply-To": "<153782013094.27450.17651924330876922486.stgit@T460>",
        "References": "<153782013094.27450.17651924330876922486.stgit@T460>",
        "User-Agent": "StGit/0.17.1-dirty",
        "MIME-Version": "1.0",
        "Content-Type": "text/plain; charset=\"utf-8\"",
        "Content-Transfer-Encoding": "7bit",
        "Subject": "[dpdk-dev] [PATCH v6 2/5] vhost: make message handling functions\n\tprepare the reply",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "As VhostUserMsg structure is reused to generate the reply, move the\nrelevant fields update into the respective message handling functions.\n\nSigned-off-by: Nikolay Nikolaev <nicknickolaev@gmail.com>\n---\n lib/librte_vhost/vhost_user.c |   24 ++++++++++++++++--------\n 1 file changed, 16 insertions(+), 8 deletions(-)",
    "diff": "diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c\nindex 505db3bfc..4ae7b9346 100644\n--- a/lib/librte_vhost/vhost_user.c\n+++ b/lib/librte_vhost/vhost_user.c\n@@ -146,11 +146,15 @@ vhost_user_reset_owner(struct virtio_net *dev)\n  * The features that we support are requested.\n  */\n static uint64_t\n-vhost_user_get_features(struct virtio_net *dev)\n+vhost_user_get_features(struct virtio_net *dev, struct VhostUserMsg *msg)\n {\n \tuint64_t features = 0;\n \n \trte_vhost_driver_get_features(dev->ifname, &features);\n+\n+\tmsg->payload.u64 = features;\n+\tmsg->size = sizeof(msg->payload.u64);\n+\n \treturn features;\n }\n \n@@ -158,11 +162,15 @@ vhost_user_get_features(struct virtio_net *dev)\n  * The queue number that we support are requested.\n  */\n static uint32_t\n-vhost_user_get_queue_num(struct virtio_net *dev)\n+vhost_user_get_queue_num(struct virtio_net *dev, struct VhostUserMsg *msg)\n {\n \tuint32_t queue_num = 0;\n \n \trte_vhost_driver_get_queue_num(dev->ifname, &queue_num);\n+\n+\tmsg->payload.u64 = (uint64_t)queue_num;\n+\tmsg->size = sizeof(msg->payload.u64);\n+\n \treturn queue_num;\n }\n \n@@ -1117,6 +1125,8 @@ vhost_user_get_vring_base(struct virtio_net *dev,\n \trte_free(vq->batch_copy_elems);\n \tvq->batch_copy_elems = NULL;\n \n+\tmsg->size = sizeof(msg->payload.state);\n+\n \treturn 0;\n }\n \n@@ -1244,6 +1254,8 @@ vhost_user_set_log_base(struct virtio_net *dev, struct VhostUserMsg *msg)\n \tdev->log_base = dev->log_addr + off;\n \tdev->log_size = size;\n \n+\tmsg->size = sizeof(msg->payload.u64);\n+\n \treturn 0;\n }\n \n@@ -1658,8 +1670,7 @@ vhost_user_msg_handler(int vid, int fd)\n \n \tswitch (msg.request.master) {\n \tcase VHOST_USER_GET_FEATURES:\n-\t\tmsg.payload.u64 = vhost_user_get_features(dev);\n-\t\tmsg.size = sizeof(msg.payload.u64);\n+\t\tvhost_user_get_features(dev, &msg);\n \t\tsend_vhost_reply(fd, &msg);\n \t\tbreak;\n \tcase VHOST_USER_SET_FEATURES:\n@@ -1690,7 +1701,6 @@ vhost_user_msg_handler(int vid, int fd)\n \t\tif (ret)\n \t\t\tgoto skip_to_reply;\n \t\t/* it needs a reply */\n-\t\tmsg.size = sizeof(msg.payload.u64);\n \t\tsend_vhost_reply(fd, &msg);\n \t\tbreak;\n \tcase VHOST_USER_SET_LOG_FD:\n@@ -1712,7 +1722,6 @@ vhost_user_msg_handler(int vid, int fd)\n \t\tret = vhost_user_get_vring_base(dev, &msg);\n \t\tif (ret)\n \t\t\tgoto skip_to_reply;\n-\t\tmsg.size = sizeof(msg.payload.state);\n \t\tsend_vhost_reply(fd, &msg);\n \t\tbreak;\n \n@@ -1730,8 +1739,7 @@ vhost_user_msg_handler(int vid, int fd)\n \t\tbreak;\n \n \tcase VHOST_USER_GET_QUEUE_NUM:\n-\t\tmsg.payload.u64 = (uint64_t)vhost_user_get_queue_num(dev);\n-\t\tmsg.size = sizeof(msg.payload.u64);\n+\t\tvhost_user_get_queue_num(dev, &msg);\n \t\tsend_vhost_reply(fd, &msg);\n \t\tbreak;\n \n",
    "prefixes": [
        "v6",
        "2/5"
    ]
}