Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/45222/?format=api
{ "id": 45222, "url": "https://patches.dpdk.org/api/patches/45222/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1537805104-17425-1-git-send-email-rahul.lakkireddy@chelsio.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1537805104-17425-1-git-send-email-rahul.lakkireddy@chelsio.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1537805104-17425-1-git-send-email-rahul.lakkireddy@chelsio.com", "date": "2018-09-24T16:05:04", "name": "net/cxgbe: add missing DEV_RX_OFFLOAD_SCATTER flag", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "c2d4b0ded95c199520dc97f5a51ff833343bc616", "submitter": { "id": 241, "url": "https://patches.dpdk.org/api/people/241/?format=api", "name": "Rahul Lakkireddy", "email": "rahul.lakkireddy@chelsio.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1537805104-17425-1-git-send-email-rahul.lakkireddy@chelsio.com/mbox/", "series": [ { "id": 1470, "url": "https://patches.dpdk.org/api/series/1470/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=1470", "date": "2018-09-24T16:05:04", "name": "net/cxgbe: add missing DEV_RX_OFFLOAD_SCATTER flag", "version": 1, "mbox": "https://patches.dpdk.org/series/1470/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/45222/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/45222/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 016485F4A;\n\tMon, 24 Sep 2018 18:05:33 +0200 (CEST)", "from stargate.chelsio.com (stargate.chelsio.com [12.32.117.8])\n\tby dpdk.org (Postfix) with ESMTP id D33955F48;\n\tMon, 24 Sep 2018 18:05:30 +0200 (CEST)", "from localhost (scalar.blr.asicdesigners.com [10.193.185.94])\n\tby stargate.chelsio.com (8.13.8/8.13.8) with ESMTP id w8OG5Oij030317; \n\tMon, 24 Sep 2018 09:05:24 -0700" ], "From": "Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>", "To": "dev@dpdk.org", "Cc": "martin.weiser@allegro-packets.com, indranil@chelsio.com,\n\tnirranjan@chelsio.com, stable@dpdk.org", "Date": "Mon, 24 Sep 2018 21:35:04 +0530", "Message-Id": "<1537805104-17425-1-git-send-email-rahul.lakkireddy@chelsio.com>", "X-Mailer": "git-send-email 2.5.3", "Subject": "[dpdk-dev] [PATCH] net/cxgbe: add missing DEV_RX_OFFLOAD_SCATTER\n\tflag", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Scatter Rx is already supported by CXGBE PMD. So, add the missing\nDEV_RX_OFFLOAD_SCATTER flag to the list of supported Rx offload\nfeatures.\n\nAlso, move the macros for supported list of offload features to\nheader file.\n\nFixes: 436125e64174 (\"net/cxgbe: update to Rx/Tx offload API\")\nCc: stable@dpdk.org\n\nReported-by: Martin Weiser <martin.weiser@allegro-packets.com>\nSigned-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>\n---\n drivers/net/cxgbe/cxgbe.h | 15 +++++++++++++++\n drivers/net/cxgbe/cxgbe_ethdev.c | 19 +++++++------------\n 2 files changed, 22 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/net/cxgbe/cxgbe.h b/drivers/net/cxgbe/cxgbe.h\nindex 5e6f5c98d..eb58f8802 100644\n--- a/drivers/net/cxgbe/cxgbe.h\n+++ b/drivers/net/cxgbe/cxgbe.h\n@@ -34,6 +34,21 @@\n \t\t\t\t ETH_RSS_IPV6_UDP_EX)\n #define CXGBE_RSS_HF_ALL (ETH_RSS_IP | ETH_RSS_TCP | ETH_RSS_UDP)\n \n+/* Tx/Rx Offloads supported */\n+#define CXGBE_TX_OFFLOADS (DEV_TX_OFFLOAD_VLAN_INSERT | \\\n+\t\t\t DEV_TX_OFFLOAD_IPV4_CKSUM | \\\n+\t\t\t DEV_TX_OFFLOAD_UDP_CKSUM | \\\n+\t\t\t DEV_TX_OFFLOAD_TCP_CKSUM | \\\n+\t\t\t DEV_TX_OFFLOAD_TCP_TSO)\n+\n+#define CXGBE_RX_OFFLOADS (DEV_RX_OFFLOAD_VLAN_STRIP | \\\n+\t\t\t DEV_RX_OFFLOAD_IPV4_CKSUM | \\\n+\t\t\t DEV_RX_OFFLOAD_UDP_CKSUM | \\\n+\t\t\t DEV_RX_OFFLOAD_TCP_CKSUM | \\\n+\t\t\t DEV_RX_OFFLOAD_JUMBO_FRAME | \\\n+\t\t\t DEV_RX_OFFLOAD_SCATTER)\n+\n+\n #define CXGBE_DEVARG_KEEP_OVLAN \"keep_ovlan\"\n #define CXGBE_DEVARG_FORCE_LINK_UP \"force_link_up\"\n \ndiff --git a/drivers/net/cxgbe/cxgbe_ethdev.c b/drivers/net/cxgbe/cxgbe_ethdev.c\nindex 117263e2b..b2f83ea37 100644\n--- a/drivers/net/cxgbe/cxgbe_ethdev.c\n+++ b/drivers/net/cxgbe/cxgbe_ethdev.c\n@@ -59,18 +59,6 @@\n */\n #include \"t4_pci_id_tbl.h\"\n \n-#define CXGBE_TX_OFFLOADS (DEV_TX_OFFLOAD_VLAN_INSERT |\\\n-\t\t\t DEV_TX_OFFLOAD_IPV4_CKSUM |\\\n-\t\t\t DEV_TX_OFFLOAD_UDP_CKSUM |\\\n-\t\t\t DEV_TX_OFFLOAD_TCP_CKSUM |\\\n-\t\t\t DEV_TX_OFFLOAD_TCP_TSO)\n-\n-#define CXGBE_RX_OFFLOADS (DEV_RX_OFFLOAD_VLAN_STRIP |\\\n-\t\t\t DEV_RX_OFFLOAD_IPV4_CKSUM |\\\n-\t\t\t DEV_RX_OFFLOAD_JUMBO_FRAME |\\\n-\t\t\t DEV_RX_OFFLOAD_UDP_CKSUM |\\\n-\t\t\t DEV_RX_OFFLOAD_TCP_CKSUM)\n-\n uint16_t cxgbe_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n \t\t\t uint16_t nb_pkts)\n {\n@@ -340,6 +328,7 @@ void cxgbe_dev_close(struct rte_eth_dev *eth_dev)\n int cxgbe_dev_start(struct rte_eth_dev *eth_dev)\n {\n \tstruct port_info *pi = (struct port_info *)(eth_dev->data->dev_private);\n+\tstruct rte_eth_rxmode *rx_conf = ð_dev->data->dev_conf.rxmode;\n \tstruct adapter *adapter = pi->adapter;\n \tint err = 0, i;\n \n@@ -360,6 +349,11 @@ int cxgbe_dev_start(struct rte_eth_dev *eth_dev)\n \t\t\tgoto out;\n \t}\n \n+\tif (rx_conf->offloads & DEV_RX_OFFLOAD_SCATTER)\n+\t\teth_dev->data->scattered_rx = 1;\n+\telse\n+\t\teth_dev->data->scattered_rx = 0;\n+\n \tcxgbe_enable_rx_queues(pi);\n \n \terr = setup_rss(pi);\n@@ -406,6 +400,7 @@ void cxgbe_dev_stop(struct rte_eth_dev *eth_dev)\n \t * have been disabled\n \t */\n \tt4_sge_eth_clear_queues(pi);\n+\teth_dev->data->scattered_rx = 0;\n }\n \n int cxgbe_dev_configure(struct rte_eth_dev *eth_dev)\n", "prefixes": [] }