Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/45214/?format=api
{ "id": 45214, "url": "https://patches.dpdk.org/api/patches/45214/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1537797030-26548-11-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1537797030-26548-11-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1537797030-26548-11-git-send-email-arybchenko@solarflare.com", "date": "2018-09-24T13:50:29", "name": "[10/11] net/sfc/base: use transceiver ID when reading info", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "e48ae32df65162f2186621eab13503e1d0d80b09", "submitter": { "id": 607, "url": "https://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1537797030-26548-11-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 1467, "url": "https://patches.dpdk.org/api/series/1467/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=1467", "date": "2018-09-24T13:50:22", "name": "net/sfc: update base driver to support 50G and 100G", "version": 1, "mbox": "https://patches.dpdk.org/series/1467/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/45214/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/45214/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E885A5B30;\n\tMon, 24 Sep 2018 15:51:16 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n\t[148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 8CAD92B8C\n\tfor <dev@dpdk.org>; Mon, 24 Sep 2018 15:50:53 +0200 (CEST)", "from webmail.solarflare.com (webmail.solarflare.com\n\t[12.187.104.26])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby mx1-us3.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with\n\tESMTPS id\n\t29C81B4005A for <dev@dpdk.org>; Mon, 24 Sep 2018 13:50:51 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1395.4; Mon, 24 Sep 2018 06:50:47 -0700", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1395.4 via Frontend Transport; Mon, 24 Sep 2018 06:50:47 -0700", "from ukv-loginhost.uk.solarflarecom.com\n\t(ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tw8ODok70014583; Mon, 24 Sep 2018 14:50:46 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n\tby ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id\n\t044751626D1; Mon, 24 Sep 2018 14:50:46 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "CC": "Richard Houldsworth <rhouldsworth@solarflare.com>", "Date": "Mon, 24 Sep 2018 14:50:29 +0100", "Message-ID": "<1537797030-26548-11-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1537797030-26548-1-git-send-email-arybchenko@solarflare.com>", "References": "<1537797030-26548-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.5.1010-24114.005", "X-TM-AS-Result": "No-7.586900-4.000000-10", "X-TMASE-MatchedRID": "d/fk1ZR9hMXoSi9uJV6wycf52VD5rJyZuKSyOjKDwbjIQofYImpSX2b6\n\tPphVtfZgUEjjMupzwwIECnVSwJiAGMHW1N2pB+QMfxzygoxuBhi2McZY43zJ423D6f6IpbLIcCE\n\t8iA5iVa1EsYdG4o1usYYe9KTt1cI1DPIzF4wRfrAURSScn+QSXt0H8LFZNFG7hqz53n/yPnockk\n\tDa7Gh6113DCZF4Rwz1EPy7S/jSt0Hwv6b36B+SxwvFyo7FWyY1", "X-TM-AS-User-Approved-Sender": "No", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10--7.586900-4.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.5.1010-24114.005", "X-MDID": "1537797051-1jwXc3dJzeC7", "Subject": "[dpdk-dev] [PATCH 10/11] net/sfc/base: use transceiver ID when\n\treading info", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Richard Houldsworth <rhouldsworth@solarflare.com>\n\nIn efx_mcdi_phy_module_get_info() probe the\ntransceiver identification byte rather than assume\nthe module matches the fixed port type. This\nsupports scenarios such as a SFP mounted in a QSFP\nport via a QSA module.\n\nSigned-off-by: Richard Houldsworth <rhouldsworth@solarflare.com>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n drivers/net/sfc/base/efx_mcdi.c | 47 ++++++++++++++++++++++++++++-----\n 1 file changed, 41 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/sfc/base/efx_mcdi.c b/drivers/net/sfc/base/efx_mcdi.c\nindex f53be015b..c896aa0bf 100644\n--- a/drivers/net/sfc/base/efx_mcdi.c\n+++ b/drivers/net/sfc/base/efx_mcdi.c\n@@ -2150,6 +2150,14 @@ efx_mcdi_get_workarounds(\n */\n #define\tEFX_PHY_MEDIA_INFO_PAGE_SIZE\t\t0x80\n \n+/*\n+ * Transceiver identifiers from SFF-8024 Table 4-1.\n+ */\n+#define\tEFX_SFF_TRANSCEIVER_ID_SFP\t\t0x03 /* SFP/SFP+/SFP28 */\n+#define\tEFX_SFF_TRANSCEIVER_ID_QSFP\t\t0x0c /* QSFP */\n+#define\tEFX_SFF_TRANSCEIVER_ID_QSFP_PLUS\t0x0d /* QSFP+ or later */\n+#define\tEFX_SFF_TRANSCEIVER_ID_QSFP28\t\t0x11 /* QSFP28 or later */\n+\n static\t__checkReturn\t\tefx_rc_t\n efx_mcdi_get_phy_media_info(\n \t__in\t\t\tefx_nic_t *enp,\n@@ -2222,6 +2230,7 @@ efx_mcdi_phy_module_get_info(\n \tefx_rc_t rc;\n \tuint32_t mcdi_lower_page;\n \tuint32_t mcdi_upper_page;\n+\tuint8_t id;\n \n \tEFSYS_ASSERT3U(enp->en_mod_flags, &, EFX_MOD_PROBE);\n \n@@ -2235,6 +2244,26 @@ efx_mcdi_phy_module_get_info(\n \t */\n \tswitch (epp->ep_fixed_port_type) {\n \tcase EFX_PHY_MEDIA_SFP_PLUS:\n+\tcase EFX_PHY_MEDIA_QSFP_PLUS:\n+\t\t/* Port type supports modules */\n+\t\tbreak;\n+\tdefault:\n+\t\trc = ENOTSUP;\n+\t\tgoto fail1;\n+\t}\n+\n+\t/*\n+\t * For all supported port types, MCDI page 0 offset 0 holds the\n+\t * transceiver identifier. Probe to determine the data layout.\n+\t * Definitions from SFF-8024 Table 4-1.\n+\t */\n+\trc = efx_mcdi_get_phy_media_info(enp,\n+\t\t 0, 0, sizeof(id), &id);\n+\tif (rc != 0)\n+\t\tgoto fail2;\n+\n+\tswitch (id) {\n+\tcase EFX_SFF_TRANSCEIVER_ID_SFP:\n \t\t/*\n \t\t * In accordance with SFF-8472 Diagnostic Monitoring\n \t\t * Interface for Optical Transceivers section 4 Memory\n@@ -2269,10 +2298,12 @@ efx_mcdi_phy_module_get_info(\n \t\t\tbreak;\n \t\tdefault:\n \t\t\trc = ENOTSUP;\n-\t\t\tgoto fail1;\n+\t\t\tgoto fail3;\n \t\t}\n \t\tbreak;\n-\tcase EFX_PHY_MEDIA_QSFP_PLUS:\n+\tcase EFX_SFF_TRANSCEIVER_ID_QSFP:\n+\tcase EFX_SFF_TRANSCEIVER_ID_QSFP_PLUS:\n+\tcase EFX_SFF_TRANSCEIVER_ID_QSFP28:\n \t\tswitch (dev_addr) {\n \t\tcase EFX_PHY_MEDIA_INFO_DEV_ADDR_QSFP:\n \t\t\t/*\n@@ -2288,12 +2319,12 @@ efx_mcdi_phy_module_get_info(\n \t\t\tbreak;\n \t\tdefault:\n \t\t\trc = ENOTSUP;\n-\t\t\tgoto fail1;\n+\t\t\tgoto fail3;\n \t\t}\n \t\tbreak;\n \tdefault:\n \t\trc = ENOTSUP;\n-\t\tgoto fail1;\n+\t\tgoto fail3;\n \t}\n \n \tEFX_STATIC_ASSERT(EFX_PHY_MEDIA_INFO_PAGE_SIZE <= 0xFF);\n@@ -2305,7 +2336,7 @@ efx_mcdi_phy_module_get_info(\n \t\trc = efx_mcdi_get_phy_media_info(enp,\n \t\t mcdi_lower_page, (uint8_t)offset, (uint8_t)read_len, data);\n \t\tif (rc != 0)\n-\t\t\tgoto fail2;\n+\t\t\tgoto fail4;\n \n \t\tdata += read_len;\n \t\tlen -= read_len;\n@@ -2322,11 +2353,15 @@ efx_mcdi_phy_module_get_info(\n \t\trc = efx_mcdi_get_phy_media_info(enp,\n \t\t mcdi_upper_page, (uint8_t)offset, (uint8_t)len, data);\n \t\tif (rc != 0)\n-\t\t\tgoto fail3;\n+\t\t\tgoto fail5;\n \t}\n \n \treturn (0);\n \n+fail5:\n+\tEFSYS_PROBE(fail5);\n+fail4:\n+\tEFSYS_PROBE(fail4);\n fail3:\n \tEFSYS_PROBE(fail3);\n fail2:\n", "prefixes": [ "10/11" ] }