Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/45203/?format=api
{ "id": 45203, "url": "https://patches.dpdk.org/api/patches/45203/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1537797030-26548-4-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1537797030-26548-4-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1537797030-26548-4-git-send-email-arybchenko@solarflare.com", "date": "2018-09-24T13:50:22", "name": "[03/11] net/sfc/base: adjust PHY module info interface", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "6856ea4d1b80bbc7d7897f021519b5f70ffafe2c", "submitter": { "id": 607, "url": "https://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1537797030-26548-4-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 1467, "url": "https://patches.dpdk.org/api/series/1467/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=1467", "date": "2018-09-24T13:50:22", "name": "net/sfc: update base driver to support 50G and 100G", "version": 1, "mbox": "https://patches.dpdk.org/series/1467/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/45203/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/45203/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E94C92B9D;\n\tMon, 24 Sep 2018 15:50:52 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n\t[148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 0C9162BF4\n\tfor <dev@dpdk.org>; Mon, 24 Sep 2018 15:50:51 +0200 (CEST)", "from webmail.solarflare.com (webmail.solarflare.com\n\t[12.187.104.26])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby mx1-us3.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with\n\tESMTPS id\n\t97ABEB400C7 for <dev@dpdk.org>; Mon, 24 Sep 2018 13:50:49 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1395.4; Mon, 24 Sep 2018 06:50:47 -0700", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1395.4 via Frontend Transport; Mon, 24 Sep 2018 06:50:46 -0700", "from ukv-loginhost.uk.solarflarecom.com\n\t(ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tw8ODojLR014491; Mon, 24 Sep 2018 14:50:45 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n\tby ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id\n\t849451626D2; Mon, 24 Sep 2018 14:50:45 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "CC": "Richard Houldsworth <rhouldsworth@solarflare.com>", "Date": "Mon, 24 Sep 2018 14:50:22 +0100", "Message-ID": "<1537797030-26548-4-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1537797030-26548-1-git-send-email-arybchenko@solarflare.com>", "References": "<1537797030-26548-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.5.1010-24114.005", "X-TM-AS-Result": "No-5.186500-4.000000-10", "X-TMASE-MatchedRID": "Rq6+UQPkS7DuqBuVmgcCWoSRlhu2vaYtQPCWRE0Lo8Is/uUAk6xP7Gb6\n\tPphVtfZgbivSzFh6w/S2EqoGfakM7aEQbsk8mNCN4pdq9sdj8LXQpOLaYmAnSKLVgbkZxM5PKLW\n\trCrDVHUni8zVgXoAltsIJ+4gwXrEtIAcCikR3vq/ef0XptdWQe3GS6Vev0DbEVcXWC+2ik3QgZ2\n\txUwlmFj/HlzP786uN/", "X-TM-AS-User-Approved-Sender": "No", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10--5.186500-4.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.5.1010-24114.005", "X-MDID": "1537797050-K5XfOmmm_ZKc", "Subject": "[dpdk-dev] [PATCH 03/11] net/sfc/base: adjust PHY module info\n\tinterface", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Richard Houldsworth <rhouldsworth@solarflare.com>\n\nAdjust data types in interface to permit the complete\nmodule information buffer to be obtained in a single\ncall.\n\nSigned-off-by: Richard Houldsworth <rhouldsworth@solarflare.com>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n drivers/net/sfc/base/efx.h | 10 ++++++++--\n drivers/net/sfc/base/efx_mcdi.c | 12 +++++++-----\n drivers/net/sfc/base/efx_mcdi.h | 4 ++--\n drivers/net/sfc/base/efx_phy.c | 7 ++++---\n 4 files changed, 21 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/net/sfc/base/efx.h b/drivers/net/sfc/base/efx.h\nindex 9eefda6a5..a8c3ae301 100644\n--- a/drivers/net/sfc/base/efx.h\n+++ b/drivers/net/sfc/base/efx.h\n@@ -1051,12 +1051,18 @@ efx_phy_media_type_get(\n */\n #define\tEFX_PHY_MEDIA_INFO_DEV_ADDR_QSFP\t0xA0\n \n+/*\n+ * Maximum accessible data offset for PHY module information.\n+ */\n+#define\tEFX_PHY_MEDIA_INFO_MAX_OFFSET\t\t0x100\n+\n+\n extern\t__checkReturn\t\tefx_rc_t\n efx_phy_module_get_info(\n \t__in\t\t\tefx_nic_t *enp,\n \t__in\t\t\tuint8_t dev_addr,\n-\t__in\t\t\tuint8_t offset,\n-\t__in\t\t\tuint8_t len,\n+\t__in\t\t\tsize_t offset,\n+\t__in\t\t\tsize_t len,\n \t__out_bcount(len)\tuint8_t *data);\n \n #if EFSYS_OPT_PHY_STATS\ndiff --git a/drivers/net/sfc/base/efx_mcdi.c b/drivers/net/sfc/base/efx_mcdi.c\nindex 01cc64e2e..f53be015b 100644\n--- a/drivers/net/sfc/base/efx_mcdi.c\n+++ b/drivers/net/sfc/base/efx_mcdi.c\n@@ -2214,8 +2214,8 @@ efx_mcdi_get_phy_media_info(\n efx_mcdi_phy_module_get_info(\n \t__in\t\t\tefx_nic_t *enp,\n \t__in\t\t\tuint8_t dev_addr,\n-\t__in\t\t\tuint8_t offset,\n-\t__in\t\t\tuint8_t len,\n+\t__in\t\t\tsize_t offset,\n+\t__in\t\t\tsize_t len,\n \t__out_bcount(len)\tuint8_t *data)\n {\n \tefx_port_t *epp = &(enp->en_port);\n@@ -2296,12 +2296,14 @@ efx_mcdi_phy_module_get_info(\n \t\tgoto fail1;\n \t}\n \n+\tEFX_STATIC_ASSERT(EFX_PHY_MEDIA_INFO_PAGE_SIZE <= 0xFF);\n+\n \tif (offset < EFX_PHY_MEDIA_INFO_PAGE_SIZE) {\n-\t\tuint8_t read_len =\n+\t\tsize_t read_len =\n \t\t MIN(len, EFX_PHY_MEDIA_INFO_PAGE_SIZE - offset);\n \n \t\trc = efx_mcdi_get_phy_media_info(enp,\n-\t\t mcdi_lower_page, offset, read_len, data);\n+\t\t mcdi_lower_page, (uint8_t)offset, (uint8_t)read_len, data);\n \t\tif (rc != 0)\n \t\t\tgoto fail2;\n \n@@ -2318,7 +2320,7 @@ efx_mcdi_phy_module_get_info(\n \t\tEFSYS_ASSERT3U(offset, <, EFX_PHY_MEDIA_INFO_PAGE_SIZE);\n \n \t\trc = efx_mcdi_get_phy_media_info(enp,\n-\t\t mcdi_upper_page, offset, len, data);\n+\t\t mcdi_upper_page, (uint8_t)offset, (uint8_t)len, data);\n \t\tif (rc != 0)\n \t\t\tgoto fail3;\n \t}\ndiff --git a/drivers/net/sfc/base/efx_mcdi.h b/drivers/net/sfc/base/efx_mcdi.h\nindex 40072405e..ddf91c111 100644\n--- a/drivers/net/sfc/base/efx_mcdi.h\n+++ b/drivers/net/sfc/base/efx_mcdi.h\n@@ -219,8 +219,8 @@ extern\t__checkReturn\tefx_rc_t\n efx_mcdi_phy_module_get_info(\n \t__in\t\t\tefx_nic_t *enp,\n \t__in\t\t\tuint8_t dev_addr,\n-\t__in\t\t\tuint8_t offset,\n-\t__in\t\t\tuint8_t len,\n+\t__in\t\t\tsize_t offset,\n+\t__in\t\t\tsize_t len,\n \t__out_bcount(len)\tuint8_t *data);\n \n #define\tMCDI_IN(_emr, _type, _ofst)\t\t\t\t\t\\\ndiff --git a/drivers/net/sfc/base/efx_phy.c b/drivers/net/sfc/base/efx_phy.c\nindex e78d6efcb..63b89e6a4 100644\n--- a/drivers/net/sfc/base/efx_phy.c\n+++ b/drivers/net/sfc/base/efx_phy.c\n@@ -288,8 +288,8 @@ efx_phy_media_type_get(\n efx_phy_module_get_info(\n \t__in\t\t\tefx_nic_t *enp,\n \t__in\t\t\tuint8_t dev_addr,\n-\t__in\t\t\tuint8_t offset,\n-\t__in\t\t\tuint8_t len,\n+\t__in\t\t\tsize_t offset,\n+\t__in\t\t\tsize_t len,\n \t__out_bcount(len)\tuint8_t *data)\n {\n \tefx_rc_t rc;\n@@ -297,7 +297,8 @@ efx_phy_module_get_info(\n \tEFSYS_ASSERT3U(enp->en_magic, ==, EFX_NIC_MAGIC);\n \tEFSYS_ASSERT(data != NULL);\n \n-\tif ((uint32_t)offset + len > 0x100) {\n+\tif ((offset > EFX_PHY_MEDIA_INFO_MAX_OFFSET) ||\n+\t ((offset + len) > EFX_PHY_MEDIA_INFO_MAX_OFFSET)) {\n \t\trc = EINVAL;\n \t\tgoto fail1;\n \t}\n", "prefixes": [ "03/11" ] }