Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/45201/?format=api
{ "id": 45201, "url": "https://patches.dpdk.org/api/patches/45201/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1537793304-27883-3-git-send-email-rasland@mellanox.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1537793304-27883-3-git-send-email-rasland@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1537793304-27883-3-git-send-email-rasland@mellanox.com", "date": "2018-09-24T12:49:07", "name": "[v2,3/3] app/testpmd: set packet dump based on verbosity level", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "0f5612e879401c219409967977c8a73b22007b87", "submitter": { "id": 513, "url": "https://patches.dpdk.org/api/people/513/?format=api", "name": "Raslan Darawsheh", "email": "rasland@mellanox.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1537793304-27883-3-git-send-email-rasland@mellanox.com/mbox/", "series": [ { "id": 1465, "url": "https://patches.dpdk.org/api/series/1465/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=1465", "date": "2018-09-24T12:49:05", "name": "[v2,1/3] app/testpmd: move dumping packets to a separate function", "version": 2, "mbox": "https://patches.dpdk.org/series/1465/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/45201/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/45201/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2F6BC4C9D;\n\tMon, 24 Sep 2018 14:49:17 +0200 (CEST)", "from EUR03-AM5-obe.outbound.protection.outlook.com\n\t(mail-eopbgr30064.outbound.protection.outlook.com [40.107.3.64])\n\tby dpdk.org (Postfix) with ESMTP id 4F9C04C93\n\tfor <dev@dpdk.org>; Mon, 24 Sep 2018 14:49:10 +0200 (CEST)", "from DB5PR05MB1254.eurprd05.prod.outlook.com (10.162.157.140) by\n\tDB5PR05MB1205.eurprd05.prod.outlook.com (10.161.244.22) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.1143.18; Mon, 24 Sep 2018 12:49:07 +0000", "from DB5PR05MB1254.eurprd05.prod.outlook.com\n\t([fe80::3516:b329:5c35:51a5]) by\n\tDB5PR05MB1254.eurprd05.prod.outlook.com\n\t([fe80::3516:b329:5c35:51a5%2]) with mapi id 15.20.1164.017;\n\tMon, 24 Sep 2018 12:49:07 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n\ts=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=MySaOVrPXJv1fdlMr12YDLN59jvMh5036pUt9NnkhpY=;\n\tb=jrBPhu8IkjY9FTW7cseebeqYb/y9Kq2u5s+nzU+IFq5i1BhiPJmNcKNCLhPrls9KI23OhEMkd2olfn3J+taFb7qgxYTYKTgPcHNPTGPDwgGIeZQpo9dd4swpcUhkKyUutLd0ttEalViXTj2a6TIRGRpoUJ2UZo6t95LyiMS50As=", "From": "Raslan Darawsheh <rasland@mellanox.com>", "To": "\"jingjing.wu@intel.com\" <jingjing.wu@intel.com>", "CC": "Thomas Monjalon <thomas@monjalon.net>, \"dev@dpdk.org\" <dev@dpdk.org>,\n\tShahaf Shuler <shahafs@mellanox.com>, Raslan Darawsheh\n\t<rasland@mellanox.com>, \"Xueming(Steven) Li\" <xuemingl@mellanox.com>, Ori\n\tKatz <orik@mellanox.com>, \"jerin.jacob@caviumnetworks.com\"\n\t<jerin.jacob@caviumnetworks.com>, \"david.marchand@6wind.com\"\n\t<david.marchand@6wind.com>", "Thread-Topic": "[PATCH v2 3/3] app/testpmd: set packet dump based on verbosity\n\tlevel", "Thread-Index": "AQHUVAT7TjQEldJBVEesMXwNIiJCdw==", "Date": "Mon, 24 Sep 2018 12:49:07 +0000", "Message-ID": "<1537793304-27883-3-git-send-email-rasland@mellanox.com>", "References": "<1536739583-29166-2-git-send-email-rasland@mellanox.com>\n\t<1537793304-27883-1-git-send-email-rasland@mellanox.com>", "In-Reply-To": "<1537793304-27883-1-git-send-email-rasland@mellanox.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-mailer": "git-send-email 2.7.4", "x-clientproxiedby": "VI1PR04CA0105.eurprd04.prod.outlook.com\n\t(2603:10a6:803:64::40) To DB5PR05MB1254.eurprd05.prod.outlook.com\n\t(2a01:111:e400:51cc::12)", "authentication-results": "spf=none (sender IP is )\n\tsmtp.mailfrom=rasland@mellanox.com; ", "x-ms-exchange-messagesentrepresentingtype": "1", "x-originating-ip": "[37.142.13.130]", "x-ms-publictraffictype": "Email", "x-microsoft-exchange-diagnostics": "1; DB5PR05MB1205;\n\t6:OTJEUY+UjXOR0u37zXM9lOwRxQ/EIF9rPIbpV3SlybEbkEYVeS2uL6Wj70sGz7rxgY00xBn2vlzJQFFuF6ad/4NQzCFzYEWGept6AYBSukpkcA1U0XvkonfzwrxZcn1D/vS/4ixApesOQ66V9EMi5DSSIrH2Lu7ZUdo5cz5X3bARjGL9RjWt5PQ7Qvfw4OsoE+eMhnK5smcDDO7SOiGEgkE7yHcFtRe7KyANou5DU9yBygOhNy+/pvfTkqqxCELuAlbD6/ZWMwm8h6UvQBpoIChna1xOMH7915SlWkabwaFmEXGX5ShmPMwpV9L4I3BvRzEkCMaX24/n3kO98OIvknzMUWFBYVs2on2ReTp1Yjbl5HdH8kovrnwxbQZaR20kh6bfmlbBP1rjX5Qgm2SU9QW63AiJ0vEF7p+uOUWgZKzeuVICjsRNxDWmD78lusCHpaVaK48b9nM87sm4MdxaJQ==;\n\t5:2+4uMiiGo8LYKSJh6gTn/S1l0ojzYbVKWwrkQPMyxqiX3lr5tD+RpVMEbesNY/VXlej/J/ajNUmjwfj0xEb2m3zXWeR4psPjXU2u7TxiZpp3YQDjvTeyAXBrICdAhphmw7RydiX3Wn7w8R4BkOOoXCS1Dj//p/DZqc/0i+fx5+8=;\n\t7:QovLUY5TNIolkrHb6Qqr0ChWGSaUP7fn1GNrEBmcFoUPJIuK7X7xmHsh1P+woGU6SFThZYR59XQV+HUDeMXQE6vCW57diEOFhGsBl6S6ux5MtWPj+x8JO4jTgzj+cMjrZemtzmifYDdOaCMw5e0YloyQDgYhWSVIrEIPv+3aroaaToH+ddBZ50zEbHh+4ueW7GJJYpsAFrKn7msJQyPaL4o6B72bCDyHx2QZLaAmnyUllbDaKSZVFal/wrurNMC7", "x-ms-office365-filtering-correlation-id": "5575ae32-9ff2-489c-9d8c-08d6221c1dc4", "x-ms-office365-filtering-ht": "Tenant", "x-microsoft-antispam": "BCL:0; PCL:0;\n\tRULEID:(7020095)(4652040)(8989299)(4534165)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020);\n\tSRVR:DB5PR05MB1205; ", "x-ms-traffictypediagnostic": "DB5PR05MB1205:", "x-ld-processed": "a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr", "x-microsoft-antispam-prvs": "<DB5PR05MB1205A2086E1928E86BAADDEBC2170@DB5PR05MB1205.eurprd05.prod.outlook.com>", "x-exchange-antispam-report-test": "UriScan:;", "x-ms-exchange-senderadcheck": "1", "x-exchange-antispam-report-cfa-test": "BCL:0; PCL:0;\n\tRULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(3231355)(944501410)(52105095)(10201501046)(93006095)(93001095)(6055026)(149066)(150027)(6041310)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(20161123564045)(201708071742011)(7699051);\n\tSRVR:DB5PR05MB1205; BCL:0; PCL:0; RULEID:; SRVR:DB5PR05MB1205; ", "x-forefront-prvs": "0805EC9467", "x-forefront-antispam-report": "SFV:NSPM;\n\tSFS:(10009020)(39860400002)(366004)(396003)(346002)(136003)(376002)(199004)(189003)(2900100001)(71190400001)(386003)(6506007)(2351001)(102836004)(8936002)(36756003)(6486002)(478600001)(68736007)(6116002)(3846002)(5250100002)(2906002)(81166006)(81156014)(8676002)(25786009)(106356001)(53936002)(26005)(316002)(186003)(5640700003)(99286004)(86362001)(4326008)(52116002)(14454004)(105586002)(305945005)(6436002)(54906003)(11346002)(575784001)(476003)(7736002)(97736004)(446003)(256004)(2616005)(486006)(6512007)(71200400001)(50226002)(6916009)(66066001)(5660300001)(2501003)(76176011);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:DB5PR05MB1205;\n\tH:DB5PR05MB1254.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en;\n\tPTR:InfoNoRecords; A:1; MX:1; ", "received-spf": "None (protection.outlook.com: mellanox.com does not designate\n\tpermitted sender hosts)", "x-microsoft-antispam-message-info": "6s+BC30RNi754O8MwUQOMAF4lfVYshnUtSgP+2GdI4sbuTZp6y/5FBEB4C6OUUGEFothfvphzus9CBNntEXtge2ZXdpqGZqOXEIKJH7qMOPvnuy1Cac0MsUwPKL7s2lanNYaJfBzssD5p3SwF15eWHuil77FM7dldsZXZevwAoJA6AALXzq5FO8L/4POO78UHLWqHrC5zhRF5rlJbtyXR4PAGuL4KfeeYjMTKWfpU+GOyoX7k+pNKwR6053rmq9xAb/RBs2nRDWYlsuAf/07OywdW2zBOvrfqaUeezo4QZo4mwtqS0Xnl4rUCTiG/DM7F8dJU8SBRSPwTXfU+cDbKA4bETi+NQPhkOX/bqCk++c=", "spamdiagnosticoutput": "1:99", "spamdiagnosticmetadata": "NSPM", "Content-Type": "text/plain; charset=\"iso-8859-1\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-OriginatorOrg": "Mellanox.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "5575ae32-9ff2-489c-9d8c-08d6221c1dc4", "X-MS-Exchange-CrossTenant-originalarrivaltime": "24 Sep 2018 12:49:07.8201\n\t(UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "a652971c-7d2e-4d9b-a6a4-d149256f461b", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DB5PR05MB1205", "Subject": "[dpdk-dev] [PATCH v2 3/3] app/testpmd: set packet dump based on\n\tverbosity level", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "when changing verbosity level it will configure rx/tx callbacks to dump\npackets based on the verbosity value as following:\n 1- dump only received packets:\n testpmd> set verbose 1\n 2- dump only sent packets:\n testpmd> set verbose 2\n 3- dump sent and received packets:\n testpmd> set verbose (any number > 2)\n 4- disable dump\n testpmd> set verbose 0\n\nSigned-off-by: Raslan Darawsheh <rasland@mellanox.com>\n---\n app/test-pmd/config.c | 25 +++++++++++++++++++++++++\n app/test-pmd/testpmd.c | 4 ++--\n app/test-pmd/testpmd.h | 1 +\n 3 files changed, 28 insertions(+), 2 deletions(-)", "diff": "diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c\nindex fb45fea..f402e04 100644\n--- a/app/test-pmd/config.c\n+++ b/app/test-pmd/config.c\n@@ -50,6 +50,7 @@\n #endif\n #include <rte_gro.h>\n #include <cmdline_parse_etheraddr.h>\n+#include <rte_config.h>\n \n #include \"testpmd.h\"\n \n@@ -2963,11 +2964,35 @@ remove_tx_dump_callbacks(portid_t portid)\n }\n \n void\n+configure_rxtx_dump_callbacks(uint16_t verbose)\n+{\n+\tportid_t portid;\n+\n+#ifndef RTE_ETHDEV_RXTX_CALLBACKS\n+\t\tTESTPMD_LOG(ERR, \"setting rxtx callbacks is not enabled\\n\");\n+\t\treturn;\n+#endif\n+\n+\tRTE_ETH_FOREACH_DEV(portid)\n+\t{\n+\t\tif (verbose == 1 || verbose > 2)\n+\t\t\tadd_rx_dump_callbacks(portid);\n+\t\telse\n+\t\t\tremove_rx_dump_callbacks(portid);\n+\t\tif (verbose >= 2)\n+\t\t\tadd_tx_dump_callbacks(portid);\n+\t\telse\n+\t\t\tremove_tx_dump_callbacks(portid);\n+\t}\n+}\n+\n+void\n set_verbose_level(uint16_t vb_level)\n {\n \tprintf(\"Change verbose level from %u to %u\\n\",\n \t (unsigned int) verbose_level, (unsigned int) vb_level);\n \tverbose_level = vb_level;\n+\tconfigure_rxtx_dump_callbacks(verbose_level);\n }\n \n void\ndiff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c\nindex 571ecb4..538723c 100644\n--- a/app/test-pmd/testpmd.c\n+++ b/app/test-pmd/testpmd.c\n@@ -1665,7 +1665,7 @@ start_port(portid_t pid)\n \t\t\t\t\treturn -1;\n \t\t\t\t}\n \t\t\t}\n-\n+\t\t\tconfigure_rxtx_dump_callbacks(0);\n \t\t\tprintf(\"Configuring Port %d (socket %u)\\n\", pi,\n \t\t\t\t\tport->socket_id);\n \t\t\t/* configure port */\n@@ -1764,7 +1764,7 @@ start_port(portid_t pid)\n \t\t\t\treturn -1;\n \t\t\t}\n \t\t}\n-\n+\t\tconfigure_rxtx_dump_callbacks(verbose_level);\n \t\t/* start port */\n \t\tif (rte_eth_dev_start(pi) < 0) {\n \t\t\tprintf(\"Fail to start port %d\\n\", pi);\ndiff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h\nindex c0d7656..e68710d 100644\n--- a/app/test-pmd/testpmd.h\n+++ b/app/test-pmd/testpmd.h\n@@ -757,6 +757,7 @@ void add_rx_dump_callbacks(portid_t portid);\n void remove_rx_dump_callbacks(portid_t portid);\n void add_tx_dump_callbacks(portid_t portid);\n void remove_tx_dump_callbacks(portid_t portid);\n+void configure_rxtx_dump_callbacks(uint16_t verbose);\n \n /*\n * Work-around of a compilation error with ICC on invocations of the\n", "prefixes": [ "v2", "3/3" ] }