Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/45116/?format=api
{ "id": 45116, "url": "https://patches.dpdk.org/api/patches/45116/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1537544182-17823-4-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1537544182-17823-4-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1537544182-17823-4-git-send-email-arybchenko@solarflare.com", "date": "2018-09-21T15:36:22", "name": "[v3,2/2] net/failsafe: support multicast address list set", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "a60231aec38f649b0b4faeb40218bf3b469bc2c8", "submitter": { "id": 607, "url": "https://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1537544182-17823-4-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 1443, "url": "https://patches.dpdk.org/api/series/1443/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=1443", "date": "2018-09-21T15:36:19", "name": "net/failsafe: support multicast MAC address set", "version": 3, "mbox": "https://patches.dpdk.org/series/1443/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/45116/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/45116/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 220B34D3A;\n\tFri, 21 Sep 2018 17:36:40 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n\t[67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 1BB884CB3\n\tfor <dev@dpdk.org>; Fri, 21 Sep 2018 17:36:38 +0200 (CEST)", "from webmail.solarflare.com (webmail.solarflare.com\n\t[12.187.104.26])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby mx1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with\n\tESMTPS id 08D9878007A; Fri, 21 Sep 2018 15:36:35 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1395.4; Fri, 21 Sep 2018 08:36:34 -0700", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1395.4 via Frontend Transport; Fri, 21 Sep 2018 08:36:34 -0700", "from ukv-loginhost.uk.solarflarecom.com\n\t(ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tw8LFaTdq025639; Fri, 21 Sep 2018 16:36:29 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n\tby ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id\n\tC83B81626D4; Fri, 21 Sep 2018 16:36:29 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "Gaetan Rivet <gaetan.rivet@6wind.com>", "CC": "<dev@dpdk.org>, Evgeny Im <Evgeny.Im@oktetlabs.com>", "Date": "Fri, 21 Sep 2018 16:36:22 +0100", "Message-ID": "<1537544182-17823-4-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1537544182-17823-1-git-send-email-arybchenko@solarflare.com>", "References": "<1535730814-24624-1-git-send-email-arybchenko@solarflare.com>\n\t<1537544182-17823-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.5.1010-24108.005", "X-TM-AS-Result": "No-1.640400-4.000000-10", "X-TMASE-MatchedRID": "Fz0Eq0xINt/Ot+/gOYaZxQPZZctd3P4BjiWciALpTNO7qpOHKudqc2lb\n\tb2DwZL4DXR9mTvb2Z4paTWdLghmLYr4VhlZ3FziRzfqlpbtmcWi2byX1qZ37Ene9QDr8+LTcFTf\n\tB1yBPlPKQX3MQT+cVnsYiV/ax0LEazHOcqjDn7NYCg1rav4R3De3+iQEtoSj4fmHrLgoJIlx+FD\n\tgUHX2SalddiyBfCnh7qVi9UAysYrgZ7Eu9TqPx8OEbUg4xvs+wn+BtC63aUh6bKItl61J/yZ+in\n\tTK0bC9eKrauXd3MZDX+Rhu66PqCG5HyBv4CioQ9J11zDgvcJCFWPtjB1wVk4m+x4uiSH3d3irtP\n\tmD3sCF7LRnuEYiOLDpKBr9X2S9QMRe9Hnf7yLLdArciPeIqWRTigZBQJvBjlD6DuZ3COjrnoW0N\n\tkKZgEnVjylogJTbSO73QlCBbmrKs=", "X-TM-AS-User-Approved-Sender": "No", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10-1.640400-4.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.5.1010-24108.005", "X-MDID": "1537544197-iXJsGl0SXfCR", "Subject": "[dpdk-dev] [PATCH v3 2/2] net/failsafe: support multicast address\n\tlist set", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Evgeny Im <Evgeny.Im@oktetlabs.com>\n\nSigned-off-by: Evgeny Im <Evgeny.Im@oktetlabs.com>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n doc/guides/nics/features/failsafe.ini | 1 +\n doc/guides/rel_notes/release_18_11.rst | 1 +\n drivers/net/failsafe/failsafe.c | 1 +\n drivers/net/failsafe/failsafe_ether.c | 17 +++++++++\n drivers/net/failsafe/failsafe_ops.c | 50 +++++++++++++++++++++++++\n drivers/net/failsafe/failsafe_private.h | 2 +\n 6 files changed, 72 insertions(+)", "diff": "diff --git a/doc/guides/nics/features/failsafe.ini b/doc/guides/nics/features/failsafe.ini\nindex 89e253df3..e3c4c08f2 100644\n--- a/doc/guides/nics/features/failsafe.ini\n+++ b/doc/guides/nics/features/failsafe.ini\n@@ -15,6 +15,7 @@ Jumbo frame = Y\n Promiscuous mode = Y\n Allmulticast mode = Y\n Unicast MAC filter = Y\n+Multicast MAC filter = Y\n VLAN filter = Y\n Flow control = Y\n Flow API = Y\ndiff --git a/doc/guides/rel_notes/release_18_11.rst b/doc/guides/rel_notes/release_18_11.rst\nindex f39cb15d2..2f53564a9 100644\n--- a/doc/guides/rel_notes/release_18_11.rst\n+++ b/doc/guides/rel_notes/release_18_11.rst\n@@ -79,6 +79,7 @@ New Features\n * Support for Rx and Tx queues start and stop.\n * Support for Rx and Tx queues deferred start.\n * Support for runtime Rx and Tx queues setup.\n+ * Support multicast MAC address set.\n \n * **Added ability to switch queue deferred start flag on testpmd app.**\n \ndiff --git a/drivers/net/failsafe/failsafe.c b/drivers/net/failsafe/failsafe.c\nindex 657919f93..c3999f026 100644\n--- a/drivers/net/failsafe/failsafe.c\n+++ b/drivers/net/failsafe/failsafe.c\n@@ -304,6 +304,7 @@ fs_rte_eth_free(const char *name)\n \tret = pthread_mutex_destroy(&PRIV(dev)->hotplug_mutex);\n \tif (ret)\n \t\tERROR(\"Error while destroying hotplug mutex\");\n+\trte_free(PRIV(dev)->mcast_addrs);\n \trte_free(PRIV(dev));\n \trte_eth_dev_release_port(dev);\n \treturn ret;\ndiff --git a/drivers/net/failsafe/failsafe_ether.c b/drivers/net/failsafe/failsafe_ether.c\nindex 191f95f14..51c96f78b 100644\n--- a/drivers/net/failsafe/failsafe_ether.c\n+++ b/drivers/net/failsafe/failsafe_ether.c\n@@ -179,6 +179,23 @@ fs_eth_dev_conf_apply(struct rte_eth_dev *dev,\n \t\t\treturn ret;\n \t\t}\n \t}\n+\t/*\n+\t * Propagate multicast MAC addresses to sub-devices,\n+\t * if non zero number of addresses is set.\n+\t * The condition is required to avoid breakage of failsafe\n+\t * for sub-devices which do not support the operation\n+\t * if the feature is really not used.\n+\t */\n+\tif (PRIV(dev)->nb_mcast_addr > 0) {\n+\t\tDEBUG(\"Configuring multicast MAC addresses\");\n+\t\tret = rte_eth_dev_set_mc_addr_list(PORT_ID(sdev),\n+\t\t\t\t\t\t PRIV(dev)->mcast_addrs,\n+\t\t\t\t\t\t PRIV(dev)->nb_mcast_addr);\n+\t\tif (ret) {\n+\t\t\tERROR(\"Failed to apply multicast MAC addresses\");\n+\t\t\treturn ret;\n+\t\t}\n+\t}\n \t/* VLAN filter */\n \tvfc1 = &dev->data->vlan_filter_conf;\n \tvfc2 = &edev->data->vlan_filter_conf;\ndiff --git a/drivers/net/failsafe/failsafe_ops.c b/drivers/net/failsafe/failsafe_ops.c\nindex 7fadf06f5..86d7fa2a0 100644\n--- a/drivers/net/failsafe/failsafe_ops.c\n+++ b/drivers/net/failsafe/failsafe_ops.c\n@@ -1126,6 +1126,55 @@ fs_mac_addr_set(struct rte_eth_dev *dev, struct ether_addr *mac_addr)\n \treturn 0;\n }\n \n+static int\n+fs_set_mc_addr_list(struct rte_eth_dev *dev,\n+\t\t struct ether_addr *mc_addr_set, uint32_t nb_mc_addr)\n+{\n+\tstruct sub_device *sdev;\n+\tuint8_t i;\n+\tint ret;\n+\tvoid *mcast_addrs;\n+\n+\tfs_lock(dev, 0);\n+\n+\tFOREACH_SUBDEV_STATE(sdev, i, dev, DEV_ACTIVE) {\n+\t\tret = rte_eth_dev_set_mc_addr_list(PORT_ID(sdev),\n+\t\t\t\t\t\t mc_addr_set, nb_mc_addr);\n+\t\tif (ret != 0) {\n+\t\t\tERROR(\"Operation rte_eth_dev_set_mc_addr_list failed for sub_device %d with error %d\",\n+\t\t\t i, ret);\n+\t\t\tgoto rollback;\n+\t\t}\n+\t}\n+\n+\tmcast_addrs = rte_realloc(PRIV(dev)->mcast_addrs,\n+\t\tnb_mc_addr * sizeof(PRIV(dev)->mcast_addrs[0]), 0);\n+\tif (mcast_addrs == NULL && nb_mc_addr > 0) {\n+\t\tret = -ENOMEM;\n+\t\tgoto rollback;\n+\t}\n+\trte_memcpy(mcast_addrs, mc_addr_set,\n+\t\t nb_mc_addr * sizeof(PRIV(dev)->mcast_addrs[0]));\n+\tPRIV(dev)->nb_mcast_addr = nb_mc_addr;\n+\tPRIV(dev)->mcast_addrs = mcast_addrs;\n+\n+\tfs_unlock(dev, 0);\n+\treturn 0;\n+\n+rollback:\n+\tFOREACH_SUBDEV_STATE(sdev, i, dev, DEV_ACTIVE) {\n+\t\tint rc = rte_eth_dev_set_mc_addr_list(PORT_ID(sdev),\n+\t\t\tPRIV(dev)->mcast_addrs,\tPRIV(dev)->nb_mcast_addr);\n+\t\tif (rc != 0) {\n+\t\t\tERROR(\"Multicast MAC address list rollback for sub_device %d failed with error %d\",\n+\t\t\t i, rc);\n+\t\t}\n+\t}\n+\n+\tfs_unlock(dev, 0);\n+\treturn ret;\n+}\n+\n static int\n fs_rss_hash_update(struct rte_eth_dev *dev,\n \t\t\tstruct rte_eth_rss_conf *rss_conf)\n@@ -1214,6 +1263,7 @@ const struct eth_dev_ops failsafe_ops = {\n \t.mac_addr_remove = fs_mac_addr_remove,\n \t.mac_addr_add = fs_mac_addr_add,\n \t.mac_addr_set = fs_mac_addr_set,\n+\t.set_mc_addr_list = fs_set_mc_addr_list,\n \t.rss_hash_update = fs_rss_hash_update,\n \t.filter_ctrl = fs_filter_ctrl,\n };\ndiff --git a/drivers/net/failsafe/failsafe_private.h b/drivers/net/failsafe/failsafe_private.h\nindex 886af8616..abbe73e87 100644\n--- a/drivers/net/failsafe/failsafe_private.h\n+++ b/drivers/net/failsafe/failsafe_private.h\n@@ -143,6 +143,8 @@ struct fs_priv {\n \tuint32_t nb_mac_addr;\n \tstruct ether_addr mac_addrs[FAILSAFE_MAX_ETHADDR];\n \tuint32_t mac_addr_pool[FAILSAFE_MAX_ETHADDR];\n+\tuint32_t nb_mcast_addr;\n+\tstruct ether_addr *mcast_addrs;\n \t/* current capabilities */\n \tstruct rte_eth_dev_info infos;\n \tstruct rte_eth_dev_owner my_owner; /* Unique owner. */\n", "prefixes": [ "v3", "2/2" ] }