Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/45096/?format=api
{ "id": 45096, "url": "https://patches.dpdk.org/api/patches/45096/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1537530366-4722-3-git-send-email-hemant.agrawal@nxp.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1537530366-4722-3-git-send-email-hemant.agrawal@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1537530366-4722-3-git-send-email-hemant.agrawal@nxp.com", "date": "2018-09-21T11:46:04", "name": "[v2,3/5] event/dpaa2: enchance timeout handling", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "d6a133ff9fd5787b9b691a983fd3bf1b79b52e9b", "submitter": { "id": 477, "url": "https://patches.dpdk.org/api/people/477/?format=api", "name": "Hemant Agrawal", "email": "hemant.agrawal@nxp.com" }, "delegate": { "id": 310, "url": "https://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1537530366-4722-3-git-send-email-hemant.agrawal@nxp.com/mbox/", "series": [ { "id": 1438, "url": "https://patches.dpdk.org/api/series/1438/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=1438", "date": "2018-09-21T11:46:03", "name": "[v2,1/5] event/dpaa2: fix mbuf assignment in atomic processing", "version": 2, "mbox": "https://patches.dpdk.org/series/1438/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/45096/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/45096/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C95064CA5;\n\tFri, 21 Sep 2018 13:48:21 +0200 (CEST)", "from inva020.nxp.com (inva020.nxp.com [92.121.34.13])\n\tby dpdk.org (Postfix) with ESMTP id 28F011B19\n\tfor <dev@dpdk.org>; Fri, 21 Sep 2018 13:48:16 +0200 (CEST)", "from inva020.nxp.com (localhost [127.0.0.1])\n\tby inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 0DAFF1A02B6;\n\tFri, 21 Sep 2018 13:48:16 +0200 (CEST)", "from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com\n\t[165.114.16.14])\n\tby inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 2D8031A02B4;\n\tFri, 21 Sep 2018 13:48:14 +0200 (CEST)", "from bf-netperf1.ap.freescale.net (bf-netperf1.ap.freescale.net\n\t[10.232.134.28])\n\tby invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id 438AF402E5;\n\tFri, 21 Sep 2018 19:48:11 +0800 (SGT)" ], "From": "Hemant Agrawal <hemant.agrawal@nxp.com>", "To": "dev@dpdk.org", "Cc": "jerin.jacob@caviumnetworks.com, Hemant Agrawal <hemant.agrawal@nxp.com>", "Date": "Fri, 21 Sep 2018 17:16:04 +0530", "Message-Id": "<1537530366-4722-3-git-send-email-hemant.agrawal@nxp.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1537530366-4722-1-git-send-email-hemant.agrawal@nxp.com>", "References": "<1535609039-10869-1-git-send-email-hemant.agrawal@nxp.com>\n\t<1537530366-4722-1-git-send-email-hemant.agrawal@nxp.com>", "X-Virus-Scanned": "ClamAV using ClamSMTP", "Subject": "[dpdk-dev] [PATCH v2 3/5] event/dpaa2: enchance timeout handling", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch enahances:\n1. configure the dequeue time out value as per the given\n method or per dequeue, global or default.\n2. The timeout values were being mixed as ns or ms timeouts.\n now the values are stored as ns and scale is in ms.\n\nSigned-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>\n---\nv2: added description\n\n drivers/event/dpaa2/dpaa2_eventdev.c | 19 ++++++++++++++++---\n drivers/event/dpaa2/dpaa2_eventdev.h | 1 +\n 2 files changed, 17 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c b/drivers/event/dpaa2/dpaa2_eventdev.c\nindex c4064a4..4b56e2e 100644\n--- a/drivers/event/dpaa2/dpaa2_eventdev.c\n+++ b/drivers/event/dpaa2/dpaa2_eventdev.c\n@@ -284,7 +284,7 @@ dpaa2_eventdev_info_get(struct rte_eventdev *dev,\n \tdev_info->max_dequeue_timeout_ns =\n \t\tDPAA2_EVENT_MAX_DEQUEUE_TIMEOUT;\n \tdev_info->dequeue_timeout_ns =\n-\t\tDPAA2_EVENT_MIN_DEQUEUE_TIMEOUT;\n+\t\tDPAA2_EVENT_PORT_DEQUEUE_TIMEOUT_NS;\n \tdev_info->max_event_queues = priv->max_event_queues;\n \tdev_info->max_event_queue_flows =\n \t\tDPAA2_EVENT_MAX_QUEUE_FLOWS;\n@@ -314,7 +314,6 @@ dpaa2_eventdev_configure(const struct rte_eventdev *dev)\n \n \tEVENTDEV_INIT_FUNC_TRACE();\n \n-\tpriv->dequeue_timeout_ns = conf->dequeue_timeout_ns;\n \tpriv->nb_event_queues = conf->nb_event_queues;\n \tpriv->nb_event_ports = conf->nb_event_ports;\n \tpriv->nb_event_queue_flows = conf->nb_event_queue_flows;\n@@ -322,6 +321,20 @@ dpaa2_eventdev_configure(const struct rte_eventdev *dev)\n \tpriv->nb_event_port_enqueue_depth = conf->nb_event_port_enqueue_depth;\n \tpriv->event_dev_cfg = conf->event_dev_cfg;\n \n+\t/* Check dequeue timeout method is per dequeue or global */\n+\tif (priv->event_dev_cfg & RTE_EVENT_DEV_CFG_PER_DEQUEUE_TIMEOUT) {\n+\t\t/*\n+\t\t * Use timeout value as given in dequeue operation.\n+\t\t * So invalidating this timeout value.\n+\t\t */\n+\t\tpriv->dequeue_timeout_ns = 0;\n+\n+\t} else if (conf->dequeue_timeout_ns == 0) {\n+\t\tpriv->dequeue_timeout_ns = DPAA2_EVENT_PORT_DEQUEUE_TIMEOUT_NS;\n+\t} else {\n+\t\tpriv->dequeue_timeout_ns = conf->dequeue_timeout_ns;\n+\t}\n+\n \tDPAA2_EVENTDEV_DEBUG(\"Configured eventdev devid=%d\",\n \t\t\t dev->data->dev_id);\n \treturn 0;\n@@ -516,7 +529,7 @@ static int\n dpaa2_eventdev_timeout_ticks(struct rte_eventdev *dev, uint64_t ns,\n \t\t\t uint64_t *timeout_ticks)\n {\n-\tuint32_t scale = 1;\n+\tuint32_t scale = 1000*1000;\n \n \tEVENTDEV_INIT_FUNC_TRACE();\n \ndiff --git a/drivers/event/dpaa2/dpaa2_eventdev.h b/drivers/event/dpaa2/dpaa2_eventdev.h\nindex d2f98c6..8898024 100644\n--- a/drivers/event/dpaa2/dpaa2_eventdev.h\n+++ b/drivers/event/dpaa2/dpaa2_eventdev.h\n@@ -21,6 +21,7 @@\n #define DPAA2_EVENT_MAX_QUEUES\t\t\t16\n #define DPAA2_EVENT_MIN_DEQUEUE_TIMEOUT\t\t1\n #define DPAA2_EVENT_MAX_DEQUEUE_TIMEOUT\t\t(UINT32_MAX - 1)\n+#define DPAA2_EVENT_PORT_DEQUEUE_TIMEOUT_NS\t100UL\n #define DPAA2_EVENT_MAX_QUEUE_FLOWS\t\t2048\n #define DPAA2_EVENT_MAX_QUEUE_PRIORITY_LEVELS\t8\n #define DPAA2_EVENT_MAX_EVENT_PRIORITY_LEVELS\t0\n", "prefixes": [ "v2", "3/5" ] }