Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/45081/?format=api
{ "id": 45081, "url": "https://patches.dpdk.org/api/patches/45081/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1537527962-25757-2-git-send-email-hemant.agrawal@nxp.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1537527962-25757-2-git-send-email-hemant.agrawal@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1537527962-25757-2-git-send-email-hemant.agrawal@nxp.com", "date": "2018-09-21T11:05:50", "name": "[v3,01/13] net/dpaa: configure frame queue on MAC ID basis", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "b432f1fdb2bcd1b80eccb6b18b4b0446e9d6ed29", "submitter": { "id": 477, "url": "https://patches.dpdk.org/api/people/477/?format=api", "name": "Hemant Agrawal", "email": "hemant.agrawal@nxp.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1537527962-25757-2-git-send-email-hemant.agrawal@nxp.com/mbox/", "series": [ { "id": 1437, "url": "https://patches.dpdk.org/api/series/1437/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=1437", "date": "2018-09-21T11:05:49", "name": "NXP DPAA driver enhancements", "version": 3, "mbox": "https://patches.dpdk.org/series/1437/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/45081/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/45081/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 482B14CC5;\n\tFri, 21 Sep 2018 13:08:10 +0200 (CEST)", "from inva020.nxp.com (inva020.nxp.com [92.121.34.13])\n\tby dpdk.org (Postfix) with ESMTP id 8B1604C9F\n\tfor <dev@dpdk.org>; Fri, 21 Sep 2018 13:08:06 +0200 (CEST)", "from inva020.nxp.com (localhost [127.0.0.1])\n\tby inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 4AFA01A02B4;\n\tFri, 21 Sep 2018 13:08:06 +0200 (CEST)", "from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com\n\t[165.114.16.14])\n\tby inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 6AED91A0039;\n\tFri, 21 Sep 2018 13:08:04 +0200 (CEST)", "from bf-netperf1.ap.freescale.net (bf-netperf1.ap.freescale.net\n\t[10.232.134.28])\n\tby invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id 2F23C402DD;\n\tFri, 21 Sep 2018 19:08:01 +0800 (SGT)" ], "From": "Hemant Agrawal <hemant.agrawal@nxp.com>", "To": "dev@dpdk.org,\n\tthomas@monjalon.net,\n\tferruh.yigit@intel.com", "Date": "Fri, 21 Sep 2018 16:35:50 +0530", "Message-Id": "<1537527962-25757-2-git-send-email-hemant.agrawal@nxp.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1537527962-25757-1-git-send-email-hemant.agrawal@nxp.com>", "References": "<1537277516-8876-2-git-send-email-hemant.agrawal@nxp.com>\n\t<1537527962-25757-1-git-send-email-hemant.agrawal@nxp.com>", "X-Virus-Scanned": "ClamAV using ClamSMTP", "Subject": "[dpdk-dev] [PATCH v3 01/13] net/dpaa: configure frame queue on MAC\n\tID basis", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The current code has the hardcoded seq for fq allocation.\nIt require multiple changes, when some of the interfaces\nare assigned to kernel stack. Changing it on the mac\nid basis provide the flexibility to assign any interface\nto kernel.\n\nSigned-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>\n---\n drivers/net/dpaa/dpaa_ethdev.c | 25 ++++++++++++++-----------\n drivers/net/dpaa/dpaa_ethdev.h | 2 +-\n 2 files changed, 15 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c\nindex 30eff65..b9bd557 100644\n--- a/drivers/net/dpaa/dpaa_ethdev.c\n+++ b/drivers/net/dpaa/dpaa_ethdev.c\n@@ -1011,7 +1011,7 @@ static int dpaa_rx_queue_init(struct qman_fq *fq, struct qman_cgr *cgr_rx,\n {\n \tstruct qm_mcc_initfq opts = {0};\n \tint ret;\n-\tu32 flags = 0;\n+\tu32 flags = QMAN_FQ_FLAG_NO_ENQUEUE;\n \tstruct qm_mcc_initcgr cgr_opts = {\n \t\t.we_mask = QM_CGR_WE_CS_THRES |\n \t\t\t\tQM_CGR_WE_CSTD_EN |\n@@ -1024,15 +1024,18 @@ static int dpaa_rx_queue_init(struct qman_fq *fq, struct qman_cgr *cgr_rx,\n \n \tPMD_INIT_FUNC_TRACE();\n \n-\tret = qman_reserve_fqid(fqid);\n-\tif (ret) {\n-\t\tDPAA_PMD_ERR(\"reserve rx fqid 0x%x failed with ret: %d\",\n-\t\t\t fqid, ret);\n-\t\treturn -EINVAL;\n+\tif (fqid) {\n+\t\tret = qman_reserve_fqid(fqid);\n+\t\tif (ret) {\n+\t\t\tDPAA_PMD_ERR(\"reserve rx fqid 0x%x failed with ret: %d\",\n+\t\t\t\t fqid, ret);\n+\t\t\treturn -EINVAL;\n+\t\t}\n+\t} else {\n+\t\tflags |= QMAN_FQ_FLAG_DYNAMIC_FQID;\n \t}\n-\n \tDPAA_PMD_DEBUG(\"creating rx fq %p, fqid 0x%x\", fq, fqid);\n-\tret = qman_create_fq(fqid, QMAN_FQ_FLAG_NO_ENQUEUE, fq);\n+\tret = qman_create_fq(fqid, flags, fq);\n \tif (ret) {\n \t\tDPAA_PMD_ERR(\"create rx fqid 0x%x failed with ret: %d\",\n \t\t\tfqid, ret);\n@@ -1051,7 +1054,7 @@ static int dpaa_rx_queue_init(struct qman_fq *fq, struct qman_cgr *cgr_rx,\n \t\tif (ret) {\n \t\t\tDPAA_PMD_WARN(\n \t\t\t\t\"rx taildrop init fail on rx fqid 0x%x(ret=%d)\",\n-\t\t\t\tfqid, ret);\n+\t\t\t\tfq->fqid, ret);\n \t\t\tgoto without_cgr;\n \t\t}\n \t\topts.we_mask |= QM_INITFQ_WE_CGID;\n@@ -1059,7 +1062,7 @@ static int dpaa_rx_queue_init(struct qman_fq *fq, struct qman_cgr *cgr_rx,\n \t\topts.fqd.fq_ctrl |= QM_FQCTRL_CGE;\n \t}\n without_cgr:\n-\tret = qman_init_fq(fq, flags, &opts);\n+\tret = qman_init_fq(fq, 0, &opts);\n \tif (ret)\n \t\tDPAA_PMD_ERR(\"init rx fqid 0x%x failed with ret:%d\", fqid, ret);\n \treturn ret;\n@@ -1212,7 +1215,7 @@ dpaa_dev_init(struct rte_eth_dev *eth_dev)\n \t\tif (default_q)\n \t\t\tfqid = cfg->rx_def;\n \t\telse\n-\t\t\tfqid = DPAA_PCD_FQID_START + dpaa_intf->ifid *\n+\t\t\tfqid = DPAA_PCD_FQID_START + dpaa_intf->fif->mac_idx *\n \t\t\t\tDPAA_PCD_FQID_MULTIPLIER + loop;\n \n \t\tif (dpaa_intf->cgr_rx)\ndiff --git a/drivers/net/dpaa/dpaa_ethdev.h b/drivers/net/dpaa/dpaa_ethdev.h\nindex c79b9f8..2c38c34 100644\n--- a/drivers/net/dpaa/dpaa_ethdev.h\n+++ b/drivers/net/dpaa/dpaa_ethdev.h\n@@ -63,7 +63,7 @@\n #define DPAA_PCD_FQID_START\t\t0x400\n #define DPAA_PCD_FQID_MULTIPLIER\t0x100\n #define DPAA_DEFAULT_NUM_PCD_QUEUES\t1\n-#define DPAA_MAX_NUM_PCD_QUEUES\t\t32\n+#define DPAA_MAX_NUM_PCD_QUEUES\t\t4\n \n #define DPAA_IF_TX_PRIORITY\t\t3\n #define DPAA_IF_RX_PRIORITY\t\t0\n", "prefixes": [ "v3", "01/13" ] }