Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/45039/?format=api
https://patches.dpdk.org/api/patches/45039/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1537451752-28759-2-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1537451752-28759-2-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1537451752-28759-2-git-send-email-arybchenko@solarflare.com", "date": "2018-09-20T13:55:49", "name": "[v2,1/4] app/testpmd: add queue deferred start switch", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "05c7ce2c157e406bff85f37fa8ed0733bf8abad8", "submitter": { "id": 607, "url": "https://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1537451752-28759-2-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 1422, "url": "https://patches.dpdk.org/api/series/1422/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=1422", "date": "2018-09-20T13:55:48", "name": "net/failsafe: support deferred queue start", "version": 2, "mbox": "https://patches.dpdk.org/series/1422/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/45039/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/45039/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 313ED6C9B;\n\tThu, 20 Sep 2018 15:56:40 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n\t[67.231.154.164]) by dpdk.org (Postfix) with ESMTP id E99695F2D\n\tfor <dev@dpdk.org>; Thu, 20 Sep 2018 15:56:32 +0200 (CEST)", "from webmail.solarflare.com (webmail.solarflare.com\n\t[12.187.104.26])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby mx1-us3.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with\n\tESMTPS id 02649B8007B; Thu, 20 Sep 2018 13:56:30 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1395.4; Thu, 20 Sep 2018 06:56:10 -0700", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1395.4 via Frontend Transport; Thu, 20 Sep 2018 06:56:10 -0700", "from ukv-loginhost.uk.solarflarecom.com\n\t(ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tw8KDu93x005362; Thu, 20 Sep 2018 14:56:09 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n\tby ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id\n\tD90801626D2; Thu, 20 Sep 2018 14:56:08 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "Gaetan Rivet <gaetan.rivet@6wind.com>", "CC": "<dev@dpdk.org>, Ian Dolzhansky <Ian.Dolzhansky@oktetlabs.ru>", "Date": "Thu, 20 Sep 2018 14:55:49 +0100", "Message-ID": "<1537451752-28759-2-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1537451752-28759-1-git-send-email-arybchenko@solarflare.com>", "References": "<1535526966-32456-1-git-send-email-arybchenko@solarflare.com>\n\t<1537451752-28759-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.5.1010-24106.004", "X-TM-AS-Result": "No-11.320800-4.000000-10", "X-TMASE-MatchedRID": "56itn3ZFAM/NwJnbTIxiVQPZZctd3P4B9DuzN5Up01uGAVmsKRo2NL6Y\n\tVRYkPkYC8oCFebEm/7+Vpex4dzu4rOVvZ9VZp3eETd1FGyH+HrKUi9wB9gmcSmFB1xLJwzNXSnR\n\tXN9MDu2rZoTly3PGW4J0llj2LKQVU+g3TEidc8f8MH4SsGvRsA85rFUwYWoZKZ5yuplze9ptWFs\n\tMQfbcNE8dKHsOqpWBlo89x5YISWbFkcSw7ximNlhes/RxhysDbfS0Ip2eEHnz3IzXlXlpamPoLR\n\t4+zsDTt/KO2LNTSuGNQW/s+auXH5ywIBfGfxMJByMUdsRVsTz5p7J+wntw7rQ==", "X-TM-AS-User-Approved-Sender": "No", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10--11.320800-4.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.5.1010-24106.004", "X-MDID": "1537451791-pfrKYnVbw2N0", "Subject": "[dpdk-dev] [PATCH v2 1/4] app/testpmd: add queue deferred start\n\tswitch", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Ian Dolzhansky <Ian.Dolzhansky@oktetlabs.ru>\n\nSigned-off-by: Ian Dolzhansky <Ian.Dolzhansky@oktetlabs.ru>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\nAcked-by: Gaetan Rivet <gaetan.rivet@6wind.com>\n---\n app/test-pmd/cmdline.c | 91 +++++++++++++++++++++\n doc/guides/rel_notes/release_18_11.rst | 8 ++\n doc/guides/testpmd_app_ug/testpmd_funcs.rst | 7 ++\n 3 files changed, 106 insertions(+)", "diff": "diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c\nindex 0cbd340c1..0c5399dc4 100644\n--- a/app/test-pmd/cmdline.c\n+++ b/app/test-pmd/cmdline.c\n@@ -883,6 +883,10 @@ static void cmd_help_long_parsed(void *parsed_result,\n \t\t\t\" Start/stop a rx/tx queue of port X. Only take effect\"\n \t\t\t\" when port X is started\\n\\n\"\n \n+\t\t\t\"port (port_id) (rxq|txq) (queue_id) deferred_start (on|off)\\n\"\n+\t\t\t\" Switch on/off a deferred start of port X rx/tx queue. Only\"\n+\t\t\t\" take effect when port X is stopped.\\n\\n\"\n+\n \t\t\t\"port (port_id) (rxq|txq) (queue_id) setup\\n\"\n \t\t\t\" Setup a rx/tx queue of port X.\\n\\n\"\n \n@@ -2439,6 +2443,92 @@ cmdline_parse_inst_t cmd_config_rxtx_queue = {\n \t},\n };\n \n+/* *** configure port rxq/txq deferred start on/off *** */\n+struct cmd_config_deferred_start_rxtx_queue {\n+\tcmdline_fixed_string_t port;\n+\tportid_t port_id;\n+\tcmdline_fixed_string_t rxtxq;\n+\tuint16_t qid;\n+\tcmdline_fixed_string_t opname;\n+\tcmdline_fixed_string_t state;\n+};\n+\n+static void\n+cmd_config_deferred_start_rxtx_queue_parsed(void *parsed_result,\n+\t\t\t__attribute__((unused)) struct cmdline *cl,\n+\t\t\t__attribute__((unused)) void *data)\n+{\n+\tstruct cmd_config_deferred_start_rxtx_queue *res = parsed_result;\n+\tstruct rte_port *port;\n+\tuint8_t isrx;\n+\tuint8_t ison;\n+\tuint8_t needreconfig = 0;\n+\n+\tif (port_id_is_invalid(res->port_id, ENABLED_WARN))\n+\t\treturn;\n+\n+\tif (port_is_started(res->port_id) != 0) {\n+\t\tprintf(\"Please stop port %u first\\n\", res->port_id);\n+\t\treturn;\n+\t}\n+\n+\tport = &ports[res->port_id];\n+\n+\tisrx = !strcmp(res->rxtxq, \"rxq\");\n+\n+\tif (isrx && rx_queue_id_is_invalid(res->qid))\n+\t\treturn;\n+\telse if (!isrx && tx_queue_id_is_invalid(res->qid))\n+\t\treturn;\n+\n+\tison = !strcmp(res->state, \"on\");\n+\n+\tif (isrx && port->rx_conf[res->qid].rx_deferred_start != ison) {\n+\t\tport->rx_conf[res->qid].rx_deferred_start = ison;\n+\t\tneedreconfig = 1;\n+\t} else if (!isrx && port->tx_conf[res->qid].tx_deferred_start != ison) {\n+\t\tport->tx_conf[res->qid].tx_deferred_start = ison;\n+\t\tneedreconfig = 1;\n+\t}\n+\n+\tif (needreconfig)\n+\t\tcmd_reconfig_device_queue(res->port_id, 0, 1);\n+}\n+\n+cmdline_parse_token_string_t cmd_config_deferred_start_rxtx_queue_port =\n+\tTOKEN_STRING_INITIALIZER(struct cmd_config_deferred_start_rxtx_queue,\n+\t\t\t\t\t\tport, \"port\");\n+cmdline_parse_token_num_t cmd_config_deferred_start_rxtx_queue_port_id =\n+\tTOKEN_NUM_INITIALIZER(struct cmd_config_deferred_start_rxtx_queue,\n+\t\t\t\t\t\tport_id, UINT16);\n+cmdline_parse_token_string_t cmd_config_deferred_start_rxtx_queue_rxtxq =\n+\tTOKEN_STRING_INITIALIZER(struct cmd_config_deferred_start_rxtx_queue,\n+\t\t\t\t\t\trxtxq, \"rxq#txq\");\n+cmdline_parse_token_num_t cmd_config_deferred_start_rxtx_queue_qid =\n+\tTOKEN_NUM_INITIALIZER(struct cmd_config_deferred_start_rxtx_queue,\n+\t\t\t\t\t\tqid, UINT16);\n+cmdline_parse_token_string_t cmd_config_deferred_start_rxtx_queue_opname =\n+\tTOKEN_STRING_INITIALIZER(struct cmd_config_deferred_start_rxtx_queue,\n+\t\t\t\t\t\topname, \"deferred_start\");\n+cmdline_parse_token_string_t cmd_config_deferred_start_rxtx_queue_state =\n+\tTOKEN_STRING_INITIALIZER(struct cmd_config_deferred_start_rxtx_queue,\n+\t\t\t\t\t\tstate, \"on#off\");\n+\n+cmdline_parse_inst_t cmd_config_deferred_start_rxtx_queue = {\n+\t.f = cmd_config_deferred_start_rxtx_queue_parsed,\n+\t.data = NULL,\n+\t.help_str = \"port <port_id> rxq|txq <queue_id> deferred_start on|off\",\n+\t.tokens = {\n+\t\t(void *)&cmd_config_deferred_start_rxtx_queue_port,\n+\t\t(void *)&cmd_config_deferred_start_rxtx_queue_port_id,\n+\t\t(void *)&cmd_config_deferred_start_rxtx_queue_rxtxq,\n+\t\t(void *)&cmd_config_deferred_start_rxtx_queue_qid,\n+\t\t(void *)&cmd_config_deferred_start_rxtx_queue_opname,\n+\t\t(void *)&cmd_config_deferred_start_rxtx_queue_state,\n+\t\tNULL,\n+\t},\n+};\n+\n /* *** configure port rxq/txq setup *** */\n struct cmd_setup_rxtx_queue {\n \tcmdline_fixed_string_t port;\n@@ -17709,6 +17799,7 @@ cmdline_parse_ctx_t main_ctx[] = {\n \t(cmdline_parse_inst_t *)&cmd_config_rss,\n \t(cmdline_parse_inst_t *)&cmd_config_rxtx_ring_size,\n \t(cmdline_parse_inst_t *)&cmd_config_rxtx_queue,\n+\t(cmdline_parse_inst_t *)&cmd_config_deferred_start_rxtx_queue,\n \t(cmdline_parse_inst_t *)&cmd_setup_rxtx_queue,\n \t(cmdline_parse_inst_t *)&cmd_config_rss_reta,\n \t(cmdline_parse_inst_t *)&cmd_showport_reta,\ndiff --git a/doc/guides/rel_notes/release_18_11.rst b/doc/guides/rel_notes/release_18_11.rst\nindex 219b0b1cf..e9f3a415c 100644\n--- a/doc/guides/rel_notes/release_18_11.rst\n+++ b/doc/guides/rel_notes/release_18_11.rst\n@@ -72,6 +72,14 @@ New Features\n choose the latest vector path that the platform supported. For example, users\n can use AVX2 vector path on BDW/HSW to get better performance.\n \n+* **Added ability to switch queue deferred start flag on testpmd app.**\n+\n+ Added a console command to testpmd app, giving ability to switch\n+ ``rx_deferred_start`` or ``tx_deferred_start`` flag of the specified queue of\n+ the specified port. The port must be stopped before the command call in order\n+ to reconfigure queues.\n+\n+\n API Changes\n -----------\n \ndiff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst\nindex dde205a2b..3a73000a6 100644\n--- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst\n+++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst\n@@ -1765,6 +1765,13 @@ Start/stop a rx/tx queue on a specific port::\n \n testpmd> port (port_id) (rxq|txq) (queue_id) (start|stop)\n \n+port config - queue deferred start\n+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n+\n+Switch on/off deferred start of a specific port queue::\n+\n+ testpmd> port (port_id) (rxq|txq) (queue_id) deferred_start (on|off)\n+\n port setup queue\n ~~~~~~~~~~~~~~~~~~~~~\n \n", "prefixes": [ "v2", "1/4" ] }{ "id": 45039, "url": "