Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/44982/?format=api
{ "id": 44982, "url": "https://patches.dpdk.org/api/patches/44982/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1537394318-17682-4-git-send-email-rasesh.mody@cavium.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1537394318-17682-4-git-send-email-rasesh.mody@cavium.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1537394318-17682-4-git-send-email-rasesh.mody@cavium.com", "date": "2018-09-19T21:59:43", "name": "[4/5] net/bnx2x: fix call to link handling periodic function", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "cf808ca72245d14b18cd5cd1bc0ef78013bb5e3a", "submitter": { "id": 569, "url": "https://patches.dpdk.org/api/people/569/?format=api", "name": "Mody, Rasesh", "email": "rasesh.mody@cavium.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1537394318-17682-4-git-send-email-rasesh.mody@cavium.com/mbox/", "series": [ { "id": 1402, "url": "https://patches.dpdk.org/api/series/1402/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=1402", "date": "2018-09-19T21:59:05", "name": "[1/5] net/bnx2x: fix logging to include dev name", "version": 1, "mbox": "https://patches.dpdk.org/series/1402/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/44982/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/44982/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 189D81B143;\n\tWed, 19 Sep 2018 23:59:49 +0200 (CEST)", "from NAM02-BL2-obe.outbound.protection.outlook.com\n\t(mail-bl2nam02on0046.outbound.protection.outlook.com [104.47.38.46])\n\tby dpdk.org (Postfix) with ESMTP id 5E0971B121;\n\tWed, 19 Sep 2018 23:59:45 +0200 (CEST)", "from BYAPR07MB5365.namprd07.prod.outlook.com (20.177.125.18) by\n\tBYAPR07MB5703.namprd07.prod.outlook.com (20.178.0.29) with Microsoft\n\tSMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.1143.17; Wed, 19 Sep 2018 21:59:43 +0000", "from BYAPR07MB5365.namprd07.prod.outlook.com\n\t([fe80::2047:9647:f196:bde0]) by\n\tBYAPR07MB5365.namprd07.prod.outlook.com\n\t([fe80::2047:9647:f196:bde0%6]) with mapi id 15.20.1143.017;\n\tWed, 19 Sep 2018 21:59:43 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=EKulMzUJUGfCraF6IlsblwUXhwy7oksrMqZ/8f0E+pU=;\n\tb=SfO5AVeJ056CETISxDXIBDJmKeQp8WVYxMDISweCX7qLWDTMF5/0m05UFG7jmnWhGbMaQbLsq47hyPYqgsJ0EjsnosRwhO9Os+0/Re3VPKhTSrGsW9keY9loKO9GOI2+Y0UVVE+QXg3bfS1uniEkQAWiRSUZa5ZjWNFDIzi+Nk4=", "From": "\"Mody, Rasesh\" <Rasesh.Mody@cavium.com>", "To": "\"dev@dpdk.org\" <dev@dpdk.org>", "CC": "\"Mody, Rasesh\" <Rasesh.Mody@cavium.com>, \"ferruh.yigit@intel.com\"\n\t<ferruh.yigit@intel.com>,\n\tDept-Eng DPDK Dev <Dept-EngDPDKDev@cavium.com>, \n\t\"stable@dpdk.org\" <stable@dpdk.org>", "Thread-Topic": "[PATCH 4/5] net/bnx2x: fix call to link handling periodic\n\tfunction", "Thread-Index": "AQHUUGQSKl0z19/awEGd3qyIkgrM2g==", "Date": "Wed, 19 Sep 2018 21:59:43 +0000", "Message-ID": "<1537394318-17682-4-git-send-email-rasesh.mody@cavium.com>", "References": "<1537394318-17682-1-git-send-email-rasesh.mody@cavium.com>", "In-Reply-To": "<1537394318-17682-1-git-send-email-rasesh.mody@cavium.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-clientproxiedby": "BYAPR04CA0003.namprd04.prod.outlook.com\n\t(2603:10b6:a03:40::16) To BYAPR07MB5365.namprd07.prod.outlook.com\n\t(2603:10b6:a03:64::18)", "authentication-results": "spf=none (sender IP is )\n\tsmtp.mailfrom=Rasesh.Mody@cavium.com; ", "x-ms-exchange-messagesentrepresentingtype": "1", "x-originating-ip": "[198.186.1.5]", "x-ms-publictraffictype": "Email", "x-microsoft-exchange-diagnostics": "1; BYAPR07MB5703;\n\t6:TOC4+VzF/bnV25D1R4kKhwTWnfC1sjT4ZyI2mOpH1Ac4Nr49Q/2E0JNxgiRnRGVpmqJeU0aNYnlztjjB+Z5egG9xTxCLGB0aiNWYBWbGukH0WgxS2xOvTbnxlK2HaXfGUK7depgn5edWMnBr0jEOKg+po4yOUzpctuOOaqdEBY+dTO9q4TvZhR6Xx7hzqhUKAWF1ICs41pVde7SQWr75gAg6Nd3i84Djimz2x9943kBhazhS/2GvJPnGSFaNcqpOeRJWRLFM5rA/W92MbwKije+oix1InlLnqdM2I2cJUj1zdVcEC08YNjX2e1hZIW4foU88FcIpqAbSDyu6lrfz+Yu5KWbNOYx3QcqjpEHB68OU30icrTsIHrP0u4ZK5l6yJq2NYedWAqc/ymIlnYbrz2XHoPoWknjHdQtXHc0E/434c0A8znf7RkHY35Wm4WX8HaNXMJOiYf7droBeObRo8Q==;\n\t5:u3NahLG54yIWeMuoIGOguDhB5P4sP4iymlEE2OzOxZ2MObnG6ejRFQ46NtrJZgR2N/4GSdjbKHAdScLrYVibUnpFFnh9KKOwsMP74P2HGdXYVI8n3MjHd3L/d8f9k1jTcbK+otk2NmTbXwssTDCwGfqevaP7jOvLDVFJnJyjEcw=;\n\t7:RjKNRzIwGGCJ7Jyg6HvuOZjRpK7FZb8f3/Oayi31A5rOWynxg3EzK3bhR13Lz7icn7gEN0FxT+esfN2HQdUTuav/Zr5gued4+yDvstH38pSSc0ypboyMQi5Q0Ep/Ix+p77pAnc5glqh/2XB/3qgOuPmR2iKWhokJTmzZyaIp4x0xi7Io2488IPEHLVFKtfbBaV2ttzlgooE+11t0s9C1r2EvoVV3yyMdmsfaRObbuTKoKd3H7JhPnZEgQc5jnUBb", "x-ms-office365-filtering-correlation-id": "634a9082-5d02-4366-3c47-08d61e7b3461", "x-microsoft-antispam": "BCL:0; PCL:0;\n\tRULEID:(7020095)(4652040)(8989299)(4534165)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020);\n\tSRVR:BYAPR07MB5703; ", "x-ms-traffictypediagnostic": "BYAPR07MB5703:", "x-microsoft-antispam-prvs": "<BYAPR07MB570322E1780B0E03A9139B539F1C0@BYAPR07MB5703.namprd07.prod.outlook.com>", "x-exchange-antispam-report-test": "UriScan:;", "x-ms-exchange-senderadcheck": "1", "x-exchange-antispam-report-cfa-test": "BCL:0; PCL:0;\n\tRULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(823301075)(3231355)(944501410)(52105095)(93006095)(93001095)(3002001)(10201501046)(149027)(150027)(6041310)(20161123564045)(20161123558120)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(201708071742011)(7699051);\n\tSRVR:BYAPR07MB5703; BCL:0; PCL:0; RULEID:; SRVR:BYAPR07MB5703; ", "x-forefront-prvs": "0800C0C167", "x-forefront-antispam-report": "SFV:NSPM;\n\tSFS:(10009020)(1496009)(346002)(136003)(396003)(376002)(39850400004)(366004)(189003)(199004)(446003)(5660300001)(76176011)(2351001)(6486002)(7736002)(6116002)(6436002)(3846002)(99286004)(54906003)(6916009)(11346002)(476003)(486006)(105586002)(2616005)(478600001)(5640700003)(106356001)(305945005)(6512007)(97736004)(66066001)(52116002)(53936002)(2906002)(256004)(316002)(4326008)(2501003)(102836004)(2900100001)(81156014)(386003)(86362001)(81166006)(5250100002)(26005)(36756003)(8676002)(72206003)(68736007)(8936002)(25786009)(1730700003)(14454004)(186003)(6506007);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR07MB5703;\n\tH:BYAPR07MB5365.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en;\n\tPTR:InfoNoRecords; MX:1; A:1; ", "received-spf": "None (protection.outlook.com: cavium.com does not designate\n\tpermitted sender hosts)", "x-microsoft-antispam-message-info": "9GL30RN6nEie0zfoI6u6ierCLBTMns9LeIyoNnjzlPR2UoYLaNYh/JU1lm7oUvoAZJnulMdX1EtOfGSYS9JdbA5GEB4qdwDOawdaRau5WQ4q2gVvQUbt7nks8qSXbbCW1M9jK4qd3L87KxOuvfgKYE2HaZbBf6WsBDshStAyiE+J4jCLh96dgDDuGr2A5pGHE2zoCyP76kx16J7U4PV66QPcOQa2HYK6yc19gHKbYWVccR28q5+pEtgLFv1eYJEDKniyKlyI0USQZrtyBMvG304RMyEkyiRPTQeEQzLuKlRTSAD4JMHbgCWVBCfcfslVVV8MrE+LUdtFDECJ9TVDAi7euc2pA0Belit8g5AZNi0=", "spamdiagnosticoutput": "1:99", "spamdiagnosticmetadata": "NSPM", "Content-Type": "text/plain; charset=\"iso-8859-1\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-OriginatorOrg": "cavium.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "634a9082-5d02-4366-3c47-08d61e7b3461", "X-MS-Exchange-CrossTenant-originalarrivaltime": "19 Sep 2018 21:59:43.2405\n\t(UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "711e4ccf-2e9b-4bcf-a551-4094005b6194", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "BYAPR07MB5703", "Subject": "[dpdk-dev] [PATCH 4/5] net/bnx2x: fix call to link handling\n\tperiodic function", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "If link handling periodic function is allowed to be called in interrupt\ncontext, the periodic function can get called too frequently and exhaust\nthe retry credits to check link status.\n\nThis change makes sure link handling periodic function is not called in\ninterrupt context.\n\nFixes: 540a211084a7 (\"bnx2x: driver core\")\nCc: stable@dpdk.org\n\nSigned-off-by: Rasesh Mody <rasesh.mody@cavium.com>\n---\n drivers/net/bnx2x/bnx2x_ethdev.c | 2 ++\n 1 file changed, 2 insertions(+)", "diff": "diff --git a/drivers/net/bnx2x/bnx2x_ethdev.c b/drivers/net/bnx2x/bnx2x_ethdev.c\nindex ae2e60a..0057843 100644\n--- a/drivers/net/bnx2x/bnx2x_ethdev.c\n+++ b/drivers/net/bnx2x/bnx2x_ethdev.c\n@@ -131,7 +131,9 @@ struct rte_bnx2x_xstats_name_off {\n \n \tPMD_DEBUG_PERIODIC_LOG(INFO, sc, \"Interrupt handled\");\n \n+\tatomic_store_rel_long(&sc->periodic_flags, PERIODIC_STOP);\n \tbnx2x_interrupt_action(dev);\n+\tatomic_store_rel_long(&sc->periodic_flags, PERIODIC_GO);\n \trte_intr_enable(&sc->pci_dev->intr_handle);\n }\n \n", "prefixes": [ "4/5" ] }