Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 44973,
    "url": "https://patches.dpdk.org/api/patches/44973/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20180919121027.57857295@xeon-e3/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20180919121027.57857295@xeon-e3>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20180919121027.57857295@xeon-e3",
    "date": "2018-09-19T19:10:27",
    "name": "vhost memory hotplug deadlock",
    "commit_ref": null,
    "pull_url": null,
    "state": "rejected",
    "archived": true,
    "hash": "9ec86c02082012c85516729064472f7a8b8ad97e",
    "submitter": {
        "id": 27,
        "url": "https://patches.dpdk.org/api/people/27/?format=api",
        "name": "Stephen Hemminger",
        "email": "stephen@networkplumber.org"
    },
    "delegate": {
        "id": 2642,
        "url": "https://patches.dpdk.org/api/users/2642/?format=api",
        "username": "mcoquelin",
        "first_name": "Maxime",
        "last_name": "Coquelin",
        "email": "maxime.coquelin@redhat.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20180919121027.57857295@xeon-e3/mbox/",
    "series": [
        {
            "id": 1400,
            "url": "https://patches.dpdk.org/api/series/1400/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=1400",
            "date": "2018-09-19T19:10:27",
            "name": "vhost memory hotplug deadlock",
            "version": 1,
            "mbox": "https://patches.dpdk.org/series/1400/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/44973/comments/",
    "check": "fail",
    "checks": "https://patches.dpdk.org/api/patches/44973/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 74C841B118;\n\tWed, 19 Sep 2018 21:10:36 +0200 (CEST)",
            "from mail-pf1-f182.google.com (mail-pf1-f182.google.com\n\t[209.85.210.182]) by dpdk.org (Postfix) with ESMTP id 6FCB01B114\n\tfor <dev@dpdk.org>; Wed, 19 Sep 2018 21:10:35 +0200 (CEST)",
            "by mail-pf1-f182.google.com with SMTP id k21-v6so3134499pff.11\n\tfor <dev@dpdk.org>; Wed, 19 Sep 2018 12:10:35 -0700 (PDT)",
            "from xeon-e3 (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\t8-v6sm25501646pgu.10.2018.09.19.12.10.34 for <dev@dpdk.org>\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tWed, 19 Sep 2018 12:10:34 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:subject:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=2xwY7afSn0C9YHaRr/n8PCrj5SkSVldpZUr9VUyh1Go=;\n\tb=tw1ixa58zkYzFRMLdaIVzX4SyxxVkxW0OR7JoKn1uK+c50ckR5peTzDIlb2yfeO7gJ\n\tvAvzo2DD4UDVMgzcK4ienn+7JSSOBa1u5kF6mgTE6Ra5J2tGG2Zbqyoopk4u3eRJuBw3\n\tAWYGWovhsrub69bsgzYufRNddq4JXkgTNq5iLqZfX8ViTrZV+YoNyGl9dLrWfPLZm3Er\n\tOr95Yyz8JTxyxN7+KgT520V1/YHsNuD6nK3XxwIvsaoF1mG9r3iuEeJV2ZhDl3GBb0pW\n\tD8XiAnAgqzbl8valj41R3BsWwvn/eO9A/bSlEpHu4k5QObpSyJ4b5LQ1tOZRgsLTogzK\n\tTDbg==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:subject:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=2xwY7afSn0C9YHaRr/n8PCrj5SkSVldpZUr9VUyh1Go=;\n\tb=o0neW83+35rWBWdnHOyE3V/cWQQa1wcZD/vKTZ4bARDXm41sQiL1DeLfqNypi9BVJ3\n\tOYCVu0Ixcx70L62ZzCjnPwVbjMC8uEdiBVWTTxb5kLIhurtxWlmJ1kIv3RRy7ZudJCpQ\n\thdOl0+E5R8T2d1T49dVU5hPoCxxRL7jwlC0s4XrJky/rvfoIEKWdoUk87d/BMNFUtSkv\n\tcmBWBZQt1dd5GXW39ZM/sOtYPY45unF7PSG0s7WlP9Mhr/fRCrWrISqcvRfRyCAp0Gjm\n\t5K0QRWpiOnXOn96Xt0B//ffusytMvIRzGpz6bqn+5/Fpzip7zADw0Z5/sb+7Fc649kUh\n\tgCIA==",
        "X-Gm-Message-State": "APzg51BYKqYJJdgSWKA/VCX3fpvZyUz4uw+oh7BSeK+ZGOUSnRraimip\n\tlFig9Ziyg8aXA/24QOTRaBpgVfbZLNA=",
        "X-Google-Smtp-Source": "ANB0VdazmE1iP5bPcSIF4cN+J1ig2ZxddFH9OL35Y2Kp7v3JE6SxBq3WSvvlo7A5eKrCXu3ZurWDew==",
        "X-Received": "by 2002:a63:f043:: with SMTP id\n\ts3-v6mr30253791pgj.94.1537384234330; \n\tWed, 19 Sep 2018 12:10:34 -0700 (PDT)",
        "Date": "Wed, 19 Sep 2018 12:10:27 -0700",
        "From": "Stephen Hemminger <stephen@networkplumber.org>",
        "To": "dev@dpdk.org",
        "Message-ID": "<20180919121027.57857295@xeon-e3>",
        "MIME-Version": "1.0",
        "Content-Type": "text/plain; charset=US-ASCII",
        "Content-Transfer-Encoding": "7bit",
        "Subject": "[dpdk-dev] vhost memory hotplug deadlock",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "The Vhost memory handling will self deadlock.\n\nThe sequence is:\n\trte_zmalloc\n\t\tmalloc_heap_alloc\n\t\t\theap_alloc_on_socket\n\t\t\t\talloc_more_mem_on_socket\n\t\t\t\t\ttry_expand_heap_primary\n\nAcquires memory_hotplug_lock for write\n\n\teal_memalloc_mem_event_notify\n\t\tvhost_user_mem_event_cb\n\t\t\tvhost_kernel_ioctl\n\t\t\t\trte_memseg_contig_walk\n\nDeadlocks acquiring memory_hotplug_lock for read\n\nThe following may fix it.",
    "diff": "diff --git a/drivers/net/virtio/virtio_user/vhost_kernel.c b/drivers/net/virtio/virtio_user/vhost_kernel.c\nindex d1be82162609..549235df0ca2 100644\n--- a/drivers/net/virtio/virtio_user/vhost_kernel.c\n+++ b/drivers/net/virtio/virtio_user/vhost_kernel.c\n@@ -115,7 +115,8 @@ prepare_vhost_memory_kernel(void)\n        wa.region_nr = 0;\n        wa.vm = vm;\n \n-       if (rte_memseg_contig_walk(add_memory_region, &wa) < 0) {\n+       /* memory_hotplug_lock already held  */\n+       if (rte_memseg_contig_walk_thread_unsafe(add_memory_region, &wa) < 0) {\n                free(vm);\n                return NULL;\n        }\n",
    "prefixes": []
}