Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/44970/?format=api
{ "id": 44970, "url": "https://patches.dpdk.org/api/patches/44970/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/af5ac3f6c87f60c958388a9cdd75c2ce4a70de93.1537372746.git.gaetan.rivet@6wind.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<af5ac3f6c87f60c958388a9cdd75c2ce4a70de93.1537372746.git.gaetan.rivet@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/af5ac3f6c87f60c958388a9cdd75c2ce4a70de93.1537372746.git.gaetan.rivet@6wind.com", "date": "2018-09-19T16:03:43", "name": "[v2,13/13] eal: add generic dev parameter", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "edbce61d7fffcecb6cdb29940fa0104f8819c3ba", "submitter": { "id": 269, "url": "https://patches.dpdk.org/api/people/269/?format=api", "name": "Gaëtan Rivet", "email": "gaetan.rivet@6wind.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/af5ac3f6c87f60c958388a9cdd75c2ce4a70de93.1537372746.git.gaetan.rivet@6wind.com/mbox/", "series": [ { "id": 1397, "url": "https://patches.dpdk.org/api/series/1397/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=1397", "date": "2018-09-19T16:03:30", "name": "Implement new devargs framework", "version": 2, "mbox": "https://patches.dpdk.org/series/1397/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/44970/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/44970/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 7BD8A7CDC;\n\tWed, 19 Sep 2018 18:04:32 +0200 (CEST)", "from mail-wr1-f66.google.com (mail-wr1-f66.google.com\n\t[209.85.221.66]) by dpdk.org (Postfix) with ESMTP id 521BD5B3A\n\tfor <dev@dpdk.org>; Wed, 19 Sep 2018 18:04:18 +0200 (CEST)", "by mail-wr1-f66.google.com with SMTP id g33-v6so6403245wrd.1\n\tfor <dev@dpdk.org>; Wed, 19 Sep 2018 09:04:18 -0700 (PDT)", "from bidouze.dev.6wind.com. (host.78.145.23.62.rev.coltfrance.com.\n\t[62.23.145.78]) by smtp.gmail.com with ESMTPSA id\n\tx24-v6sm34983671wrd.13.2018.09.19.09.04.16\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 19 Sep 2018 09:04:16 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=9n/liH3PJLh2eeKwIDG92wTMMNTl7wZomtkWeSppUWY=;\n\tb=gbHyEXITxWxJdhKq2zUPPSnWkbLT6BIse0uctBK3U/22lK5WCKwAkZ27qP9Mu+jFtQ\n\tc7y81wA9C1UPBP0r817t8ACShg6vZ+lgYKDdVOz73qENv4KuSwnIyYiE6loW3rHkKZ81\n\tQ+BygxlsZTtRoJuKxZd9tkQF4uLN221aO8UCg+Bqrwsrl5rqbLm3Quz6ib+w/61QIK9w\n\thMdJUR84/xhqP1J2CdkSWcGRvaj43sMzu2V/nGDOMVHTOLY3TGlqjfqdZbu+oUnrH8Z1\n\tAQMBeN9yj7hJggktnRuPnFWyYi4uNVlHCgfLj2eHEIxd61ydEIm1TIxYq3Qx8zKgYglj\n\tOpaQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=9n/liH3PJLh2eeKwIDG92wTMMNTl7wZomtkWeSppUWY=;\n\tb=iMdr+kazzTxQeeMm9vGgErW8SnIY/H/Fmb8zImoEn8uWq1hmk/hSx5Ofo3mAT6talk\n\tpu+mmXr1pOEEOqJND+FqEnMBUI3wziEOL0GM7ePONK/5700UGP+lVXUPmYLEk4Z4AD2L\n\tTJXArsTh7IH5SgKj0NOnYEyYbrVnrJpE0pa7yrjx+nh4NtpygkhMsbuyxVKzlZ4xMAmY\n\tV1zQSniLMlREEJBDq+Fma71r3uLCtavaymi7thi1sYDbG8ZFKv85C9yT2EZjtQlMjUnw\n\tVQwuLhTG2roQ2a07l/5BjtPxABNM2xeaYFAgvynhIvDy3HtVQnEND8b2T4wNfodWmin2\n\tY+/w==", "X-Gm-Message-State": "APzg51A0wahoZuzK3or/t0jQAqp1c37ON6VL4bg39zvRwp16d9SKHQS1\n\tfKQstaZpHcAuqSE/WNdCAf3h6qV6znI=", "X-Google-Smtp-Source": "ANB0VdaIkRkkLW5i64IvPF6B6FH8uXiutL9WWQailRJSSjfZkXDR1JYlN2/BSgq8CQ3dfRgK/QaRyg==", "X-Received": "by 2002:adf:8445:: with SMTP id\n\t63-v6mr29875618wrf.41.1537373057539; \n\tWed, 19 Sep 2018 09:04:17 -0700 (PDT)", "From": "Gaetan Rivet <gaetan.rivet@6wind.com>", "To": "dev@dpdk.org", "Cc": "Gaetan Rivet <gaetan.rivet@6wind.com>", "Date": "Wed, 19 Sep 2018 18:03:43 +0200", "Message-Id": "<af5ac3f6c87f60c958388a9cdd75c2ce4a70de93.1537372746.git.gaetan.rivet@6wind.com>", "X-Mailer": "git-send-email 2.18.0", "In-Reply-To": "<cover.1537372746.git.gaetan.rivet@6wind.com>", "References": "<cover.1537372746.git.gaetan.rivet@6wind.com>", "Subject": "[dpdk-dev] [PATCH v2 13/13] eal: add generic dev parameter", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add the --dev parameter to the EAL.\nThis new parameter takes a generic device declaration as argument.\n\nIt uses the new devargs parsing API.\n\nSigned-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>\n---\n lib/librte_eal/common/eal_common_devargs.c | 4 +++\n lib/librte_eal/common/eal_common_options.c | 36 +++++++++++++++++++---\n lib/librte_eal/common/eal_options.h | 2 ++\n 3 files changed, 37 insertions(+), 5 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/eal_common_devargs.c b/lib/librte_eal/common/eal_common_devargs.c\nindex dac2402a4..f1f4628db 100644\n--- a/lib/librte_eal/common/eal_common_devargs.c\n+++ b/lib/librte_eal/common/eal_common_devargs.c\n@@ -219,6 +219,10 @@ rte_devargs_parse(struct rte_devargs *da, const char *dev)\n \tif (da == NULL)\n \t\treturn -EINVAL;\n \n+\tif (strncmp(dev, \"bus=\", 4) == 0 ||\n+\t strncmp(dev, \"class=\", 6) == 0)\n+\t\treturn rte_devargs_layers_parse(da, dev);\n+\n \t/* Retrieve eventual bus info */\n \tdo {\n \t\tdevname = dev;\ndiff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c\nindex ddd624110..703932a30 100644\n--- a/lib/librte_eal/common/eal_common_options.c\n+++ b/lib/librte_eal/common/eal_common_options.c\n@@ -54,6 +54,7 @@ const struct option\n eal_long_options[] = {\n \t{OPT_BASE_VIRTADDR, 1, NULL, OPT_BASE_VIRTADDR_NUM },\n \t{OPT_CREATE_UIO_DEV, 0, NULL, OPT_CREATE_UIO_DEV_NUM },\n+\t{OPT_DEV, 1, NULL, OPT_DEV_NUM },\n \t{OPT_FILE_PREFIX, 1, NULL, OPT_FILE_PREFIX_NUM },\n \t{OPT_HELP, 0, NULL, OPT_HELP_NUM },\n \t{OPT_HUGE_DIR, 1, NULL, OPT_HUGE_DIR_NUM },\n@@ -111,6 +112,7 @@ TAILQ_HEAD(device_option_list, device_option);\n struct device_option {\n \tTAILQ_ENTRY(device_option) next;\n \n+\tint new;\n \tenum rte_devtype type;\n \tchar arg[];\n };\n@@ -123,7 +125,8 @@ static int mem_parsed;\n static int core_parsed;\n \n static int\n-eal_option_device_add(enum rte_devtype type, const char *optarg)\n+eal_option_device_add(enum rte_devtype type, const char *optarg,\n+\t\t int new)\n {\n \tstruct device_option *devopt;\n \tsize_t optlen;\n@@ -137,6 +140,7 @@ eal_option_device_add(enum rte_devtype type, const char *optarg)\n \t}\n \n \tdevopt->type = type;\n+\tdevopt->new = new;\n \tret = snprintf(devopt->arg, optlen, \"%s\", optarg);\n \tif (ret < 0) {\n \t\tRTE_LOG(ERR, EAL, \"Unable to copy device option\\n\");\n@@ -156,7 +160,22 @@ eal_option_device_parse(void)\n \n \tTAILQ_FOREACH_SAFE(devopt, &devopt_list, next, tmp) {\n \t\tif (ret == 0) {\n-\t\t\tret = rte_devargs_add(devopt->type, devopt->arg);\n+\t\t\tif (devopt->new) {\n+\t\t\t\tstruct rte_devargs *da;\n+\n+\t\t\t\tda = calloc(1, sizeof(*da));\n+\t\t\t\tret = rte_devargs_parse(da, devopt->arg);\n+\t\t\t\tif (ret) {\n+\t\t\t\t\tfree(da);\n+\t\t\t\t} else {\n+\t\t\t\t\tret = rte_devargs_insert(da);\n+\t\t\t\t\tif (ret)\n+\t\t\t\t\t\tfree(da);\n+\t\t\t\t}\n+\t\t\t} else {\n+\t\t\t\tret = rte_devargs_add(devopt->type,\n+\t\t\t\t\t\t devopt->arg);\n+\t\t\t}\n \t\t\tif (ret)\n \t\t\t\tRTE_LOG(ERR, EAL, \"Unable to parse device '%s'\\n\",\n \t\t\t\t\tdevopt->arg);\n@@ -1088,7 +1107,7 @@ eal_parse_common_option(int opt, const char *optarg,\n \t\tif (w_used)\n \t\t\tgoto bw_used;\n \t\tif (eal_option_device_add(RTE_DEVTYPE_BLACKLISTED_PCI,\n-\t\t\t\toptarg) < 0) {\n+\t\t\t\toptarg, 0) < 0) {\n \t\t\treturn -1;\n \t\t}\n \t\tb_used = 1;\n@@ -1098,7 +1117,7 @@ eal_parse_common_option(int opt, const char *optarg,\n \t\tif (b_used)\n \t\t\tgoto bw_used;\n \t\tif (eal_option_device_add(RTE_DEVTYPE_WHITELISTED_PCI,\n-\t\t\t\toptarg) < 0) {\n+\t\t\t\toptarg, 0) < 0) {\n \t\t\treturn -1;\n \t\t}\n \t\tw_used = 1;\n@@ -1234,9 +1253,16 @@ eal_parse_common_option(int opt, const char *optarg,\n \t\t}\n \t\tbreak;\n \n+\tcase OPT_DEV_NUM:\n+\t\t/* devtype is meaningless in the new format. */\n+\t\tif (eal_option_device_add(0, optarg, 1) < 0) {\n+\t\t\treturn -1;\n+\t\t}\n+\t\tbreak;\n+\n \tcase OPT_VDEV_NUM:\n \t\tif (eal_option_device_add(RTE_DEVTYPE_VIRTUAL,\n-\t\t\t\toptarg) < 0) {\n+\t\t\t\toptarg, 0) < 0) {\n \t\t\treturn -1;\n \t\t}\n \t\tbreak;\ndiff --git a/lib/librte_eal/common/eal_options.h b/lib/librte_eal/common/eal_options.h\nindex 96e166787..8a17eb22c 100644\n--- a/lib/librte_eal/common/eal_options.h\n+++ b/lib/librte_eal/common/eal_options.h\n@@ -21,6 +21,8 @@ enum {\n \tOPT_BASE_VIRTADDR_NUM,\n #define OPT_CREATE_UIO_DEV \"create-uio-dev\"\n \tOPT_CREATE_UIO_DEV_NUM,\n+#define OPT_DEV \"dev\"\n+\tOPT_DEV_NUM,\n #define OPT_FILE_PREFIX \"file-prefix\"\n \tOPT_FILE_PREFIX_NUM,\n #define OPT_HUGE_DIR \"huge-dir\"\n", "prefixes": [ "v2", "13/13" ] }