Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/44969/?format=api
{ "id": 44969, "url": "https://patches.dpdk.org/api/patches/44969/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/52d2e15926c5c190cb9e98e1b462b3e1e2057842.1537372746.git.gaetan.rivet@6wind.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<52d2e15926c5c190cb9e98e1b462b3e1e2057842.1537372746.git.gaetan.rivet@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/52d2e15926c5c190cb9e98e1b462b3e1e2057842.1537372746.git.gaetan.rivet@6wind.com", "date": "2018-09-19T16:03:42", "name": "[v2,12/13] ethdev: process declarative eth devargs", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a7af31b45349e84254c7b20f8fe43fc46d68b6ae", "submitter": { "id": 269, "url": "https://patches.dpdk.org/api/people/269/?format=api", "name": "Gaëtan Rivet", "email": "gaetan.rivet@6wind.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/52d2e15926c5c190cb9e98e1b462b3e1e2057842.1537372746.git.gaetan.rivet@6wind.com/mbox/", "series": [ { "id": 1397, "url": "https://patches.dpdk.org/api/series/1397/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=1397", "date": "2018-09-19T16:03:30", "name": "Implement new devargs framework", "version": 2, "mbox": "https://patches.dpdk.org/series/1397/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/44969/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/44969/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 31F556CC3;\n\tWed, 19 Sep 2018 18:04:31 +0200 (CEST)", "from mail-wm1-f52.google.com (mail-wm1-f52.google.com\n\t[209.85.128.52]) by dpdk.org (Postfix) with ESMTP id 699575B36\n\tfor <dev@dpdk.org>; Wed, 19 Sep 2018 18:04:17 +0200 (CEST)", "by mail-wm1-f52.google.com with SMTP id n11-v6so7585271wmc.2\n\tfor <dev@dpdk.org>; Wed, 19 Sep 2018 09:04:17 -0700 (PDT)", "from bidouze.dev.6wind.com. (host.78.145.23.62.rev.coltfrance.com.\n\t[62.23.145.78]) by smtp.gmail.com with ESMTPSA id\n\tx24-v6sm34983671wrd.13.2018.09.19.09.04.15\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 19 Sep 2018 09:04:15 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=16Hb8UovXCHR9FohgrgsJxW0jLcJyIzOgFOiPw0BzW0=;\n\tb=GooncoIKzlmsjpRuhK9ifx77IT8N7Gn+9Scf1VcSEQc0QT7sMFoCElsT7rNs2oJhT8\n\tBZr4I/tFlms7OlfWp2swPTzlssoqyRNxGJtE3V31KY+jzeoPAON+nbzKA0TeH+1jphxG\n\tU//2iwZ9vkoVeV/FGt8lIJurirsAEGD9C1Aj3wPenHOkzhP6T9nX0B1rYx7TR+Y21Sbu\n\tPTyAPcttMESdAiWrNSX2ZN1zBG7AwI+PSyy/Od5PeeUaR9ANQ6dPzCVfixIg7hftaPy6\n\tpPdFG2DQuEesWD/+cLdvoI20AnRfMmWxkVj29doQ4V/CZYxeuenLiKKs6auX5/yFjIp0\n\tnPGA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=16Hb8UovXCHR9FohgrgsJxW0jLcJyIzOgFOiPw0BzW0=;\n\tb=e02svKTjX/Jwz2k3MamlzZXxwICp1jjfn74bntII/axzywGnOCVMP2byiqseVQvFZ4\n\tebfu6ozNZUgnprI6aXbVn777aLt9vAyM+xGuQ8f5r8DMfm9ynjBgTutfeLl/jHM88b5u\n\tJkQ5quz7vxUoASA+DGcp0q69P221Y2YFdnzphvlxJD3oYHA+Dn2yypvP2KVrEBxNwhmd\n\t7doPCvO2295BL9ljBqWJ/dz9lz5qfmF5qFP2PVBU63OCWyWNulRpiG+M1v6ACC0t9Zzf\n\t+KHmY8gQY+U2uOKhFz33xd8WLhZtYH7ODRhj+/MMoFcNV/BPIj9U/hUKDj8/vBcylsb1\n\tIMng==", "X-Gm-Message-State": "APzg51B0WiZcgZPqQb0vJYQVlokZkorj2hiXIjGqV5C9zWCJddW8BEMR\n\tXzoKlY7vmbp8DpKJj+0qtEilQAy0cbc=", "X-Google-Smtp-Source": "ANB0VdaZJGNle6aly2A+tyV7+kg+rfDZiTG2iVUBdUIROh+++RKs3V6TjQHtIL4wUHVHgXkZVY2cUQ==", "X-Received": "by 2002:a1c:501:: with SMTP id\n\t1-v6mr20834864wmf.140.1537373056596; \n\tWed, 19 Sep 2018 09:04:16 -0700 (PDT)", "From": "Gaetan Rivet <gaetan.rivet@6wind.com>", "To": "dev@dpdk.org", "Cc": "Gaetan Rivet <gaetan.rivet@6wind.com>", "Date": "Wed, 19 Sep 2018 18:03:42 +0200", "Message-Id": "<52d2e15926c5c190cb9e98e1b462b3e1e2057842.1537372746.git.gaetan.rivet@6wind.com>", "X-Mailer": "git-send-email 2.18.0", "In-Reply-To": "<cover.1537372746.git.gaetan.rivet@6wind.com>", "References": "<cover.1537372746.git.gaetan.rivet@6wind.com>", "Subject": "[dpdk-dev] [PATCH v2 12/13] ethdev: process declarative eth devargs", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Process the eth parameters of a devargs.\nFor each parameters that have a setter implemented,\nthe relevant field in rte_eth_dev field is written.\n\nCurrently only \"name\" is implemented.\n\nSigned-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>\n---\n lib/librte_ethdev/ethdev_private.h | 5 +++\n lib/librte_ethdev/rte_class_eth.c | 72 ++++++++++++++++++++++++++++++\n lib/librte_ethdev/rte_ethdev.c | 7 +++\n 3 files changed, 84 insertions(+)", "diff": "diff --git a/lib/librte_ethdev/ethdev_private.h b/lib/librte_ethdev/ethdev_private.h\nindex 0f5c6d5c4..c0c065165 100644\n--- a/lib/librte_ethdev/ethdev_private.h\n+++ b/lib/librte_ethdev/ethdev_private.h\n@@ -19,6 +19,11 @@ struct rte_eth_dev *\n eth_find_device(const struct rte_eth_dev *_start, rte_eth_cmp_t cmp,\n \t\tconst void *data);\n \n+/* Generic rte_eth_dev parameters processor. */\n+int\n+rte_eth_dev_args_parse(struct rte_eth_dev *eth_dev,\n+\t\t struct rte_devargs *da);\n+\n #ifdef __cplusplus\n }\n #endif\ndiff --git a/lib/librte_ethdev/rte_class_eth.c b/lib/librte_ethdev/rte_class_eth.c\nindex 66fd48dc2..7a8b81423 100644\n--- a/lib/librte_ethdev/rte_class_eth.c\n+++ b/lib/librte_ethdev/rte_class_eth.c\n@@ -6,9 +6,11 @@\n \n #include <rte_class.h>\n #include <rte_compat.h>\n+#include <rte_devargs.h>\n #include <rte_errno.h>\n #include <rte_kvargs.h>\n #include <rte_log.h>\n+#include <rte_string_fns.h>\n \n #include \"rte_ethdev.h\"\n #include \"rte_ethdev_core.h\"\n@@ -35,6 +37,19 @@ struct eth_dev_match_arg {\n \t\t.kvlist = (k), \\\n \t})\n \n+typedef int (*eth_dev_set_t)(struct rte_eth_dev *edev, const char *value);\n+\n+static enum eth_params\n+ethdev_param_id(const char *key)\n+{\n+\tint i;\n+\n+\tfor (i = 0; i < RTE_ETH_PARAMS_MAX; i++)\n+\t\tif (strcmp(key, eth_params_keys[i]) == 0)\n+\t\t\treturn i;\n+\treturn RTE_ETH_PARAMS_MAX;\n+}\n+\n static int\n eth_dev_match(const struct rte_eth_dev *edev,\n \t const void *_arg)\n@@ -79,6 +94,63 @@ eth_dev_iterate(const void *start,\n \treturn edev;\n }\n \n+static int\n+eth_dev_set_name(struct rte_eth_dev *edev,\n+\t\t const char *value)\n+{\n+\tsize_t n;\n+\n+\tn = strlcpy(edev->data->name, value,\n+\t\tsizeof(edev->data->name));\n+\n+\t/* Name was truncated. */\n+\tif (n >= sizeof(edev->data->name)) {\n+\t\tRTE_LOG(ERR, EAL, \"Name %s is too long\\n\", value);\n+\t\treturn -1;\n+\t}\n+\treturn 0;\n+}\n+\n+static int\n+ethdev_args_process(const char *key,\n+\t\t const char *value,\n+\t\t void *_edev)\n+{\n+\tstatic eth_dev_set_t eth_dev_set[] = {\n+\t\t[RTE_ETH_PARAMS_NAME] = eth_dev_set_name,\n+\t\t[RTE_ETH_PARAMS_MAX] = NULL,\n+\t};\n+\tstruct rte_eth_dev *edev = _edev;\n+\tint param;\n+\n+\tparam = ethdev_param_id(key);\n+\tif (eth_dev_set[param])\n+\t\treturn eth_dev_set[param](edev, value);\n+\treturn 0;\n+}\n+\n+int\n+rte_eth_dev_args_parse(struct rte_eth_dev *edev,\n+\t\t struct rte_devargs *devargs)\n+{\n+\tstruct rte_kvargs *kvargs = NULL;\n+\tint ret;\n+\n+\tif (devargs == NULL || devargs->cls_str == NULL)\n+\t\treturn 0;\n+\n+\tkvargs = rte_kvargs_parse_delim(devargs->cls_str, eth_params_keys, \"/\");\n+\tif (kvargs == NULL) {\n+\t\tRTE_LOG(ERR, EAL, \"cannot parse argument list\\n\");\n+\t\treturn -EINVAL;\n+\t}\n+\tret = rte_kvargs_process(kvargs, NULL, ethdev_args_process, edev);\n+\trte_kvargs_free(kvargs);\n+\tif (ret != 0)\n+\t\treturn -1;\n+\treturn 0;\n+}\n+\n struct rte_class rte_class_eth = {\n \t.dev_iterate = eth_dev_iterate,\n };\ndiff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c\nindex aa7730ce2..b03fe7f4b 100644\n--- a/lib/librte_ethdev/rte_ethdev.c\n+++ b/lib/librte_ethdev/rte_ethdev.c\n@@ -41,6 +41,7 @@\n #include \"rte_ethdev.h\"\n #include \"rte_ethdev_driver.h\"\n #include \"ethdev_profile.h\"\n+#include \"ethdev_private.h\"\n \n int rte_eth_dev_logtype;\n \n@@ -3504,6 +3505,12 @@ rte_eth_dev_create(struct rte_device *device, const char *name,\n \t\t}\n \t}\n \n+\tretval = rte_eth_dev_args_parse(ethdev, device->devargs);\n+\tif (retval) {\n+\t\tRTE_LOG(ERR, EAL, \"ethdev parsing failed\");\n+\t\tgoto probe_failed;\n+\t}\n+\n \tretval = ethdev_init(ethdev, init_params);\n \tif (retval) {\n \t\tRTE_LOG(ERR, EAL, \"ethdev initialisation failed\");\n", "prefixes": [ "v2", "12/13" ] }