Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/44967/?format=api
{ "id": 44967, "url": "https://patches.dpdk.org/api/patches/44967/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/64dbe73a53b28681244e7a752ebff6185526ec55.1537372746.git.gaetan.rivet@6wind.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<64dbe73a53b28681244e7a752ebff6185526ec55.1537372746.git.gaetan.rivet@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/64dbe73a53b28681244e7a752ebff6185526ec55.1537372746.git.gaetan.rivet@6wind.com", "date": "2018-09-19T16:03:40", "name": "[v2,10/13] bus/vdev: pre-process declarative vdev devargs", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "9f9e21ed7568026b355f8ca66fe43d92f64fc7c7", "submitter": { "id": 269, "url": "https://patches.dpdk.org/api/people/269/?format=api", "name": "Gaëtan Rivet", "email": "gaetan.rivet@6wind.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/64dbe73a53b28681244e7a752ebff6185526ec55.1537372746.git.gaetan.rivet@6wind.com/mbox/", "series": [ { "id": 1397, "url": "https://patches.dpdk.org/api/series/1397/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=1397", "date": "2018-09-19T16:03:30", "name": "Implement new devargs framework", "version": 2, "mbox": "https://patches.dpdk.org/series/1397/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/44967/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/44967/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 5E4B95F57;\n\tWed, 19 Sep 2018 18:04:28 +0200 (CEST)", "from mail-wm1-f50.google.com (mail-wm1-f50.google.com\n\t[209.85.128.50]) by dpdk.org (Postfix) with ESMTP id 689835B20\n\tfor <dev@dpdk.org>; Wed, 19 Sep 2018 18:04:15 +0200 (CEST)", "by mail-wm1-f50.google.com with SMTP id b19-v6so6876006wme.3\n\tfor <dev@dpdk.org>; Wed, 19 Sep 2018 09:04:15 -0700 (PDT)", "from bidouze.dev.6wind.com. (host.78.145.23.62.rev.coltfrance.com.\n\t[62.23.145.78]) by smtp.gmail.com with ESMTPSA id\n\tx24-v6sm34983671wrd.13.2018.09.19.09.04.13\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 19 Sep 2018 09:04:13 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=LyIKplS9f6Nt6prBvmiliNtk7CBPKndKNWs2mwAkzHU=;\n\tb=zBAwA/1kg6/rVH01UWtIBR5ApTdoGUDvHGKuKAFvk+umkbjs0tEKT3X2Ri5mmWtZGE\n\toS4xYdEA8rQPFCPEIzEyeyKVAxSt84XIy7gV/ydU0zWnL3N0ceZNTdQadlwu7/2EfplT\n\tV/Q8tM8+u3WiRuC8OnloDbqD+Me+P5CSe7RkTLK1CpTUoTcXrrATV0gmNEEpdxD+BdsY\n\tjqWgU+AUdfRbl6dTgWAzN842Fk4LdWG8LQ6APMhKxUHrk+2Gy0w8CtiVDi6Lntv+jDyk\n\t+RzgysOrytzy0BoUYIKDBMzKx8iCCgLjJIKLUIxTd4t1aa9GJ82mj/VTxHdL5Izl6mhy\n\tVaOw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=LyIKplS9f6Nt6prBvmiliNtk7CBPKndKNWs2mwAkzHU=;\n\tb=UG9yYyV38egQGlSRFvc+iX9pWRbl+2GIQ7W0ZaDNW5sh/cG46x9B3OjPFbm+eaDgiA\n\tjOIZicN3ZrUO+bB20ubbPebtvV1eYM4i4uvU1K/YVIrXpFtcGEe4UcLY84OjiOFCIkY/\n\ta+a4hTLFbUV5P68/MTTDjeNNqB02hiNCUHRMYTrMCLMsgFeP3i4Czauw0k6Ah6tp5ATD\n\tfG0K6NnrR0vhV+Cm82i9OCLCyScjiJCgEOro90MoxccuKusoWbL0lQt2Jbepes4BwoL/\n\tnP2g61ekREsXmY049ZWQ+sJuPPS08KEjl3FpWGSzUahE3MycV1kJ+IXad6MAGAvxIwpW\n\t5YDQ==", "X-Gm-Message-State": "APzg51BKz+SSdt+ILl3DN3B5pOXb9vCbSbV21AlovC8OFfYL+6ZUSrBt\n\tB9fAGo4nOIJJ2LxGSQRHWK57OeTdyPI=", "X-Google-Smtp-Source": "ANB0VdbX0ap0MUGRTgPmwGW4Z6/Y4lIPiCYma5XwAYkSCsoBT56Rvb+JrNmdl81SsUub901vtvHo5Q==", "X-Received": "by 2002:a1c:a94d:: with SMTP id\n\ts74-v6mr20984211wme.39.1537373054578; \n\tWed, 19 Sep 2018 09:04:14 -0700 (PDT)", "From": "Gaetan Rivet <gaetan.rivet@6wind.com>", "To": "dev@dpdk.org", "Cc": "Gaetan Rivet <gaetan.rivet@6wind.com>", "Date": "Wed, 19 Sep 2018 18:03:40 +0200", "Message-Id": "<64dbe73a53b28681244e7a752ebff6185526ec55.1537372746.git.gaetan.rivet@6wind.com>", "X-Mailer": "git-send-email 2.18.0", "In-Reply-To": "<cover.1537372746.git.gaetan.rivet@6wind.com>", "References": "<cover.1537372746.git.gaetan.rivet@6wind.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 10/13] bus/vdev: pre-process declarative vdev\n\tdevargs", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The new devargs format does not recognize a particular device name.\nEach bus uses its specific format.\n\nProcess each devargs privately prior to attempting a bus scan.\nPrepare them if they are using the new devargs format.\n\nSigned-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>\n---\n drivers/bus/vdev/vdev.c | 10 ++++---\n drivers/bus/vdev/vdev_params.c | 50 +++++++++++++++++++++++++++++++++\n drivers/bus/vdev/vdev_private.h | 6 ++++\n 3 files changed, 62 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c\nindex ef3ad6d99..5699e0744 100644\n--- a/drivers/bus/vdev/vdev.c\n+++ b/drivers/bus/vdev/vdev.c\n@@ -115,8 +115,8 @@ rte_vdev_remove_custom_scan(rte_vdev_scan_callback callback, void *user_arg)\n \treturn 0;\n }\n \n-static int\n-vdev_parse(const char *name, void *addr)\n+int\n+rte_vdev_parse(const char *name, void *addr)\n {\n \tstruct rte_vdev_driver **out = addr;\n \tstruct rte_vdev_driver *driver = NULL;\n@@ -148,7 +148,7 @@ vdev_probe_all_drivers(struct rte_vdev_device *dev)\n \tVDEV_LOG(DEBUG, \"Search driver %s to probe device %s\", name,\n \t\trte_vdev_device_name(dev));\n \n-\tif (vdev_parse(name, &driver))\n+\tif (rte_vdev_parse(name, &driver))\n \t\treturn -1;\n \tdev->device.driver = &driver->driver;\n \tret = driver->probe(dev);\n@@ -447,6 +447,8 @@ vdev_scan(void)\n \n \t/* for virtual devices we scan the devargs_list populated via cmdline */\n \tRTE_EAL_DEVARGS_FOREACH(\"vdev\", devargs) {\n+\t\tif (rte_vdev_devargs_prepare(devargs))\n+\t\t\tcontinue;\n \n \t\tdev = calloc(1, sizeof(*dev));\n \t\tif (!dev)\n@@ -540,7 +542,7 @@ static struct rte_bus rte_vdev_bus = {\n \t.find_device = rte_vdev_find_device,\n \t.plug = vdev_plug,\n \t.unplug = vdev_unplug,\n-\t.parse = vdev_parse,\n+\t.parse = rte_vdev_parse,\n \t.dev_iterate = rte_vdev_dev_iterate,\n };\n \ndiff --git a/drivers/bus/vdev/vdev_params.c b/drivers/bus/vdev/vdev_params.c\nindex 2f55f451f..aafaf3330 100644\n--- a/drivers/bus/vdev/vdev_params.c\n+++ b/drivers/bus/vdev/vdev_params.c\n@@ -2,11 +2,14 @@\n * Copyright 2018 Gaëtan Rivet\n */\n \n+#include <string.h>\n+\n #include <rte_dev.h>\n #include <rte_bus.h>\n #include <rte_bus_vdev.h>\n #include <rte_kvargs.h>\n #include <rte_errno.h>\n+#include <rte_devargs.h>\n \n #include \"vdev_logs.h\"\n #include \"vdev_private.h\"\n@@ -60,3 +63,50 @@ rte_vdev_dev_iterate(const void *start,\n \trte_kvargs_free(kvargs);\n \treturn dev;\n }\n+\n+static int\n+vdev_driver_kv_parse(const char *key __rte_unused,\n+\t\t const char *value,\n+\t\t void *_devargs)\n+{\n+\tstruct rte_devargs *devargs = _devargs;\n+\tstruct rte_vdev_driver *driver;\n+\n+\t/* Verify that the driver matches. */\n+\tif (rte_vdev_parse(value, &driver))\n+\t\treturn -1;\n+\n+\t/* Copy the driver name as-is. */\n+\tsnprintf(devargs->name, sizeof(devargs->name), \"%s\", value);\n+\treturn 0;\n+}\n+\n+int\n+rte_vdev_devargs_prepare(struct rte_devargs *devargs)\n+{\n+\tstruct rte_kvargs *kvargs = NULL;\n+\tchar *args;\n+\tint ret;\n+\n+\tif (devargs->bus_str == NULL)\n+\t\treturn 0;\n+\n+\targs = strchr(devargs->bus_str, ',');\n+\tif (args == NULL)\n+\t\treturn 0;\n+\targs++;\n+\n+\tkvargs = rte_kvargs_parse(args, vdev_params_keys);\n+\tif (kvargs == NULL) {\n+\t\tVDEV_LOG(ERR, \"unable to parse parameter list: %s\\n\",\n+\t\t\t devargs->bus_str);\n+\t\trte_errno = EINVAL;\n+\t\treturn -1;\n+\t}\n+\n+\tret = rte_kvargs_process(kvargs, \"driver\",\n+\t\t\t\t vdev_driver_kv_parse, devargs);\n+\n+\trte_kvargs_free(kvargs);\n+\treturn ret;\n+}\ndiff --git a/drivers/bus/vdev/vdev_private.h b/drivers/bus/vdev/vdev_private.h\nindex ba6dc48ff..da57b84dd 100644\n--- a/drivers/bus/vdev/vdev_private.h\n+++ b/drivers/bus/vdev/vdev_private.h\n@@ -19,6 +19,12 @@ rte_vdev_dev_iterate(const void *start,\n \t\t const char *str,\n \t\t const struct rte_dev_iterator *it);\n \n+int\n+rte_vdev_parse(const char *name, void *addr);\n+\n+int\n+rte_vdev_devargs_prepare(struct rte_devargs *da);\n+\n #ifdef __cplusplus\n }\n #endif\n", "prefixes": [ "v2", "10/13" ] }