Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/44901/?format=api
{ "id": 44901, "url": "https://patches.dpdk.org/api/patches/44901/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1537343726-169561-1-git-send-email-xuemingl@mellanox.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1537343726-169561-1-git-send-email-xuemingl@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1537343726-169561-1-git-send-email-xuemingl@mellanox.com", "date": "2018-09-19T07:55:26", "name": "[v3] net/mlx5: fix representor port xstats", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "a9ab4ef690e39828797cc6e0e800a2aca2bcc633", "submitter": { "id": 814, "url": "https://patches.dpdk.org/api/people/814/?format=api", "name": "Xueming Li", "email": "xuemingl@mellanox.com" }, "delegate": { "id": 6624, "url": "https://patches.dpdk.org/api/users/6624/?format=api", "username": "shahafs", "first_name": "Shahaf", "last_name": "Shuler", "email": "shahafs@mellanox.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1537343726-169561-1-git-send-email-xuemingl@mellanox.com/mbox/", "series": [ { "id": 1382, "url": "https://patches.dpdk.org/api/series/1382/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=1382", "date": "2018-09-19T07:55:26", "name": "[v3] net/mlx5: fix representor port xstats", "version": 3, "mbox": "https://patches.dpdk.org/series/1382/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/44901/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/44901/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 537291041;\n\tWed, 19 Sep 2018 09:55:45 +0200 (CEST)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n\tby dpdk.org (Postfix) with ESMTP id 3C937F04\n\tfor <dev@dpdk.org>; Wed, 19 Sep 2018 09:55:43 +0200 (CEST)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n\txuemingl@mellanox.com)\n\twith ESMTPS (AES256-SHA encrypted); 19 Sep 2018 10:00:05 +0200", "from dev-r630-06.mtbc.labs.mlnx (dev-r630-06.mtbc.labs.mlnx\n\t[10.12.205.180])\n\tby labmailer.mlnx (8.13.8/8.13.8) with ESMTP id w8J7tfLf005233;\n\tWed, 19 Sep 2018 10:55:42 +0300", "from dev-r630-06.mtbc.labs.mlnx (localhost [127.0.0.1])\n\tby dev-r630-06.mtbc.labs.mlnx (8.14.7/8.14.7) with ESMTP id\n\tw8J7teYV169601; Wed, 19 Sep 2018 15:55:40 +0800", "(from xuemingl@localhost)\n\tby dev-r630-06.mtbc.labs.mlnx (8.14.7/8.14.7/Submit) id\n\tw8J7ta9F169599; Wed, 19 Sep 2018 15:55:36 +0800" ], "From": "Xueming Li <xuemingl@mellanox.com>", "To": "Shahaf Shuler <shahafs@mellanox.com>, Yongseok Koh <yskoh@mellanox.com>", "Cc": "Xueming Li <xuemingl@mellanox.com>, dev@dpdk.org,\n\tadrien.mazarguil@6wind.com", "Date": "Wed, 19 Sep 2018 15:55:26 +0800", "Message-Id": "<1537343726-169561-1-git-send-email-xuemingl@mellanox.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1536906807-118827-1-git-send-email-xuemingl@mellanox.com>", "References": "<1536906807-118827-1-git-send-email-xuemingl@mellanox.com>", "Subject": "[dpdk-dev] [PATCH v3] net/mlx5: fix representor port xstats", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch fixes the issue that representor port shows xstats of PF.\n\nFixes: 2b7302638898 (\"net/mlx5: probe all port representors\")\nCc: adrien.mazarguil@6wind.com\n\nSigned-off-by: Xueming Li <xuemingl@mellanox.com>\n---\n drivers/net/mlx5/mlx5_stats.c | 13 +++++++++----\n 1 file changed, 9 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_stats.c b/drivers/net/mlx5/mlx5_stats.c\nindex 91f3d47..ed5b51b 100644\n--- a/drivers/net/mlx5/mlx5_stats.c\n+++ b/drivers/net/mlx5/mlx5_stats.c\n@@ -146,7 +146,7 @@ struct mlx5_counter_ctrl {\n \tet_stats->cmd = ETHTOOL_GSTATS;\n \tet_stats->n_stats = xstats_ctrl->stats_n;\n \tifr.ifr_data = (caddr_t)et_stats;\n-\tret = mlx5_ifreq(dev, SIOCETHTOOL, &ifr, 1);\n+\tret = mlx5_ifreq(dev, SIOCETHTOOL, &ifr, 0);\n \tif (ret) {\n \t\tDRV_LOG(WARNING,\n \t\t\t\"port %u unable to read statistic values from device\",\n@@ -194,7 +194,7 @@ struct mlx5_counter_ctrl {\n \n \tdrvinfo.cmd = ETHTOOL_GDRVINFO;\n \tifr.ifr_data = (caddr_t)&drvinfo;\n-\tret = mlx5_ifreq(dev, SIOCETHTOOL, &ifr, 1);\n+\tret = mlx5_ifreq(dev, SIOCETHTOOL, &ifr, 0);\n \tif (ret) {\n \t\tDRV_LOG(WARNING, \"port %u unable to query number of statistics\",\n \t\t\tdev->data->port_id);\n@@ -229,7 +229,6 @@ struct mlx5_counter_ctrl {\n \t\treturn;\n \t}\n \tdev_stats_n = ret;\n-\txstats_ctrl->stats_n = dev_stats_n;\n \t/* Allocate memory to grab stat names and values. */\n \tstr_sz = dev_stats_n * ETH_GSTRING_LEN;\n \tstrings = (struct ethtool_gstrings *)\n@@ -244,7 +243,7 @@ struct mlx5_counter_ctrl {\n \tstrings->string_set = ETH_SS_STATS;\n \tstrings->len = dev_stats_n;\n \tifr.ifr_data = (caddr_t)strings;\n-\tret = mlx5_ifreq(dev, SIOCETHTOOL, &ifr, 1);\n+\tret = mlx5_ifreq(dev, SIOCETHTOOL, &ifr, 0);\n \tif (ret) {\n \t\tDRV_LOG(WARNING, \"port %u unable to get statistic names\",\n \t\t\tdev->data->port_id);\n@@ -275,6 +274,7 @@ struct mlx5_counter_ctrl {\n \t\t\tgoto free;\n \t\t}\n \t}\n+\txstats_ctrl->stats_n = dev_stats_n;\n \t/* Copy to base at first time. */\n \tassert(xstats_n <= MLX5_MAX_XSTATS);\n \tret = mlx5_read_dev_counters(dev, xstats_ctrl->base);\n@@ -307,6 +307,8 @@ struct mlx5_counter_ctrl {\n \tunsigned int i;\n \tuint64_t counters[n];\n \n+\tif (!priv->xstats_ctrl.stats_n)\n+\t\treturn 0;\n \tif (n >= xstats_n && stats) {\n \t\tstruct mlx5_xstats_ctrl *xstats_ctrl = &priv->xstats_ctrl;\n \t\tint stats_n;\n@@ -480,8 +482,11 @@ struct mlx5_counter_ctrl {\n mlx5_xstats_get_names(struct rte_eth_dev *dev __rte_unused,\n \t\t struct rte_eth_xstat_name *xstats_names, unsigned int n)\n {\n+\tstruct priv *priv = dev->data->dev_private;\n \tunsigned int i;\n \n+\tif (!priv->xstats_ctrl.stats_n)\n+\t\treturn 0;\n \tif (n >= xstats_n && xstats_names) {\n \t\tfor (i = 0; i != xstats_n; ++i) {\n \t\t\tstrncpy(xstats_names[i].name,\n", "prefixes": [ "v3" ] }