Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/44882/?format=api
{ "id": 44882, "url": "https://patches.dpdk.org/api/patches/44882/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1537298539-31403-1-git-send-email-dharmik.thakkar@arm.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1537298539-31403-1-git-send-email-dharmik.thakkar@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1537298539-31403-1-git-send-email-dharmik.thakkar@arm.com", "date": "2018-09-18T19:22:19", "name": "[v2] test/hash: solve unit test hash compilation error", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "385517b34ddb4c91316df02dc93dbfd9e9d6fc82", "submitter": { "id": 1108, "url": "https://patches.dpdk.org/api/people/1108/?format=api", "name": "Dharmik Thakkar", "email": "dharmik.thakkar@arm.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1537298539-31403-1-git-send-email-dharmik.thakkar@arm.com/mbox/", "series": [ { "id": 1377, "url": "https://patches.dpdk.org/api/series/1377/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=1377", "date": "2018-09-18T19:22:19", "name": "[v2] test/hash: solve unit test hash compilation error", "version": 2, "mbox": "https://patches.dpdk.org/series/1377/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/44882/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/44882/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 238CE2BF7;\n\tTue, 18 Sep 2018 21:23:06 +0200 (CEST)", "from foss.arm.com (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70])\n\tby dpdk.org (Postfix) with ESMTP id 23DE1F04;\n\tTue, 18 Sep 2018 21:23:05 +0200 (CEST)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249])\n\tby usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CFF57ED1;\n\tTue, 18 Sep 2018 12:23:03 -0700 (PDT)", "from 2p2660v4-1.austin.arm.com (2p2660v4-1.austin.arm.com\n\t[10.118.14.24])\n\tby usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id\n\t741F13F5BD; Tue, 18 Sep 2018 12:23:03 -0700 (PDT)" ], "From": "Dharmik Thakkar <dharmik.thakkar@arm.com>", "To": "Bruce Richardson <bruce.richardson@intel.com>,\n\tPablo de Lara <pablo.de.lara.guarch@intel.com>", "Cc": "dev@dpdk.org, honnappa.nagarahalli@arm.com, thomas@monjalon.net,\n\tDharmik Thakkar <dharmik.thakkar@arm.com>, stable@dpdk.org", "Date": "Tue, 18 Sep 2018 14:22:19 -0500", "Message-Id": "<1537298539-31403-1-git-send-email-dharmik.thakkar@arm.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1535379969-19642-1-git-send-email-dharmik.thakkar@arm.com>", "References": "<1535379969-19642-1-git-send-email-dharmik.thakkar@arm.com>", "Subject": "[dpdk-dev] [PATCH v2] test/hash: solve unit test hash compilation\n\terror", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Enable print_key_info() function compilation always.\n\nFixes: af75078fece36 (\"first public release\")\nCc: stable@dpdk.org\n\nSuggested-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>\nSigned-off-by: Dharmik Thakkar <dharmik.thakkar@arm.com>\nReviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>\nReviewed-by: Gavin Hu <gavin.hu@arm.com>\n---\nv2:\n* Fix checkpatch coding style issue\n* Add \"Fixes:\" tag\n---\n test/test/test_hash.c | 24 +++++++++---------------\n 1 file changed, 9 insertions(+), 15 deletions(-)", "diff": "diff --git a/test/test/test_hash.c b/test/test/test_hash.c\nindex b3db9fd10547..db6442a2b101 100644\n--- a/test/test/test_hash.c\n+++ b/test/test/test_hash.c\n@@ -80,29 +80,23 @@ static uint32_t pseudo_hash(__attribute__((unused)) const void *keys,\n \treturn 3;\n }\n \n+#define UNIT_TEST_HASH_VERBOSE\t0\n /*\n * Print out result of unit test hash operation.\n */\n-#if defined(UNIT_TEST_HASH_VERBOSE)\n static void print_key_info(const char *msg, const struct flow_key *key,\n \t\t\t\t\t\t\t\tint32_t pos)\n {\n-\tuint8_t *p = (uint8_t *)key;\n-\tunsigned i;\n-\n-\tprintf(\"%s key:0x\", msg);\n-\tfor (i = 0; i < sizeof(struct flow_key); i++) {\n-\t\tprintf(\"%02X\", p[i]);\n+\tif (UNIT_TEST_HASH_VERBOSE) {\n+\t\tconst uint8_t *p = (const uint8_t *)key;\n+\t\tunsigned int i;\n+\n+\t\tprintf(\"%s key:0x\", msg);\n+\t\tfor (i = 0; i < sizeof(struct flow_key); i++)\n+\t\t\tprintf(\"%02X\", p[i]);\n+\t\tprintf(\" @ pos %d\\n\", pos);\n \t}\n-\tprintf(\" @ pos %d\\n\", pos);\n-}\n-#else\n-static void print_key_info(__attribute__((unused)) const char *msg,\n-\t\t__attribute__((unused)) const struct flow_key *key,\n-\t\t__attribute__((unused)) int32_t pos)\n-{\n }\n-#endif\n \n /* Keys used by unit test functions */\n static struct flow_key keys[5] = { {\n", "prefixes": [ "v2" ] }