Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/44825/?format=api
{ "id": 44825, "url": "https://patches.dpdk.org/api/patches/44825/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20180918105552.58464-1-bruce.richardson@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180918105552.58464-1-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180918105552.58464-1-bruce.richardson@intel.com", "date": "2018-09-18T10:55:52", "name": "build: fix compatibility with meson 0.41 onwards", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "deec5d3cc30bec79d1a01cb20c26220731c609c8", "submitter": { "id": 20, "url": "https://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20180918105552.58464-1-bruce.richardson@intel.com/mbox/", "series": [ { "id": 1366, "url": "https://patches.dpdk.org/api/series/1366/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=1366", "date": "2018-09-18T10:55:52", "name": "build: fix compatibility with meson 0.41 onwards", "version": 1, "mbox": "https://patches.dpdk.org/series/1366/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/44825/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/44825/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 89B1A5B2C;\n\tTue, 18 Sep 2018 12:56:08 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id 372B65B26\n\tfor <dev@dpdk.org>; Tue, 18 Sep 2018 12:56:06 +0200 (CEST)", "from orsmga007.jf.intel.com ([10.7.209.58])\n\tby orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t18 Sep 2018 03:56:05 -0700", "from silpixa00399126.ir.intel.com (HELO\n\tsilpixa00399126.ger.corp.intel.com) ([10.237.223.223])\n\tby orsmga007.jf.intel.com with ESMTP; 18 Sep 2018 03:56:04 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.53,389,1531810800\"; d=\"scan'208\";a=\"73926656\"", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>", "Date": "Tue, 18 Sep 2018 11:55:52 +0100", "Message-Id": "<20180918105552.58464-1-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.17.1", "Subject": "[dpdk-dev] [PATCH] build: fix compatibility with meson 0.41 onwards", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Versions of meson prior to 0.47 flattened the parameters to the\n\"set_variable\" function, which meant that the function could not take\narray variables as a parameter. Therefore, we need to disable driver\ntracking for those older versions, in order to maintain compatibility\nwith the minimum supported 0.41 version, and also v0.45 shipped in\nUbuntu 18.04 release.\n\nFixes: 806c45dd483d (\"build: add configuration summary at end of config\")\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n drivers/meson.build | 5 ++++-\n meson.build | 33 +++++++++++++++++++--------------\n 2 files changed, 23 insertions(+), 15 deletions(-)", "diff": "diff --git a/drivers/meson.build b/drivers/meson.build\nindex b6ce974de..c5df313dd 100644\n--- a/drivers/meson.build\n+++ b/drivers/meson.build\n@@ -145,5 +145,8 @@ foreach class:driver_classes\n \t\tendif # build\n \tendforeach\n \n-\tset_variable(class + '_drivers', class_drivers)\n+\tif meson.version().version_compare('>=0.47')\n+\t\t# prior to 0.47, set_variable can't take array params\n+\t\tset_variable(class + '_drivers', class_drivers)\n+\tendif\n endforeach\ndiff --git a/meson.build b/meson.build\nindex 7332e75b5..2ed1247a3 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -89,18 +89,23 @@ foreach lib:enabled_libs\n endforeach\n message(output_message + '\\n')\n \n-output_message = '\\n===============\\nDrivers Enabled\\n===============\\n'\n-foreach class:driver_classes\n-\tclass_drivers = get_variable(class + '_drivers')\n-\toutput_message += '\\n' + class + ':\\n\\t'\n-\toutput_count = 0\n-\tforeach drv:class_drivers\n-\t\toutput_message += drv + ', '\n-\t\toutput_count += 1\n-\t\tif output_count == 8\n-\t\t\toutput_message += '\\n\\t'\n-\t\t\toutput_count = 0\n-\t\tendif\n+\n+# prior to 0.47 set_variable didn't work with arrays, so we can't\n+# track driver lists easily\n+if meson.version().version_compare('>=0.47')\n+\toutput_message = '\\n===============\\nDrivers Enabled\\n===============\\n'\n+\tforeach class:driver_classes\n+\t\tclass_drivers = get_variable(class + '_drivers')\n+\t\toutput_message += '\\n' + class + ':\\n\\t'\n+\t\toutput_count = 0\n+\t\tforeach drv:class_drivers\n+\t\t\toutput_message += drv + ', '\n+\t\t\toutput_count += 1\n+\t\t\tif output_count == 8\n+\t\t\t\toutput_message += '\\n\\t'\n+\t\t\t\toutput_count = 0\n+\t\t\tendif\n+\t\tendforeach\n \tendforeach\n-endforeach\n-message(output_message + '\\n')\n+\tmessage(output_message + '\\n')\n+endif\n", "prefixes": [] }