Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 44817,
    "url": "https://patches.dpdk.org/api/patches/44817/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20180917152429.30518-1-marko.kovacevic@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20180917152429.30518-1-marko.kovacevic@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20180917152429.30518-1-marko.kovacevic@intel.com",
    "date": "2018-09-17T15:24:29",
    "name": "doc: add note into coding style",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "3cb3dfd8b664ae5c9ab4d2b23a9b6d3595250b6f",
    "submitter": {
        "id": 853,
        "url": "https://patches.dpdk.org/api/people/853/?format=api",
        "name": "Kovacevic, Marko",
        "email": "marko.kovacevic@intel.com"
    },
    "delegate": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20180917152429.30518-1-marko.kovacevic@intel.com/mbox/",
    "series": [
        {
            "id": 1358,
            "url": "https://patches.dpdk.org/api/series/1358/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=1358",
            "date": "2018-09-17T15:24:29",
            "name": "doc: add note into coding style",
            "version": 1,
            "mbox": "https://patches.dpdk.org/series/1358/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/44817/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/44817/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A32435F4D;\n\tMon, 17 Sep 2018 17:26:30 +0200 (CEST)",
            "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby dpdk.org (Postfix) with ESMTP id 6E1195F2E\n\tfor <dev@dpdk.org>; Mon, 17 Sep 2018 17:26:28 +0200 (CEST)",
            "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t17 Sep 2018 08:26:26 -0700",
            "from silpixa00399502.ir.intel.com (HELO\n\tsilpixa00399502.ger.corp.intel.com) ([10.237.223.218])\n\tby orsmga002.jf.intel.com with ESMTP; 17 Sep 2018 08:26:23 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.53,385,1531810800\"; d=\"scan'208\";a=\"92459756\"",
        "From": "Marko Kovacevic <marko.kovacevic@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "ferruh.yigit@intel.com, john.mcnamara@intel.com,\n\tMarko Kovacevic <marko.kovacevic@intel.com>",
        "Date": "Mon, 17 Sep 2018 16:24:29 +0100",
        "Message-Id": "<20180917152429.30518-1-marko.kovacevic@intel.com>",
        "X-Mailer": "git-send-email 2.9.5",
        "Subject": "[dpdk-dev] [PATCH] doc: add note into coding style",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Added a note into the coding style to\nhighlight the use of a bool within a struct\n\nSigned-off-by: Marko Kovacevic <marko.kovacevic@intel.com>\n---\n doc/guides/contributing/coding_style.rst | 9 +++++++++\n 1 file changed, 9 insertions(+)",
    "diff": "diff --git a/doc/guides/contributing/coding_style.rst b/doc/guides/contributing/coding_style.rst\nindex b1bf0d1..8b1febe 100644\n--- a/doc/guides/contributing/coding_style.rst\n+++ b/doc/guides/contributing/coding_style.rst\n@@ -247,6 +247,15 @@ Structure Declarations\n * Use of the structures should be by separate variable declarations and those declarations must be extern if they are declared in a header file.\n * Externally visible structure definitions should have the structure name prefixed by ``rte_`` to avoid namespace collisions.\n \n+.. note::\n+\n+    Uses of ``bool`` in structures are not preferred as is wastes space and\n+    it's also not clear as to what type size the bool is. A preferred use of\n+    ``bool`` is mainly as a return type from functions that return true/false,\n+    and maybe local variable functions.\n+\n+    Ref: `LKML <https://lkml.org/lkml/2017/11/21/384>`_\n+\n Queues\n ~~~~~~\n \n",
    "prefixes": []
}