Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/44705/?format=api
{ "id": 44705, "url": "https://patches.dpdk.org/api/patches/44705/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20180914012517.44977-1-xiao.w.wang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180914012517.44977-1-xiao.w.wang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180914012517.44977-1-xiao.w.wang@intel.com", "date": "2018-09-14T01:25:17", "name": "[v2] net/ifc: do not notify before HW ready", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "faf80f9d35b4cf360822eab0a25c097a4e4d2922", "submitter": { "id": 281, "url": "https://patches.dpdk.org/api/people/281/?format=api", "name": "Xiao Wang", "email": "xiao.w.wang@intel.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20180914012517.44977-1-xiao.w.wang@intel.com/mbox/", "series": [ { "id": 1315, "url": "https://patches.dpdk.org/api/series/1315/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=1315", "date": "2018-09-14T01:25:17", "name": "[v2] net/ifc: do not notify before HW ready", "version": 2, "mbox": "https://patches.dpdk.org/series/1315/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/44705/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/44705/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 7375E7CB0;\n\tFri, 14 Sep 2018 03:32:09 +0200 (CEST)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby dpdk.org (Postfix) with ESMTP id BB26D5F65\n\tfor <dev@dpdk.org>; Fri, 14 Sep 2018 03:32:07 +0200 (CEST)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t13 Sep 2018 18:32:06 -0700", "from dpdk-xiao-1.sh.intel.com ([10.67.111.123])\n\tby orsmga002.jf.intel.com with ESMTP; 13 Sep 2018 18:31:57 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.53,371,1531810800\"; d=\"scan'208\";a=\"91592862\"", "From": "Xiao Wang <xiao.w.wang@intel.com>", "To": "xiaolong.ye@intel.com", "Cc": "tiwei.bie@intel.com,\n\tdev@dpdk.org,\n\tXiao Wang <xiao.w.wang@intel.com>", "Date": "Fri, 14 Sep 2018 09:25:17 +0800", "Message-Id": "<20180914012517.44977-1-xiao.w.wang@intel.com>", "X-Mailer": "git-send-email 2.15.1", "In-Reply-To": "<20180910110531.138449-1-xiao.w.wang@intel.com>", "References": "<20180910110531.138449-1-xiao.w.wang@intel.com>", "Subject": "[dpdk-dev] [PATCH v2] net/ifc: do not notify before HW ready", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "If the device is not clearly reset by the previous driver and holds\nsome invalid ring addr, and the relay thread kicks it before HW is\nproperly re-configured, a bad DMA request may happen.\n\nBesides, the notify_addr which is used by the relay thread is set in\nthe vdpa_ifcvf_start function, if a kick relay happens before\nvdpa_ifcvf_start finishes, a null addr is accessed.\n\nFixes: a3f8150eac6d (\"net/ifcvf: add ifcvf vDPA driver\")\n\nSigned-off-by: Xiao Wang <xiao.w.wang@intel.com>\n---\nv2:\n* Add description for the fix in the commit log.\n---\n drivers/net/ifc/ifcvf_vdpa.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ifc/ifcvf_vdpa.c b/drivers/net/ifc/ifcvf_vdpa.c\nindex 3c5430dc0..7d3085d8d 100644\n--- a/drivers/net/ifc/ifcvf_vdpa.c\n+++ b/drivers/net/ifc/ifcvf_vdpa.c\n@@ -503,11 +503,11 @@ update_datapath(struct ifcvf_internal *internal)\n \t\tif (ret)\n \t\t\tgoto err;\n \n-\t\tret = setup_notify_relay(internal);\n+\t\tret = vdpa_ifcvf_start(internal);\n \t\tif (ret)\n \t\t\tgoto err;\n \n-\t\tret = vdpa_ifcvf_start(internal);\n+\t\tret = setup_notify_relay(internal);\n \t\tif (ret)\n \t\t\tgoto err;\n \n@@ -515,12 +515,12 @@ update_datapath(struct ifcvf_internal *internal)\n \t} else if (rte_atomic32_read(&internal->running) &&\n \t\t (!rte_atomic32_read(&internal->started) ||\n \t\t !rte_atomic32_read(&internal->dev_attached))) {\n-\t\tvdpa_ifcvf_stop(internal);\n-\n \t\tret = unset_notify_relay(internal);\n \t\tif (ret)\n \t\t\tgoto err;\n \n+\t\tvdpa_ifcvf_stop(internal);\n+\n \t\tret = vdpa_disable_vfio_intr(internal);\n \t\tif (ret)\n \t\t\tgoto err;\n", "prefixes": [ "v2" ] }