Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/44467/?format=api
{ "id": 44467, "url": "https://patches.dpdk.org/api/patches/44467/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1536561658-3830-1-git-send-email-anoob.joseph@caviumnetworks.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1536561658-3830-1-git-send-email-anoob.joseph@caviumnetworks.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1536561658-3830-1-git-send-email-anoob.joseph@caviumnetworks.com", "date": "2018-09-10T06:40:58", "name": "[v1] app/test-crypto-perf: fix double allocation of memory", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "d184180eecc5a0ae9281c7b19e799c186646091f", "submitter": { "id": 893, "url": "https://patches.dpdk.org/api/people/893/?format=api", "name": "Anoob Joseph", "email": "anoob.joseph@caviumnetworks.com" }, "delegate": { "id": 6690, "url": "https://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1536561658-3830-1-git-send-email-anoob.joseph@caviumnetworks.com/mbox/", "series": [ { "id": 1243, "url": "https://patches.dpdk.org/api/series/1243/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=1243", "date": "2018-09-10T06:40:58", "name": "[v1] app/test-crypto-perf: fix double allocation of memory", "version": 1, "mbox": "https://patches.dpdk.org/series/1243/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/44467/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/44467/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 3D10F1559;\n\tMon, 10 Sep 2018 09:16:23 +0200 (CEST)", "from NAM03-BY2-obe.outbound.protection.outlook.com\n\t(mail-by2nam03on0052.outbound.protection.outlook.com [104.47.42.52])\n\tby dpdk.org (Postfix) with ESMTP id 29A1611A4\n\tfor <dev@dpdk.org>; Mon, 10 Sep 2018 09:16:21 +0200 (CEST)", "from ajoseph83.caveonetworks.com.com (115.113.156.2) by\n\tSN6PR07MB4909.namprd07.prod.outlook.com (2603:10b6:805:37::30) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.1080.15; Mon, 10 Sep 2018 07:16:14 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=+7ohRbb7jXiYQiVa44LS6tN7vCjlGcTyUWdRAyj3XYU=;\n\tb=W7U47123vDNHpl8W/Tzo2rbA6QOBEMFVcvcjTGRJjBTl+jksahvh8qtmfrGyQh2qJ8Jq2QowEqhPMb5kk8TMk8yjd+Q/NTRVVIo2zrFK0cAkyIhokMphNNPQtNGInrey9w/iSHBaiPLhs8aeKSaOB4LtY0TPAoqOZFt5jFC0e/I=", "Authentication-Results": "spf=none (sender IP is )\n\tsmtp.mailfrom=Anoob.Joseph@cavium.com; ", "From": "Anoob Joseph <anoob.joseph@caviumnetworks.com>", "To": "Akhil Goyal <akhil.goyal@nxp.com>,\n\tDeclan Doherty <declan.doherty@intel.com>,\n\tPablo de Lara <pablo.de.lara.guarch@intel.com>", "Cc": "Anoob Joseph <anoob.joseph@caviumnetworks.com>,\n\tJerin Jacob <jerin.jacob@caviumnetworks.com>,\n\tNarayana Prasad <narayanaprasad.athreya@caviumnetworks.com>,\n\tdev@dpdk.org, Akash Saxena <akash.saxena@caviumnetworks.com>", "Date": "Mon, 10 Sep 2018 12:10:58 +0530", "Message-Id": "<1536561658-3830-1-git-send-email-anoob.joseph@caviumnetworks.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1536560043-24807-1-git-send-email-anoob.joseph@caviumnetworks.com>", "References": "<1536560043-24807-1-git-send-email-anoob.joseph@caviumnetworks.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[115.113.156.2]", "X-ClientProxiedBy": "MA1PR01CA0080.INDPRD01.PROD.OUTLOOK.COM\n\t(2603:1096:a00::20)\n\tTo SN6PR07MB4909.namprd07.prod.outlook.com\n\t(2603:10b6:805:37::30)", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "8a21bdb4-590a-45d6-82d0-08d616ed4caf", "X-Microsoft-Antispam": "BCL:0; PCL:0;\n\tRULEID:(7020095)(4652040)(8989137)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(2017052603328)(7153060)(7193020);\n\tSRVR:SN6PR07MB4909; ", "X-Microsoft-Exchange-Diagnostics": [ "1; SN6PR07MB4909;\n\t3:4Wgy6zrawK/rVruQZZEPIEx9BOOcQRat+eKP8zJk6gxF4QRrN5DiBk5aGmJWmB038L9JKPchaXa8duZb3Rq4m0FjkPTPCJOxa/m6Ba0SmBtg1k4rwq3h6+HyEnakK3CXlanETlk20m/osJ0vh+4wSPkdJyBAKWu7qjJOsXf6kr+/p/scDjWKs3BloBQfNOntEFKUxyj3l8yRFxj2ElUYDzpamVNlj5V7Cwp4elLWAJcVM7+diF4aaKuXxdCYfflU;\n\t25:0sHJJAqnwMEDqsnFB5NdtC3+IDxCvrAm4xYgG/LUOGCtwAvzptzdwHCSimRI95VJA+7mOCjbWoYWkV7FSxY00o+RHCvv3CTiQsHjxLS4m3HdTDvWVpt7VOFPLzYJ+n4gvFW/mYXKxkHkcV6Plij+YpYbE+f7qjq2RcL9NzfJDmWo7uZzi7qfySAYpQmJyAYJU3irsZT+2UaXnx20yldgq0v7/VHFlC/8fzmlK0NUAqRzf24AlYvhxRBUMoQcHSYpqqV57RPA+Yee/s9GH8AD4c8Qe1KHApnCx84Jur4LiorbSRXluXr/ieHQZez45hj2v/YRmVDqAfkXjJOezNIhYw==;\n\t31:oSdCOn/zb3Sesr5NXLlk2/QH9TP78spt9TN67awaCpPcLcnwiTm/FVOr6rwObWwQY8OfsoimhQJ8zBc3mrFpgFG8IeRMRUp1SMFRGlmTlyVJ1prBeeU7mIDIblgaM+P/qvnf9NvUXNpxyxMs4nYTmkG3BjypYCr0JLfYWdAlakoDcYkSeuuJR2mf/wCBTKzUmrxYw+1mXyjwZYM4r5Z1X69QeiAZpCgVXEyi31LqkN8=", "1; SN6PR07MB4909;\n\t20:Sx6bqK00MvPJX7UvItVwiAZf63takFkDPhjPpO+FkU6ESdLCSRlaOv59WOzRv9vnI2KoNxE9QKnUMSHMABnjlGMkLxP6SCTe/jZfim148H+U6UYR31ulShTQnB4Knrq6Opac2l41KF5rxjtrlSaHNOoZw/zmGcEmicUXMtIvW3zcr38HVmrRCmf7tVB/yU8zi6wUHst0F5iVPz//drSdwYEMSmTc4oEnwX8ibNOtvPiJuf8nrqqaBZ5YI/125iJp39l94eZZE9/dfPUHSn19Wnst8mTMJ+agXE7hyK9LWlXSejd+puTQJZIJQJK+QPiILcWZLy5u14Gxk8DeFPENKOmCm4eqXXlSS9v5VPB6OCGTvzLye8MM+//J3mXFow14y83KKjxJpRwHxZFSqKuxwFkK/Nq/4cbPjsWTkFo3mAu8D/sDXms0hrI5A6lgicL8HTpwDHRJgvMv4QyoLQpzrrVUfJW4F4kc3AhqqDjoFhLmlwzxungg7wV0HqKnKHO2HTejRpm9ho9cFiz0jfCVAhAPVFKktUTshQPRbYrxsO7NZpr/Ma5SAqxgoDZIC3zaoPuXug92fNJnts+FYD2cky7bT0D252MhLkLQzGNykm0=;\n\t4:GRMhKQtbXW04WyyBfZHUL8tslivmshLHSCsORhRWyb22KZ1M2VojOJ85gi+6AFqUqXTqZkMYWoZpWJdhWVuEZhVv7ja1EyLyiRmw/opO2xcF+PhVqeV7HRIcG6LCMt8FKRtPrqq6gW3PVJuQQO2nCMXzxmPJBonGrXSMPnbvmMZ7Eh0fKFcdNDaTfID5Xr7CO0eDU1YfwJZuzVFOjM89otfvKuL+seni+FOgmcmqqisilRyIKuvbN5IFvm8NPpCl+Rx4dSVEYLPBXfTYbyu2wA==", "=?us-ascii?Q?1; SN6PR07MB4909;\n\t23:8FqGLRxB6OydVDvHrJNaW2K40hK2e6HMjuD/xnuWh?=\n\tqnfuzlGlNkseN+TTO1goMEWOHIB59oltGk+P0RSPIotLwPnB5QAe0IV7sMjKuZzdqJGEUqmSxpJLVqvkmdlQXU54mT4u/E14J2VWzQBGr3SfJYqs08gzK+Sncmj6VNFUABAZWinlM6vzr/eFGjmQsaLfysvphR6S8q8HkNu+sn3aAZ/OppfCz9ncyb0egs1mD9NPGppcQup4S13m36FsQPxToNgAnvDzzATg9qRstoy2T8gzQDV/tYnTEboc+d8g/bmBBLriByM5EGp9WiD+uTb+wGj03rvzxZO4316doLxQ8tuELmSkUL1JhNGhCzJC0rWxefcg0s55L0RnComQEaEhWfdYSAjrH2CMH51ZexHx/ZE9e3eZQJWqzVR2dRJ7iw2+Ji57sf7s3yZieCAtBolAeL6oXD3CQIA9JYZzDenx1TmArNq8uSZ11pYHF3nn9m++///+rQladbCmqxyxMNP4et1hivNLqdWWo8mbxVuV7ANFHXOE0tM6hTxAKyhmcv+eG5CEbIORuiwIqdG3fev53yX3xrjtqhrMIxPzpkKzQ9jvPFlhixfT7aLBp1blFpVWTd/r8h9CDAFUYopRfkmAAYkngOXqpmk62UJQU+Dg/cPCK8keT/YaVT1d4HDDfRkkqq8AwmUF0Y4cGR6umM0bXhcE8dWeycWMz2CAUMwbagJ1N4m104sAzmzX+B/BpOfVmRek25rcL4dUMxNo9STBKKJ9th6KZ66mFUwAxS3+b7ihXa2EWlmdFlQn0YU3tRUNDkaeNkGUJzQiINWT+16GnOJ6HCB3/b54lx9ARHiToJJS3iEadI+z4ymDyjgFydtDOVw9kdMtD7QZ4MEX0ehjoBKe4jBZNoSHF7vak5g5yc33lUIvwWRqN4j+z2PcGqIoxG48kC3HHs07vLbLzFqUJmx6sf4uGqEC+dsj3C8Iby5c7gmyLkG2x+HWEmaL/RIm+lgokTWwk4kSagZtzFnB6dBFlPZo1Z6wdgjt9VnvYUuI6lpTr0HRoDW65s/ppzMT5kS+gXTSPSoJtsbDsy0I5D19r130CBoLhbBLHMKmRSJEO3fi/xUv1oFO8zqSVcz9ruFAjTsxJQu6FwMa0CK6v2JT9XTEWUUi+IdTRZ7BOcSnncFRFPh1Q1kreucqOb6a+PUdFdAe2UaN+KVCwWT7eWU5vUxJdOvHzKaH2EYikOD85V2TX2Mrb6FEWoEdaGsVfja81yilBU6QLobk6Lc", "1; SN6PR07MB4909;\n\t6:tHkNuROPWKq4oaPcHrFVd18022UCfI7Rw2r1rgjeA8bU9GQPRQAZ/BsdxfPitDUyP33cKZ27iBmwSzKO9MT3gWmjrK+wWADbzILMlKvtOSixfpAOJzwDETfmXQNFryEm2opznWy+7w1LBE8lDJu3gS+KjwtJdAPgqg1/cVhxr1FE9cUh9X4yIT1zrNLJZhgoVQ3TJxLwhI6EkaNZhFX88sCJuRoTzTih8oaOqlLwnKFU3Z04X/bAgh92mCi//1IRZ3dNScA7PWXEwm3sL27tKiD8nDXSnbPpq9a7Zvjfc7cWA4L9mPGDy4Z1QTPZ6YtfrFgvhpQ6A5noTBOOOf+doyr2SLG1g6SIqVUfM2i/+vrMtwjjfkzG3CHpZm1Q5Cpc7rirOVow/FASbwAOqvzSTjh/q6f+9sbHAHeDFKYIHJBWdcfjO7hQy52L7sGk+Cjz+xhio+aqSRsWm0HvZ02Y7Q==;\n\t5:veS2UJb3owI70fwIXtSiaPuR6TL+YYdBiea18cN6fp/jM6DFsNUREF+rxKSO5tJ2XVOQKDfjQLta+5l4bTw9b++yxRN5kFx/42NQoccDkRJLiBvg5O7xJqunr38X0m2Ek2p5cjlGX9Pkr8Na09Fiq2B9WFT8Dssz0mVNI5DAMWo=;\n\t7:bdBHfKtuB0bLFVLqe97WTM+GKCPskPkGcqP01i5wlrNpaifQvi7mLB2uJTMGWaf8HnothLLwbzvkEVZTgVtNgdCs1QIcFV0sopBtnJyGe1HacJmjzXd8hnTVlq3dglNf7V2z7oVY/ve52H9/lbGh3FvRRUx9YsxhoF3egXkK58p0USIhUV6MfhTSg7huY4G56hugio7jxsasdeNnrfL1eJ2JNniHkzSIytcrAWOwEa7TQVH4dnkqS28glcngJNfo" ], "X-MS-TrafficTypeDiagnostic": "SN6PR07MB4909:", "X-Microsoft-Antispam-PRVS": "<SN6PR07MB4909EE119893721C4377B524F8050@SN6PR07MB4909.namprd07.prod.outlook.com>", "X-Exchange-Antispam-Report-Test": "UriScan:;", "X-MS-Exchange-SenderADCheck": "1", "X-Exchange-Antispam-Report-CFA-Test": "BCL:0; PCL:0;\n\tRULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(93006095)(3002001)(3231311)(944501410)(52105095)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(20161123558120)(20161123564045)(201708071742011)(7699050);\n\tSRVR:SN6PR07MB4909; BCL:0; PCL:0; RULEID:; SRVR:SN6PR07MB4909; ", "X-Forefront-PRVS": "07915F544A", "X-Forefront-Antispam-Report": "SFV:NSPM;\n\tSFS:(10009020)(396003)(346002)(376002)(39860400002)(136003)(366004)(199004)(189003)(316002)(6666003)(6486002)(68736007)(36756003)(8676002)(16586007)(8936002)(4326008)(110136005)(54906003)(105586002)(106356001)(50466002)(48376002)(25786009)(50226002)(66066001)(47776003)(6116002)(186003)(6506007)(76176011)(81156014)(81166006)(5660300001)(52116002)(51416003)(6512007)(16526019)(2906002)(107886003)(478600001)(55236004)(386003)(7736002)(3846002)(305945005)(53936002)(446003)(26005)(2616005)(11346002)(956004)(72206003)(476003)(486006)(44832011)(42882007)(97736004);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:SN6PR07MB4909;\n\tH:ajoseph83.caveonetworks.com.com; FPR:; SPF:None; LANG:en;\n\tPTR:InfoNoRecords; A:1; MX:1; ", "Received-SPF": "None (protection.outlook.com: cavium.com does not designate\n\tpermitted sender hosts)", "X-Microsoft-Antispam-Message-Info": "+4UAutwGMePAWzm4viGyN00673euYRCXnfMzt2abRQ+1eNoVBWPoYHUmOBnb2HTidZ/wVP2BgKhoVGMB3ksiTO9HhmDsmJIfuHsXx1XanG4Xxu91R0dOd7jbthh+twD/dzUVCN/QXPqcqrVq09ndu7xRCiPA4e8dU1i+ye2OP5tV2gIaPupMBtCjd0nSMa/TsUeOqHdhpM5dG8No2fOeD0pSqeg6LMgg0O0NE15WVnCcnw6AZc3yTnv4jxXvdRHg+Oe4XYyNOHAOnjOyOfS725/4MouJBysDqd/OzW9tp/AD/Ww2i7f5cBo0whdX8AM5NTI4ZFSwLY3LrLRS0auUCcm+xAl1DJHSWuT6f7xIPwQ=", "SpamDiagnosticOutput": "1:99", "SpamDiagnosticMetadata": "NSPM", "X-OriginatorOrg": "caviumnetworks.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "10 Sep 2018 07:16:14.3353\n\t(UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "8a21bdb4-590a-45d6-82d0-08d616ed4caf", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "711e4ccf-2e9b-4bcf-a551-4094005b6194", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "SN6PR07MB4909", "Subject": "[dpdk-dev] [PATCH v1] app/test-crypto-perf: fix double allocation\n\tof memory", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The field, 'cipher_iv.data' is allocated twice when cipher is not null.\nIdeally the allocation should depend only on the field\n'cperf_options.cipher_iv_sz'. This will make sure this code path gets\nvalid for ciphers which doesn't require IV.\n\nFixes: 0fbd75a99fc9 (\"cryptodev: move IV parameters to session\")\n\nSigned-off-by: Akash Saxena <akash.saxena@caviumnetworks.com>\nSigned-off-by: Anoob Joseph <anoob.joseph@caviumnetworks.com>\n---\nv1:\n* Fixed typo\n\n app/test-crypto-perf/cperf_test_vectors.c | 22 +++++++++-------------\n 1 file changed, 9 insertions(+), 13 deletions(-)", "diff": "diff --git a/app/test-crypto-perf/cperf_test_vectors.c b/app/test-crypto-perf/cperf_test_vectors.c\nindex 907a995..1af9524 100644\n--- a/app/test-crypto-perf/cperf_test_vectors.c\n+++ b/app/test-crypto-perf/cperf_test_vectors.c\n@@ -419,13 +419,19 @@ cperf_test_vector_get_dummy(struct cperf_options *options)\n \t\t\tt_vec->cipher_key.length = 0;\n \t\t\tt_vec->ciphertext.data = plaintext;\n \t\t\tt_vec->cipher_key.data = NULL;\n-\t\t\tt_vec->cipher_iv.data = NULL;\n \t\t} else {\n \t\t\tt_vec->cipher_key.length = options->cipher_key_sz;\n \t\t\tt_vec->ciphertext.data = ciphertext;\n \t\t\tt_vec->cipher_key.data = cipher_key;\n-\t\t\tt_vec->cipher_iv.data = rte_malloc(NULL, options->cipher_iv_sz,\n-\t\t\t\t\t16);\n+\t\t}\n+\n+\t\t/* Init IV data ptr */\n+\t\tt_vec->cipher_iv.data = NULL;\n+\n+\t\tif (options->cipher_iv_sz != 0) {\n+\t\t\t/* Set IV parameters */\n+\t\t\tt_vec->cipher_iv.data = rte_malloc(NULL,\n+\t\t\t\t\toptions->cipher_iv_sz, 16);\n \t\t\tif (t_vec->cipher_iv.data == NULL) {\n \t\t\t\trte_free(t_vec);\n \t\t\t\treturn NULL;\n@@ -433,17 +439,7 @@ cperf_test_vector_get_dummy(struct cperf_options *options)\n \t\t\tmemcpy(t_vec->cipher_iv.data, iv, options->cipher_iv_sz);\n \t\t}\n \t\tt_vec->ciphertext.length = options->max_buffer_size;\n-\n-\t\t/* Set IV parameters */\n-\t\tt_vec->cipher_iv.data = rte_malloc(NULL, options->cipher_iv_sz,\n-\t\t\t\t16);\n-\t\tif (options->cipher_iv_sz && t_vec->cipher_iv.data == NULL) {\n-\t\t\trte_free(t_vec);\n-\t\t\treturn NULL;\n-\t\t}\n-\t\tmemcpy(t_vec->cipher_iv.data, iv, options->cipher_iv_sz);\n \t\tt_vec->cipher_iv.length = options->cipher_iv_sz;\n-\n \t\tt_vec->data.cipher_offset = 0;\n \t\tt_vec->data.cipher_length = options->max_buffer_size;\n \n", "prefixes": [ "v1" ] }