Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/44392/?format=api
https://patches.dpdk.org/api/patches/44392/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20180907145340.79670-1-dariusz.stojaczyk@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180907145340.79670-1-dariusz.stojaczyk@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180907145340.79670-1-dariusz.stojaczyk@intel.com", "date": "2018-09-07T14:53:40", "name": "pci/linux: use RTE_IOVA_VA whenever possible", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": true, "hash": "056d7b5e397c5156832a40ec9eb232ee565b34b9", "submitter": { "id": 1123, "url": "https://patches.dpdk.org/api/people/1123/?format=api", "name": "Stojaczyk, Dariusz", "email": "dariusz.stojaczyk@intel.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20180907145340.79670-1-dariusz.stojaczyk@intel.com/mbox/", "series": [ { "id": 1225, "url": "https://patches.dpdk.org/api/series/1225/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=1225", "date": "2018-09-07T14:53:40", "name": "pci/linux: use RTE_IOVA_VA whenever possible", "version": 1, "mbox": "https://patches.dpdk.org/series/1225/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/44392/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/44392/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 613CB2BEA;\n\tFri, 7 Sep 2018 16:55:43 +0200 (CEST)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby dpdk.org (Postfix) with ESMTP id CB1E21041\n\tfor <dev@dpdk.org>; Fri, 7 Sep 2018 16:55:41 +0200 (CEST)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t07 Sep 2018 07:55:40 -0700", "from violet.igk.intel.com ([10.102.17.58])\n\tby fmsmga004.fm.intel.com with ESMTP; 07 Sep 2018 07:55:38 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.53,342,1531810800\"; d=\"scan'208\";a=\"86865390\"", "From": "Darek Stojaczyk <dariusz.stojaczyk@intel.com>", "To": "dev@dpdk.org, Santosh Shukla <santosh.shukla@caviumnetworks.com>,\n\tHemant Agrawal <hemant.agrawal@nxp.com>,\n\tJerin Jacob <jerin.jacob@caviumnetworks.com>", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>,\n\tAnatoly Burakov <anatoly.burakov@intel.com>,\n\tChas Williams <chas3@att.com>, \n\tDarek Stojaczyk <dariusz.stojaczyk@intel.com>", "Date": "Fri, 7 Sep 2018 16:53:40 +0200", "Message-Id": "<20180907145340.79670-1-dariusz.stojaczyk@intel.com>", "X-Mailer": "git-send-email 2.17.1", "Subject": "[dpdk-dev] [PATCH] pci/linux: use RTE_IOVA_VA whenever possible", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This allows DPDK to use RTE_IOVA_VA with VFIO/UIO-bound PCI\ndevices present on the system, but not attached to any\nrte_pci_driver at the time of init.\n\nSo far we used RTE_IOVA_VA whenever there was at least one\ndevice attached to a driver with an RTE_PCI_DRV_IOVA_AS_VA flag,\nmeaning that other drivers which didn't explicitly report such\nflag could have been forced to work in RTE_IOVA_VA as well.\n\nThis patch makes the RTE_PCI_DRV_IOVA_AS_VA explicitly a hint.\nIf it's set, but RTE_IOVA_VA cannot be used, then EAL will print\na proper warning.\n\nSigned-off-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>\n---\n drivers/bus/pci/linux/pci.c | 11 +++++------\n 1 file changed, 5 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/bus/pci/linux/pci.c b/drivers/bus/pci/linux/pci.c\nindex 04648ac93..961e24024 100644\n--- a/drivers/bus/pci/linux/pci.c\n+++ b/drivers/bus/pci/linux/pci.c\n@@ -534,7 +534,7 @@ pci_one_device_bound_uio(void)\n * Any one of the device has iova as va\n */\n static inline int\n-pci_one_device_has_iova_va(void)\n+pci_one_device_want_iova_va(void)\n {\n \tstruct rte_pci_device *dev = NULL;\n \tstruct rte_pci_driver *drv = NULL;\n@@ -635,7 +635,7 @@ rte_pci_get_iommu_class(void)\n {\n \tbool is_bound;\n \tbool is_vfio_noiommu_enabled = true;\n-\tbool has_iova_va;\n+\tbool want_iova_va;\n \tbool is_bound_uio;\n \tbool iommu_no_va;\n \n@@ -643,7 +643,7 @@ rte_pci_get_iommu_class(void)\n \tif (!is_bound)\n \t\treturn RTE_IOVA_DC;\n \n-\thas_iova_va = pci_one_device_has_iova_va();\n+\twant_iova_va = pci_one_device_want_iova_va();\n \tis_bound_uio = pci_one_device_bound_uio();\n \tiommu_no_va = !pci_devices_iommu_support_va();\n #ifdef VFIO_PRESENT\n@@ -651,11 +651,10 @@ rte_pci_get_iommu_class(void)\n \t\t\t\t\ttrue : false;\n #endif\n \n-\tif (has_iova_va && !is_bound_uio && !is_vfio_noiommu_enabled &&\n-\t\t\t!iommu_no_va)\n+\tif (!is_bound_uio && !is_vfio_noiommu_enabled && !iommu_no_va)\n \t\treturn RTE_IOVA_VA;\n \n-\tif (has_iova_va) {\n+\tif (want_iova_va) {\n \t\tRTE_LOG(WARNING, EAL, \"Some devices want iova as va but pa will be used because.. \");\n \t\tif (is_vfio_noiommu_enabled)\n \t\t\tRTE_LOG(WARNING, EAL, \"vfio-noiommu mode configured\\n\");\n", "prefixes": [] }{ "id": 44392, "url": "