Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 44372,
    "url": "https://patches.dpdk.org/api/patches/44372/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20180907005307.98363-1-zhouqiang2633@gmail.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20180907005307.98363-1-zhouqiang2633@gmail.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20180907005307.98363-1-zhouqiang2633@gmail.com",
    "date": "2018-09-07T00:53:07",
    "name": "vhost: fix crash on unregistering in client mode",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "23089a993838118bbe66c3914ba4d4a27bb3a774",
    "submitter": {
        "id": 1121,
        "url": "https://patches.dpdk.org/api/people/1121/?format=api",
        "name": "Qiang Zhou",
        "email": "zhouqiang2633@gmail.com"
    },
    "delegate": {
        "id": 2642,
        "url": "https://patches.dpdk.org/api/users/2642/?format=api",
        "username": "mcoquelin",
        "first_name": "Maxime",
        "last_name": "Coquelin",
        "email": "maxime.coquelin@redhat.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20180907005307.98363-1-zhouqiang2633@gmail.com/mbox/",
    "series": [
        {
            "id": 1217,
            "url": "https://patches.dpdk.org/api/series/1217/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=1217",
            "date": "2018-09-07T00:53:07",
            "name": "vhost: fix crash on unregistering in client mode",
            "version": 1,
            "mbox": "https://patches.dpdk.org/series/1217/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/44372/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/44372/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 493244C80;\n\tFri,  7 Sep 2018 02:53:32 +0200 (CEST)",
            "from mail-pl1-f193.google.com (mail-pl1-f193.google.com\n\t[209.85.214.193]) by dpdk.org (Postfix) with ESMTP id CD44E3772;\n\tFri,  7 Sep 2018 02:53:30 +0200 (CEST)",
            "by mail-pl1-f193.google.com with SMTP id w14-v6so5759631plp.6;\n\tThu, 06 Sep 2018 17:53:30 -0700 (PDT)",
            "from localhost.localdomain ([203.100.54.194])\n\tby smtp.gmail.com with ESMTPSA id\n\tc1-v6sm7938460pfi.142.2018.09.06.17.53.28\n\t(version=TLS1 cipher=AES128-SHA bits=128/128);\n\tThu, 06 Sep 2018 17:53:29 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id;\n\tbh=LODiD/i/CfV5o7lt5erb3P+vUBZTmDlaKTMZuIZEVNE=;\n\tb=nCXCIget8LflNSOXiMiYhQ37wEUg5fB9UlY7mHBtlDmf0t7s3qovDzCnaLZ9ucTxh2\n\t3T22i7Rn0M2SCHzggzHSoGykv+3+vL1uOZCbXifldL9KxGjQeEs08XWoWKjBYXuaOWXR\n\txjEh9lr6+ogW6UsFx38iMerHu+64xlWYDPQO2Phhvns26Qy3KsATsJuSYDGy6VOvfdfb\n\tgqowfPmkQB3We4NVVGVtVJ0xnBufxukOKgfzgtjGVdOV7BHq3NDqYn4pn5oW490GTQC8\n\tk5/WTAr30cIx+VarY0PJuo68mziQexSUmVYsYhYxdHszMSr7bx1patW0/n2+z9czZsEy\n\t6jJA==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=LODiD/i/CfV5o7lt5erb3P+vUBZTmDlaKTMZuIZEVNE=;\n\tb=TpR2eLfp8JwWfgj6j468fupuxrU2z/C3vMEH3PzdEAvniX2eA8zgw8zqUewLlTvA+Z\n\t2UpUxWnl0GpMp66McHW/7d4+QVlRyxM7MirDDjuYjSbTeBRA8H4XfJgothzuWZvv411D\n\tYqvToH1KpaDf6PUpSw/bFRcDRfwLUN91B21n1fOwIH81zYuOZ8n11ChnjlJpobQIVL5k\n\txl/ZM86UunM+9uCkxO2Ag31PIOEaOJ7JD8TJNNzxng2PmXQuoKrpH96BTv3iWqnb1eJ8\n\ttVTrfZBchaNFMF0Jo98a29DJPyJr2MoZHxVmGezAdEtcDs+JYxj/BVwCZXdG0rI6QqBA\n\tLbrA==",
        "X-Gm-Message-State": "APzg51D/Y9yd8c7+RcYebHSGBGuibCN0A7qwEuOhgAE/VROBjA9NCVS9\n\tBbim1/ECB/4uAHavxdjycy5oILxr",
        "X-Google-Smtp-Source": "ANB0VdYOVPAnqxTh8MyfTXEWuUCGzlUkN/WySwMgyjvGIPDLBFpTCyY8JKLtkQzosMZnBOLnb0oRYw==",
        "X-Received": "by 2002:a17:902:3a3:: with SMTP id\n\td32-v6mr5413907pld.294.1536281609989; \n\tThu, 06 Sep 2018 17:53:29 -0700 (PDT)",
        "From": "Qiang Zhou <zhouqiang2633@gmail.com>",
        "To": "dev@dpdk.org",
        "Cc": "Qiang Zhou <zhouqiang2633@gmail.com>,\n\tstable@dpdk.org",
        "Date": "Fri,  7 Sep 2018 08:53:07 +0800",
        "Message-Id": "<20180907005307.98363-1-zhouqiang2633@gmail.com>",
        "X-Mailer": "git-send-email 2.14.3 (Apple Git-98)",
        "Subject": "[dpdk-dev] [PATCH] vhost: fix crash on unregistering in client mode",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "when rte_vhost_driver_unregister delete the connection fd,\nthe fd lock will prevent the vsocket to be freed. But when\nvhost_user_msg_handler return error, it will delete vsocket\nconn_list. And then the fd lock will become invalid. So the\nvsocket will be freed in rte_vhost_drivere_unregister and\nthe vhost_user_read_cb will reconnect.\n\nTo fix this:\nmove delete vsocket conn after reconnect\n\nCc: stable@dpdk.org\n\nSigned-off-by: Qiang Zhou <zhouqiang2633@gmail.com>\n---\n lib/librte_vhost/socket.c | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)",
    "diff": "diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c\nindex d63031747..43da1c51b 100644\n--- a/lib/librte_vhost/socket.c\n+++ b/lib/librte_vhost/socket.c\n@@ -293,16 +293,16 @@ vhost_user_read_cb(int connfd, void *dat, int *remove)\n \t\tif (vsocket->notify_ops->destroy_connection)\n \t\t\tvsocket->notify_ops->destroy_connection(conn->vid);\n \n+\t\tif (vsocket->reconnect) {\n+\t\t\tcreate_unix_socket(vsocket);\n+\t\t\tvhost_user_start_client(vsocket);\n+\t\t}\n+\n \t\tpthread_mutex_lock(&vsocket->conn_mutex);\n \t\tTAILQ_REMOVE(&vsocket->conn_list, conn, next);\n \t\tpthread_mutex_unlock(&vsocket->conn_mutex);\n \n \t\tfree(conn);\n-\n-\t\tif (vsocket->reconnect) {\n-\t\t\tcreate_unix_socket(vsocket);\n-\t\t\tvhost_user_start_client(vsocket);\n-\t\t}\n \t}\n }\n \n",
    "prefixes": []
}