Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/4434/?format=api
{ "id": 4434, "url": "https://patches.dpdk.org/api/patches/4434/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1429696650-9043-11-git-send-email-olivier.matz@6wind.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1429696650-9043-11-git-send-email-olivier.matz@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1429696650-9043-11-git-send-email-olivier.matz@6wind.com", "date": "2015-04-22T09:57:27", "name": "[dpdk-dev,v6,10/13] test/mbuf: rename mc variable in m", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "1292b3661e2e377d6fff47dbc6b263388a20916f", "submitter": { "id": 8, "url": "https://patches.dpdk.org/api/people/8/?format=api", "name": "Olivier Matz", "email": "olivier.matz@6wind.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1429696650-9043-11-git-send-email-olivier.matz@6wind.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/4434/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/4434/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 21206C3E8;\n\tWed, 22 Apr 2015 11:58:02 +0200 (CEST)", "from mail-wg0-f53.google.com (mail-wg0-f53.google.com\n\t[74.125.82.53]) by dpdk.org (Postfix) with ESMTP id A699CC370\n\tfor <dev@dpdk.org>; Wed, 22 Apr 2015 11:57:53 +0200 (CEST)", "by wgyo15 with SMTP id o15so240980243wgy.2\n\tfor <dev@dpdk.org>; Wed, 22 Apr 2015 02:57:53 -0700 (PDT)", "from glumotte.dev.6wind.com (6wind.net2.nerim.net.\n\t[213.41.180.237]) by mx.google.com with ESMTPSA id\n\tyr1sm6570006wjc.37.2015.04.22.02.57.52\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tWed, 22 Apr 2015 02:57:53 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=LYuXFF+tiLn3NfnW1Az8iP9CQv8k0gCoGFgaQdw96Jo=;\n\tb=kZfFU7A7CFFhZJE9S2XMga2G9zKqVkiuc+4sygHR7qssZN3ftZybDg5DO4w9c7w3li\n\tnpQA8DXoKwpPhbJbmAVeG1zcfuvgmBs4IYDwvPK72LhYjX4me9415a+jqExiSzKW3L1F\n\twnR0wUs5WQ4PyXHJ19fxP4gvtZU2PsdrsvqFzwvpFZEZNGi6aX4TpHPJa6TbiQN6dlSb\n\toeFRGfCmLQjwNoAPUzFoDoIyJahrqN5/RgI3Z9nUhi6NZ/HDQXY7e5RbRzTRwmM9uguI\n\tvuBaugCdHEE3Z+GpYVuKTJysXgC3BH30b69b8ZHcuxfAeND8kl7LUB2qi59mJ0pbIfRK\n\t/NSg==", "X-Gm-Message-State": "ALoCoQmBMPA0epWdiHNLxkluq0xPRde8SCJnfXiMjYxgyIIygDeOian4lUzz+Bv61reTL3dvqmrT", "X-Received": "by 10.194.175.70 with SMTP id by6mr50493333wjc.42.1429696673595; \n\tWed, 22 Apr 2015 02:57:53 -0700 (PDT)", "From": "Olivier Matz <olivier.matz@6wind.com>", "To": "dev@dpdk.org", "Date": "Wed, 22 Apr 2015 11:57:27 +0200", "Message-Id": "<1429696650-9043-11-git-send-email-olivier.matz@6wind.com>", "X-Mailer": "git-send-email 2.1.4", "In-Reply-To": "<1429696650-9043-1-git-send-email-olivier.matz@6wind.com>", "References": "<1429610122-30943-1-git-send-email-olivier.matz@6wind.com>\n\t<1429696650-9043-1-git-send-email-olivier.matz@6wind.com>", "Subject": "[dpdk-dev] [PATCH v6 10/13] test/mbuf: rename mc variable in m", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "It's better to name the mbuf 'm' instead of 'mc' as it's not a clone.\n\nSigned-off-by: Olivier Matz <olivier.matz@6wind.com>\nAcked-by: Neil Horman <nhorman@tuxdriver.com>\n---\n app/test/test_mbuf.c | 25 ++++++++++++-------------\n 1 file changed, 12 insertions(+), 13 deletions(-)", "diff": "diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c\nindex 4774263..2614598 100644\n--- a/app/test/test_mbuf.c\n+++ b/app/test/test_mbuf.c\n@@ -320,43 +320,42 @@ fail:\n static int\n testclone_testupdate_testdetach(void)\n {\n-\tstruct rte_mbuf *mc = NULL;\n+\tstruct rte_mbuf *m = NULL;\n \tstruct rte_mbuf *clone = NULL;\n \n \t/* alloc a mbuf */\n-\n-\tmc = rte_pktmbuf_alloc(pktmbuf_pool);\n-\tif (mc == NULL)\n+\tm = rte_pktmbuf_alloc(pktmbuf_pool);\n+\tif (m == NULL)\n \t\tGOTO_FAIL(\"ooops not allocating mbuf\");\n \n-\tif (rte_pktmbuf_pkt_len(mc) != 0)\n+\tif (rte_pktmbuf_pkt_len(m) != 0)\n \t\tGOTO_FAIL(\"Bad length\");\n \n \n \t/* clone the allocated mbuf */\n-\tclone = rte_pktmbuf_clone(mc, pktmbuf_pool);\n+\tclone = rte_pktmbuf_clone(m, pktmbuf_pool);\n \tif (clone == NULL)\n \t\tGOTO_FAIL(\"cannot clone data\\n\");\n \trte_pktmbuf_free(clone);\n \n-\tmc->next = rte_pktmbuf_alloc(pktmbuf_pool);\n-\tif(mc->next == NULL)\n+\tm->next = rte_pktmbuf_alloc(pktmbuf_pool);\n+\tif (m->next == NULL)\n \t\tGOTO_FAIL(\"Next Pkt Null\\n\");\n \n-\tclone = rte_pktmbuf_clone(mc, pktmbuf_pool);\n+\tclone = rte_pktmbuf_clone(m, pktmbuf_pool);\n \tif (clone == NULL)\n \t\tGOTO_FAIL(\"cannot clone data\\n\");\n \n \t/* free mbuf */\n-\trte_pktmbuf_free(mc);\n+\trte_pktmbuf_free(m);\n \trte_pktmbuf_free(clone);\n-\tmc = NULL;\n+\tm = NULL;\n \tclone = NULL;\n \treturn 0;\n \n fail:\n-\tif (mc)\n-\t\trte_pktmbuf_free(mc);\n+\tif (m)\n+\t\trte_pktmbuf_free(m);\n \treturn -1;\n }\n #undef GOTO_FAIL\n", "prefixes": [ "dpdk-dev", "v6", "10/13" ] }