Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/4388/?format=api
{ "id": 4388, "url": "https://patches.dpdk.org/api/patches/4388/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1429544496-22532-11-git-send-email-olivier.matz@6wind.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1429544496-22532-11-git-send-email-olivier.matz@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1429544496-22532-11-git-send-email-olivier.matz@6wind.com", "date": "2015-04-20T15:41:34", "name": "[dpdk-dev,v4,10/12] test/mbuf: rename mc variable in m", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "1292b3661e2e377d6fff47dbc6b263388a20916f", "submitter": { "id": 8, "url": "https://patches.dpdk.org/api/people/8/?format=api", "name": "Olivier Matz", "email": "olivier.matz@6wind.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1429544496-22532-11-git-send-email-olivier.matz@6wind.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/4388/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/4388/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 756E8C3E8;\n\tMon, 20 Apr 2015 17:42:03 +0200 (CEST)", "from mail-wi0-f174.google.com (mail-wi0-f174.google.com\n\t[209.85.212.174]) by dpdk.org (Postfix) with ESMTP id 078D6C392\n\tfor <dev@dpdk.org>; Mon, 20 Apr 2015 17:41:56 +0200 (CEST)", "by wicmx19 with SMTP id mx19so43093831wic.1\n\tfor <dev@dpdk.org>; Mon, 20 Apr 2015 08:41:55 -0700 (PDT)", "from glumotte.dev.6wind.com (6wind.net2.nerim.net.\n\t[213.41.180.237]) by mx.google.com with ESMTPSA id\n\tfm8sm11258951wib.9.2015.04.20.08.41.55\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tMon, 20 Apr 2015 08:41:55 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=DfVQMGhl7YdNi80LQn8wdtXNXTJV4cP4+6HMgHWHYk4=;\n\tb=a0bNIlvxgnyp1cBFCnROhJZQgI/XJvtfY4GkjDi4JfDhrUBtgF15GFvKtiWcrEzYjn\n\tEEV98/LkcoCAfSNH2hc8fVgOa80joGkNmLDf6tDR2XUN3OchRxqTq9VyibNTNktjbDgR\n\tEupYv94C9P6naOG9sDoNEn4EBRZoOd24QjAACk3gL6APKwslIYRapCyHuESWvJMgea2Y\n\tVVe1Bywzc45jTaVVzLnQAdbDoIDCbwrj55awmuXF7I2btyzZUvWSWFOt5aASM1hS5QsN\n\t4HM+qipMSD+NIJJVzPHx5XcCRd0p0fxRgxQPSSTk0wbiD27omlN20tgdvQa1RkEWJu5+\n\tAAQg==", "X-Gm-Message-State": "ALoCoQl0eo26QTA8V3RaZc46GFyeO5Pgdtl8MbP+tZWajRL+JsfHAijPrM0bocZjVYJTLxJvoKvT", "X-Received": "by 10.180.99.231 with SMTP id et7mr26737384wib.23.1429544515929; \n\tMon, 20 Apr 2015 08:41:55 -0700 (PDT)", "From": "Olivier Matz <olivier.matz@6wind.com>", "To": "dev@dpdk.org", "Date": "Mon, 20 Apr 2015 17:41:34 +0200", "Message-Id": "<1429544496-22532-11-git-send-email-olivier.matz@6wind.com>", "X-Mailer": "git-send-email 2.1.4", "In-Reply-To": "<1429544496-22532-1-git-send-email-olivier.matz@6wind.com>", "References": "<1427829784-12323-2-git-send-email-zer0@droids-corp.org>\n\t<1429544496-22532-1-git-send-email-olivier.matz@6wind.com>", "Subject": "[dpdk-dev] [PATCH v4 10/12] test/mbuf: rename mc variable in m", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "It's better to name the mbuf 'm' instead of 'mc' as it's not a clone.\n\nSigned-off-by: Olivier Matz <olivier.matz@6wind.com>\n---\n app/test/test_mbuf.c | 25 ++++++++++++-------------\n 1 file changed, 12 insertions(+), 13 deletions(-)", "diff": "diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c\nindex 4774263..2614598 100644\n--- a/app/test/test_mbuf.c\n+++ b/app/test/test_mbuf.c\n@@ -320,43 +320,42 @@ fail:\n static int\n testclone_testupdate_testdetach(void)\n {\n-\tstruct rte_mbuf *mc = NULL;\n+\tstruct rte_mbuf *m = NULL;\n \tstruct rte_mbuf *clone = NULL;\n \n \t/* alloc a mbuf */\n-\n-\tmc = rte_pktmbuf_alloc(pktmbuf_pool);\n-\tif (mc == NULL)\n+\tm = rte_pktmbuf_alloc(pktmbuf_pool);\n+\tif (m == NULL)\n \t\tGOTO_FAIL(\"ooops not allocating mbuf\");\n \n-\tif (rte_pktmbuf_pkt_len(mc) != 0)\n+\tif (rte_pktmbuf_pkt_len(m) != 0)\n \t\tGOTO_FAIL(\"Bad length\");\n \n \n \t/* clone the allocated mbuf */\n-\tclone = rte_pktmbuf_clone(mc, pktmbuf_pool);\n+\tclone = rte_pktmbuf_clone(m, pktmbuf_pool);\n \tif (clone == NULL)\n \t\tGOTO_FAIL(\"cannot clone data\\n\");\n \trte_pktmbuf_free(clone);\n \n-\tmc->next = rte_pktmbuf_alloc(pktmbuf_pool);\n-\tif(mc->next == NULL)\n+\tm->next = rte_pktmbuf_alloc(pktmbuf_pool);\n+\tif (m->next == NULL)\n \t\tGOTO_FAIL(\"Next Pkt Null\\n\");\n \n-\tclone = rte_pktmbuf_clone(mc, pktmbuf_pool);\n+\tclone = rte_pktmbuf_clone(m, pktmbuf_pool);\n \tif (clone == NULL)\n \t\tGOTO_FAIL(\"cannot clone data\\n\");\n \n \t/* free mbuf */\n-\trte_pktmbuf_free(mc);\n+\trte_pktmbuf_free(m);\n \trte_pktmbuf_free(clone);\n-\tmc = NULL;\n+\tm = NULL;\n \tclone = NULL;\n \treturn 0;\n \n fail:\n-\tif (mc)\n-\t\trte_pktmbuf_free(mc);\n+\tif (m)\n+\t\trte_pktmbuf_free(m);\n \treturn -1;\n }\n #undef GOTO_FAIL\n", "prefixes": [ "dpdk-dev", "v4", "10/12" ] }