Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/43797/?format=api
{ "id": 43797, "url": "https://patches.dpdk.org/api/patches/43797/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20180821084515.2a802429@xeon-e3/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180821084515.2a802429@xeon-e3>", "list_archive_url": "https://inbox.dpdk.org/dev/20180821084515.2a802429@xeon-e3", "date": "2018-08-21T15:45:15", "name": "[v3] ethdev: silence error message on rte_eth_dev_owner_unset", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "b62085dc385d15727ea3e2872009fb908ea4d941", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20180821084515.2a802429@xeon-e3/mbox/", "series": [ { "id": 1025, "url": "https://patches.dpdk.org/api/series/1025/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=1025", "date": "2018-08-21T15:45:15", "name": "[v3] ethdev: silence error message on rte_eth_dev_owner_unset", "version": 3, "mbox": "https://patches.dpdk.org/series/1025/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/43797/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/43797/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 935522C38;\n\tTue, 21 Aug 2018 17:45:20 +0200 (CEST)", "from mail-pg1-f195.google.com (mail-pg1-f195.google.com\n\t[209.85.215.195]) by dpdk.org (Postfix) with ESMTP id A098098\n\tfor <dev@dpdk.org>; Tue, 21 Aug 2018 17:45:18 +0200 (CEST)", "by mail-pg1-f195.google.com with SMTP id a11-v6so8640131pgw.6\n\tfor <dev@dpdk.org>; Tue, 21 Aug 2018 08:45:18 -0700 (PDT)", "from xeon-e3 (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\tc11-v6sm7478567pgc.70.2018.08.21.08.45.17\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 21 Aug 2018 08:45:17 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=dMbA1glzFBgl06m7iI1DvA4pllQNgt7KVOXGY9ZR5t4=;\n\tb=yOh3Ng9j4OB00RzL6tkNH8RjnX8uDtdwohQAuOX1UC4EQCynamHKsY4kHAsHqnu6S/\n\tb3K+/ua54JFYtOZ+X1D7AcfptW1GKJO67DSIL+rDNKoa8U6lUxuXT1l+zjuCDLpqZ/oN\n\t+adIHH+1YxgEwHF5WSdfrI8ZRZq0x4fsMauaEfBxomJeuxf1znoortgtqLeXuPC9ANWH\n\tr7rO6wU4p3P07nHDvaI3/VhzbltLN0UNjLGoAgJ3znGtHjbJ8euF0a9PbrWFz8qYCvqP\n\t+vI2qj2MXcQ2rwifZbAf0SqrAWRJMcL5YgnJEQTgafi70D21NTnj9eNZJi9EtD75aR80\n\ttbYw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=dMbA1glzFBgl06m7iI1DvA4pllQNgt7KVOXGY9ZR5t4=;\n\tb=OXZDIGLmTiQMuyC7xnL7/6nBxSVFLxkhFQpcOjcC/SfzPWp02lb+t4VWCEApikFMyC\n\tSOV03pwYgULN7zMgjqAVEB/6OtYAuWfM+Y1QGGJAL8+ZBx149OmL1oWLQXgGc+ZW8nf+\n\t8Pm0biQPxFO1M5xg/KUHLcmofg37lVWoJ5VWlGcVm9t6XNips7DUCArC1dBlRag/wwL7\n\th4kykmtsUL+f0yKb9RGrEWaUMo/603fF1aZy//Nk40HJvam5c1yi5+xH9MillHhUK/oH\n\tDdc4xIAFCIuuG22TcYPkfJ/qMi33Mb88f6zkMDZw9VJHiq77JYYTi3jUroDUto0rTUof\n\taTPA==", "X-Gm-Message-State": "APzg51CR5iVpFoiV2gElTJT/8se5kJOgXWxw0YdNaNSiVIMw53BfJqft\n\t5TBIFk20/OYmGcN/sDFwuQmdgw==", "X-Google-Smtp-Source": "ANB0VdYN4aMDlI5uoWs8CeVvLTvzwzNd//1qFKdTRIBniXV6AeWQABDpBe7t7eNmIAgJwrql1sLpsA==", "X-Received": "by 2002:a65:65c6:: with SMTP id\n\ty6-v6mr2291077pgv.436.1534866317660; \n\tTue, 21 Aug 2018 08:45:17 -0700 (PDT)", "Date": "Tue, 21 Aug 2018 08:45:15 -0700", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "matan@mellanox.com", "Cc": "dev@dpdk.org", "Message-ID": "<20180821084515.2a802429@xeon-e3>", "In-Reply-To": "<20180816224409.5719-2-stephen@networkplumber.org>", "References": "<20180814001926.19630-1-stephen@networkplumber.org>\n\t<20180816224409.5719-1-stephen@networkplumber.org>\n\t<20180816224409.5719-2-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=US-ASCII", "Content-Transfer-Encoding": "quoted-printable", "Subject": "[dpdk-dev] [PATCH v3] ethdev: silence error message on\n\trte_eth_dev_owner_unset", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From 74ad4c60262b1451a5a2fabf79a2df89c6c5373d Mon Sep 17 00:00:00 2001\nFrom: Stephen Hemminger <stephen@networkplumber.org>\nDate: Thu, 16 Aug 2018 15:37:14 -0700\nSubject: [PATCH 1/5] ethdev: silence error message on rte_eth_dev_owner_unset\n\nThe rte_eth_dev_owner_unset function always generates a log\nmessage because the unset value for owner id is 0.\n\nAlso, when rte_eth_dev_owner_delete is called with a valid\nowner id, the log message should be at NOTICE not ERROR\nseverity.\n\nFixes: 5b7ba31148a8 (\"ethdev: add port ownership\")\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\nv3 - handle rte_eth_dev_owner_delete\n leave other cleanups to later patch series\n\n lib/librte_ethdev/rte_ethdev.c | 17 +++++++++++------\n 1 file changed, 11 insertions(+), 6 deletions(-)", "diff": "diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c\nindex 4c320250589a..56dd9c2e83d9 100644\n--- a/lib/librte_ethdev/rte_ethdev.c\n+++ b/lib/librte_ethdev/rte_ethdev.c\n@@ -393,11 +393,8 @@ static int\n rte_eth_is_valid_owner_id(uint64_t owner_id)\n {\n \tif (owner_id == RTE_ETH_DEV_NO_OWNER ||\n-\t rte_eth_dev_shared_data->next_owner_id <= owner_id) {\n-\t\tRTE_ETHDEV_LOG(ERR, \"Invalid owner_id=%016\"PRIx64\"\\n\",\n-\t\t\towner_id);\n+\t rte_eth_dev_shared_data->next_owner_id <= owner_id)\n \t\treturn 0;\n-\t}\n \treturn 1;\n }\n \n@@ -444,8 +441,12 @@ _rte_eth_dev_owner_set(const uint16_t port_id, const uint64_t old_owner_id,\n \t}\n \n \tif (!rte_eth_is_valid_owner_id(new_owner->id) &&\n-\t !rte_eth_is_valid_owner_id(old_owner_id))\n+\t !rte_eth_is_valid_owner_id(old_owner_id)) {\n+\t\tRTE_ETHDEV_LOG(ERR,\n+\t\t\t \"Invalid owner old_id=%016\"PRIx64\" new_id=%016\"PRIx64\"\\n\",\n+\t\t\t old_owner_id, new_owner->id);\n \t\treturn -EINVAL;\n+\t}\n \n \tport_owner = &rte_eth_devices[port_id].data->owner;\n \tif (port_owner->id != old_owner_id) {\n@@ -516,9 +517,13 @@ rte_eth_dev_owner_delete(const uint64_t owner_id)\n \t\t\tif (rte_eth_devices[port_id].data->owner.id == owner_id)\n \t\t\t\tmemset(&rte_eth_devices[port_id].data->owner, 0,\n \t\t\t\t sizeof(struct rte_eth_dev_owner));\n-\t\tRTE_ETHDEV_LOG(ERR,\n+\t\tRTE_ETHDEV_LOG(NOTICE,\n \t\t\t\"All port owners owned by %016\"PRIx64\" identifier have removed\\n\",\n \t\t\towner_id);\n+\t} else {\n+\t\tRTE_ETHDEV_LOG(ERR,\n+\t\t\t \"Invalid owner id=%016\"PRIx64\"\\n\",\n+\t\t\t owner_id);\n \t}\n \n \trte_spinlock_unlock(&rte_eth_dev_shared_data->ownership_lock);\n", "prefixes": [ "v3" ] }