Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/43709/?format=api
{ "id": 43709, "url": "https://patches.dpdk.org/api/patches/43709/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20180814143035.19640-2-bluca@debian.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180814143035.19640-2-bluca@debian.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20180814143035.19640-2-bluca@debian.org", "date": "2018-08-14T14:30:35", "name": "[2/2] virtio: fix PCI config err handling", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "7755c6091225f8d0fc3e8875ba8b619d35db901e", "submitter": { "id": 823, "url": "https://patches.dpdk.org/api/people/823/?format=api", "name": "Luca Boccassi", "email": "bluca@debian.org" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20180814143035.19640-2-bluca@debian.org/mbox/", "series": [ { "id": 980, "url": "https://patches.dpdk.org/api/series/980/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=980", "date": "2018-08-14T14:30:34", "name": "[1/2] bus/pci: harmonize and document rte_pci_read_config return value", "version": 1, "mbox": "https://patches.dpdk.org/series/980/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/43709/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/43709/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C64DA4F90;\n\tTue, 14 Aug 2018 16:30:55 +0200 (CEST)", "from mail-wr1-f68.google.com (mail-wr1-f68.google.com\n\t[209.85.221.68]) by dpdk.org (Postfix) with ESMTP id 11F424D3A\n\tfor <dev@dpdk.org>; Tue, 14 Aug 2018 16:30:54 +0200 (CEST)", "by mail-wr1-f68.google.com with SMTP id r16-v6so17384392wrt.11\n\tfor <dev@dpdk.org>; Tue, 14 Aug 2018 07:30:54 -0700 (PDT)", "from localhost ([2001:1be0:110d:fcfe:41aa:5bfa:6cf3:7531])\n\tby smtp.gmail.com with ESMTPSA id\n\tj16-v6sm8136186wme.8.2018.08.14.07.30.52\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 14 Aug 2018 07:30:52 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=nAtpUAhVt9PRymbt5xr8vsospfnub2qfL/2BPNoA8cc=;\n\tb=m5epH6B0Qx7Eoug3NSX4Mle2vfLM0tsHfLFGRB5Ko9iZie1N4BSQwG/h6qbOHPlj3c\n\tWXg6y9vP9XMfl+ICwCNq1PqNRsS9NEDCUDLVJ9nFnpFrw1ihIJe03UqwRLpZ4krEd3kw\n\t2sZGOtfJn4Btqc7bBfVy9apdKFQdGMkvXNunXe0GSl2RUGy1XyAWPPCYWaTs04ZrDO7O\n\tMyFE0ZIcWiLiOJdDA0MnTiiqU4QeosabHh+TN3kmMIxakQVUfHJ9Huu2MuRx8Vqbx5GC\n\tO77sx/2R+kIkTk5mHV87qJdqz5SMFAazOwi4H7rPqZzaDqXaufkuUwClhtQz4DqS97A+\n\tjn+A==", "X-Gm-Message-State": "AOUpUlEptqpgb+nIKSiI1wmDhIW4Br+YFS80k2ufA6dggH1kjUIz1tMu\n\tB7EF/2Df8l/1nj/i+nBT6FQzuz1Q", "X-Google-Smtp-Source": "AA+uWPy/CTqAxtcBCcd9z8MkXHmRoiu+PfIQZaNxiyBV+AnU4qVvFBtzPOlC5aH3hapsSzQXPkXxhw==", "X-Received": "by 2002:a5d:574d:: with SMTP id\n\tq13-v6mr12969949wrw.24.1534257053456; \n\tTue, 14 Aug 2018 07:30:53 -0700 (PDT)", "From": "Luca Boccassi <bluca@debian.org>", "To": "dev@dpdk.org", "Cc": "maxime.coquelin@redhat.com, zhihong.wang@intel.com, tiwei.bie@intel.com, \n\tbruce.richardson@intel.com, Brian Russell <brussell@brocade.com>", "Date": "Tue, 14 Aug 2018 15:30:35 +0100", "Message-Id": "<20180814143035.19640-2-bluca@debian.org>", "X-Mailer": "git-send-email 2.18.0", "In-Reply-To": "<20180814143035.19640-1-bluca@debian.org>", "References": "<20180814143035.19640-1-bluca@debian.org>", "Subject": "[dpdk-dev] [PATCH 2/2] virtio: fix PCI config err handling", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Brian Russell <brussell@brocade.com>\n\nIn virtio_read_caps, rte_pci_read_config returns the number of bytes\nread from PCI config or < 0 on error.\nIf less than the expected number of bytes are read then log the\nfailure and return rather than carrying on with garbage.\n\nSigned-off-by: Brian Russell <brussell@brocade.com>\n---\n\nFollow-up from:\nhttp://mails.dpdk.org/archives/dev/2017-June/067278.html\nhttps://patches.dpdk.org/patch/25056/\n\n drivers/net/virtio/virtio_pci.c | 12 +++++++-----\n 1 file changed, 7 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/virtio/virtio_pci.c b/drivers/net/virtio/virtio_pci.c\nindex 6bd22e54a6..a10698aed8 100644\n--- a/drivers/net/virtio/virtio_pci.c\n+++ b/drivers/net/virtio/virtio_pci.c\n@@ -567,16 +567,18 @@ virtio_read_caps(struct rte_pci_device *dev, struct virtio_hw *hw)\n \t}\n \n \tret = rte_pci_read_config(dev, &pos, 1, PCI_CAPABILITY_LIST);\n-\tif (ret < 0) {\n-\t\tPMD_INIT_LOG(DEBUG, \"failed to read pci capability list\");\n+\tif (ret != 1) {\n+\t\tPMD_INIT_LOG(DEBUG,\n+\t\t\t \"failed to read pci capability list, ret %d\", ret);\n \t\treturn -1;\n \t}\n \n \twhile (pos) {\n \t\tret = rte_pci_read_config(dev, &cap, sizeof(cap), pos);\n-\t\tif (ret < 0) {\n-\t\t\tPMD_INIT_LOG(ERR,\n-\t\t\t\t\"failed to read pci cap at pos: %x\", pos);\n+\t\tif (ret != sizeof(cap)) {\n+\t\t\tPMD_INIT_LOG(DEBUG,\n+\t\t\t\t \"failed to read pci cap at pos: %x ret %d\",\n+\t\t\t\t pos, ret);\n \t\t\tbreak;\n \t\t}\n \n", "prefixes": [ "2/2" ] }