Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/4318/?format=api
{ "id": 4318, "url": "https://patches.dpdk.org/api/patches/4318/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1429130956-17828-1-git-send-email-thomas.monjalon@6wind.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1429130956-17828-1-git-send-email-thomas.monjalon@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1429130956-17828-1-git-send-email-thomas.monjalon@6wind.com", "date": "2015-04-15T20:49:15", "name": "[dpdk-dev,v2,1/2] ixgbe: fix build with gcc 4.4", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "c1eae14a1358c81b5df57b8a7345f1d532e3cf6f", "submitter": { "id": 1, "url": "https://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1429130956-17828-1-git-send-email-thomas.monjalon@6wind.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/4318/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/4318/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id DB765C360;\n\tWed, 15 Apr 2015 22:50:15 +0200 (CEST)", "from mail-wi0-f179.google.com (mail-wi0-f179.google.com\n\t[209.85.212.179]) by dpdk.org (Postfix) with ESMTP id EEB99C35C\n\tfor <dev@dpdk.org>; Wed, 15 Apr 2015 22:50:13 +0200 (CEST)", "by wizk4 with SMTP id k4so170102343wiz.1\n\tfor <dev@dpdk.org>; Wed, 15 Apr 2015 13:50:13 -0700 (PDT)", "from localhost.localdomain (136-92-190-109.dsl.ovh.fr.\n\t[109.190.92.136]) by mx.google.com with ESMTPSA id\n\tpv2sm7480174wjc.33.2015.04.15.13.50.12\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tWed, 15 Apr 2015 13:50:12 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-type:content-transfer-encoding;\n\tbh=0QLXWViNiXes1x8Afw1pF7QmKJJtUUKFuBz4a6/hhqw=;\n\tb=drkV2RBagmzL40vXfsrGbLn8xJTxW0medLdDe04eGkhlWHS4sW2fQCK1+FXD0yCr4k\n\t04zyJDxxvF1rh8pAIMvSJRNLwKrlTOjFXNFnNM4nlKHDVTft5vWafb+oR+TSe9T0NOKP\n\tx9dPw3d4AWON307aunXwaZQXgVTjDQVV3AX+tm3UoREkjioGJsP8QigFUyUDIxG9gLzO\n\t/VrrQZY2RRmedgRhKS51IvAFY0c55+WXVEsl3V08YarY53/m6JbMZskiIw7KcJNiGaC6\n\tZp0mROO5Ty90SsLozSz+ZRWRdIMDlr/zdgf6LSUA9x05qMPuGs5r3ncRNDkenQmSfWxi\n\tcZ1w==", "X-Gm-Message-State": "ALoCoQkLqPgicF1+HqsLJyxMw4mMD+kEA7LX9+CdXLAVfu0VCDVlEpDYQ8q4gt/C0C4h437GhHuj", "X-Received": "by 10.194.200.42 with SMTP id jp10mr52267782wjc.66.1429131013828;\n\tWed, 15 Apr 2015 13:50:13 -0700 (PDT)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "dev@dpdk.org", "Date": "Wed, 15 Apr 2015 22:49:15 +0200", "Message-Id": "<1429130956-17828-1-git-send-email-thomas.monjalon@6wind.com>", "X-Mailer": "git-send-email 2.2.2", "In-Reply-To": "<1958525.YbKd0lDtje@xps13>", "References": "<1958525.YbKd0lDtje@xps13>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 1/2] ixgbe: fix build with gcc 4.4", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "With GCC 4.4.7 from CentOS 6.5, the following errors arise:\n\nlib/librte_pmd_ixgbe/ixgbe_rxtx.c: In function ‘ixgbe_dev_rx_queue_setup’:\nlib/librte_pmd_ixgbe/ixgbe_rxtx.c:2509: error: missing initializer\nlib/librte_pmd_ixgbe/ixgbe_rxtx.c:2509: error: (near initialization for ‘dev_info.driver_name’)\n\nlib/librte_pmd_ixgbe/ixgbe_rxtx.c: In function ‘ixgbe_set_rsc’:\nlib/librte_pmd_ixgbe/ixgbe_rxtx.c:4072: error: missing initializer\nlib/librte_pmd_ixgbe/ixgbe_rxtx.c:4072: error: (near initialization for ‘dev_info.driver_name’)\n\nlib/librte_pmd_ixgbe/ixgbe_rxtx.c: In function ‘ixgbe_recv_pkts_lro_single_alloc’:\nlib/librte_pmd_ixgbe/ixgbe_rxtx.c:1479: error: ‘next_rsc_entry’ may be used uninitialized in this function\nlib/librte_pmd_ixgbe/ixgbe_rxtx.c:1480: error: ‘next_rxe’ may be used uninitialized in this function\n\nThe \"missing initializer\" warning is a GCC bug which seems fixed in 4.7.\nThe \"may be used uninitialized\" warning seems to be another GCC bug and is\nworkarounded with NULL initialization.\n\nFixes: 8eecb3295aed (\"ixgbe: add LRO support\")\n\nSigned-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>\n---\nchanges in v2:\n- option -Wno-missing-field-initializers for old GCC instead of code workaround\n\n lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 4 ++--\n mk/toolchain/gcc/rte.vars.mk | 5 +++++\n 2 files changed, 7 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c\nindex f1da9ec..6475c44 100644\n--- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c\n+++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c\n@@ -1476,8 +1476,8 @@ ixgbe_recv_pkts_lro(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts,\n \t\tbool eop;\n \t\tstruct ixgbe_rx_entry *rxe;\n \t\tstruct ixgbe_rsc_entry *rsc_entry;\n-\t\tstruct ixgbe_rsc_entry *next_rsc_entry;\n-\t\tstruct ixgbe_rx_entry *next_rxe;\n+\t\tstruct ixgbe_rsc_entry *next_rsc_entry = NULL;\n+\t\tstruct ixgbe_rx_entry *next_rxe = NULL;\n \t\tstruct rte_mbuf *first_seg;\n \t\tstruct rte_mbuf *rxm;\n \t\tstruct rte_mbuf *nmb;\ndiff --git a/mk/toolchain/gcc/rte.vars.mk b/mk/toolchain/gcc/rte.vars.mk\nindex 88f235c..208cddd 100644\n--- a/mk/toolchain/gcc/rte.vars.mk\n+++ b/mk/toolchain/gcc/rte.vars.mk\n@@ -80,5 +80,10 @@ WERROR_FLAGS += -Wundef -Wwrite-strings\n # process cpu flags\n include $(RTE_SDK)/mk/toolchain/$(RTE_TOOLCHAIN)/rte.toolchain-compat.mk\n \n+# workaround GCC bug with warning \"missing initializer\" for \"= {0}\"\n+ifeq ($(shell test $(GCC_VERSION) -lt 47 && echo 1), 1)\n+WERROR_FLAGS += -Wno-missing-field-initializers\n+endif\n+\n export CC AS AR LD OBJCOPY OBJDUMP STRIP READELF\n export TOOLCHAIN_CFLAGS TOOLCHAIN_LDFLAGS TOOLCHAIN_ASFLAGS\n", "prefixes": [ "dpdk-dev", "v2", "1/2" ] }