Show a patch.

GET /api/patches/430/?format=api
HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 430,
    "url": "https://patches.dpdk.org/api/patches/430/?format=api",
    "web_url": "https://patches.dpdk.org/patch/430/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk"
    },
    "msgid": "<1411089280-23595-4-git-send-email-helin.zhang@intel.com>",
    "date": "2014-09-19T01:14:40",
    "name": "[dpdk-dev,v2,3/3] i40evf: support of RSS in VF",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "32216b04638cb3aa831ea2554d96681aeddb42db",
    "submitter": {
        "id": 14,
        "url": "https://patches.dpdk.org/api/people/14/?format=api",
        "name": "Helin Zhang",
        "email": "helin.zhang@intel.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/patch/430/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/430/comments/",
    "check": "pending",
    "checks": "https://patches.dpdk.org/api/patches/430/checks/",
    "tags": {},
    "headers": {
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "Return-Path": "<dev-bounces@dpdk.org>",
        "Message-Id": "<1411089280-23595-4-git-send-email-helin.zhang@intel.com>",
        "X-Mailer": "git-send-email 1.7.4.1",
        "To": "dev@dpdk.org",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 24C82B392;\n\tFri, 19 Sep 2014 03:09:38 +0200 (CEST)",
            "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id 25209B347\n\tfor <dev@dpdk.org>; Fri, 19 Sep 2014 03:09:35 +0200 (CEST)",
            "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga103.fm.intel.com with ESMTP; 18 Sep 2014 18:06:26 -0700",
            "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby fmsmga001.fm.intel.com with ESMTP; 18 Sep 2014 18:14:51 -0700",
            "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id s8J1EoXJ024917;\n\tFri, 19 Sep 2014 09:14:50 +0800",
            "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid s8J1Emhj023651; Fri, 19 Sep 2014 09:14:50 +0800",
            "(from hzhan75@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id s8J1Emv6023647; \n\tFri, 19 Sep 2014 09:14:48 +0800"
        ],
        "X-BeenThere": "dev@dpdk.org",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "Subject": "[dpdk-dev] [PATCH v2 3/3] i40evf: support of RSS in VF",
        "In-Reply-To": "<1411089280-23595-1-git-send-email-helin.zhang@intel.com>",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "Date": "Fri, 19 Sep 2014 09:14:40 +0800",
        "X-ExtLoop1": "1",
        "Precedence": "list",
        "From": "Helin Zhang <helin.zhang@intel.com>",
        "X-IronPort-AV": "E=Sophos;i=\"5.04,550,1406617200\"; d=\"scan'208\";a=\"593580955\"",
        "References": "<1411089280-23595-1-git-send-email-helin.zhang@intel.com>",
        "X-Original-To": "patchwork@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>",
        "Errors-To": "dev-bounces@dpdk.org",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "Delivered-To": "patchwork@dpdk.org",
        "X-Mailman-Version": "2.1.15"
    },
    "content": "i40e hardware supports RSS in VF, the code changes are to add\nthis support.\n\nv2 changes:\nUpdating/querying redirection table has been removed, as it\nwill be in another patches of supporting different redirection\ntable sizes soon later.\n\nSigned-off-by: Helin Zhang <helin.zhang@intel.com>\nReviewed-by: Cunming Liang <cunming.liang@intel.com>\nReviewed-by: Jijiang Liu <jijiang.liu@intel.com>\n---\n lib/librte_pmd_i40e/i40e_ethdev.h    |   6 ++\n lib/librte_pmd_i40e/i40e_ethdev_vf.c | 142 +++++++++++++++++++++++++++++++++++\n 2 files changed, 148 insertions(+)",
    "diff": "diff --git a/lib/librte_pmd_i40e/i40e_ethdev.h b/lib/librte_pmd_i40e/i40e_ethdev.h\nindex c801345..1d42cd2 100644\n--- a/lib/librte_pmd_i40e/i40e_ethdev.h\n+++ b/lib/librte_pmd_i40e/i40e_ethdev.h\n@@ -283,6 +283,8 @@ struct i40e_vf_tx_queues {\n  * Structure to store private data specific for VF instance.\n  */\n struct i40e_vf {\n+\tstruct i40e_adapter *adapter; /* The adapter this VF associate to */\n+\tstruct rte_eth_dev_data *dev_data; /* Pointer to the device data */\n \tuint16_t num_queue_pairs;\n \tuint16_t max_pkt_len; /* Maximum packet length */\n \tbool promisc_unicast_enabled;\n@@ -393,6 +395,10 @@ i40e_get_vsi_from_adapter(struct i40e_adapter *adapter)\n #define I40E_PF_TO_ADAPTER(pf) \\\n \t((struct i40e_adapter *)pf->adapter)\n \n+/* I40E_VF_TO */\n+#define I40E_VF_TO_HW(vf) \\\n+\t(&(((struct i40e_vf *)vf)->adapter->hw))\n+\n static inline void\n i40e_init_adminq_parameter(struct i40e_hw *hw)\n {\ndiff --git a/lib/librte_pmd_i40e/i40e_ethdev_vf.c b/lib/librte_pmd_i40e/i40e_ethdev_vf.c\nindex d8552ad..840ae65 100644\n--- a/lib/librte_pmd_i40e/i40e_ethdev_vf.c\n+++ b/lib/librte_pmd_i40e/i40e_ethdev_vf.c\n@@ -125,10 +125,19 @@ static void i40evf_dev_allmulticast_disable(struct rte_eth_dev *dev);\n static int i40evf_get_link_status(struct rte_eth_dev *dev,\n \t\t\t\t  struct rte_eth_link *link);\n static int i40evf_init_vlan(struct rte_eth_dev *dev);\n+static int i40evf_config_rss(struct i40e_vf *vf);\n+static int i40evf_dev_rss_hash_update(struct rte_eth_dev *dev,\n+\t\t\t\t      struct rte_eth_rss_conf *rss_conf);\n+static int i40evf_dev_rss_hash_conf_get(struct rte_eth_dev *dev,\n+\t\t\t\t\tstruct rte_eth_rss_conf *rss_conf);\n static int i40evf_dev_rx_queue_start(struct rte_eth_dev *, uint16_t);\n static int i40evf_dev_rx_queue_stop(struct rte_eth_dev *, uint16_t);\n static int i40evf_dev_tx_queue_start(struct rte_eth_dev *, uint16_t);\n static int i40evf_dev_tx_queue_stop(struct rte_eth_dev *, uint16_t);\n+\n+/* Default hash key buffer for RSS */\n+static uint32_t rss_key_default[I40E_VFQF_HKEY_MAX_INDEX + 1];\n+\n static struct eth_dev_ops i40evf_eth_dev_ops = {\n \t.dev_configure        = i40evf_dev_configure,\n \t.dev_start            = i40evf_dev_start,\n@@ -152,6 +161,8 @@ static struct eth_dev_ops i40evf_eth_dev_ops = {\n \t.rx_queue_release     = i40e_dev_rx_queue_release,\n \t.tx_queue_setup       = i40e_dev_tx_queue_setup,\n \t.tx_queue_release     = i40e_dev_tx_queue_release,\n+\t.rss_hash_update      = i40evf_dev_rss_hash_update,\n+\t.rss_hash_conf_get    = i40evf_dev_rss_hash_conf_get,\n };\n \n static int\n@@ -978,6 +989,8 @@ i40evf_init_vf(struct rte_eth_dev *dev)\n \tstruct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n \tstruct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);\n \n+\tvf->adapter = I40E_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);\n+\tvf->dev_data = dev->data;\n \terr = i40evf_set_mac_type(hw);\n \tif (err) {\n \t\tPMD_INIT_LOG(ERR, \"set_mac_type failed: %d\\n\", err);\n@@ -1334,11 +1347,13 @@ i40evf_vlan_filter_set(struct rte_eth_dev *dev, uint16_t vlan_id, int on)\n static int\n i40evf_rx_init(struct rte_eth_dev *dev)\n {\n+\tstruct i40e_vf *vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);\n \tuint16_t i;\n \tstruct i40e_rx_queue **rxq =\n \t\t(struct i40e_rx_queue **)dev->data->rx_queues;\n \tstruct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n \n+\ti40evf_config_rss(vf);\n \tfor (i = 0; i < dev->data->nb_rx_queues; i++) {\n \t\trxq[i]->qrx_tail = hw->hw_addr + I40E_QRX_TAIL1(i);\n \t\tI40E_PCI_REG_WRITE(rxq[i]->qrx_tail, rxq[i]->nb_rx_desc - 1);\n@@ -1573,3 +1588,130 @@ i40evf_dev_close(struct rte_eth_dev *dev)\n \ti40evf_reset_vf(hw);\n \ti40e_shutdown_adminq(hw);\n }\n+\n+static int\n+i40evf_hw_rss_hash_set(struct i40e_hw *hw, struct rte_eth_rss_conf *rss_conf)\n+{\n+\tuint32_t *hash_key;\n+\tuint8_t hash_key_len;\n+\tuint64_t rss_hf, hena;\n+\n+\thash_key = (uint32_t *)(rss_conf->rss_key);\n+\thash_key_len = rss_conf->rss_key_len;\n+\tif (hash_key != NULL && hash_key_len >=\n+\t\t(I40E_VFQF_HKEY_MAX_INDEX + 1) * sizeof(uint32_t)) {\n+\t\tuint16_t i;\n+\n+\t\tfor (i = 0; i <= I40E_VFQF_HKEY_MAX_INDEX; i++)\n+\t\t\tI40E_WRITE_REG(hw, I40E_VFQF_HKEY(i), hash_key[i]);\n+\t}\n+\n+\trss_hf = rss_conf->rss_hf;\n+\thena = (uint64_t)I40E_READ_REG(hw, I40E_VFQF_HENA(0));\n+\thena |= ((uint64_t)I40E_READ_REG(hw, I40E_VFQF_HENA(1))) << 32;\n+\thena &= ~I40E_RSS_HENA_ALL;\n+\thena |= i40e_config_hena(rss_hf);\n+\tI40E_WRITE_REG(hw, I40E_VFQF_HENA(0), (uint32_t)hena);\n+\tI40E_WRITE_REG(hw, I40E_VFQF_HENA(1), (uint32_t)(hena >> 32));\n+\tI40EVF_WRITE_FLUSH(hw);\n+\n+\treturn 0;\n+}\n+\n+static void\n+i40evf_disable_rss(struct i40e_vf *vf)\n+{\n+\tstruct i40e_hw *hw = I40E_VF_TO_HW(vf);\n+\tuint64_t hena;\n+\n+\thena = (uint64_t)I40E_READ_REG(hw, I40E_VFQF_HENA(0));\n+\thena |= ((uint64_t)I40E_READ_REG(hw, I40E_VFQF_HENA(1))) << 32;\n+\thena &= ~I40E_RSS_HENA_ALL;\n+\tI40E_WRITE_REG(hw, I40E_VFQF_HENA(0), (uint32_t)hena);\n+\tI40E_WRITE_REG(hw, I40E_VFQF_HENA(1), (uint32_t)(hena >> 32));\n+\tI40EVF_WRITE_FLUSH(hw);\n+}\n+\n+static int\n+i40evf_config_rss(struct i40e_vf *vf)\n+{\n+\tstruct i40e_hw *hw = I40E_VF_TO_HW(vf);\n+\tstruct rte_eth_rss_conf rss_conf;\n+\tuint32_t i, j, lut = 0, nb_q = (I40E_VFQF_HLUT_MAX_INDEX + 1) * 4;\n+\n+\tif (vf->dev_data->dev_conf.rxmode.mq_mode != ETH_MQ_RX_RSS) {\n+\t\ti40evf_disable_rss(vf);\n+\t\tPMD_DRV_LOG(DEBUG, \"RSS not configured\\n\");\n+\t\treturn 0;\n+\t}\n+\n+\t/* Fill out the look up table */\n+\tfor (i = 0, j = 0; i < nb_q; i++, j++) {\n+\t\tif (j >= vf->num_queue_pairs)\n+\t\t\tj = 0;\n+\t\tlut = (lut << 8) | j;\n+\t\tif ((i & 3) == 3)\n+\t\t\tI40E_WRITE_REG(hw, I40E_VFQF_HLUT(i >> 2), lut);\n+\t}\n+\n+\trss_conf = vf->dev_data->dev_conf.rx_adv_conf.rss_conf;\n+\tif ((rss_conf.rss_hf & I40E_RSS_OFFLOAD_ALL) == 0) {\n+\t\ti40evf_disable_rss(vf);\n+\t\tPMD_DRV_LOG(DEBUG, \"No hash flag is set\\n\");\n+\t\treturn 0;\n+\t}\n+\n+\tif (rss_conf.rss_key == NULL || rss_conf.rss_key_len < nb_q) {\n+\t\t/* Calculate the default hash key */\n+\t\tfor (i = 0; i <= I40E_VFQF_HKEY_MAX_INDEX; i++)\n+\t\t\trss_key_default[i] = (uint32_t)rte_rand();\n+\t\trss_conf.rss_key = (uint8_t *)rss_key_default;\n+\t\trss_conf.rss_key_len = nb_q;\n+\t}\n+\n+\treturn i40evf_hw_rss_hash_set(hw, &rss_conf);\n+}\n+\n+static int\n+i40evf_dev_rss_hash_update(struct rte_eth_dev *dev,\n+\t\t\t   struct rte_eth_rss_conf *rss_conf)\n+{\n+\tstruct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n+\tuint64_t rss_hf = rss_conf->rss_hf & I40E_RSS_OFFLOAD_ALL;\n+\tuint64_t hena;\n+\n+\thena = (uint64_t)I40E_READ_REG(hw, I40E_VFQF_HENA(0));\n+\thena |= ((uint64_t)I40E_READ_REG(hw, I40E_VFQF_HENA(1))) << 32;\n+\tif (!(hena & I40E_RSS_HENA_ALL)) { /* RSS disabled */\n+\t\tif (rss_hf != 0) /* Enable RSS */\n+\t\t\treturn -EINVAL;\n+\t\treturn 0;\n+\t}\n+\n+\t/* RSS enabled */\n+\tif (rss_hf == 0) /* Disable RSS */\n+\t\treturn -EINVAL;\n+\n+\treturn i40evf_hw_rss_hash_set(hw, rss_conf);\n+}\n+\n+static int\n+i40evf_dev_rss_hash_conf_get(struct rte_eth_dev *dev,\n+\t\t\t     struct rte_eth_rss_conf *rss_conf)\n+{\n+\tstruct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n+\tuint32_t *hash_key = (uint32_t *)(rss_conf->rss_key);\n+\tuint64_t hena;\n+\tuint16_t i;\n+\n+\tif (hash_key) {\n+\t\tfor (i = 0; i <= I40E_VFQF_HKEY_MAX_INDEX; i++)\n+\t\t\thash_key[i] = I40E_READ_REG(hw, I40E_VFQF_HKEY(i));\n+\t\trss_conf->rss_key_len = i * sizeof(uint32_t);\n+\t}\n+\thena = (uint64_t)I40E_READ_REG(hw, I40E_VFQF_HENA(0));\n+\thena |= ((uint64_t)I40E_READ_REG(hw, I40E_VFQF_HENA(1))) << 32;\n+\trss_conf->rss_hf = i40e_parse_hena(hena);\n+\n+\treturn 0;\n+}\n",
    "prefixes": [
        "dpdk-dev",
        "v2",
        "3/3"
    ]
}