Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/42787/?format=api
{ "id": 42787, "url": "https://patches.dpdk.org/api/patches/42787/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1531289248-20025-10-git-send-email-anoob.joseph@caviumnetworks.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1531289248-20025-10-git-send-email-anoob.joseph@caviumnetworks.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1531289248-20025-10-git-send-email-anoob.joseph@caviumnetworks.com", "date": "2018-07-11T06:07:25", "name": "[v2,09/12] examples/l2fwd: skip timer updates for non master cores", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": true, "hash": "3ef8921597c62aa6c67cb4b7bbc68694e42983c8", "submitter": { "id": 893, "url": "https://patches.dpdk.org/api/people/893/?format=api", "name": "Anoob Joseph", "email": "anoob.joseph@caviumnetworks.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1531289248-20025-10-git-send-email-anoob.joseph@caviumnetworks.com/mbox/", "series": [ { "id": 509, "url": "https://patches.dpdk.org/api/series/509/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=509", "date": "2018-07-11T06:07:16", "name": "preparing l2fwd for eventmode additions", "version": 2, "mbox": "https://patches.dpdk.org/series/509/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/42787/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/42787/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 05BAB1B504;\n\tWed, 11 Jul 2018 08:08:23 +0200 (CEST)", "from NAM01-BY2-obe.outbound.protection.outlook.com\n\t(mail-by2nam01on0085.outbound.protection.outlook.com [104.47.34.85])\n\tby dpdk.org (Postfix) with ESMTP id 7722E1B502\n\tfor <dev@dpdk.org>; Wed, 11 Jul 2018 08:08:21 +0200 (CEST)", "from ajoseph83.caveonetworks.com.caveonetworks.com (115.113.156.2)\n\tby BN7PR07MB4898.namprd07.prod.outlook.com (2603:10b6:406:ef::27)\n\twith Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.930.21;\n\tWed, 11 Jul 2018 06:08:18 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=+lixC/zKtJ1we0PYtNKIVcQdUFbuAk9EhQY18T85fbY=;\n\tb=IvSFluRRcRZBUUr3DaeFbDWGwHlQeXfW1tJ+5iB+MQJUjH8oGNjBb8GZUB+nsu1zKxBTWeh9qYqsQSRmYZRrOKgQGvEZHNNrbcHCKThuKu81mmaHBHFz+0Ltq8YgrRad/PsyrzIRhGxJufPIJz//kQEtTwOR+OMyjKMyiCABDm8=", "Authentication-Results": "spf=none (sender IP is )\n\tsmtp.mailfrom=Anoob.Joseph@cavium.com; ", "From": "Anoob Joseph <anoob.joseph@caviumnetworks.com>", "To": "Bruce Richardson <bruce.richardson@intel.com>,\n\tPablo de Lara <pablo.de.lara.guarch@intel.com>", "Cc": "Anoob Joseph <anoob.joseph@caviumnetworks.com>,\n\tJerin Jacob <jerin.jacob@caviumnetworks.com>,\n\tNarayana Prasad <narayanaprasad.athreya@caviumnetworks.com>, dev@dpdk.org", "Date": "Wed, 11 Jul 2018 11:37:25 +0530", "Message-Id": "<1531289248-20025-10-git-send-email-anoob.joseph@caviumnetworks.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1531289248-20025-1-git-send-email-anoob.joseph@caviumnetworks.com>", "References": "<1528976946-14396-1-git-send-email-anoob.joseph@caviumnetworks.com>\n\t<1531289248-20025-1-git-send-email-anoob.joseph@caviumnetworks.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[115.113.156.2]", "X-ClientProxiedBy": "BMXPR01CA0027.INDPRD01.PROD.OUTLOOK.COM\n\t(2603:1096:b00:c::13) To BN7PR07MB4898.namprd07.prod.outlook.com\n\t(2603:10b6:406:ef::27)", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "48322009-acc6-4756-34af-08d5e6f4b39c", "X-Microsoft-Antispam": "UriScan:; BCL:0; PCL:0;\n\tRULEID:(7020095)(4652040)(8989117)(5600053)(711020)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020);\n\tSRVR:BN7PR07MB4898; ", "X-Microsoft-Exchange-Diagnostics": [ "1; BN7PR07MB4898;\n\t3:VICy+ULkma873lDL4/kB1qLMUvf9ps35kbeAd9ND8QEeicXjZawxP0plKNFEWNyflzRJRYLZH6dClTgL4femKFMNFZGRFrxDKjcaxrbpA8guOpdUicogr0knxCtTq2sMrsKyV9D1tYAO4hht6vx9nsYGxuvqrtodd2DgG8sgNkuPHiRVVDbEcfr1mPTOk7eY/F4A3kANYR3Bk0sEav/M0hln3Tt6d9Cw8QF0ET6nnwowstNYvgAZoQcUx/JWOrXE;\n\t25:EGdDsirZA+EOnPHgz429a/BuHVEcz1j8ECyON3kTqTuy5XBjwEgoRGyPXZiCUxrf1o7jSY3XmQBHuxPnS4aAwxKTOSp12NN0Q5w3hEPZjpQnJmv8seiv7HUgNAAO9BPSneeYXRJMDBpfPrrI63NgeP9jmiYqOSqZzICajeCKUxlXUjsbtFviHgLOKTJ1NG5H6zW3vq5ugmZ63GwUydyu/kKqAA72jfVhTMbUSy4FNGGkrfaJkP7BIbA8M/wspwUy5JMflq3DoLqpFbFe5j9jhdMe5qWRBOpy6k/k6Ai2onKfLAgh4qveYF/pFoK4W4FRRqfXQo+M/8gZrv4s8wk4Aw==;\n\t31:MXt9nZoEcwoRswFHVL4rbLyEM7DubODdshdgogIOOnyudD2cLyZRJxnJVEhg8NNUreZ+F0sz8mlzhuSwe/sYgKPrXsJK5RuE/Tgaod0Q9zONc5i/B6/qKvVRHNEDHBmQPSGCax7YIojQKElypmKc8vJn/I52JcD08patLoAWnmt3fgJvGYOtj9tQWI+7/XEwoEWkOj7+FdmQV/MfOdOpPi/pYw17VkYn6gh1Qf1nuYs=", "1; BN7PR07MB4898;\n\t20:XpyxOcnCYdc/a738QqkQqxvmWvMlypS4SWSsiXkzrNw2AIyw59zP4GILadHkzsAZOQoF84hnG2fa66a4QTsyw7W+2f1gqU27vkY1qElUXy6agLUhXcS5rcfwgUmn0YT4nJEO5uumeKHRNh1lHj4OK9UgiIqZebVkb9Vct43sBkyjoc/3PLJ0Pno075SJW6xaREPrsFZq+fJtXhmTrFRs5jmbamKCQ85H+yM3yayw5/n0ZCcep15OL6EAdYPASxGgTAUpxPxtvEhXc6rnhX6SiKlffcp0lEp2IB7nfp0jlpHBSx+tQFa+GEaXPjyfJsPJoFXgzbZfAoSRtVLQacEyt1J9KPGwi58L5hmqP6P1OLkB+uAv2vuQBdD8iBM71UGgWSIWOzyXFdspKg3hHyBN/q52/6dG/y41ZWg4iw9izVN6ZS7BPsBjjd5ojomTlSoeXGxdonJyBiIosRMZjeDG4c1KEpkl3h/n+hrj404dhjrrYL4CvmuIb3wg0wuRyryX1wRUeaRtSYYzcez1CigXPawTJHKmvkg2lcJROU0sX3QiPlHZIaZfuFrCEXzcaLpbAyOKb3GMMXQr+LsrEVKUcGgReZvYKMf1drCfWGTJXe0=;\n\t4:VaTLm38sgV4z9H/Y1eDXF8LJWiieE9mJhITKJBOt3H0Bk6uERkCS7JLqueHMzUwjl6b826Aq7pRUrpNfaMWc3LlAwblBR3QH+5Bi/oZDzxpDphTw8qIzLDgpR+vPbMoKLKWEPr78ip6ZFe49ePO/MYyxKhjXxfFpPMvw4WSf/o2xD3fU5BfftsXwT4dq9qYMMibhrZ0p/i2/IYsegCbECptEjxdCJJwbUd762VSBXx18GQV030GVjG2NvAP2ri9F8FVRQPXr8RDd/kDh9S7qRw==", "=?us-ascii?Q?1; BN7PR07MB4898;\n\t23:ksq/P41tsqVCxEIvE898i7N/DVYlBxlKDYNq6HHWD?=\n\tlLBmSQKqz2yj+xMhIHhfbgkzv6ZBLpjjm3yFEWvYGQua/YA0XHEJiBY27KabTj73hLYKYqDFzOEvcb5cjDzj4cmKovZ4DMwOlxneQMi90n7RMk5NFqG19tQgjXiyoPXbbxbbFchYSGKrNRoHAAb5SZiN6fVIWTgehlDhpSbPVr6+Q5BWT8DKwiuUz9G6XE7uOoWtaUTwzB3tYRCpp1al+psR38BAhq8ALRtkw8gjgwYINi0MUEEbM1LLGRO6H58ry9fj0PsBT34w/wB8i9WuHzlYR4LC87UjOnsn0n42m5dCAPlRTxmtAiCgge4gwsk/eswBF8PKcwNYuJWGOC90aSYyv5FAUnB6qPVvStB0KSvLgsZ+s4nycMdSo1l19JXkX5ly78OykbpRN0MA/Cff3TRjRZU0wAGrOUvaKAnj/HOq4a7HFWwJkytN9giyPzMRmBJ2gL2XZ4QEqOZmNuuAnzrULZ4n4G1j4wQeSCif3jd6UGCC/vfVXa83wZIi8N1a0PLOe2AdbFY0+G5GTs9Sj/NrLPd7zujKZHWdWawCpteR3DhBb1z2uGISTwn0saXmDz69KXr+V+b8hNuFlM7LMYPhyFtvgTafxFT/kstqoDsCsgYJQu09BpcHbGq5384Dp3mMMoHOb1NnF+Frs0sNblKBJWA9I6kahu/geKOBKaTe7+C5G94VcwKTtP6CaDHq6ZL7zPxNN/qYZspGj2NtGfkpIYn3WsnWMF7R/DvHdK8Fi5MfF1BeSCwrDIem6C+S70i3nIr1kPG6yoLh5hoqzg+K/UR9ywPG4voJE9Ai1kV5LnRFt3KnjjL6X9nrjZiYuBjjdpaQoW0ZSh+k9IfWhRGbNjKNX1+7/S+6kcP2EgRTI9VI7aYTZhH7UrC9YcE3SYLVX0iGC2suRddZYrDcYNJ9XAzyRX8Ze/235B5mXTgu+J+lYiDtQWh8XTEPvqNpfxRzWwpdJLpzU2HnmAhmG2T3KSEc6nT3m3vo1EdgdoL0yb8d7Jw4xmF1fr+E5faLPJiYydMajn+ri8xJJr4M0xAV5wosr9tq1AjEmYgz5+LAkKGpnExNYUL2S9AE8e64E6CX39dM6rjn3busHp7LR+8TMNw2Ydl5eQ0PAzYpCP1abbJOU7h5BqlL2jhDitFZJAk2j5OgsGfwfu4qct7behSz0/xTTiKTMOfqZYzc7eQDovy4IKQ9QUjtDP2iJvYGVXF05CCs1pEmGouDa4rXlE+GG/Q5L2kX2jkmJICNWi7C4WONgxm+mG4UjJgx6JM13k=", "1; BN7PR07MB4898;\n\t6:KLPsLaU+B9R5jcpKLOQvKeIu99EzsDyU2Qm2T7GypN265OnG8mGoDB+3P06D4HrSG6qiZdgsmkXGN9QWmLEB1fwBblHOMRfUnEe4aE8IqiZEmzwCen9eu4K2Nk0MU6qobA6ynNVlWPSPlW7uZKoIMCDP4m3UUHWUPMTvurnz6ybmRUlvpn7/EtpmKhXu4WwT8cXaQ8PH8oWCq/KmYh+1+8WdDNKLGqgb7eWJBr1dKqZ6cml1cBnTXbOY6Lge7c2GCECfjHpmPPEmnCyy/2kE4H58EQ12t02abZwQEs1BV/s3QqEtACW1a03801A/kDq0ZJa1ZE0QK9bEYu7oP3OUBudYml87rlksK3t+CUeU6gpqPxcWYt7ZjJ2bk8O/ySHZ8Qy6SH4rmUzE6tRWBUu8MuYV4sCX78g/Cq2idPKIU1kACyjvEgWtoqtRJtZpzOrW3GP7k2lgOmo+chdaOwmLtg==;\n\t5://iZONchbjk41p9d5XIKqOReSeRF7ukvgqCX0YDRqIrtpsVl9b5Xw13sRfi69HpKVAuDR3d6QZEMefwQTIvKQaygKZfFe9EArAgAYu5Qu2FM25ZxtyG6/PwSHygij8Y7Cj4zA5egSgpsndQN5y9FGYGZARfeMT168AQV+7XZ+Wg=;\n\t24:mosLc9IuuuMf+abQJDZxgFeWfWaFFDLt+3Hi8GL9lHXLuhWAkxFtpsRLKvbFMYtIm5kF5T77zjy78DA242FuP3xVGbNEbZkdSbEAOJVXFxY=", "1; BN7PR07MB4898;\n\t7:oOMB7lFQ1x3IM0x/cxem5r+A5wQDz+rejMoLJ/dlaqCSk6549SeAV4zTuQdrit3JL0bwrJASzoEB7k/r+unVBMe0/CnkVZgYtwiyBKOqwQYZmhLde2OfRPQO1LaRfy5wx+1HiSp2RAUdP2i3Cbyb8Abop7ACdBOou1nP1dKhdn5ziMhf6RyO+nMOrybASTlPxpDhrCPJqWJlSWctnTyIhqOjUv58a0P3osA3GudQm+ce08KNbeWjf2gAjiUSFG/f" ], "X-MS-TrafficTypeDiagnostic": "BN7PR07MB4898:", "X-Microsoft-Antispam-PRVS": "<BN7PR07MB48988A5B3D181237B2A60361F85A0@BN7PR07MB4898.namprd07.prod.outlook.com>", "X-Exchange-Antispam-Report-Test": "UriScan:;", "X-MS-Exchange-SenderADCheck": "1", "X-Exchange-Antispam-Report-CFA-Test": "BCL:0; PCL:0;\n\tRULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231311)(944501410)(52105095)(10201501046)(93006095)(3002001)(149027)(150027)(6041310)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123558120)(6072148)(201708071742011)(7699016);\n\tSRVR:BN7PR07MB4898; BCL:0; PCL:0; RULEID:; SRVR:BN7PR07MB4898; ", "X-Forefront-PRVS": "0730093765", "X-Forefront-Antispam-Report": "SFV:NSPM;\n\tSFS:(10009020)(346002)(376002)(136003)(39860400002)(366004)(396003)(189003)(199004)(68736007)(81166006)(8676002)(81156014)(44832011)(50466002)(6666003)(25786009)(6512007)(7736002)(4326008)(6486002)(48376002)(8936002)(2906002)(3846002)(478600001)(575784001)(72206003)(15650500001)(305945005)(6116002)(486006)(16586007)(2616005)(54906003)(110136005)(316002)(36756003)(476003)(956004)(446003)(11346002)(47776003)(26005)(42882007)(52116002)(105586002)(186003)(76176011)(16526019)(66066001)(106356001)(51416003)(97736004)(6506007)(55236004)(50226002)(53936002)(5660300001)(386003);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:BN7PR07MB4898;\n\tH:ajoseph83.caveonetworks.com.caveonetworks.com; FPR:; SPF:None;\n\tLANG:en; PTR:InfoNoRecords; MX:1; A:1; ", "Received-SPF": "None (protection.outlook.com: cavium.com does not designate\n\tpermitted sender hosts)", "X-Microsoft-Antispam-Message-Info": "ZKSYoTdjOYj9P3G+ARplJ+s497/NBBJnUpb2hp6NhaWdLPNdRIF3RVREqoJT9WeGXvdBiOEdM+I9bt76xbMa1aNFHYusmHFMZAcvIykzPlz+HUyVadkdjajeyuO1b1SycsFPjYFtIF4SSc8UQQA1bH7F/A+Veft9rpCBmRY/i9RZ7YA/89TPtcitKPbq4DUpCS1KuH4PlL/tLShEnX/YIM0WOCXhskptKF/p+qAFrAwjxLgkVJSS5rFFvV1TfG2SnFJzWqwxDtTDQd5i/mNHltienVoIlGkvTstl+WPrD6aa4o3re40ENx7n9JXnuPbxh7bTWNDWlTURULLN1gJT8n/SDRhf2XpAYryNTmXcWGU=", "SpamDiagnosticOutput": "1:99", "SpamDiagnosticMetadata": "NSPM", "X-OriginatorOrg": "caviumnetworks.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "11 Jul 2018 06:08:18.4537\n\t(UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "48322009-acc6-4756-34af-08d5e6f4b39c", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "711e4ccf-2e9b-4bcf-a551-4094005b6194", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "BN7PR07MB4898", "Subject": "[dpdk-dev] [PATCH v2 09/12] examples/l2fwd: skip timer updates for\n\tnon master cores", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The timer updates and checks are required only for stats printing by the\nmaster core. This can be entirely skipped for other cores.\n\nSigned-off-by: Anoob Joseph <anoob.joseph@caviumnetworks.com>\n---\nv2:\n* No change\n\nv1:\n* No change\n\n examples/l2fwd/l2fwd_worker.c | 21 +++++++++++++--------\n 1 file changed, 13 insertions(+), 8 deletions(-)", "diff": "diff --git a/examples/l2fwd/l2fwd_worker.c b/examples/l2fwd/l2fwd_worker.c\nindex 868d0c6..d6a5e90 100644\n--- a/examples/l2fwd/l2fwd_worker.c\n+++ b/examples/l2fwd/l2fwd_worker.c\n@@ -111,6 +111,14 @@ l2fwd_periodic_drain_stats_monitor(struct lcore_queue_conf *qconf,\n \t\t/* Drain buffers */\n \t\tl2fwd_drain_buffers(qconf);\n \n+\t\tt->prev_tsc = cur_tsc;\n+\n+\t\t/* Skip the timer based stats prints if not master core */\n+\t\tif (!is_master_core)\n+\t\t\treturn;\n+\n+\t\t/* On master core */\n+\n \t\t/* if timer is enabled */\n \t\tif (timer_period > 0) {\n \n@@ -120,16 +128,13 @@ l2fwd_periodic_drain_stats_monitor(struct lcore_queue_conf *qconf,\n \t\t\t/* if timer has reached its timeout */\n \t\t\tif (unlikely(t->timer_tsc >= timer_period)) {\n \n-\t\t\t\t/* do this only on master core */\n-\t\t\t\tif (is_master_core) {\n-\t\t\t\t\tprint_stats();\n-\t\t\t\t\t/* reset the timer */\n-\t\t\t\t\tt->timer_tsc = 0;\n-\t\t\t\t}\n+\t\t\t\t/* Print stats */\n+\t\t\t\tprint_stats();\n+\n+\t\t\t\t/* reset the timer */\n+\t\t\t\tt->timer_tsc = 0;\n \t\t\t}\n \t\t}\n-\n-\t\tt->prev_tsc = cur_tsc;\n \t}\n }\n \n", "prefixes": [ "v2", "09/12" ] }