Patch Comment List
List patch comments
GET /api/patches/424/comments/?format=api&order=-date
[ { "id": 854, "web_url": "https://patches.dpdk.org/comment/854/", "msgid": "<59AF69C657FD0841A61C55336867B5B0343F3406@IRSMSX103.ger.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/59AF69C657FD0841A61C55336867B5B0343F3406@IRSMSX103.ger.corp.intel.com", "date": "2014-09-18T12:35:21", "subject": "Re: [dpdk-dev] [PATCH] ixgbe: fix compile error with gcc4.4 (used\n\tRHEL 6)", "submitter": { "id": 20, "url": "https://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "content": "> -----Original Message-----\n> From: Neil Horman [mailto:nhorman@tuxdriver.com]\n> Sent: Thursday, September 18, 2014 1:25 PM\n> To: Thomas Monjalon\n> Cc: Richardson, Bruce; dev@dpdk.org\n> Subject: Re: [dpdk-dev] [PATCH] ixgbe: fix compile error with gcc4.4 (used RHEL\n> 6)\n> \n> On Thu, Sep 18, 2014 at 01:09:16PM +0200, Thomas Monjalon wrote:\n> > > The refcnt field is contained within an anonymous union within the mbuf\n> > > data structure, and gcc 4.4 gives an error about an unknown field unless\n> > > the initialiser for the field is contained within extra braces.\n> > >\n> > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>\n> >\n> > Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>\n> >\n> > Thanks Bruce, it is now applied.\n> \n> Hang on here, we use anonymous unions all the time in RHEL6, and make\n> assignments to them frequently, and the compiler doesn't complain (see the\n> dropcount variable in sk_buff for an example). Not saying that this is a big\n> deal, but can you explain a little more about what you're seeing when this error\n> occurs, before we just paper over it?\n> \n\nOriginally reported on RHEL6 as a build failure. When I use gcc4.4 on Fedora 20, I get the following without this change:\n\n CC ixgbe_rxtx_vec.o\n== Build lib/librte_table\n/home/bruce/dpdk.org/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c: In function 'ixgbe_rxq_vec_setup':\n/home/bruce/dpdk.org/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c:726: error: unknown field 'refcnt' specified in initializer\ncompilation terminated due to -Wfatal-errors.\nmake[5]: *** [ixgbe_rxtx_vec.o] Error 1\nmake[4]: *** [librte_pmd_ixgbe] Error 2\nmake[4]: *** Waiting for unfinished jobs....\nmake[3]: *** [lib] Error 2\nmake[2]: *** [all] Error 2\nmake[1]: *** [x86_64-native-linuxapp-gcc_install] Error 2\nmake: *** [install] Error 2\n\nRegards,\n/Bruce", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 831F6B3A9;\n\tThu, 18 Sep 2014 14:30:48 +0200 (CEST)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id A1E34B3A7\n\tfor <dev@dpdk.org>; Thu, 18 Sep 2014 14:30:46 +0200 (CEST)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby fmsmga101.fm.intel.com with ESMTP; 18 Sep 2014 05:36:30 -0700", "from irsmsx104.ger.corp.intel.com ([163.33.3.159])\n\tby FMSMGA003.fm.intel.com with ESMTP; 18 Sep 2014 05:30:56 -0700", "from irsmsx154.ger.corp.intel.com (163.33.192.96) by\n\tIRSMSX104.ger.corp.intel.com (163.33.3.159) with Microsoft SMTP\n\tServer (TLS) id 14.3.195.1; Thu, 18 Sep 2014 13:35:22 +0100", "from irsmsx103.ger.corp.intel.com ([169.254.3.112]) by\n\tIRSMSX154.ger.corp.intel.com ([169.254.12.233]) with mapi id\n\t14.03.0195.001; Thu, 18 Sep 2014 13:35:22 +0100" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"4.97,862,1389772800\"; d=\"scan'208\";a=\"388020558\"", "From": "\"Richardson, Bruce\" <bruce.richardson@intel.com>", "To": "Neil Horman <nhorman@tuxdriver.com>, Thomas Monjalon\n\t<thomas.monjalon@6wind.com>", "Thread-Topic": "[dpdk-dev] [PATCH] ixgbe: fix compile error with gcc4.4 (used\n\tRHEL 6)", "Thread-Index": "AQHP0y8i6ESf/18xKkWRib04BdvGMpwGqtYAgAAVSYCAABLtoA==", "Date": "Thu, 18 Sep 2014 12:35:21 +0000", "Message-ID": "<59AF69C657FD0841A61C55336867B5B0343F3406@IRSMSX103.ger.corp.intel.com>", "References": "<1411037752-8000-1-git-send-email-bruce.richardson@intel.com>\n\t<5076244.KSjCyF24zI@xps13>\n\t<20140918122527.GE20389@hmsreliant.think-freely.org>", "In-Reply-To": "<20140918122527.GE20389@hmsreliant.think-freely.org>", "Accept-Language": "en-GB, en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[163.33.239.180]", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "Cc": "\"dev@dpdk.org\" <dev@dpdk.org>", "Subject": "Re: [dpdk-dev] [PATCH] ixgbe: fix compile error with gcc4.4 (used\n\tRHEL 6)", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 853, "web_url": "https://patches.dpdk.org/comment/853/", "msgid": "<20140918122527.GE20389@hmsreliant.think-freely.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20140918122527.GE20389@hmsreliant.think-freely.org", "date": "2014-09-18T12:25:27", "subject": "Re: [dpdk-dev] [PATCH] ixgbe: fix compile error with gcc4.4 (used\n\tRHEL 6)", "submitter": { "id": 32, "url": "https://patches.dpdk.org/api/people/32/?format=api", "name": "Neil Horman", "email": "nhorman@tuxdriver.com" }, "content": "On Thu, Sep 18, 2014 at 01:09:16PM +0200, Thomas Monjalon wrote:\n> > The refcnt field is contained within an anonymous union within the mbuf\n> > data structure, and gcc 4.4 gives an error about an unknown field unless\n> > the initialiser for the field is contained within extra braces.\n> > \n> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>\n> \n> Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>\n> \n> Thanks Bruce, it is now applied.\n\nHang on here, we use anonymous unions all the time in RHEL6, and make\nassignments to them frequently, and the compiler doesn't complain (see the\ndropcount variable in sk_buff for an example). Not saying that this is a big\ndeal, but can you explain a little more about what you're seeing when this error\noccurs, before we just paper over it?\n\nNeil\n\n> -- \n> Thomas\n>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id BF7E4B3A6;\n\tThu, 18 Sep 2014 14:20:04 +0200 (CEST)", "from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58])\n\tby dpdk.org (Postfix) with ESMTP id 85DDAB3A3\n\tfor <dev@dpdk.org>; Thu, 18 Sep 2014 14:20:03 +0200 (CEST)", "from hmsreliant.think-freely.org\n\t([2001:470:8:a08:7aac:c0ff:fec2:933b] helo=localhost)\n\tby smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63)\n\t(envelope-from <nhorman@tuxdriver.com>)\n\tid 1XUam8-0001Oo-8h; Thu, 18 Sep 2014 08:25:44 -0400" ], "Date": "Thu, 18 Sep 2014 08:25:27 -0400", "From": "Neil Horman <nhorman@tuxdriver.com>", "To": "Thomas Monjalon <thomas.monjalon@6wind.com>", "Message-ID": "<20140918122527.GE20389@hmsreliant.think-freely.org>", "References": "<1411037752-8000-1-git-send-email-bruce.richardson@intel.com>\n\t<5076244.KSjCyF24zI@xps13>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=us-ascii", "Content-Disposition": "inline", "In-Reply-To": "<5076244.KSjCyF24zI@xps13>", "User-Agent": "Mutt/1.5.23 (2014-03-12)", "X-Spam-Score": "-2.9 (--)", "X-Spam-Status": "No", "Cc": "dev@dpdk.org", "Subject": "Re: [dpdk-dev] [PATCH] ixgbe: fix compile error with gcc4.4 (used\n\tRHEL 6)", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 852, "web_url": "https://patches.dpdk.org/comment/852/", "msgid": "<5076244.KSjCyF24zI@xps13>", "list_archive_url": "https://inbox.dpdk.org/dev/5076244.KSjCyF24zI@xps13", "date": "2014-09-18T11:09:16", "subject": "Re: [dpdk-dev] [PATCH] ixgbe: fix compile error with gcc4.4 (used\n\tRHEL 6)", "submitter": { "id": 1, "url": "https://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "content": "> The refcnt field is contained within an anonymous union within the mbuf\n> data structure, and gcc 4.4 gives an error about an unknown field unless\n> the initialiser for the field is contained within extra braces.\n> \n> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>\n\nAcked-by: Thomas Monjalon <thomas.monjalon@6wind.com>\n\nThanks Bruce, it is now applied.", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 895BCB3A6;\n\tThu, 18 Sep 2014 13:03:43 +0200 (CEST)", "from mail-wi0-f172.google.com (mail-wi0-f172.google.com\n\t[209.85.212.172]) by dpdk.org (Postfix) with ESMTP id 63D1768C2\n\tfor <dev@dpdk.org>; Thu, 18 Sep 2014 13:03:42 +0200 (CEST)", "by mail-wi0-f172.google.com with SMTP id e4so2861916wiv.17\n\tfor <dev@dpdk.org>; Thu, 18 Sep 2014 04:09:27 -0700 (PDT)", "from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])\n\tby mx.google.com with ESMTPSA id\n\tba3sm2567931wib.10.2014.09.18.04.09.25 for <multiple recipients>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 18 Sep 2014 04:09:26 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:organization\n\t:user-agent:in-reply-to:references:mime-version\n\t:content-transfer-encoding:content-type;\n\tbh=Z9g5NAqWLKF+GHA+wRvVTLBhOCpS+WONElDHkErHjyc=;\n\tb=cTWUHs939Q+QjG4XNnmF1k3L8e1iEFZjg1DGH0x7e3ggjqAUF8/aB0DHiskm5EuQRM\n\t4rWHPJktzrhmmJmUOrjqPO7iHW3AeQ90ANUY5T0BNW8yl43h2/f8+npT98PgwVN8hVxt\n\tY80GqfO3p7/PEG2IXQu2kqw3EGbmZCY4lVSdplo2Lo56C00EjxJeDipgobnK91C79KAX\n\tEAWyl59GAqUuDGtdIttgkVoiMxmf+QyQ6MtGAV2698GYCPahZ4TgDTP3d2neQsMJCbFf\n\tyh+0iHGNwTYrRzkkoHSpsa2xBdtXVyg7WB2+Va2wbWqdb3skN6DYczdITh+0/PmvHjFJ\n\tXqCA==", "X-Gm-Message-State": "ALoCoQkG+pk70STnwxlPxzuhicGsdKQWSyuh9OrQeP5yWBzE8WAwLM9xTKfFB1139gYtFy4hj3mW", "X-Received": "by 10.194.3.106 with SMTP id b10mr4007692wjb.3.1411038567607;\n\tThu, 18 Sep 2014 04:09:27 -0700 (PDT)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "Bruce Richardson <bruce.richardson@intel.com>", "Date": "Thu, 18 Sep 2014 13:09:16 +0200", "Message-ID": "<5076244.KSjCyF24zI@xps13>", "Organization": "6WIND", "User-Agent": "KMail/4.13.3 (Linux/3.15.8-1-ARCH; KDE/4.13.3; x86_64; ; )", "In-Reply-To": "<1411037752-8000-1-git-send-email-bruce.richardson@intel.com>", "References": "<1411037752-8000-1-git-send-email-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "7Bit", "Content-Type": "text/plain; charset=\"us-ascii\"", "Cc": "dev@dpdk.org", "Subject": "Re: [dpdk-dev] [PATCH] ixgbe: fix compile error with gcc4.4 (used\n\tRHEL 6)", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]