Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41885/?format=api
{ "id": 41885, "url": "https://patches.dpdk.org/api/patches/41885/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20180628201549.3507-23-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180628201549.3507-23-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180628201549.3507-23-ajit.khaparde@broadcom.com", "date": "2018-06-28T20:15:48", "name": "[v2,22/23] net/bnxt: fix Rx ring count limitation", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "fb7cb354a7c20155f5f158da49a89a886508530c", "submitter": { "id": 501, "url": "https://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20180628201549.3507-23-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 300, "url": "https://patches.dpdk.org/api/series/300/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=300", "date": "2018-06-28T20:15:29", "name": "bnxt patchset", "version": 2, "mbox": "https://patches.dpdk.org/series/300/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/41885/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/41885/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D21891B5C1;\n\tThu, 28 Jun 2018 22:16:53 +0200 (CEST)", "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n\t[192.19.229.170]) by dpdk.org (Postfix) with ESMTP id 47C151B4FF;\n\tThu, 28 Jun 2018 22:16:00 +0200 (CEST)", "from nis-sj1-27.broadcom.com (nis-sj1-27.lvn.broadcom.net\n\t[10.75.144.136])\n\tby rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 8321C30C02F;\n\tThu, 28 Jun 2018 13:15:59 -0700 (PDT)", "from C02VPB22HTD6.dhcp.broadcom.net (c02vpb22htd6.dhcp.broadcom.net\n\t[10.136.50.120])\n\tby nis-sj1-27.broadcom.com (Postfix) with ESMTP id 526FBAC078F;\n\tThu, 28 Jun 2018 13:15:59 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com 8321C30C02F", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n\ts=dkimrelay; t=1530216959;\n\tbh=rnuLh3lElKy9wFkLGlUjzCaxeABXmy0Re6ipM4vi9f4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=u1gcdEJ8Z4xehQOtEydfAJuc1U31DXLW9TpesVkiJ2JJJeqOsPjpoPbYxrrjcnx72\n\tEk3m+CubjevrpNWwdjSghXWHfY/BwSs2uv53cqm+GA+QHv/LPYeantWEvmlkhr93As\n\tTVkTGltlIEWn6O8J74YmY4bqQ+VyO5841GDoFLRU=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com,\n\tstable@dpdk.org", "Date": "Thu, 28 Jun 2018 13:15:48 -0700", "Message-Id": "<20180628201549.3507-23-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.15.2 (Apple Git-101.1)", "In-Reply-To": "<20180628201549.3507-1-ajit.khaparde@broadcom.com>", "References": "<f02289d7-4111-ab00-9ce9-00dd5c8b3c18@intel.com>\n\t<20180628201549.3507-1-ajit.khaparde@broadcom.com>", "Subject": "[dpdk-dev] [PATCH v2 22/23] net/bnxt: fix Rx ring count limitation", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Fixed size of fw_grp_ids in VNIC is limiting the number of Rx rings\nbeing created. With this patch we are allocating fw_grp_ids dynamically,\nallowing us to get over this artificial limit.\n\nFixes: 9738793f28ec (\"net/bnxt: add VNIC functions and structs\")\nCc: stable@dpdk.org\n\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt_ethdev.c | 11 +++++++++++\n drivers/net/bnxt/bnxt_hwrm.c | 5 ++++-\n drivers/net/bnxt/bnxt_vnic.c | 5 +----\n drivers/net/bnxt/bnxt_vnic.h | 6 +-----\n 4 files changed, 17 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex 34c3d6ba3..a1f835ed9 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -250,6 +250,17 @@ static int bnxt_init_chip(struct bnxt *bp)\n \tfor (i = 0; i < bp->nr_vnics; i++) {\n \t\tstruct rte_eth_conf *dev_conf = &bp->eth_dev->data->dev_conf;\n \t\tstruct bnxt_vnic_info *vnic = &bp->vnic_info[i];\n+\t\tuint32_t size = sizeof(*vnic->fw_grp_ids) * bp->max_ring_grps;\n+\n+\t\tvnic->fw_grp_ids = rte_zmalloc(\"vnic_fw_grp_ids\", size, 0);\n+\t\tif (!vnic->fw_grp_ids) {\n+\t\t\tPMD_DRV_LOG(ERR,\n+\t\t\t\t \"Failed to alloc %d bytes for group ids\\n\",\n+\t\t\t\t size);\n+\t\t\trc = -ENOMEM;\n+\t\t\tgoto err_out;\n+\t\t}\n+\t\tmemset(vnic->fw_grp_ids, -1, size);\n \n \t\trc = bnxt_hwrm_vnic_alloc(bp, vnic);\n \t\tif (rc) {\ndiff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c\nindex de04fe863..37aefbdc9 100644\n--- a/drivers/net/bnxt/bnxt_hwrm.c\n+++ b/drivers/net/bnxt/bnxt_hwrm.c\n@@ -1319,8 +1319,9 @@ int bnxt_hwrm_vnic_alloc(struct bnxt *bp, struct bnxt_vnic_info *vnic)\n \t/* map ring groups to this vnic */\n \tPMD_DRV_LOG(DEBUG, \"Alloc VNIC. Start %x, End %x\\n\",\n \t\tvnic->start_grp_id, vnic->end_grp_id);\n-\tfor (i = vnic->start_grp_id, j = 0; i <= vnic->end_grp_id; i++, j++)\n+\tfor (i = vnic->start_grp_id, j = 0; i < vnic->end_grp_id; i++, j++)\n \t\tvnic->fw_grp_ids[j] = bp->grp_info[i].fw_grp_id;\n+\n \tvnic->dflt_ring_grp = bp->grp_info[vnic->start_grp_id].fw_grp_id;\n \tvnic->rss_rule = (uint16_t)HWRM_NA_SIGNATURE;\n \tvnic->cos_rule = (uint16_t)HWRM_NA_SIGNATURE;\n@@ -2106,6 +2107,8 @@ void bnxt_free_all_hwrm_resources(struct bnxt *bp)\n \t\tbnxt_hwrm_vnic_tpa_cfg(bp, vnic, false);\n \n \t\tbnxt_hwrm_vnic_free(bp, vnic);\n+\n+\t\trte_free(vnic->fw_grp_ids);\n \t}\n \t/* Ring resources */\n \tbnxt_free_all_hwrm_rings(bp);\ndiff --git a/drivers/net/bnxt/bnxt_vnic.c b/drivers/net/bnxt/bnxt_vnic.c\nindex 19d06af55..c0577cd76 100644\n--- a/drivers/net/bnxt/bnxt_vnic.c\n+++ b/drivers/net/bnxt/bnxt_vnic.c\n@@ -39,7 +39,7 @@ void bnxt_init_vnics(struct bnxt *bp)\n {\n \tstruct bnxt_vnic_info *vnic;\n \tuint16_t max_vnics;\n-\tint i, j;\n+\tint i;\n \n \tmax_vnics = bp->max_vnics;\n \tSTAILQ_INIT(&bp->free_vnic_list);\n@@ -52,9 +52,6 @@ void bnxt_init_vnics(struct bnxt *bp)\n \t\tvnic->hash_mode =\n \t\t\tHWRM_VNIC_RSS_CFG_INPUT_HASH_MODE_FLAGS_DEFAULT;\n \n-\t\tfor (j = 0; j < MAX_QUEUES_PER_VNIC; j++)\n-\t\t\tvnic->fw_grp_ids[j] = (uint16_t)HWRM_NA_SIGNATURE;\n-\n \t\tprandom_bytes(vnic->rss_hash_key, HW_HASH_KEY_SIZE);\n \t\tSTAILQ_INIT(&vnic->filter);\n \t\tSTAILQ_INIT(&vnic->flow_list);\ndiff --git a/drivers/net/bnxt/bnxt_vnic.h b/drivers/net/bnxt/bnxt_vnic.h\nindex c521d7e5a..9029f78c3 100644\n--- a/drivers/net/bnxt/bnxt_vnic.h\n+++ b/drivers/net/bnxt/bnxt_vnic.h\n@@ -15,13 +15,9 @@ struct bnxt_vnic_info {\n \n \tuint16_t\tfw_vnic_id; /* returned by Chimp during alloc */\n \tuint16_t\trss_rule;\n-#define MAX_NUM_TRAFFIC_CLASSES\t\t8\n-#define MAX_NUM_RSS_QUEUES_PER_VNIC\t16\n-#define MAX_QUEUES_PER_VNIC\t(MAX_NUM_RSS_QUEUES_PER_VNIC + \\\n-\t\t\t\t MAX_NUM_TRAFFIC_CLASSES)\n \tuint16_t\tstart_grp_id;\n \tuint16_t\tend_grp_id;\n-\tuint16_t\tfw_grp_ids[MAX_QUEUES_PER_VNIC];\n+\tuint16_t\t*fw_grp_ids;\n \tuint16_t\tdflt_ring_grp;\n \tuint16_t\tmru;\n \tuint16_t\thash_type;\n", "prefixes": [ "v2", "22/23" ] }