List comments

GET /api/patches/417/comments/?format=api
HTTP 200 OK
Allow: GET, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

[
    {
        "id": 833,
        "web_url": "https://patches.dpdk.org/comment/833/",
        "msgid": "<20140917144531.GB4213@localhost.localdomain>",
        "date": "2014-09-17T14:45:31",
        "subject": "Re: [dpdk-dev] [PATCH v3 20/20] eal: set log level from command line",
        "submitter": {
            "id": 32,
            "url": "https://patches.dpdk.org/api/people/32/?format=api",
            "name": "Neil Horman",
            "email": "nhorman@tuxdriver.com"
        },
        "content": "On Wed, Sep 17, 2014 at 03:46:52PM +0200, David Marchand wrote:\n> Add a --log-level option to set the default eal log level.\n> \n> Signed-off-by: David Marchand <david.marchand@6wind.com>\n> Acked-by: Bruce Richardson <bruce.richardson@intel.com>\n> ---\n>  #else\n> @@ -652,6 +679,18 @@ eal_parse_args(int argc, char **argv)\n>  \t\t\t\t\teal_usage(prgname);\n>  \t\t\t\t\treturn -1;\n>  \t\t\t\t}\n> +\t\t\t} else if (!strcmp(lgopts[option_index].name,\n> +\t\t\t\t\t OPT_LOG_LEVEL)) {\n> +\t\t\t\tuint32_t log;\n> +\n> +\t\t\t\tif (eal_parse_log_level(optarg, &log) < 0) {\n> +\t\t\t\t\tRTE_LOG(ERR, EAL,\n> +\t\t\t\t\t\t\"invalid parameters for --\"\n> +\t\t\t\t\t\tOPT_LOG_LEVEL \"\\n\");\n> +\t\t\t\t\teal_usage(prgname);\n> +\t\t\t\t\treturn -1;\n> +\t\t\t\t}\n> +\t\t\t\tinternal_config.log_level = log;\n\n\nThis is a nit, but since you're working in this code anyway, would you mind\nfixing the long options parsing please?  Instead of having a single case\nstatement that just does a never ending if..else..if series of strcmps that\ncould possibly cause a stack overflow, you can set the val value in the lgopts\narray to a unique value for each option and just have a set of case statements.\nIt would look a lot more readable and exeucte more safely.\n\nThanks\nNeil",
        "headers": {
            "X-Mailman-Version": "2.1.15",
            "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
            "In-Reply-To": "<1410961612-8571-21-git-send-email-david.marchand@6wind.com>",
            "Errors-To": "dev-bounces@dpdk.org",
            "Received": [
                "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 486A3B3C0;\n\tWed, 17 Sep 2014 16:40:09 +0200 (CEST)",
                "from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58])\n\tby dpdk.org (Postfix) with ESMTP id 31838B3BF\n\tfor <dev@dpdk.org>; Wed, 17 Sep 2014 16:40:07 +0200 (CEST)",
                "from nat-pool-rdu-u.redhat.com ([66.187.233.203] helo=localhost)\n\tby smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63)\n\t(envelope-from <nhorman@tuxdriver.com>)\n\tid 1XUGUE-0000xN-8b; Wed, 17 Sep 2014 10:45:46 -0400"
            ],
            "References": "<1410961612-8571-1-git-send-email-david.marchand@6wind.com>\n\t<1410961612-8571-21-git-send-email-david.marchand@6wind.com>",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "MIME-Version": "1.0",
            "Message-ID": "<20140917144531.GB4213@localhost.localdomain>",
            "Delivered-To": "patchwork@dpdk.org",
            "Precedence": "list",
            "From": "Neil Horman <nhorman@tuxdriver.com>",
            "X-Original-To": "patchwork@dpdk.org",
            "Content-Type": "text/plain; charset=us-ascii",
            "Content-Disposition": "inline",
            "Return-Path": "<dev-bounces@dpdk.org>",
            "Sender": "\"dev\" <dev-bounces@dpdk.org>",
            "User-Agent": "Mutt/1.5.23 (2014-03-12)",
            "List-Post": "<mailto:dev@dpdk.org>",
            "To": "David Marchand <david.marchand@6wind.com>",
            "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
            "X-Spam-Status": "No",
            "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
            "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "X-BeenThere": "dev@dpdk.org",
            "Date": "Wed, 17 Sep 2014 10:45:31 -0400",
            "Cc": "dev@dpdk.org",
            "X-Spam-Score": "-2.9 (--)",
            "Subject": "Re: [dpdk-dev] [PATCH v3 20/20] eal: set log level from command line"
        }
    },
    {
        "id": 845,
        "web_url": "https://patches.dpdk.org/comment/845/",
        "msgid": "<CALwxeUumccXr2BEwAH-RNqa2-sJ7aQnBu5TaHS-EuUp1-ip7Lw@mail.gmail.com>",
        "date": "2014-09-18T07:46:54",
        "subject": "Re: [dpdk-dev] [PATCH v3 20/20] eal: set log level from command line",
        "submitter": {
            "id": 3,
            "url": "https://patches.dpdk.org/api/people/3/?format=api",
            "name": "David Marchand",
            "email": "david.marchand@6wind.com"
        },
        "content": "Hello Neil,\n\n\nOn Wed, Sep 17, 2014 at 4:45 PM, Neil Horman <nhorman@tuxdriver.com> wrote:\n\n>\n> This is a nit, but since you're working in this code anyway, would you mind\n> fixing the long options parsing please?  Instead of having a single case\n> statement that just does a never ending if..else..if series of strcmps that\n> could possibly cause a stack overflow, you can set the val value in the\n> lgopts\n> array to a unique value for each option and just have a set of case\n> statements.\n> It would look a lot more readable and exeucte more safely.\n>\n\nI agree, but I will send it in a different patchset: already made some\nchanges, it builds fine (at least on my linux), but I want to check it\nactually works and maybe more cleanups can be done there (merging bsd and\nlinux code).",
        "headers": {
            "X-Mailman-Version": "2.1.15",
            "Date": "Thu, 18 Sep 2014 09:46:54 +0200",
            "X-Content-Filtered-By": "Mailman/MimeDel 2.1.15",
            "In-Reply-To": "<20140917144531.GB4213@localhost.localdomain>",
            "Errors-To": "dev-bounces@dpdk.org",
            "Received": [
                "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id D3014B3A0;\n\tThu, 18 Sep 2014 09:41:13 +0200 (CEST)",
                "from mail-ob0-f176.google.com (mail-ob0-f176.google.com\n\t[209.85.214.176]) by dpdk.org (Postfix) with ESMTP id 8F06DB39B\n\tfor <dev@dpdk.org>; Thu, 18 Sep 2014 09:41:11 +0200 (CEST)",
                "by mail-ob0-f176.google.com with SMTP id uz6so368590obc.21\n\tfor <dev@dpdk.org>; Thu, 18 Sep 2014 00:46:55 -0700 (PDT)",
                "by 10.202.13.21 with HTTP; Thu, 18 Sep 2014 00:46:54 -0700 (PDT)"
            ],
            "References": "<1410961612-8571-1-git-send-email-david.marchand@6wind.com>\n\t<1410961612-8571-21-git-send-email-david.marchand@6wind.com>\n\t<20140917144531.GB4213@localhost.localdomain>",
            "X-BeenThere": "dev@dpdk.org",
            "X-Received": "by 10.202.198.137 with SMTP id w131mr24907oif.41.1411026414973; \n\tThu, 18 Sep 2014 00:46:54 -0700 (PDT)",
            "Message-ID": "<CALwxeUumccXr2BEwAH-RNqa2-sJ7aQnBu5TaHS-EuUp1-ip7Lw@mail.gmail.com>",
            "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:mime-version:in-reply-to:references:date\n\t:message-id:subject:from:to:cc:content-type;\n\tbh=364tDesVJSIzVUHQgriW7kGQiFHtJtogld/u0A1+JZk=;\n\tb=aZTBmDLww8AQD5s+DAiKRGFUOZ7HmnH5/oFHm1HWOBnyMbPwCLxObMO29oIa97s6zp\n\tIMnu3q7FyvjCGKqL1dvDyzscNuBMlVAWnCXALSK94rPfQ6J/KGRcnABSTCK5+t62NbGj\n\toTIdWbTnqkX7RrOQNwqkHWC8tpnNt2dGobTzdvN1nuoDPGalTWRUD+vbJWGTiU2OR2wf\n\tXIswTYCvSOsWUIxfJIx914/uf3SQE0a9/h6h9/GCxoKTy4lVMk/F8PMa5O37RN1Qzlb4\n\tAOZj3vPgwSKUKCQjwqpKn0txoPwgP9itbc8iGnFTKZAj2cgxoSdOSeOkCEwojYDYw7hw\n\t0W2Q==",
            "Delivered-To": "patchwork@dpdk.org",
            "Precedence": "list",
            "From": "David Marchand <david.marchand@6wind.com>",
            "X-Original-To": "patchwork@dpdk.org",
            "Content-Type": "text/plain; charset=UTF-8",
            "List-Post": "<mailto:dev@dpdk.org>",
            "Return-Path": "<dev-bounces@dpdk.org>",
            "Sender": "\"dev\" <dev-bounces@dpdk.org>",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
            "To": "Neil Horman <nhorman@tuxdriver.com>",
            "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
            "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "MIME-Version": "1.0",
            "X-Gm-Message-State": "ALoCoQlkB/M8GLcBH56CZLDpFT6mXGDd8LXgL4Vngr4z7e4IJBS7aeWVfuIdiOOZnWh/qXPGsoN4",
            "Cc": "\"dev@dpdk.org\" <dev@dpdk.org>",
            "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
            "Subject": "Re: [dpdk-dev] [PATCH v3 20/20] eal: set log level from command line"
        }
    },
    {
        "id": 847,
        "web_url": "https://patches.dpdk.org/comment/847/",
        "msgid": "<20140918102702.GB20389@hmsreliant.think-freely.org>",
        "date": "2014-09-18T10:27:02",
        "subject": "Re: [dpdk-dev] [PATCH v3 20/20] eal: set log level from command line",
        "submitter": {
            "id": 32,
            "url": "https://patches.dpdk.org/api/people/32/?format=api",
            "name": "Neil Horman",
            "email": "nhorman@tuxdriver.com"
        },
        "content": "On Thu, Sep 18, 2014 at 09:46:54AM +0200, David Marchand wrote:\n> Hello Neil,\n> \n> \n> On Wed, Sep 17, 2014 at 4:45 PM, Neil Horman <nhorman@tuxdriver.com> wrote:\n> \n> >\n> > This is a nit, but since you're working in this code anyway, would you mind\n> > fixing the long options parsing please?  Instead of having a single case\n> > statement that just does a never ending if..else..if series of strcmps that\n> > could possibly cause a stack overflow, you can set the val value in the\n> > lgopts\n> > array to a unique value for each option and just have a set of case\n> > statements.\n> > It would look a lot more readable and exeucte more safely.\n> >\n> \n> I agree, but I will send it in a different patchset: already made some\n> changes, it builds fine (at least on my linux), but I want to check it\n> actually works and maybe more cleanups can be done there (merging bsd and\n> linux code).\n> \nThats fine with me, thanks!\nNeil\n\n> -- \n> David Marchand",
        "headers": {
            "X-Mailman-Version": "2.1.15",
            "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
            "In-Reply-To": "<CALwxeUumccXr2BEwAH-RNqa2-sJ7aQnBu5TaHS-EuUp1-ip7Lw@mail.gmail.com>",
            "Errors-To": "dev-bounces@dpdk.org",
            "Received": [
                "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id A0CCDB3A6;\n\tThu, 18 Sep 2014 12:21:28 +0200 (CEST)",
                "from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58])\n\tby dpdk.org (Postfix) with ESMTP id 0B8CF68C2\n\tfor <dev@dpdk.org>; Thu, 18 Sep 2014 12:21:27 +0200 (CEST)",
                "from hmsreliant.think-freely.org\n\t([2001:470:8:a08:7aac:c0ff:fec2:933b] helo=localhost)\n\tby smtp.tuxdriver.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.63)\n\t(envelope-from <nhorman@tuxdriver.com>)\n\tid 1XUYvX-0000a2-Ke; Thu, 18 Sep 2014 06:27:09 -0400"
            ],
            "References": "<1410961612-8571-1-git-send-email-david.marchand@6wind.com>\n\t<1410961612-8571-21-git-send-email-david.marchand@6wind.com>\n\t<20140917144531.GB4213@localhost.localdomain>\n\t<CALwxeUumccXr2BEwAH-RNqa2-sJ7aQnBu5TaHS-EuUp1-ip7Lw@mail.gmail.com>",
            "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
            "MIME-Version": "1.0",
            "Message-ID": "<20140918102702.GB20389@hmsreliant.think-freely.org>",
            "Delivered-To": "patchwork@dpdk.org",
            "Precedence": "list",
            "From": "Neil Horman <nhorman@tuxdriver.com>",
            "X-Original-To": "patchwork@dpdk.org",
            "Content-Type": "text/plain; charset=us-ascii",
            "Content-Disposition": "inline",
            "Return-Path": "<dev-bounces@dpdk.org>",
            "Sender": "\"dev\" <dev-bounces@dpdk.org>",
            "User-Agent": "Mutt/1.5.23 (2014-03-12)",
            "List-Post": "<mailto:dev@dpdk.org>",
            "To": "David Marchand <david.marchand@6wind.com>",
            "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
            "X-Spam-Status": "No",
            "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
            "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
            "X-BeenThere": "dev@dpdk.org",
            "Date": "Thu, 18 Sep 2014 06:27:02 -0400",
            "Cc": "\"dev@dpdk.org\" <dev@dpdk.org>",
            "X-Spam-Score": "-2.9 (--)",
            "Subject": "Re: [dpdk-dev] [PATCH v3 20/20] eal: set log level from command line"
        }
    }
]