Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 4143,
    "url": "https://patches.dpdk.org/api/patches/4143/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1427319492-943-1-git-send-email-jingjing.wu@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1427319492-943-1-git-send-email-jingjing.wu@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1427319492-943-1-git-send-email-jingjing.wu@intel.com",
    "date": "2015-03-25T21:38:12",
    "name": "[dpdk-dev] i40e: zero local variable",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "b43dc0e9e8cc156d302e02914a1410b24f7f1ecd",
    "submitter": {
        "id": 47,
        "url": "https://patches.dpdk.org/api/people/47/?format=api",
        "name": "Jingjing Wu",
        "email": "jingjing.wu@intel.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1427319492-943-1-git-send-email-jingjing.wu@intel.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/4143/comments/",
    "check": "pending",
    "checks": "https://patches.dpdk.org/api/patches/4143/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id E9BE89ACA;\n\tWed, 25 Mar 2015 22:38:22 +0100 (CET)",
            "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id 488BA5A9F\n\tfor <dev@dpdk.org>; Wed, 25 Mar 2015 22:38:21 +0100 (CET)",
            "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga101.jf.intel.com with ESMTP; 25 Mar 2015 14:38:20 -0700",
            "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby orsmga001.jf.intel.com with ESMTP; 25 Mar 2015 14:38:20 -0700",
            "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id t2PLcHNa017466;\n\tThu, 26 Mar 2015 05:38:17 +0800",
            "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid t2PLcElH000977; Thu, 26 Mar 2015 05:38:16 +0800",
            "(from wujingji@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id t2PLcE5s000973; \n\tThu, 26 Mar 2015 05:38:14 +0800"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.11,467,1422950400\"; d=\"scan'208\";a=\"670625840\"",
        "From": "Jingjing Wu <jingjing.wu@intel.com>",
        "To": "dev@dpdk.org",
        "Date": "Thu, 26 Mar 2015 05:38:12 +0800",
        "Message-Id": "<1427319492-943-1-git-send-email-jingjing.wu@intel.com>",
        "X-Mailer": "git-send-email 1.7.4.1",
        "Subject": "[dpdk-dev] [PATCH] i40e: zero local variable",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "This patch sets the local variable ctxt to zero to avoid uncertain\ndata causes error when creating a vsi for flow director.\n\nSigned-off-by: Jingjing Wu <jingjing.wu@intel.com>\n---\n lib/librte_pmd_i40e/i40e_ethdev.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)",
    "diff": "diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c b/lib/librte_pmd_i40e/i40e_ethdev.c\nindex cf6685e..80fc432 100644\n--- a/lib/librte_pmd_i40e/i40e_ethdev.c\n+++ b/lib/librte_pmd_i40e/i40e_ethdev.c\n@@ -3120,6 +3120,7 @@ i40e_vsi_setup(struct i40e_pf *pf,\n \t\tctxt.info.valid_sections |=\n \t\t\trte_cpu_to_le_16(I40E_AQ_VSI_PROP_SCHED_VALID);\n \t} else if (type == I40E_VSI_FDIR) {\n+\t\tmemset(&ctxt, 0, sizeof(ctxt));\n \t\tvsi->uplink_seid = uplink_vsi->uplink_seid;\n \t\tctxt.pf_num = hw->pf_id;\n \t\tctxt.vf_num = 0;\n@@ -3143,7 +3144,7 @@ i40e_vsi_setup(struct i40e_pf *pf,\n \n \tif (vsi->type != I40E_VSI_MAIN) {\n \t\tret = i40e_aq_add_vsi(hw, &ctxt, NULL);\n-\t\tif (ret) {\n+\t\tif (ret != I40E_SUCCESS) {\n \t\t\tPMD_DRV_LOG(ERR, \"add vsi failed, aq_err=%d\",\n \t\t\t\t    hw->aq.asq_last_status);\n \t\t\tgoto fail_msix_alloc;\n",
    "prefixes": [
        "dpdk-dev"
    ]
}