Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41338/?format=api
{ "id": 41338, "url": "https://patches.dpdk.org/api/patches/41338/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20180621020059.1198-20-qi.z.zhang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180621020059.1198-20-qi.z.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180621020059.1198-20-qi.z.zhang@intel.com", "date": "2018-06-21T02:00:56", "name": "[v2,19/22] net/softnic: enable port detach on secondary process", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a0f69d8ed35860907b7f397b5f86b38faf819193", "submitter": { "id": 504, "url": "https://patches.dpdk.org/api/people/504/?format=api", "name": "Qi Zhang", "email": "qi.z.zhang@intel.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20180621020059.1198-20-qi.z.zhang@intel.com/mbox/", "series": [ { "id": 184, "url": "https://patches.dpdk.org/api/series/184/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=184", "date": "2018-06-21T02:00:39", "name": "enable hotplug on multi-process", "version": 2, "mbox": "https://patches.dpdk.org/series/184/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/41338/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/41338/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id DA6DF1BA8F;\n\tThu, 21 Jun 2018 04:10:44 +0200 (CEST)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby dpdk.org (Postfix) with ESMTP id 03E9C1B8B2\n\tfor <dev@dpdk.org>; Thu, 21 Jun 2018 04:00:57 +0200 (CEST)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t20 Jun 2018 19:00:57 -0700", "from dpdk51.sh.intel.com ([10.67.110.190])\n\tby fmsmga004.fm.intel.com with ESMTP; 20 Jun 2018 19:00:56 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,249,1526367600\"; d=\"scan'208\";a=\"64993966\"", "From": "Qi Zhang <qi.z.zhang@intel.com>", "To": "thomas@monjalon.net,\n\tanatoly.burakov@intel.com", "Cc": "konstantin.ananyev@intel.com, dev@dpdk.org, bruce.richardson@intel.com, \n\tferruh.yigit@intel.com, benjamin.h.shelton@intel.com,\n\tnarender.vangati@intel.com, Qi Zhang <qi.z.zhang@intel.com>", "Date": "Thu, 21 Jun 2018 10:00:56 +0800", "Message-Id": "<20180621020059.1198-20-qi.z.zhang@intel.com>", "X-Mailer": "git-send-email 2.13.6", "In-Reply-To": "<20180621020059.1198-1-qi.z.zhang@intel.com>", "References": "<20180607123849.14439-1-qi.z.zhang@intel.com>\n\t<20180621020059.1198-1-qi.z.zhang@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 19/22] net/softnic: enable port detach on\n\tsecondary process", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Previously, detach port on secondary process will mess primary\nprocess and cause same device can't be attached again, by take\nadvantage of rte_eth_release_port_private, we can support this\nwith minor change.\n\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\n---\n drivers/net/softnic/rte_eth_softnic.c | 19 ++++++++++++++++---\n 1 file changed, 16 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/softnic/rte_eth_softnic.c b/drivers/net/softnic/rte_eth_softnic.c\nindex 6b3c13e5c..a45a7b0dd 100644\n--- a/drivers/net/softnic/rte_eth_softnic.c\n+++ b/drivers/net/softnic/rte_eth_softnic.c\n@@ -750,6 +750,7 @@ pmd_probe(struct rte_vdev_device *vdev)\n \t\t}\n \t\t/* TODO: request info from primary to set up Rx and Tx */\n \t\teth_dev->dev_ops = &pmd_ops;\n+\t\teth_dev->device = &vdev->device;\n \t\trte_eth_dev_probing_finish(eth_dev);\n \t\treturn 0;\n \t}\n@@ -803,17 +804,29 @@ pmd_remove(struct rte_vdev_device *vdev)\n {\n \tstruct rte_eth_dev *dev = NULL;\n \tstruct pmd_internals *p;\n+\tconst char *name;\n \n \tif (!vdev)\n \t\treturn -EINVAL;\n \n-\tPMD_LOG(INFO, \"Removing device \\\"%s\\\"\",\n-\t\trte_vdev_device_name(vdev));\n+\tname = rte_vdev_device_name(vdev);\n+\tPMD_LOG(INFO, \"Removing device \\\"%s\\\"\", name);\n \n \t/* Find the ethdev entry */\n-\tdev = rte_eth_dev_allocated(rte_vdev_device_name(vdev));\n+\tdev = rte_eth_dev_allocated(name);\n \tif (dev == NULL)\n \t\treturn -ENODEV;\n+\n+\tif (rte_eal_process_type() != RTE_PROC_PRIMARY) {\n+\t\t/* detach device on local pprocess only */\n+\t\tif (strlen(rte_vdev_device_args(vdev)) == 0)\n+\t\t\treturn rte_eth_dev_release_port_private(dev);\n+\t\t/**\n+\t\t * else this is a private device for current process\n+\t\t * so continue with normal detach scenario\n+\t\t */\n+\t}\n+\n \tp = dev->data->dev_private;\n \n \t/* Free device data structures*/\n", "prefixes": [ "v2", "19/22" ] }