Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41299/?format=api
{ "id": 41299, "url": "https://patches.dpdk.org/api/patches/41299/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20180619213058.12273-30-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180619213058.12273-30-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180619213058.12273-30-ajit.khaparde@broadcom.com", "date": "2018-06-19T21:30:56", "name": "[29/31] net/bnxt: fix incorrect IO address handling in Tx", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "2d05d334b223c676b690f4ccfae7795c958e020e", "submitter": { "id": 501, "url": "https://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20180619213058.12273-30-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 171, "url": "https://patches.dpdk.org/api/series/171/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=171", "date": "2018-06-19T21:30:31", "name": "bnxt patchset", "version": 1, "mbox": "https://patches.dpdk.org/series/171/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/41299/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/41299/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A60431B4CF;\n\tTue, 19 Jun 2018 23:32:16 +0200 (CEST)", "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n\t[192.19.229.170]) by dpdk.org (Postfix) with ESMTP id 917691B057;\n\tTue, 19 Jun 2018 23:31:11 +0200 (CEST)", "from nis-sj1-27.broadcom.com (nis-sj1-27.lvn.broadcom.net\n\t[10.75.144.136])\n\tby rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 7B78C30C07E;\n\tTue, 19 Jun 2018 14:31:10 -0700 (PDT)", "from C02VPB22HTD6.dhcp.broadcom.net (c02vpb22htd6.dhcp.broadcom.net\n\t[10.136.50.120])\n\tby nis-sj1-27.broadcom.com (Postfix) with ESMTP id A633AAC0799;\n\tTue, 19 Jun 2018 14:31:10 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com 7B78C30C07E", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n\ts=dkimrelay; t=1529443870;\n\tbh=PekTvKybUCrJKzY84kWwZkURrM3ifdOn0tlWT6btxKU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=EsJFtvH1TeOHJiFrir23xuikWUq8Ni+ekxEQu66j/czw1V3EnmWG1bJmL7H+aDZfq\n\tuHclew/kQKR0+JWEEKT6L4eRFySwXHSSFjnd+NPxK86MmiEZEBytErKx/+33yCIxZ0\n\tWY6Cme0c5Xy2SC+hL/JB7ThLhtHWzkSzaS+gsiCE=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com,\n\tstable@dpdk.org", "Date": "Tue, 19 Jun 2018 14:30:56 -0700", "Message-Id": "<20180619213058.12273-30-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.15.1 (Apple Git-101)", "In-Reply-To": "<20180619213058.12273-1-ajit.khaparde@broadcom.com>", "References": "<20180619213058.12273-1-ajit.khaparde@broadcom.com>", "Subject": "[dpdk-dev] [PATCH 29/31] net/bnxt: fix incorrect IO address\n\thandling in Tx", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "rte_mbuf_data_iova returns a 64-bit address. But we are incorrectly\nusing only 32-bits of that. Use rte_cpu_to_le_64 instead of\nrte_cpu_to_le_32\n\nFixes: 6eb3cc2294fd (\"net/bnxt: add initial Tx code\")\nCc: stable@dpdk.org\n\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt_txr.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_txr.c b/drivers/net/bnxt/bnxt_txr.c\nindex 23c8e6660..4e684f208 100644\n--- a/drivers/net/bnxt/bnxt_txr.c\n+++ b/drivers/net/bnxt/bnxt_txr.c\n@@ -164,7 +164,7 @@ static uint16_t bnxt_start_xmit(struct rte_mbuf *tx_pkt,\n \t\ttxbd->flags_type |= TX_BD_LONG_FLAGS_LHINT_GTE2K;\n \telse\n \t\ttxbd->flags_type |= lhint_arr[tx_pkt->pkt_len >> 9];\n-\ttxbd->address = rte_cpu_to_le_32(rte_mbuf_data_iova(tx_buf->mbuf));\n+\ttxbd->address = rte_cpu_to_le_64(rte_mbuf_data_iova(tx_buf->mbuf));\n \n \tif (long_bd) {\n \t\ttxbd->flags_type |= TX_BD_LONG_TYPE_TX_BD_LONG;\n@@ -287,7 +287,7 @@ static uint16_t bnxt_start_xmit(struct rte_mbuf *tx_pkt,\n \t\ttx_buf = &txr->tx_buf_ring[txr->tx_prod];\n \n \t\ttxbd = &txr->tx_desc_ring[txr->tx_prod];\n-\t\ttxbd->address = rte_cpu_to_le_32(rte_mbuf_data_iova(m_seg));\n+\t\ttxbd->address = rte_cpu_to_le_64(rte_mbuf_data_iova(m_seg));\n \t\ttxbd->flags_type |= TX_BD_SHORT_TYPE_TX_BD_SHORT;\n \t\ttxbd->len = m_seg->data_len;\n \n", "prefixes": [ "29/31" ] }