Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41293/?format=api
{ "id": 41293, "url": "https://patches.dpdk.org/api/patches/41293/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20180619213058.12273-21-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180619213058.12273-21-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180619213058.12273-21-ajit.khaparde@broadcom.com", "date": "2018-06-19T21:30:47", "name": "[20/31] net/bnxt: code cleanup style of bnxt ethdev", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "584c00ab7c8894ab530cc166a4303b7df61a9cef", "submitter": { "id": 501, "url": "https://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20180619213058.12273-21-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 171, "url": "https://patches.dpdk.org/api/series/171/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=171", "date": "2018-06-19T21:30:31", "name": "bnxt patchset", "version": 1, "mbox": "https://patches.dpdk.org/series/171/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/41293/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/41293/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C2B861B470;\n\tTue, 19 Jun 2018 23:32:00 +0200 (CEST)", "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n\t[192.19.229.170]) by dpdk.org (Postfix) with ESMTP id E27D41B057\n\tfor <dev@dpdk.org>; Tue, 19 Jun 2018 23:31:09 +0200 (CEST)", "from nis-sj1-27.broadcom.com (nis-sj1-27.lvn.broadcom.net\n\t[10.75.144.136])\n\tby rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 5AA4130C078;\n\tTue, 19 Jun 2018 14:31:07 -0700 (PDT)", "from C02VPB22HTD6.dhcp.broadcom.net (c02vpb22htd6.dhcp.broadcom.net\n\t[10.136.50.120])\n\tby nis-sj1-27.broadcom.com (Postfix) with ESMTP id 8BD7EAC0799;\n\tTue, 19 Jun 2018 14:31:07 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com 5AA4130C078", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n\ts=dkimrelay; t=1529443867;\n\tbh=nEy+cIHiSi2v++Xzs6K6Pk1cJUxBuVzEIej0Yuqk/eE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=L1cz9c1cFewQfmL/TqEjoxN82XXah+YtPkxvHRwl16E6DhQIuq5h0N6CfQAqKvg32\n\t5VZDMGQBz9hZviA2PSDX+z8I0KZpBuHDc7GeciFDMIvpkhVZglxGRPZG8z5mEnqO0k\n\tIRSSQe9ga0s6JZ5zVGCdDxCCQkEzUoRB9nRjXhIY=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com,\n\tScott Branden <scott.branden@broadcom.com>", "Date": "Tue, 19 Jun 2018 14:30:47 -0700", "Message-Id": "<20180619213058.12273-21-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.15.1 (Apple Git-101)", "In-Reply-To": "<20180619213058.12273-1-ajit.khaparde@broadcom.com>", "References": "<20180619213058.12273-1-ajit.khaparde@broadcom.com>", "Subject": "[dpdk-dev] [PATCH 20/31] net/bnxt: code cleanup style of bnxt ethdev", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Scott Branden <scott.branden@broadcom.com>\n\nCleanup alignment, brackets, debug string style of bnxt_ethdev\n\nSigned-off-by: Scott Branden <scott.branden@broadcom.com>\nReviewed-by: Randy Schacher <stuart.schacher@broadcom.com>\nReviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt_ethdev.c | 204 ++++++++++++++++++++++-------------------\n 1 file changed, 112 insertions(+), 92 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex d66a29758..6516aeedd 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -315,8 +315,9 @@ static int bnxt_init_chip(struct bnxt *bp)\n \t\tintr_vector = bp->eth_dev->data->nb_rx_queues;\n \t\tPMD_DRV_LOG(DEBUG, \"intr_vector = %d\\n\", intr_vector);\n \t\tif (intr_vector > bp->rx_cp_nr_rings) {\n-\t\t\tPMD_DRV_LOG(ERR, \"At most %d intr queues supported\",\n-\t\t\t\t\tbp->rx_cp_nr_rings);\n+\t\t\tPMD_DRV_LOG(ERR,\n+\t\t\t\t \"At most %d intr queues supported\\n\",\n+\t\t\t\t bp->rx_cp_nr_rings);\n \t\t\treturn -ENOTSUP;\n \t\t}\n \t\tif (rte_intr_efd_enable(intr_handle, intr_vector))\n@@ -329,14 +330,15 @@ static int bnxt_init_chip(struct bnxt *bp)\n \t\t\t\t bp->eth_dev->data->nb_rx_queues *\n \t\t\t\t sizeof(int), 0);\n \t\tif (intr_handle->intr_vec == NULL) {\n-\t\t\tPMD_DRV_LOG(ERR, \"Failed to allocate %d rx_queues\"\n-\t\t\t\t\" intr_vec\", bp->eth_dev->data->nb_rx_queues);\n+\t\t\tPMD_DRV_LOG(ERR,\n+\t\t\t\t \"Failed to allocate %d rx_queues intr_vec\\n\",\n+\t\t\t\t bp->eth_dev->data->nb_rx_queues);\n \t\t\treturn -ENOMEM;\n \t\t}\n-\t\tPMD_DRV_LOG(DEBUG, \"intr_handle->intr_vec = %p \"\n-\t\t\t\"intr_handle->nb_efd = %d intr_handle->max_intr = %d\\n\",\n-\t\t\t intr_handle->intr_vec, intr_handle->nb_efd,\n-\t\t\tintr_handle->max_intr);\n+\t\tPMD_DRV_LOG(DEBUG,\n+\t\t\t \"intr_handle->intr_vec = %p intr_handle->nb_efd = %d intr_handle->max_intr = %d\\n\",\n+\t\t\t intr_handle->intr_vec, intr_handle->nb_efd,\n+\t\t\t intr_handle->max_intr);\n \t}\n \n \tfor (queue_id = 0; queue_id < bp->eth_dev->data->nb_rx_queues;\n@@ -404,7 +406,7 @@ static int bnxt_init_nic(struct bnxt *bp)\n */\n \n static void bnxt_dev_info_get_op(struct rte_eth_dev *eth_dev,\n-\t\t\t\t struct rte_eth_dev_info *dev_info)\n+\t\t\t\t struct rte_eth_dev_info *dev_info)\n {\n \tstruct bnxt *bp = (struct bnxt *)eth_dev->data->dev_private;\n \tuint16_t max_vnics, i, j, vpool, vrxq;\n@@ -706,15 +708,22 @@ static void bnxt_mac_addr_remove_op(struct rte_eth_dev *eth_dev,\n \t\t\twhile (filter) {\n \t\t\t\ttemp_filter = STAILQ_NEXT(filter, next);\n \t\t\t\tif (filter->mac_index == index) {\n-\t\t\t\t\tSTAILQ_REMOVE(&vnic->filter, filter,\n-\t\t\t\t\t\t bnxt_filter_info, next);\n+\t\t\t\t\tSTAILQ_REMOVE(&vnic->filter,\n+\t\t\t\t\t\t filter,\n+\t\t\t\t\t\t bnxt_filter_info,\n+\t\t\t\t\t\t next);\n+\n \t\t\t\t\tbnxt_hwrm_clear_l2_filter(bp, filter);\n \t\t\t\t\tfilter->mac_index = INVALID_MAC_INDEX;\n-\t\t\t\t\tmemset(&filter->l2_addr, 0,\n+\n+\t\t\t\t\tmemset(&filter->l2_addr,\n+\t\t\t\t\t 0,\n \t\t\t\t\t ETHER_ADDR_LEN);\n-\t\t\t\t\tSTAILQ_INSERT_TAIL(\n-\t\t\t\t\t\t\t&bp->free_filter_list,\n-\t\t\t\t\t\t\tfilter, next);\n+\n+\t\t\t\t\tSTAILQ_INSERT_TAIL\n+\t\t\t\t\t\t(&bp->free_filter_list,\n+\t\t\t\t\t\t filter,\n+\t\t\t\t\t\t next);\n \t\t\t\t}\n \t\t\t\tfilter = temp_filter;\n \t\t\t}\n@@ -785,9 +794,10 @@ int bnxt_link_update_op(struct rte_eth_dev *eth_dev, int wait_to_complete)\n out:\n \t/* Timed out or success */\n \tif (new.link_status != eth_dev->data->dev_link.link_status ||\n-\tnew.link_speed != eth_dev->data->dev_link.link_speed) {\n-\t\tmemcpy(ð_dev->data->dev_link, &new,\n-\t\t\tsizeof(struct rte_eth_link));\n+\t new.link_speed != eth_dev->data->dev_link.link_speed) {\n+\t\tmemcpy(ð_dev->data->dev_link,\n+\t\t &new,\n+\t\t sizeof(struct rte_eth_link));\n \n \t\t_rte_eth_dev_callback_process(eth_dev,\n \t\t\t\t\t RTE_ETH_EVENT_INTR_LSC,\n@@ -856,8 +866,8 @@ static void bnxt_allmulticast_disable_op(struct rte_eth_dev *eth_dev)\n }\n \n static int bnxt_reta_update_op(struct rte_eth_dev *eth_dev,\n-\t\t\t struct rte_eth_rss_reta_entry64 *reta_conf,\n-\t\t\t uint16_t reta_size)\n+\t\t\t struct rte_eth_rss_reta_entry64 *reta_conf,\n+\t\t\t uint16_t reta_size)\n {\n \tstruct bnxt *bp = (struct bnxt *)eth_dev->data->dev_private;\n \tstruct rte_eth_conf *dev_conf = &bp->eth_dev->data->dev_conf;\n@@ -868,9 +878,9 @@ static int bnxt_reta_update_op(struct rte_eth_dev *eth_dev,\n \t\treturn -EINVAL;\n \n \tif (reta_size != HW_HASH_INDEX_SIZE) {\n-\t\tPMD_DRV_LOG(ERR, \"The configured hash table lookup size \"\n-\t\t\t\"(%d) must equal the size supported by the hardware \"\n-\t\t\t\"(%d)\\n\", reta_size, HW_HASH_INDEX_SIZE);\n+\t\tPMD_DRV_LOG(ERR,\n+\t\t\t \"Configured hash table lookup size (%d) != (%d)\\n\",\n+\t\t\t reta_size, HW_HASH_INDEX_SIZE);\n \t\treturn -EINVAL;\n \t}\n \t/* Update the RSS VNIC(s) */\n@@ -900,9 +910,9 @@ static int bnxt_reta_query_op(struct rte_eth_dev *eth_dev,\n \t\treturn -EINVAL;\n \n \tif (reta_size != HW_HASH_INDEX_SIZE) {\n-\t\tPMD_DRV_LOG(ERR, \"The configured hash table lookup size \"\n-\t\t\t\"(%d) must equal the size supported by the hardware \"\n-\t\t\t\"(%d)\\n\", reta_size, HW_HASH_INDEX_SIZE);\n+\t\tPMD_DRV_LOG(ERR,\n+\t\t\t \"Configured hash table lookup size (%d) != (%d)\\n\",\n+\t\t\t reta_size, HW_HASH_INDEX_SIZE);\n \t\treturn -EINVAL;\n \t}\n \t/* EW - need to revisit here copying from uint64_t to uint16_t */\n@@ -1021,8 +1031,8 @@ static int bnxt_rss_hash_conf_get_op(struct rte_eth_dev *eth_dev,\n \t\t}\n \t\tif (hash_types) {\n \t\t\tPMD_DRV_LOG(ERR,\n-\t\t\t\t\"Unknwon RSS config from firmware (%08x), RSS disabled\",\n-\t\t\t\tvnic->hash_type);\n+\t\t\t\t \"Unknown RSS config (%08x), RSS disabled\\n\",\n+\t\t\t\t vnic->hash_type);\n \t\t\treturn -ENOTSUP;\n \t\t}\n \t} else {\n@@ -1032,7 +1042,7 @@ static int bnxt_rss_hash_conf_get_op(struct rte_eth_dev *eth_dev,\n }\n \n static int bnxt_flow_ctrl_get_op(struct rte_eth_dev *dev,\n-\t\t\t struct rte_eth_fc_conf *fc_conf)\n+\t\t\t\t struct rte_eth_fc_conf *fc_conf)\n {\n \tstruct bnxt *bp = (struct bnxt *)dev->data->dev_private;\n \tstruct rte_eth_link link_info;\n@@ -1064,7 +1074,7 @@ static int bnxt_flow_ctrl_get_op(struct rte_eth_dev *dev,\n }\n \n static int bnxt_flow_ctrl_set_op(struct rte_eth_dev *dev,\n-\t\t\t struct rte_eth_fc_conf *fc_conf)\n+\t\t\t\t struct rte_eth_fc_conf *fc_conf)\n {\n \tstruct bnxt *bp = (struct bnxt *)dev->data->dev_private;\n \n@@ -1120,7 +1130,7 @@ static int bnxt_flow_ctrl_set_op(struct rte_eth_dev *dev,\n /* Add UDP tunneling port */\n static int\n bnxt_udp_tunnel_port_add_op(struct rte_eth_dev *eth_dev,\n-\t\t\t struct rte_eth_udp_tunnel *udp_tunnel)\n+\t\t\t struct rte_eth_udp_tunnel *udp_tunnel)\n {\n \tstruct bnxt *bp = (struct bnxt *)eth_dev->data->dev_private;\n \tuint16_t tunnel_type = 0;\n@@ -1168,7 +1178,7 @@ bnxt_udp_tunnel_port_add_op(struct rte_eth_dev *eth_dev,\n \n static int\n bnxt_udp_tunnel_port_del_op(struct rte_eth_dev *eth_dev,\n-\t\t\t struct rte_eth_udp_tunnel *udp_tunnel)\n+\t\t\t struct rte_eth_udp_tunnel *udp_tunnel)\n {\n \tstruct bnxt *bp = (struct bnxt *)eth_dev->data->dev_private;\n \tuint16_t tunnel_type = 0;\n@@ -1256,9 +1266,10 @@ static int bnxt_del_vlan_filter(struct bnxt *bp, uint16_t vlan_id)\n \t\t\t\t\tSTAILQ_REMOVE(&vnic->filter, filter,\n \t\t\t\t\t\t bnxt_filter_info, next);\n \t\t\t\t\tbnxt_hwrm_clear_l2_filter(bp, filter);\n-\t\t\t\t\tSTAILQ_INSERT_TAIL(\n-\t\t\t\t\t\t\t&bp->free_filter_list,\n-\t\t\t\t\t\t\tfilter, next);\n+\t\t\t\t\tSTAILQ_INSERT_TAIL\n+\t\t\t\t\t\t\t(&bp->free_filter_list,\n+\t\t\t\t\t\t\t filter,\n+\t\t\t\t\t\t\t next);\n \n \t\t\t\t\t/*\n \t\t\t\t\t * Need to examine to see if the MAC\n@@ -1281,9 +1292,10 @@ static int bnxt_del_vlan_filter(struct bnxt *bp, uint16_t vlan_id)\n \t\t\t\t\tmemcpy(new_filter->l2_addr,\n \t\t\t\t\t filter->l2_addr, ETHER_ADDR_LEN);\n \t\t\t\t\t/* MAC only filter */\n-\t\t\t\t\trc = bnxt_hwrm_set_l2_filter(bp,\n-\t\t\t\t\t\t\tvnic->fw_vnic_id,\n-\t\t\t\t\t\t\tnew_filter);\n+\t\t\t\t\trc = bnxt_hwrm_set_l2_filter\n+\t\t\t\t\t\t\t(bp,\n+\t\t\t\t\t\t\t vnic->fw_vnic_id,\n+\t\t\t\t\t\t\t new_filter);\n \t\t\t\t\tif (rc)\n \t\t\t\t\t\tgoto exit;\n \t\t\t\t\tPMD_DRV_LOG(INFO,\n@@ -1335,9 +1347,10 @@ static int bnxt_add_vlan_filter(struct bnxt *bp, uint16_t vlan_id)\n \t\t\t\t\t\t bnxt_filter_info, next);\n \t\t\t\t\tbnxt_hwrm_clear_l2_filter(bp, filter);\n \t\t\t\t\tfilter->l2_ovlan = 0;\n-\t\t\t\t\tSTAILQ_INSERT_TAIL(\n-\t\t\t\t\t\t\t&bp->free_filter_list,\n-\t\t\t\t\t\t\tfilter, next);\n+\t\t\t\t\tSTAILQ_INSERT_TAIL\n+\t\t\t\t\t\t(&bp->free_filter_list,\n+\t\t\t\t\t\t filter,\n+\t\t\t\t\t\t next);\n \t\t\t\t}\n \t\t\t\tnew_filter = bnxt_alloc_filter(bp);\n \t\t\t\tif (!new_filter) {\n@@ -1405,6 +1418,7 @@ bnxt_vlan_offload_set_op(struct rte_eth_dev *dev, int mask)\n \t\t/* Enable or disable VLAN stripping */\n \t\tfor (i = 0; i < bp->nr_vnics; i++) {\n \t\t\tstruct bnxt_vnic_info *vnic = &bp->vnic_info[i];\n+\n \t\t\tif (rx_offloads & DEV_RX_OFFLOAD_VLAN_STRIP)\n \t\t\t\tvnic->vlan_strip = true;\n \t\t\telse\n@@ -1460,8 +1474,8 @@ bnxt_set_default_mac_addr_op(struct rte_eth_dev *dev, struct ether_addr *addr)\n \n static int\n bnxt_dev_set_mc_addr_list_op(struct rte_eth_dev *eth_dev,\n-\t\t\t struct ether_addr *mc_addr_set,\n-\t\t\t uint32_t nb_mc_addr)\n+\t\t\t struct ether_addr *mc_addr_set,\n+\t\t\t uint32_t nb_mc_addr)\n {\n \tstruct bnxt *bp = (struct bnxt *)eth_dev->data->dev_private;\n \tchar *mc_addr_list = (char *)mc_addr_set;\n@@ -1497,8 +1511,9 @@ bnxt_fw_version_get(struct rte_eth_dev *dev, char *fw_version, size_t fw_size)\n \tuint8_t fw_updt = (bp->fw_ver >> 8) & 0xff;\n \tint ret;\n \n-\tret = snprintf(fw_version, fw_size, \"%d.%d.%d\",\n-\t\t\tfw_major, fw_minor, fw_updt);\n+\tret = snprintf(fw_version, fw_size,\n+\t\t \"%d.%d.%d\",\n+\t\t fw_major, fw_minor, fw_updt);\n \n \tret += 1; /* add the size of '\\0' */\n \tif (fw_size < (uint32_t)ret)\n@@ -1508,8 +1523,9 @@ bnxt_fw_version_get(struct rte_eth_dev *dev, char *fw_version, size_t fw_size)\n }\n \n static void\n-bnxt_rxq_info_get_op(struct rte_eth_dev *dev, uint16_t queue_id,\n-\tstruct rte_eth_rxq_info *qinfo)\n+bnxt_rxq_info_get_op(struct rte_eth_dev *dev,\n+\t\t uint16_t queue_id,\n+\t\t struct rte_eth_rxq_info *qinfo)\n {\n \tstruct bnxt_rx_queue *rxq;\n \n@@ -1525,8 +1541,9 @@ bnxt_rxq_info_get_op(struct rte_eth_dev *dev, uint16_t queue_id,\n }\n \n static void\n-bnxt_txq_info_get_op(struct rte_eth_dev *dev, uint16_t queue_id,\n-\tstruct rte_eth_txq_info *qinfo)\n+bnxt_txq_info_get_op(struct rte_eth_dev *dev,\n+\t\t uint16_t queue_id,\n+\t\t struct rte_eth_txq_info *qinfo)\n {\n \tstruct bnxt_tx_queue *txq;\n \n@@ -1561,7 +1578,6 @@ static int bnxt_mtu_set_op(struct rte_eth_dev *eth_dev, uint16_t new_mtu)\n \t\treturn -EINVAL;\n \t}\n \n-\n \tif (new_mtu > ETHER_MTU) {\n \t\tbp->flags |= BNXT_FLAG_JUMBO;\n \t\tbp->eth_dev->data->dev_conf.rxmode.offloads |=\n@@ -1655,17 +1671,16 @@ bnxt_rx_queue_count_op(struct rte_eth_dev *dev, uint16_t rx_queue_id)\n \t\tvalid = FLIP_VALID(cons, cpr->cp_ring_struct->ring_mask, valid);\n \t\tcmp_type = CMP_TYPE(rxcmp);\n \t\tif (cmp_type == RX_TPA_END_CMPL_TYPE_RX_TPA_END) {\n-\t\t\tcmp = (rte_le_to_cpu_32(\n-\t\t\t\t\t((struct rx_tpa_end_cmpl *)\n-\t\t\t\t\t (rxcmp))->agg_bufs_v1) &\n-\t\t\t RX_TPA_END_CMPL_AGG_BUFS_MASK) >>\n-\t\t\t\tRX_TPA_END_CMPL_AGG_BUFS_SFT;\n+\t\t\tcmp = (rte_le_to_cpu_32\n+\t\t\t\t(((struct rx_tpa_end_cmpl *)\n+\t\t\t\t (rxcmp))->agg_bufs_v1)\n+\t\t\t\t& RX_TPA_END_CMPL_AGG_BUFS_MASK)\n+\t\t\t\t>> RX_TPA_END_CMPL_AGG_BUFS_SFT;\n \t\t\tdesc++;\n \t\t} else if (cmp_type == 0x11) {\n \t\t\tdesc++;\n-\t\t\tcmp = (rxcmp->agg_bufs_v1 &\n-\t\t\t\t RX_PKT_CMPL_AGG_BUFS_MASK) >>\n-\t\t\t\tRX_PKT_CMPL_AGG_BUFS_SFT;\n+\t\t\tcmp = (rxcmp->agg_bufs_v1 & RX_PKT_CMPL_AGG_BUFS_MASK)\n+\t\t\t\t>> RX_PKT_CMPL_AGG_BUFS_SFT;\n \t\t} else {\n \t\t\tcmp = 1;\n \t\t}\n@@ -1710,7 +1725,6 @@ bnxt_rx_descriptor_status_op(void *rx_queue, uint16_t offset)\n \tif (rx_buf->mbuf == NULL)\n \t\treturn RTE_ETH_RX_DESC_UNAVAIL;\n \n-\n \treturn RTE_ETH_RX_DESC_AVAIL;\n }\n \n@@ -2882,16 +2896,20 @@ bnxt_get_eeprom_length_op(struct rte_eth_dev *dev)\n \n static int\n bnxt_get_eeprom_op(struct rte_eth_dev *dev,\n-\t\tstruct rte_dev_eeprom_info *in_eeprom)\n+\t\t struct rte_dev_eeprom_info *in_eeprom)\n {\n \tstruct bnxt *bp = (struct bnxt *)dev->data->dev_private;\n \tuint32_t index;\n \tuint32_t offset;\n \n-\tPMD_DRV_LOG(INFO, \"%04x:%02x:%02x:%02x in_eeprom->offset = %d \"\n-\t\t\"len = %d\\n\", bp->pdev->addr.domain,\n-\t\tbp->pdev->addr.bus, bp->pdev->addr.devid,\n-\t\tbp->pdev->addr.function, in_eeprom->offset, in_eeprom->length);\n+\tPMD_DRV_LOG(INFO,\n+\t\t \"%04x:%02x:%02x:%02x in_eeprom->offset = %d len = %d\\n\",\n+\t\t bp->pdev->addr.domain,\n+\t\t bp->pdev->addr.bus,\n+\t\t bp->pdev->addr.devid,\n+\t\t bp->pdev->addr.function,\n+\t\t in_eeprom->offset,\n+\t\t in_eeprom->length);\n \n \tif (in_eeprom->offset == 0) /* special offset value to get directory */\n \t\treturn bnxt_get_nvram_directory(bp, in_eeprom->length,\n@@ -2953,16 +2971,17 @@ static bool bnxt_dir_type_is_executable(uint16_t dir_type)\n \n static int\n bnxt_set_eeprom_op(struct rte_eth_dev *dev,\n-\t\tstruct rte_dev_eeprom_info *in_eeprom)\n+\t\t struct rte_dev_eeprom_info *in_eeprom)\n {\n \tstruct bnxt *bp = (struct bnxt *)dev->data->dev_private;\n \tuint8_t index, dir_op;\n \tuint16_t type, ext, ordinal, attr;\n \n-\tPMD_DRV_LOG(INFO, \"%04x:%02x:%02x:%02x in_eeprom->offset = %d \"\n-\t\t\"len = %d\\n\", bp->pdev->addr.domain,\n-\t\tbp->pdev->addr.bus, bp->pdev->addr.devid,\n-\t\tbp->pdev->addr.function, in_eeprom->offset, in_eeprom->length);\n+\tPMD_DRV_LOG(INFO,\n+\t\t \"%04x:%02x:%02x:%02x in_eeprom->offset = %d len = %d\\n\",\n+\t\t bp->pdev->addr.domain, bp->pdev->addr.bus,\n+\t\t bp->pdev->addr.devid, bp->pdev->addr.function,\n+\t\t in_eeprom->offset, in_eeprom->length);\n \n \tif (!BNXT_PF(bp)) {\n \t\tPMD_DRV_LOG(ERR, \"NVM write not supported from a VF\\n\");\n@@ -3195,14 +3214,14 @@ bnxt_dev_init(struct rte_eth_dev *eth_dev)\n \t\t\t pci_dev->addr.function, \"rx_port_stats\");\n \t\tmz_name[RTE_MEMZONE_NAMESIZE - 1] = 0;\n \t\tmz = rte_memzone_lookup(mz_name);\n-\t\ttotal_alloc_len = RTE_CACHE_LINE_ROUNDUP(\n-\t\t\t\tsizeof(struct rx_port_stats) + 512);\n+\t\ttotal_alloc_len = RTE_CACHE_LINE_ROUNDUP\n+\t\t\t\t\t(sizeof(struct rx_port_stats) + 512);\n \t\tif (!mz) {\n \t\t\tmz = rte_memzone_reserve(mz_name, total_alloc_len,\n-\t\t\t\t\tSOCKET_ID_ANY,\n-\t\t\t\t\tRTE_MEMZONE_2MB |\n-\t\t\t\t\tRTE_MEMZONE_SIZE_HINT_ONLY |\n-\t\t\t\t\tRTE_MEMZONE_IOVA_CONTIG);\n+\t\t\t\t\t\t SOCKET_ID_ANY,\n+\t\t\t\t\t\t RTE_MEMZONE_2MB |\n+\t\t\t\t\t\t RTE_MEMZONE_SIZE_HINT_ONLY |\n+\t\t\t\t\t\t RTE_MEMZONE_IOVA_CONTIG);\n \t\t\tif (mz == NULL)\n \t\t\t\treturn -ENOMEM;\n \t\t}\n@@ -3216,7 +3235,7 @@ bnxt_dev_init(struct rte_eth_dev *eth_dev)\n \t\t\tmz_phys_addr = rte_mem_virt2iova(mz->addr);\n \t\t\tif (mz_phys_addr == 0) {\n \t\t\t\tPMD_DRV_LOG(ERR,\n-\t\t\t\t\"unable to map address to physical memory\\n\");\n+\t\t\t\t\t\"unable to map addr to phys memory\\n\");\n \t\t\t\treturn -ENOMEM;\n \t\t\t}\n \t\t}\n@@ -3231,15 +3250,15 @@ bnxt_dev_init(struct rte_eth_dev *eth_dev)\n \t\t\t pci_dev->addr.function, \"tx_port_stats\");\n \t\tmz_name[RTE_MEMZONE_NAMESIZE - 1] = 0;\n \t\tmz = rte_memzone_lookup(mz_name);\n-\t\ttotal_alloc_len = RTE_CACHE_LINE_ROUNDUP(\n-\t\t\t\tsizeof(struct tx_port_stats) + 512);\n+\t\ttotal_alloc_len = RTE_CACHE_LINE_ROUNDUP\n+\t\t\t\t\t(sizeof(struct tx_port_stats) + 512);\n \t\tif (!mz) {\n \t\t\tmz = rte_memzone_reserve(mz_name,\n-\t\t\t\t\ttotal_alloc_len,\n-\t\t\t\t\tSOCKET_ID_ANY,\n-\t\t\t\t\tRTE_MEMZONE_2MB |\n-\t\t\t\t\tRTE_MEMZONE_SIZE_HINT_ONLY |\n-\t\t\t\t\tRTE_MEMZONE_IOVA_CONTIG);\n+\t\t\t\t\t\t total_alloc_len,\n+\t\t\t\t\t\t SOCKET_ID_ANY,\n+\t\t\t\t\t\t RTE_MEMZONE_2MB |\n+\t\t\t\t\t\t RTE_MEMZONE_SIZE_HINT_ONLY |\n+\t\t\t\t\t\t RTE_MEMZONE_IOVA_CONTIG);\n \t\t\tif (mz == NULL)\n \t\t\t\treturn -ENOMEM;\n \t\t}\n@@ -3253,7 +3272,7 @@ bnxt_dev_init(struct rte_eth_dev *eth_dev)\n \t\t\tmz_phys_addr = rte_mem_virt2iova(mz->addr);\n \t\t\tif (mz_phys_addr == 0) {\n \t\t\t\tPMD_DRV_LOG(ERR,\n-\t\t\t\t\"unable to map address to physical memory\\n\");\n+\t\t\t\t\t \"unable to map to phys memory\\n\");\n \t\t\t\treturn -ENOMEM;\n \t\t\t}\n \t\t}\n@@ -3298,10 +3317,11 @@ bnxt_dev_init(struct rte_eth_dev *eth_dev)\n \t\tgoto error_free;\n \t}\n \teth_dev->data->mac_addrs = rte_zmalloc(\"bnxt_mac_addr_tbl\",\n-\t\t\t\t\tETHER_ADDR_LEN * bp->max_l2_ctx, 0);\n+\t\t\t\t\t ETHER_ADDR_LEN * bp->max_l2_ctx,\n+\t\t\t\t\t 0);\n \tif (eth_dev->data->mac_addrs == NULL) {\n \t\tPMD_DRV_LOG(ERR,\n-\t\t\t\"Failed to alloc %u bytes needed to store MAC addr tbl\",\n+\t\t\t\"Failed to alloc %u bytes to store MAC addr tbl\\n\",\n \t\t\tETHER_ADDR_LEN * bp->max_l2_ctx);\n \t\trc = -ENOMEM;\n \t\tgoto error_free;\n@@ -3328,7 +3348,8 @@ bnxt_dev_init(struct rte_eth_dev *eth_dev)\n \t}\n \n \tbp->grp_info = rte_zmalloc(\"bnxt_grp_info\",\n-\t\t\t\tsizeof(*bp->grp_info) * bp->max_ring_grps, 0);\n+\t\t\t\t sizeof(*bp->grp_info) * bp->max_ring_grps,\n+\t\t\t\t 0);\n \tif (!bp->grp_info) {\n \t\tPMD_DRV_LOG(ERR,\n \t\t\t\"Failed to alloc %zu bytes to store group info table\\n\",\n@@ -3339,8 +3360,8 @@ bnxt_dev_init(struct rte_eth_dev *eth_dev)\n \n \t/* Forward all requests if firmware is new enough */\n \tif (((bp->fw_ver >= ((20 << 24) | (6 << 16) | (100 << 8))) &&\n-\t (bp->fw_ver < ((20 << 24) | (7 << 16)))) ||\n-\t ((bp->fw_ver >= ((20 << 24) | (8 << 16))))) {\n+\t (bp->fw_ver < ((20 << 24) | (7 << 16)))) ||\n+\t (bp->fw_ver >= ((20 << 24) | (8 << 16)))) {\n \t\tmemset(bp->pf.vf_req_fwd, 0xff, sizeof(bp->pf.vf_req_fwd));\n \t} else {\n \t\tPMD_DRV_LOG(WARNING,\n@@ -3363,8 +3384,7 @@ bnxt_dev_init(struct rte_eth_dev *eth_dev)\n \tALLOW_FUNC(HWRM_VNIC_TPA_CFG);\n \trc = bnxt_hwrm_func_driver_register(bp);\n \tif (rc) {\n-\t\tPMD_DRV_LOG(ERR,\n-\t\t\t\"Failed to register driver\");\n+\t\tPMD_DRV_LOG(ERR, \"Failed to register driver\\n\");\n \t\trc = -EBUSY;\n \t\tgoto error_free;\n \t}\n@@ -3477,7 +3497,7 @@ bnxt_dev_uninit(struct rte_eth_dev *eth_dev)\n }\n \n static int bnxt_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,\n-\tstruct rte_pci_device *pci_dev)\n+\t\t\t struct rte_pci_device *pci_dev)\n {\n \treturn rte_eth_dev_pci_generic_probe(pci_dev, sizeof(struct bnxt),\n \t\tbnxt_dev_init);\n", "prefixes": [ "20/31" ] }